praxis 2.0.pre.17 → 2.0.pre.21

data/spec/praxis/mapper/selector_generator_spec.rb

@@ -1,49 +1,50 @@
-require 'spec_helper'
+# frozen_string_literal: true
 
+require 'spec_helper'
 
 describe Praxis::Mapper::SelectorGenerator do
   let(:resource) { SimpleResource }
-  subject(:generator) {described_class.new }
+  subject(:generator) { described_class.new }
 
   context '#add' do
     let(:resource) { SimpleResource }
     shared_examples 'a proper selector' do
       it { expect(generator.add(resource, fields).selectors.dump).to be_deep_equal selectors }
     end
-    
+
     context 'basic combos' do
       context 'direct column fields' do
-        let(:fields) { {id: true, foobar: true} }
-        let(:selectors) do 
+        let(:fields) { { id: true, foobar: true } }
+        let(:selectors) do
           {
             model: SimpleModel,
-            columns: [:id, :foobar]
-          } 
+            columns: %i[id foobar]
+          }
         end
         it_behaves_like 'a proper selector'
       end
 
       context 'aliased column fields' do
-        let(:fields) { {id: true, name: true} }
+        let(:fields) { { id: true, name: true } }
         let(:selectors) do
           {
             model: SimpleModel,
-            columns: [:id, :simple_name]
+            columns: %i[id simple_name]
           }
         end
         it_behaves_like 'a proper selector'
       end
 
       context 'pure associations without recursion' do
-        let(:fields) { {other_model: true} }
+        let(:fields) { { other_model: true } }
         let(:selectors) do
           {
             model: SimpleModel,
             columns: [:other_model_id], # FK of the other_model association
             tracks: {
-              other_model: { 
+              other_model: {
                 columns: [:id], # joining key for the association
-                model: OtherModel 
+                model: OtherModel
               }
             }
           }
@@ -52,15 +53,15 @@ describe Praxis::Mapper::SelectorGenerator do
       end
 
       context 'aliased associations without recursion' do
-        let(:fields) { {other_resource: true} }
+        let(:fields) { { other_resource: true } }
         let(:selectors) do
           {
             model: SimpleModel,
             columns: [:other_model_id], # FK of the other_model association
             tracks: {
-              other_model: { 
+              other_model: {
                 columns: [:id], # joining key for the association
-                model: OtherModel 
+                model: OtherModel
               }
             }
           }
@@ -68,15 +69,15 @@ describe Praxis::Mapper::SelectorGenerator do
         it_behaves_like 'a proper selector'
       end
       context 'aliased associations without recursion (that map to columns and other associations)' do
-        let(:fields) { {aliased_method: true} }
+        let(:fields) { { aliased_method: true } }
         let(:selectors) do
           {
             model: SimpleModel,
-            columns: [:column1, :other_model_id], # other_model_id => because of the association
+            columns: %i[column1 other_model_id], # other_model_id => because of the association
             tracks: {
-              other_model: { 
+              other_model: {
                 columns: [:id], # joining key for the association
-                model: OtherModel 
+                model: OtherModel
               }
             }
           }
@@ -85,13 +86,13 @@ describe Praxis::Mapper::SelectorGenerator do
       end
 
       context 'redefined associations that add some extra columns (would need both the underlying association AND the columns in place)' do
-        let(:fields) { {parent: true} }
+        let(:fields) { { parent: true } }
         let(:selectors) do
           {
             model: SimpleModel,
-            columns: [:parent_id, :added_column],
+            columns: %i[parent_id added_column],
             tracks: {
-              parent: { 
+              parent: {
                 columns: [:id],
                 model: ParentModel
               }
@@ -102,29 +103,29 @@ describe Praxis::Mapper::SelectorGenerator do
       end
 
       context 'a simple property that requires all fields' do
-        let(:fields) { {everything: true} }
+        let(:fields) { { everything: true } }
         let(:selectors) do
           {
             model: SimpleModel,
-            columns: [:*],
+            columns: [:*]
           }
         end
         it_behaves_like 'a proper selector'
       end
 
       context 'a simple property that requires itself' do
-        let(:fields) { {circular_dep: true} }
+        let(:fields) { { circular_dep: true } }
         let(:selectors) do
           {
             model: SimpleModel,
-            columns: [:circular_dep, :column1], #allows to "expand" the dependency into itself + others
+            columns: %i[circular_dep column1] # allows to "expand" the dependency into itself + others
           }
         end
         it_behaves_like 'a proper selector'
       end
 
       context 'a simple property without dependencies' do
-        let(:fields) { {no_deps: true} }
+        let(:fields) { { no_deps: true } }
         let(:selectors) do
           {
             model: SimpleModel
@@ -132,13 +133,12 @@ describe Praxis::Mapper::SelectorGenerator do
         end
         it_behaves_like 'a proper selector'
       end
-
     end
 
     context 'nested tracking' do
       context 'pure associations follow the nested fields' do
         let(:fields) do
-          { 
+          {
             other_model: {
               id: true
             }
@@ -196,7 +196,7 @@ describe Praxis::Mapper::SelectorGenerator do
         let(:selectors) do
           {
             model: SimpleModel,
-            columns: [:parent_id, :added_column],
+            columns: %i[parent_id added_column],
             tracks: {
               parent: {
                 model: ParentModel,
@@ -225,7 +225,7 @@ describe Praxis::Mapper::SelectorGenerator do
             tracks: {
               other_model: {
                 model: OtherModel,
-                columns: [:id, :name]
+                columns: %i[id name]
               }
             }
           }
@@ -242,7 +242,7 @@ describe Praxis::Mapper::SelectorGenerator do
             tracks: {
               other_model: {
                 model: OtherModel,
-                columns: [:id, :name]
+                columns: %i[id name]
               }
             }
           }
@@ -251,13 +251,13 @@ describe Praxis::Mapper::SelectorGenerator do
       end
 
       context 'for a property that requires all fields from an association' do
-        let(:fields) { {everything_from_parent: true} }
+        let(:fields) { { everything_from_parent: true } }
         let(:selectors) do
           {
             model: SimpleModel,
             columns: [:parent_id],
             tracks: {
-              parent: { 
+              parent: {
                 model: ParentModel,
                 columns: [:*]
               }
@@ -270,15 +270,15 @@ describe Praxis::Mapper::SelectorGenerator do
 
     context 'required extra select fields due to associations' do
       context 'many_to_one' do
-        let(:fields) { {other_model: true} }
+        let(:fields) { { other_model: true } }
         let(:selectors) do
           {
             model: SimpleModel,
             columns: [:other_model_id], # FK of the other_model association
             tracks: {
-              other_model: { 
+              other_model: {
                 columns: [:id],
-                model: OtherModel 
+                model: OtherModel
               }
             }
           }
@@ -287,39 +287,73 @@ describe Praxis::Mapper::SelectorGenerator do
       end
       context 'one_to_many' do
         let(:resource) { ParentResource }
-        let(:fields) { {simple_children: true} }
+        let(:fields) { { simple_children: true } }
         let(:selectors) do
           {
             model: ParentModel,
             columns: [:id], # No FKs in the source model for one_to_many
             tracks: {
-              simple_children: { 
+              simple_children: {
                 columns: [:parent_id],
-                model: SimpleModel 
+                model: SimpleModel
               }
             }
           }
         end
         it_behaves_like 'a proper selector'
-      end      
+      end
       context 'many_to_many' do
         let(:resource) { OtherResource }
-        let(:fields) { {simple_models: true} }
+        let(:fields) { { simple_models: true } }
         let(:selectors) do
           {
             model: OtherModel,
-            columns: [:id], #join key in the source model for many_to_many (where the middle table points to)
+            columns: [:id], # join key in the source model for many_to_many (where the middle table points to)
             tracks: {
-              simple_models: { 
-                columns: [:id], #join key in the target model for many_to_many (where the middle table points to)
+              simple_models: {
+                columns: [:id], # join key in the target model for many_to_many (where the middle table points to)
                 model: SimpleModel
               }
             }
           }
         end
         it_behaves_like 'a proper selector'
-      end      
+      end
 
+      context 'that are several attriutes deep' do
+        let(:fields) { { deep_nested_deps: true } }
+        let(:selectors) do
+          {
+            model: SimpleModel,
+            columns: [:parent_id],
+            tracks: {
+              parent: {
+                model: ParentModel,
+                columns: [:id], # No FKs in the source model for one_to_many
+                tracks: {
+                  simple_children: {
+                    columns: %i[parent_id other_model_id],
+                    model: SimpleModel,
+                    tracks: {
+                      other_model: {
+                        model: OtherModel,
+                        columns: %i[id parent_id],
+                        tracks: {
+                          parent: {
+                            model: ParentModel,
+                            columns: %i[id simple_name other_attribute]
+                          }
+                        }
+                      }
+                    }
+                  }
+                }
+              }
+            }
+          }
+        end
+        it_behaves_like 'a proper selector'
+      end
     end
   end
 end

data/spec/praxis/media_type_identifier_spec.rb

@@ -1,4 +1,8 @@
-require "spec_helper"
+# frozen_string_literal: true
+
+# rubocop:disable Style/StringConcatenation
+
+require 'spec_helper'
 
 describe Praxis::MediaTypeIdentifier do
   let(:example) { 'application/ice-cream+sundae; nuts="true"; fudge="true"' }
@@ -14,7 +18,7 @@ describe Praxis::MediaTypeIdentifier do
     end
 
     context 'of empty string values' do
-      let(:example) { "" }
+      let(:example) { '' }
       it 'returns nil' do
         expect(subject).to be(nil)
       end
@@ -47,8 +51,6 @@ describe Praxis::MediaTypeIdentifier do
       #   pending("need to stop using a regexp to do a context-free parser's job")
       #   expect(described_class.new(tricky_example).parameters['sauce']).to eq('yes; absolutely')
       # end
-
-
     end
 
     context 'given a malformed type' do
@@ -164,7 +166,7 @@ describe Praxis::MediaTypeIdentifier do
 
     let(:with_suffix) { 'application/vnd.widget+xml' }
     let(:with_subtype) { 'text/xml' }
-    let(:with_both) { 'text/json+xml' } #nonsensical but valid!
+    let(:with_both) { 'text/json+xml' } # nonsensical but valid!
 
     it 'uses the suffix' do
       expect(subject.new(with_suffix).handler_name).to eq('xml')
@@ -192,15 +194,15 @@ describe Praxis::MediaTypeIdentifier do
 
     it 'adds parameters' do
       expect(simple_subject + 'nuts=true').to \
-      eq(described_class.new('application/vnd.icecream; nuts=true'))
+        eq(described_class.new('application/vnd.icecream; nuts=true'))
 
       expect(simple_subject + '; nuts=true').to \
-      eq(described_class.new('application/vnd.icecream; nuts=true'))
+        eq(described_class.new('application/vnd.icecream; nuts=true'))
     end
 
     it 'adds suffix and parameters' do
       expect(simple_subject + 'xml; nuts=true').to \
-      eq(described_class.new('application/vnd.icecream+xml; nuts=true'))
+        eq(described_class.new('application/vnd.icecream+xml; nuts=true'))
     end
 
     it 'replaces the suffix' do
@@ -210,7 +212,7 @@ describe Praxis::MediaTypeIdentifier do
 
     it 'replaces existing parameters and adds new ones' do
       expect(complex_subject + 'nuts=false; cherry=true').to \
-      eq(described_class.new('application/vnd.icecream+json; cherry=true; nuts=false'))
+        eq(described_class.new('application/vnd.icecream+json; cherry=true; nuts=false'))
 
       expect(complex_subject + '; nuts=false; cherry=true').to \
         eq(described_class.new('application/vnd.icecream+json; cherry=true; nuts=false'))
@@ -235,4 +237,5 @@ describe Praxis::MediaTypeIdentifier do
       end
     end
   end
-end
+end
+# rubocop:enable Style/StringConcatenation

data/spec/praxis/media_type_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Praxis::MediaType do
@@ -5,19 +7,18 @@ describe Praxis::MediaType do
   let(:manager_resource) { instance_double(Person, id: 101, name: /[:name:]/.gen, href: '/') }
   let(:custodian_resource) { instance_double(Person, id: 102, name: /[:name:]/.gen, href: '/') }
   let(:residents_summary_resource) do
-    instance_double(Person::CollectionSummary, href: "/people", size: 2)
+    instance_double(Person::CollectionSummary, href: '/people', size: 2)
   end
 
   let(:resource) do
     double('address',
-      id: 1,
-      name: 'Home',
-      owner: owner_resource,
-      manager: manager_resource,
-      custodian: custodian_resource,
-      residents_summary: residents_summary_resource,
-      fields: {id: true, name: true}
-    )
+           id: 1,
+           name: 'Home',
+           owner: owner_resource,
+           manager: manager_resource,
+           custodian: custodian_resource,
+           residents_summary: residents_summary_resource,
+           fields: { id: true, name: true })
   end
 
   subject(:address) { Address.new(resource) }
@@ -28,7 +29,6 @@ describe Praxis::MediaType do
     its(:owner) { should be_instance_of(Person) }
   end
 
-
   context 'accessor methods' do
     subject(:address_klass) { address.class }
 
@@ -41,12 +41,12 @@ describe Praxis::MediaType do
     its(:description) { should be_kind_of(String) }
   end
 
-  context "rendering" do
+  context 'rendering' do
     subject(:output) { address.render }
 
     its([:id])    { should eq(address.id) }
     its([:name])  { should eq(address.name) }
     its([:owner]) { should eq(Person.dump(owner_resource)) }
-    its([:fields]) { should eq(address.fields.dump ) }
+    its([:fields]) { should eq(address.fields.dump) }
   end
 end

data/spec/praxis/middleware_app_spec.rb

@@ -1,73 +1,74 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Praxis::MiddlewareApp do
-
-  let(:init_args){ { root: 'here'} }
-  let(:middleware) { Praxis::MiddlewareApp.for( **init_args ) }
-  let(:instance){ middleware.new(target)}
+  let(:init_args) { { root: 'here' } }
+  let(:middleware) { Praxis::MiddlewareApp.for(**init_args) }
+  let(:instance) { middleware.new(target) }
 
   context '.for' do
     it 'does not initialize the Application instance yet' do
-      expect( Praxis::Application.instance ).to_not receive(:setup)
+      expect(Praxis::Application.instance).to_not receive(:setup)
       middleware
     end
     it 'returns its class' do
-      expect( middleware ).to be < Praxis::MiddlewareApp 
+      expect(middleware).to be < Praxis::MiddlewareApp
     end
   end
 
   context 'instantiated' do
-    subject{ instance }
-    let(:target_response){ [201,{}] }
-    let(:target){ double("target app", call: target_response) }
+    subject { instance }
+    let(:target_response) { [201, {}] }
+    let(:target) { double('target app', call: target_response) }
     it 'saves the target app' do
       expect(subject.target).to be(target)
     end
     it 'does not initialize the Application instance yet' do
-      expect( Praxis::Application.instance ).to_not receive(:setup)
+      expect(Praxis::Application.instance).to_not receive(:setup)
       subject
     end
-    
+
     context '.call' do
-      let(:env){ {} }
-      let(:praxis_response){ [200,{}] }
-      subject(:response){ instance.call(env) }
+      let(:env) { {} }
+      let(:praxis_response) { [200, {}] }
+      subject(:response) { instance.call(env) }
       before do
         # always invokes the praxis app
-        expect( Praxis::Application.instance ).to receive(:call).with( env ).once.and_return(praxis_response)
+        expect(Praxis::Application.instance).to receive(:call).with(env).once.and_return(praxis_response)
       end
 
       context 'when it has not been setup yet' do
         it 'initializes the application singleton with the passed parameters' do
-          expect( Praxis::Application.instance ).to receive(:setup).with( init_args ).once
+          expect(Praxis::Application.instance).to receive(:setup).with(init_args).once
           subject
         end
       end
       context 'when it has already been setup' do
         it 'does NOT call instance setup' do
           middleware.setup
-          expect( Praxis::Application.instance ).to_not receive(:setup)
+          expect(Praxis::Application.instance).to_not receive(:setup)
           subject
         end
       end
 
       context 'properly handled (non-404 and 405) responses from praxis' do
         it 'are returned straight through' do
-          expect( response ).to be(praxis_response)
+          expect(response).to be(praxis_response)
         end
       end
 
       context '404/405 responses with X-Cascade = pass' do
-        let(:praxis_response){ [404, {'X-Cascade' => 'pass'}]}
+        let(:praxis_response) { [404, { 'X-Cascade' => 'pass' }] }
         it 'are forwarded to the target app' do
-          expect( response ).to be(target_response)
+          expect(response).to be(target_response)
         end
       end
 
       context '404/405 responses without X-Cascade = pass' do
-        let(:praxis_response){ [404, {}]}
+        let(:praxis_response) { [404, {}] }
         it 'returned straight through' do
-          expect( response ).to be(praxis_response)
+          expect(response).to be(praxis_response)
         end
       end
     end

data/spec/praxis/multipart/parser_spec.rb

@@ -1,7 +1,8 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Praxis::MultipartParser do
-
   let(:form) do
     form_data = MIME::Multipart::FormData.new
 
@@ -36,17 +37,16 @@ describe Praxis::MultipartParser do
       form.add text, 'file', 'docker'
     end
 
-    subject(:part) { parts.find { |p| p.name == 'file'} }
-    #subject(:part_body) { part.body }
-
+    subject(:part) { parts.find { |p| p.name == 'file' } }
+    # subject(:part_body) { part.body }
 
     its(:payload) { should be_kind_of(Tempfile) }
-    its(:filename) { should eq("docker") }
-    its(:name) { should eq("file") }
+    its(:filename) { should eq('docker') }
+    its(:name) { should eq('file') }
 
     context 'headers' do
       subject(:part_headers) { part.headers }
-      its(['Content-Type']) { should eq("text/plain") }
+      its(['Content-Type']) { should eq('text/plain') }
       its(['Content-Disposition']) { should match(/filename=docker/) }
     end
 
@@ -56,7 +56,5 @@ describe Praxis::MultipartParser do
       part.payload.rewind
       expect(part.payload.read).to eq('DOCKER_HOST=tcp://127.0.0.1:2375')
     end
-
   end
-
 end

data/spec/praxis/notifications_spec.rb

@@ -1,11 +1,12 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Praxis::Notifications do
-
   let(:events) { [] }
 
   before do
-    Praxis::Notifications.subscribe('render') do |name, start, finish, id, payload|
+    Praxis::Notifications.subscribe('render') do |_name, _start, _finish, _id, payload|
       events << payload
     end
 
@@ -17,7 +18,6 @@ describe Praxis::Notifications do
 
   it 'works' do
     expect(events).to have(2).items
-    expect(events).to match [{extra: :information}, {extra: :single}]
+    expect(events).to match [{ extra: :information }, { extra: :single }]
   end
-
 end

data/spec/praxis/plugin_concern_spec.rb

@@ -1,21 +1,20 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Praxis::PluginConcern do
-
   it 'works' do
     expect(Praxis::Request.instance_methods).to include(:user_abilities)
   end
 
   context 'ActionDefinition' do
     subject(:action) { ApiResources::Instances.actions[:terminate] }
-    its(:required_abilities) { should match_array [:terminate, :read] }
+    its(:required_abilities) { should match_array %i[terminate read] }
 
     context '#describe' do
       subject(:describe) { action.describe }
-      it { should have_key :required_abilities}
-      its([:required_abilities]) { should match_array action.required_abilities}
+      it { should have_key :required_abilities }
+      its([:required_abilities]) { should match_array action.required_abilities }
     end
-
   end
-
 end