praxis-mapper 4.1.1 → 4.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0d6680ca8a7a141d49b78517c33a45305cba5ac1
-  data.tar.gz: c9fe79656d4ae8d65b00d91a8aa1f31f8c43c264
+  metadata.gz: 5a54434e8e0f9299b8ae645f800e93ebbc1b0fae
+  data.tar.gz: 78806cff2fdeda7b7375f8ccc1a68f26addddbfb
 SHA512:
-  metadata.gz: b194a3a75bc1a36cb1d62b977ba63fef76c968c1c2927b6c2e2404925a89a82a49defd02d355b8e0578fc5f6126d3602cb9339d840d69ad3e31e19831f1e1031
-  data.tar.gz: 0c7f61c1b671de5ed918c3e2591b2dbdd1bfd6867353a88fc66784e4e347d9b3fc94b3698b5f3a46a003f00c8e64283429a4bc3be9025ba0732c7ee79353319c
+  metadata.gz: 668be9af356c5099402fdcfb46533004c5a3cc629085235417e73bdd8688ca061c1c440686aabd515fbe05f82a7acb879770f43037fb6ee9955caf7620d8ed11
+  data.tar.gz: 96effa292125c2d3f3ce5d20eba3f338cf7ef0c4d8c7486c62054626e4840162080a9975942d8fef5989fd19065c4a060c97397b7bcaaf404c606a3f50f65601

data/.travis.yml

@@ -1,4 +1,5 @@
 language: ruby
+sudo: false
 rvm:
   - 2.1.2
   - 2.2.2

data/CHANGELOG.md

@@ -2,6 +2,11 @@
 
 ## next
 
+## 4.1.2
+
+* Remove finalizer from IdentityMap to fix memory leak that was preventing them from being GC'd properly.
+
+
 ## 4.1.1
 
 * Fixed critical bug in `IdentityMap#finalize!`=

data/lib/praxis-mapper/connection_factories/sequel.rb

@@ -39,7 +39,7 @@ module Praxis::Mapper
 
       def release(connection_manager, connection)
         # ensure we only release connections we own, in case
-        # we've acquired a connection from Sequel that 
+        # we've acquired a connection from Sequel that
         # is likely still in use.
         if (@owned_connections.delete(connection_manager.thread))
           @connection.pool.send(:sync) do
@@ -50,9 +50,9 @@ module Praxis::Mapper
 
       def acquire(thread)
         # check connection's pool to see if it already has a connection
-        # if so, re-use it. otherwise, acquire a new one and mark that we 
+        # if so, re-use it. otherwise, acquire a new one and mark that we
         # "own" it for future releasing.
-        if (owned = @connection.pool.send(:owned_connection, thread))
+        if @connection.pool.send(:owned_connection, thread)
           return true
         else
           conn = @connection.pool.send(:acquire, thread)

data/lib/praxis-mapper/connection_manager.rb

@@ -17,7 +17,7 @@ module Praxis::Mapper
 
       query = data[:query] || Praxis::Mapper::Query::Sql
       factory_class = data[:factory] || ConnectionFactories::Simple
-      
+
       opts = data[:opts] || {}
       if query.kind_of? String
         query = query.constantize
@@ -26,14 +26,14 @@ module Praxis::Mapper
       if factory_class.kind_of? String
         factory_class = factory_class.constantize
       end
-      
+
       repositories[repository_name] = {
         query: query,
         factory: factory_class.new(**opts, &block)
       }
     end
 
-    
+
     def repositories
       self.class.repositories
     end
@@ -73,7 +73,7 @@ module Praxis::Mapper
         release_one(name)
       else
         names = @connections.keys
-        names.each { |name| release_one(name) }
+        names.each { |n| release_one(n) }
       end
     end
 

data/lib/praxis-mapper/identity_map.rb

@@ -70,11 +70,6 @@ module Praxis::Mapper
       @connection_manager = ConnectionManager.new
       @scope = scope
       clear!
-
-      # Ensure we clean up open connections
-      ObjectSpace.define_finalizer(self) do
-        @connection_manager.release
-      end
     end
 
     def clear!

data/lib/praxis-mapper/version.rb

@@ -1,5 +1,5 @@
 module Praxis
   module Mapper
-    VERSION = "4.1.1"
+    VERSION = "4.1.2"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: praxis-mapper
 version: !ruby/object:Gem::Version
-  version: 4.1.1
+  version: 4.1.2
 platform: ruby
 authors:
 - Josep M. Blanquer
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-21 00:00:00.000000000 Z
+date: 2015-09-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: randexp