pravangi 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0e16f61a50c9e552b723ae85b71904f7ce8ff7cd
-  data.tar.gz: 30df35bd5528144a319186b452378a0c3e7d67d1
+  metadata.gz: 17eb6808981135d07d9e82a9d813d026cdf9df54
+  data.tar.gz: c89b505e48a2c4e5fb25f4dee867f2d9639a923f
 SHA512:
-  metadata.gz: dfa893d9870564f6c8e932e80fd9afd069f2d9ae468a1ed60e74fb09acc0a0d088bb53093a818e52c6079dcd44cf4ae94de853ab37e800ad413dd532631a047e
-  data.tar.gz: 33a428a1cbcb62fdbad0065f748fe58e096d868736413b7c8089937d20fc4d05b3ad0897cac06125e08d717669885d3b68b853d54d54fa87fa5a2ae57fa11434
+  metadata.gz: 13addedda080733c3dd64f99eb5a7f9232b2adb8f532f7adb8b5dc2635a7c07f885d4ba4488bd63c4d20da959202f06007941d595b5007e56046ec6fb76d78b6
+  data.tar.gz: af3da5a09ace4ab69ce06e499a98ed85506484bf3f214fae8a6ce4e282090334362516bf259f747ae43d846ea146e3695beade288b17266abd917443bf66b44d

data/lib/pravangi/models/pending_approval.rb

@@ -15,7 +15,7 @@ module Pravangi
       self.object_changes.keys
     end
 
-    def commit
+    def approve_changes
       resource.skip_approval = true
       object_changes.each do |k,v|
         resource[k] = v[1]
@@ -24,6 +24,10 @@ module Pravangi
       resource.reload
     end
 
+    def reject_changes
+      self.destroy
+    end
+
     def skip_attributes
       if self.resource.class.pravangi_options[:skip_attributes]
         object_changes.except(*self.resource.class.pravangi_options[:skip_attributes])

data/lib/pravangi/version.rb

@@ -1,3 +1,3 @@
 module Pravangi
-  VERSION = "0.1.0"
+  VERSION = "0.2.0"
 end

data/spec/lib/pravangi_spec.rb

@@ -134,7 +134,7 @@ describe Pravangi do
       end
 
       it 'should be able to apply all changes to bring the object to desired state' do
-        post.pending_approvals.each(&:commit)
+        post.pending_approvals.each(&:approve_changes)
         post.reload
         expect(post.title).to eq('metaware 3')
       end
@@ -161,7 +161,7 @@ describe Pravangi do
 
     end
 
-    context '#commit' do
+    context '#approve_changes' do
 
       before(:each) do
         post.title = 'metaware 2'
@@ -170,44 +170,52 @@ describe Pravangi do
       end
 
       it 'should be able to revert the object back to the requested state' do
-        post.pending_approvals.last.commit
+        post.pending_approvals.last.approve_changes
         post.reload
         expect(post.title).to eq('metaware 2')
       end
 
     end
 
-    context 'does not requires approval' do
+    context '#reject_changes' do
 
       before(:each) do
-        expect(post).to receive(:approved?).and_return(false)
+        post.title = 'metaware 2'
         post.save
         post.reload
       end
 
-      it 'should just commit the changes' do
-        expect(post.title).to eq('new metaware')
+      it 'should be able to revert the object back to the requested state' do
+        post.pending_approvals.last.reject_changes
+        post.reload
+        expect(post.title).to eq('metaware')
       end
 
-      it 'should return false when approval is not required' do
+      it 'should clear any pending approvals in the queue' do
+        post.pending_approvals.last.reject_changes
+        post.reload
         expect(post.pending_approval?).to eq(false)
+        expect(post.pending_approvals).to be_empty
       end
 
     end
 
-  end
+    context 'does not requires approval' do
 
-  context 'when taking an object to satisfying if condition' do
+      before(:each) do
+        expect(post).to receive(:approved?).and_return(false)
+        post.save
+        post.reload
+      end
+
+      it 'should just commit the changes' do
+        expect(post.title).to eq('new metaware')
+      end
 
-    let(:post) { Post.create(title: 'metaware', state: 'draft') }
+      it 'should return false when approval is not required' do
+        expect(post.pending_approval?).to eq(false)
+      end
 
-    it 'should trigger approval tracking only when the object is in a satisfying state' do
-      skip('the following is a failing test case, however not an immediate concern as we are doing state change as an isolated action on our objects')
-      # post.title = 'metaware draft'
-      # post.state = 'approved'
-      # post.save
-      # post.reload
-      # expect(post.title).to eq('metaware draft')
     end
 
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pravangi
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Jasdeep Singh