practical 3.0.0.pre.alpha1 → 3.0.0.pre.alpha2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: df17b4a0aff5baa56ac16602fe85779f7693b00331bff301258f084dbd4c15ef
-  data.tar.gz: a9ba95edf2300f43c70c72e028282a1045d831f76128cc705c1aaf7ab287e6dc
+  metadata.gz: d5cd9e0fb40bc07050d68f122c8f99b2769ebc047de756ba4baba2df7eb5a5fd
+  data.tar.gz: 4f9ea83a5bd5dc2b6da7a8a7b50321b185a1368abf820ba2c7abaac9e82468ae
 SHA512:
-  metadata.gz: 38706fd22c3881826b066a9dd4d1032395d19ce2fe062b0ea64dca1cb974b4de0944bd7ddfc563277495dbdc35cbb0ca4ae83c264ed884515b09dec74c0f9bac
-  data.tar.gz: bbab74d5607eb57b2eeff685935cd20421170e2ce99c4eee30bf593e2581b4fc97d9c4c86d1e82698d0c1a2b76fd3a6b2a8156a2d4c30d103afcc344c41327cd
+  metadata.gz: 790f33b8ef5decf8588d588f798f2e9ac65cb8b776eb0ca108a124e361bed765ba8230d8637918a3e904db2c497237064421028993b876081130efab9482f3d3
+  data.tar.gz: 0f07a49cd479ce6ff63d3627b1111e0908536e3b81807aec6daae24b913b342ab54d285b3c33e591d08071737a1da6007ced40112f21f62444efab9089aa4cc9

data/app/components/practical/views/form/error_list_component.rb

@@ -8,7 +8,7 @@ class Practical::Views::Form::ErrorListComponent < Practical::Views::BaseCompone
   end
 
   def call
-    tag.ul(class: 'error-list') {
+    tag.ul(data: {'data-pf-error-container': true}) {
       safe_join(errors.map{|error| render Practical::Views::Form::ErrorListItemComponent.new(error: error) })
     }
   end

data/app/components/practical/views/form/error_list_item_component.rb

@@ -12,9 +12,9 @@ class Practical::Views::Form::ErrorListItemComponent < Practical::Views::BaseCom
   end
 
   def call
-    tag.li(class: 'wa-flank', data: {"error-type": error.type}) {
+    tag.li(class: 'wa-flank', data: {"pf-error-type": error.type, "pf-error-visible": true}) {
       render(icon_set.error_list_icon) +
-      tag.span(error.message)
+      tag.span(error.message, data: { "pf-error-message": true })
     }
   end
 end

data/app/components/practical/views/form/error_list_item_template_component.rb

@@ -2,7 +2,7 @@
 
 class Practical::Views::Form::ErrorListItemTemplateComponent < Practical::Views::BaseComponent
   def call
-    tag.template(id: 'error-list-item-template') {
+    tag.template(id: 'pf-error-list-item-template') {
       render Practical::Views::Form::ErrorListItemComponent.new(error: ActiveModel::Error.new(nil, nil, nil))
     }
   end

data/app/components/practical/views/form/fallback_errors_section_component.rb

@@ -11,7 +11,8 @@ class Practical::Views::Form::FallbackErrorsSectionComponent < Practical::Views:
 
   def finalized_options
     mix({
-      class: ["error-section", "fallback-error-section", "wa-callout", "wa-danger"],
+      class: ["wa-callout", "wa-danger"],
+      data: {"pf-error-container": true, "pf-fallback-error-section": true},
       id: id
     }, @options)
   end

data/app/lib/practical/test/shared/memberships/controllers/organization/membership.rb

@@ -160,7 +160,7 @@ module Practical::Test::Shared::Memberships::Controllers::Organization::Membersh
       end
       end
 
-      assert_response :bad_request
+      assert_response :unprocessable_entity
 
       assert_error_json_contains(
         container_id: "organization_new_membership_invitation_form_base_errors",
@@ -192,7 +192,7 @@ module Practical::Test::Shared::Memberships::Controllers::Organization::Membersh
       end
       end
 
-      assert_response :bad_request
+      assert_response :unprocessable_entity
 
       assert_error_json_contains(
         container_id: "organization_new_membership_invitation_form_base_errors",
@@ -224,7 +224,7 @@ module Practical::Test::Shared::Memberships::Controllers::Organization::Membersh
       end
       end
 
-      assert_response :bad_request
+      assert_response :unprocessable_entity
 
       assert_error_json_contains(
         container_id: "organization_new_membership_invitation_form_base_errors",
@@ -252,7 +252,7 @@ module Practical::Test::Shared::Memberships::Controllers::Organization::Membersh
         post organization_memberships_url(organization), params: params, as: :json
       end
       end
-      assert_response :bad_request
+      assert_response :unprocessable_entity
 
       assert_error_json_contains(
         container_id: "organization_new_membership_invitation_form_email_errors",
@@ -280,7 +280,7 @@ module Practical::Test::Shared::Memberships::Controllers::Organization::Membersh
         post organization_memberships_url(organization), params: params
       end
       end
-      assert_response :bad_request
+      assert_response :unprocessable_entity
 
       assert_error_dom(
         container_id: "organization_new_membership_invitation_form_email_errors",
@@ -387,7 +387,7 @@ module Practical::Test::Shared::Memberships::Controllers::Organization::Membersh
         }}
       end
 
-      assert_response :bad_request
+      assert_response :unprocessable_entity
 
       assert_error_dom(
         container_id: "generic_errors_organization_membership_form",

data/app/lib/practical/views/error_response.rb

@@ -7,14 +7,14 @@ module Practical::Views::ErrorResponse
     format.json do
       errors = Practical::Views::ErrorHandling.build_error_json(model: model, helpers: helpers)
       yield(errors) if block_given?
-      render json: errors, status: :bad_request
+      render json: errors, status: :unprocessable_entity
     end
   end
 
   def render_html_error(action:, format:)
     format.html do
       yield  if block_given?
-      render action, status: :bad_request
+      render action, status: :unprocessable_entity
     end
   end
 

data/lib/practical/framework/engine.rb

@@ -18,7 +18,7 @@ module Practical
         def practical_form_with(**args, &block)
           original_field_error_proc = ::ActionView::Base.field_error_proc
           ::ActionView::Base.field_error_proc = ->(html_tag, instance) { html_tag }
-          content_tag(:"practical-framework-error-handling") do
+          content_tag(:"application-error-handling") do
             form_with(**args, &block)
           end
         ensure

data/lib/practical/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Practical
-  VERSION = "3.0.0-alpha1"
+  VERSION = "3.0.0-alpha2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: practical
 version: !ruby/object:Gem::Version
-  version: 3.0.0.pre.alpha1
+  version: 3.0.0.pre.alpha2
 platform: ruby
 authors:
 - Thomas Cannon