practical 0.1.0 → 3.0.0.pre.alpha1

data/app/lib/practical/test/shared/memberships/controllers/user/membership_invitation.rb

@@ -0,0 +1,57 @@
+# frozen_string_literal: true
+
+module Practical::Test::Shared::Memberships::Controllers::User::MembershipInvitation
+  extend ActiveSupport::Concern
+
+  included do
+    test "destroy: destroys a pending invitation and returns a flash message" do
+      resource = resource_instance
+      sign_in_as_resource(resource: resource)
+
+      membership_invitation = membership_invitation_class.find_by!(email: resource.email)
+
+      assert_policies_applied(resource: resource, membership_invitation: membership_invitation) do
+      assert_difference "#{membership_invitation_class}.count", -1 do
+        delete_invitation_action(membership_invitation: membership_invitation)
+      end
+      end
+
+      assert_redirected_to user_memberships_url
+      message = I18n.t('user_memberships.invitation_hidden_message', organization_name: membership_invitation.organization.name)
+      assert_flash_message(type: :alert, message: message, icon_name: 'solid-warehouse-slash')
+    end
+
+    test "destroy: returns 404 if the invitation is already tied to a user" do
+      resource = other_resource_instance
+      sign_in_as_resource(resource: resource)
+
+      membership_invitation = membership_invitation_class.find_by!(email: resource.email)
+
+      assert_policies_applied_on_404(resource: resource) do
+      assert_no_difference "membership_invitation_class.count" do
+        delete_invitation_action(membership_invitation: membership_invitation)
+      end
+      end
+
+      assert_response :not_found
+      assert_no_enqueued_emails
+    end
+
+    test "destroy: returns 404 if the invitation is not visible" do
+      resource = resource_instance
+      sign_in_as_resource(resource: resource)
+
+      membership_invitation = membership_invitation_class.find_by!(email: resource.email)
+      membership_invitation.update!(visible: false)
+
+      assert_policies_applied_on_404(resource: resource) do
+      assert_no_difference "membership_invitation_class.count" do
+        delete_invitation_action(membership_invitation: membership_invitation)
+      end
+      end
+
+      assert_response :not_found
+      assert_no_enqueued_emails
+    end
+  end
+end

data/app/lib/practical/test/shared/memberships/forms/create_new_user_with_membership_invitation.rb

@@ -0,0 +1,197 @@
+# frozen_string_literal: true
+
+module Practical::Test::Shared::Memberships::Forms::CreateNewUserWithMembershipInvitation
+  extend ActiveSupport::Concern
+
+  included do
+    def dummy_webauthn_credential
+      OpenStruct.new(public_key: SecureRandom.hex, raw_id: SecureRandom.bytes(10), sign_count: 0)
+    end
+
+    test "save: merges errors from the attempted new user and re-raises" do
+      membership_invitation = organizations.organization_3.membership_invitations.first
+      form = form_class.new(
+        user: user_class.new(webauthn_id: SecureRandom.hex),
+        membership_invitation: membership_invitation,
+        email: membership_invitation.email,
+        name: "    ",
+        passkey_label: Faker::Computer.os,
+        webauthn_credential: dummy_webauthn_credential
+      )
+
+      assert_no_difference "#{user_class}.count" do
+      assert_no_difference "#{passkey_class}.count" do
+      assert_raises ActiveRecord::RecordInvalid do
+        form.save!
+      end
+      end
+      end
+
+      assert_equal true, form.errors.of_kind?(:name, :blank)
+    end
+
+    test "save: merges errors when trying to create a user with an existing email" do
+      membership_invitation = organizations.organization_3.membership_invitations.first
+      form = form_class.new(
+        user: user_class.new(webauthn_id: SecureRandom.hex),
+        membership_invitation: membership_invitation,
+        email: users.organization_1_manager.email,
+        name: Faker::Name.name,
+        passkey_label: Faker::Computer.os,
+        webauthn_credential: dummy_webauthn_credential
+      )
+
+      assert_no_difference "#{user_class}.count" do
+      assert_no_difference "#{passkey_class}.count" do
+      assert_raises ActiveRecord::RecordInvalid do
+        form.save!
+      end
+      end
+      end
+
+      assert_equal true, form.errors.of_kind?(:email, :taken)
+    end
+
+    test "save: merges errors from the attempted new passkey and re-raises" do
+      membership_invitation = organizations.organization_3.membership_invitations.first
+
+      credential = dummy_webauthn_credential
+      credential.public_key =  "     "
+
+      form = form_class.new(
+        user: user_class.new(webauthn_id: SecureRandom.hex),
+        membership_invitation: membership_invitation,
+        email: membership_invitation.email,
+        name: Faker::Name.name,
+        passkey_label: "   ",
+        webauthn_credential: credential
+      )
+
+      assert_no_difference "#{user_class}.count" do
+      assert_no_difference "#{passkey_class}.count" do
+      assert_raises ActiveRecord::RecordInvalid do
+        form.save!
+      end
+      end
+      end
+
+      assert_equal true, form.errors.of_kind?(:passkey_label, :blank)
+      assert_equal true, form.errors.of_kind?(:public_key, :blank)
+    end
+    test "save: merges errors when trying to create a passkey that already exists" do
+      membership_invitation = organizations.organization_3.membership_invitations.first
+
+      credential = dummy_webauthn_credential
+      credential.public_key = passkey_class.first.public_key
+
+      form = form_class.new(
+        user: user_class.new(webauthn_id: SecureRandom.hex),
+        membership_invitation: membership_invitation,
+        email: membership_invitation.email,
+        name: Faker::Name.name,
+        passkey_label: Faker::Computer.os,
+        webauthn_credential: credential
+      )
+
+      assert_no_difference "#{user_class}.count" do
+      assert_no_difference "#{passkey_class}.count" do
+      assert_raises ActiveRecord::RecordInvalid do
+        form.save!
+      end
+      end
+      end
+
+      assert_equal true, form.errors.of_kind?(:public_key, :taken)
+    end
+
+    test "save: raises unexpected errors" do
+      membership_invitation = organizations.organization_3.membership_invitations.first
+
+      Spy.on(membership_invitation, :use_for_and_notify!).and_raise(ArgumentError)
+
+      form = form_class.new(
+        user: user_class.new(webauthn_id: SecureRandom.hex),
+        membership_invitation: membership_invitation,
+        email: membership_invitation.email,
+        name: Faker::Name.name,
+        passkey_label: Faker::Computer.os,
+        webauthn_credential: dummy_webauthn_credential
+      )
+
+      assert_no_difference "#{user_class}.count" do
+      assert_no_difference "#{passkey_class}.count" do
+      assert_raises ArgumentError do
+        form.save!
+      end
+      end
+      end
+    end
+
+    test "save: raises an AlreadyUsedError if the membership_invitation has a user" do
+      membership_invitation = users.invited_user_2.membership_invitations.first
+
+      form = form_class.new(
+        user: user_class.new(webauthn_id: SecureRandom.hex),
+        membership_invitation: membership_invitation,
+        email: Faker::Internet.email,
+        name: Faker::Name.name,
+        passkey_label: Faker::Computer.os,
+        webauthn_credential: dummy_webauthn_credential
+      )
+
+      assert_no_difference "#{user_class}.count" do
+      assert_no_difference "#{passkey_class}.count" do
+      assert_raises MembershipInvitation::AlreadyUsedError do
+        form.save!
+      end
+      end
+      end
+    end
+
+    test """save:
+      - creates the user with the given email & name
+      - creates the passkey for the user
+      - enqueues the email that the membership_invitation has been accepted
+    """ do
+      membership_invitation = organizations.organization_3.membership_invitations.first
+
+      credential = dummy_webauthn_credential
+
+      form = form_class.new(
+        user: user_class.new(webauthn_id: SecureRandom.hex),
+        membership_invitation: membership_invitation,
+        email: membership_invitation.email,
+        name: Faker::Name.name,
+        passkey_label: Faker::Computer.os,
+        webauthn_credential: credential
+      )
+
+      time = Time.now.utc
+
+      Timecop.freeze(time) do
+      assert_difference "#{user_class}.count", +1 do
+      assert_difference "#{passkey_class}.count", +1 do
+        form.save!
+      end
+      end
+      end
+
+      membership_invitation.reload
+
+      new_user = form.user
+
+      assert_equal true, new_user.persisted?
+      assert_equal form.email, new_user.email
+      assert_equal form.name, new_user.name
+
+      assert_equal new_user, membership_invitation.user
+
+      new_passkey = form.user.passkeys.first
+
+      assert_equal true, new_passkey.persisted?
+      assert_equal form.passkey_label, new_passkey.label
+      assert_equal credential.public_key, new_passkey.public_key
+      assert_equal time.to_formatted_s(:db), new_passkey.created_at.to_formatted_s(:db)
+    end
+  end
+end

data/app/lib/practical/test/shared/memberships/forms/organization/membership.rb

@@ -0,0 +1,162 @@
+# frozen_string_literal: true
+
+module Practical::Test::Shared::Memberships::Forms::Organization::Membership
+  extend ActiveSupport::Concern
+
+  included do
+    test "raises a validation error if trying to archive the only organization_manager" do
+      user = users.organization_2_owner
+      organization = organizations.organization_2
+      membership = user.memberships.find_by!(organization: organization)
+
+      form = form_class.new(current_user: user,
+                            current_organization: organization,
+                            membership: membership,
+                            state: :archived_by_organization
+                          )
+
+      assert_raises ActiveModel::ValidationError do
+        form.save!
+      end
+
+      assert_equal true, form.errors.of_kind?(:state, :cannot_be_archived)
+      assert_equal true, membership.reload.active?
+    end
+
+    test "can archive an organization_manager" do
+      user = users.organization_1_owner
+      organization = organizations.organization_1
+      membership = users.organization_1_manager.memberships.find_by!(organization: organization)
+
+      form = form_class.new(current_user: user,
+                            current_organization: organization,
+                            membership: membership,
+                            state: :archived_by_organization
+                          )
+
+      form.save!
+
+      assert_equal true, membership.reload.archived_by_organization?
+    end
+
+    test "can change an archived_by_organization membership to pending_reacceptance" do
+      user = users.organization_1_owner
+      organization = organizations.organization_1
+      membership = users.retired_staff.memberships.find_by!(organization: organization)
+
+      form = form_class.new(current_user: user,
+                            current_organization: organization,
+                            membership: membership,
+                            state: :pending_reacceptance
+                          )
+
+      form.save!
+
+      assert_equal true, membership.reload.pending_reacceptance?
+    end
+
+    test "can change a pending_reacceptance membership to archived_by_organization" do
+      user = users.organization_2_owner
+      organization = organizations.organization_2
+      membership = users.organization_1_staff.memberships.find_by!(organization: organization)
+
+      form = form_class.new(current_user: user,
+                            current_organization: organization,
+                            membership: membership,
+                            state: :archived_by_organization
+                          )
+
+      form.save!
+
+      assert_equal true, membership.reload.archived_by_organization?
+    end
+
+    test "cannot change the membership_type for the only organization_manager" do
+      user = users.organization_2_owner
+      organization = organizations.organization_2
+      membership = user.memberships.find_by!(organization: organization)
+
+      form = form_class.new(current_user: user,
+                            current_organization: organization,
+                            membership: membership,
+                            membership_type: :staff
+                          )
+
+      assert_raises ActiveModel::ValidationError do
+        form.save!
+      end
+
+      assert_equal true, form.errors.of_kind?(:membership_type, :cannot_be_downgraded)
+      assert_equal true, membership.reload.active?
+      assert_equal true, membership.reload.organization_manager?
+    end
+
+    test "can change the membership_type for an organization_manager" do
+      user = users.organization_1_owner
+      organization = organizations.organization_1
+      membership = users.organization_1_manager.memberships.find_by!(organization: organization)
+
+      form = form_class.new(current_user: user,
+                            current_organization: organization,
+                            membership: membership,
+                            membership_type: :staff
+                          )
+
+      form.save!
+
+      assert_equal true, membership.reload.active?
+      assert_equal true, membership.reload.staff?
+    end
+
+    test "can change the membership_type for a staff member" do
+      user = users.organization_1_owner
+      organization = organizations.organization_1
+      membership = users.works_at_org_1_and_2.memberships.find_by!(organization: organization)
+
+      form = form_class.new(current_user: user,
+                            current_organization: organization,
+                            membership: membership,
+                            membership_type: :organization_manager
+                          )
+
+      form.save!
+
+      assert_equal true, membership.reload.active?
+      assert_equal true, membership.reload.organization_manager?
+    end
+
+    test "can change the membership_type for an archived membership" do
+      user = users.organization_1_owner
+      organization = organizations.organization_1
+      membership = users.retired_staff.memberships.find_by!(organization: organization)
+
+      form = form_class.new(current_user: user,
+                            current_organization: organization,
+                            membership: membership,
+                            membership_type: :organization_manager
+                          )
+
+      form.save!
+
+      assert_equal true, membership.reload.archived_by_organization?
+      assert_equal true, membership.reload.organization_manager?
+    end
+
+    test "can change the membership_type for a pending_reacceptance membership" do
+      user = users.organization_2_owner
+      organization = organizations.organization_2
+      membership = users.organization_1_staff.memberships.find_by!(organization: organization)
+
+      form = form_class.new(current_user: user,
+                            current_organization: organization,
+                            membership: membership,
+                            membership_type: :organization_manager
+                          )
+
+      form.save!
+
+      assert_equal true, membership.reload.pending_reacceptance?
+      assert_equal true, membership.reload.organization_manager?
+    end
+  end
+end

data/app/lib/practical/test/shared/memberships/forms/organization/new_membership_invitation.rb

@@ -0,0 +1,195 @@
+# frozen_string_literal: true
+
+module Practical::Test::Shared::Memberships::Forms::Organization::NewMembershipInvitation
+  extend ActiveSupport::Concern
+
+  included do
+    test "save!: raises a validation error if the email is blank" do
+      form = form_class.new(email: "    ")
+      assert_raises ActiveModel::ValidationError do
+        form.save!
+      end
+
+      assert_equal true, form.errors.of_kind?(:email, :blank)
+    end
+
+    test "save!: raises a validation error if the current_organization is missing" do
+      form = form_class.new(current_organization: nil)
+      assert_raises ActiveModel::ValidationError do
+        form.save!
+      end
+
+      assert_equal true, form.errors.of_kind?(:current_organization, :blank)
+    end
+
+    test "save!: raises validation errors from the underlying MembershipInvitation object" do
+      form = form_class.new(email: Faker::Internet.email,
+                            current_organization: organizations.organization_1,
+                            sender: users.organization_2_owner,
+                            membership_type: :organization_manager
+                          )
+
+      assert_raises ActiveRecord::RecordInvalid do
+        form.save!
+      end
+
+      assert_equal true, form.errors.of_kind?(:sender, :cannot_manage_organization)
+    end
+
+    test "save!: creates a new MembershipInvitation and enqueues the email" do
+      email = Faker::Internet.email
+      form = form_class.new(email: email,
+                            current_organization: organizations.organization_1,
+                            sender: users.organization_1_manager,
+                            membership_type: :staff
+                           )
+
+      time = Time.now.utc
+
+      assert_difference "#{membership_invitation_class}.count", +1 do
+      assert_no_difference "#{membership_class}.count" do
+      Timecop.freeze(time) do
+        form.save!
+      end
+      end
+      end
+
+      assert_equal email, form.invitation.email
+      assert_equal "staff", form.invitation.membership_type
+      assert_equal organizations.organization_1, form.invitation.organization
+      assert_equal users.organization_1_manager, form.invitation.sender
+
+      assert_enqueued_email_with(MembershipInvitationMailer, :invitation, args: [{membership_invitation: form.invitation}])
+      assert_equal time.to_fs(:db), form.invitation.last_sent_at.to_fs(:db)
+    end
+
+    test "save!: re-sends a MembershipInvitation where we can re-send the email" do
+      email = Faker::Internet.email
+
+      existing_invitation = organizations.organization_1.membership_invitations.create!(email: email, sender: users.organization_1_owner, membership_type: :organization_manager)
+
+      form = form_class.new(email: email,
+                            current_organization: organizations.organization_1,
+                            sender: users.organization_1_manager,
+                            membership_type: :staff
+                           )
+
+      time = Time.now.utc
+
+      assert_no_difference "#{membership_invitation_class}.count" do
+      assert_no_difference "#{membership_class}.count" do
+      Timecop.freeze(time) do
+        form.save!
+      end
+      end
+      end
+
+      assert_equal email, form.invitation.email
+      assert_equal "organization_manager", form.invitation.membership_type
+      assert_equal organizations.organization_1, form.invitation.organization
+      assert_equal users.organization_1_owner, form.invitation.sender
+
+      assert_enqueued_email_with(MembershipInvitationMailer, :invitation, args: [{membership_invitation: existing_invitation}])
+      assert_equal time.to_fs(:db), form.invitation.last_sent_at.to_fs(:db)
+    end
+
+    test "save!: returns an error if the MembershipInvitation cannot be re-sent" do
+      user = users.organization_1_staff
+      email = user.email
+      existing_invitation = organizations.organization_1.membership_invitations.create!(email: email, sender: users.organization_1_manager, membership_type: :staff, user: user)
+
+      form = form_class.new(email: email,
+                            current_organization: organizations.organization_1,
+                            sender: users.organization_1_manager,
+                            membership_type: :staff
+                           )
+
+      assert_no_difference "#{membership_invitation_class}.count" do
+      assert_no_difference "#{membership_class}.count" do
+      assert_raises ActiveModel::ValidationError do
+        form.save!
+      end
+      end
+      end
+
+      assert_equal true, form.errors.of_kind?(:base, :cannot_be_resent)
+      assert_no_enqueued_emails
+    end
+
+    test "save!: returns an error if the Membership is archived_by_user" do
+      user = users.organization_1_staff
+      email = user.email
+      organization = organizations.organization_2
+
+      existing_membership = user.memberships.find_by!(organization: organization)
+      existing_membership.update!(state: :archived_by_user)
+
+      form = form_class.new(email: email,
+                            current_organization: organizations.organization_2,
+                            sender: users.organization_2_owner,
+                            membership_type: :staff
+                           )
+
+      assert_no_difference "#{membership_invitation_class}.count" do
+      assert_no_difference "#{membership_class}.count" do
+      assert_raises ActiveModel::ValidationError do
+        form.save!
+      end
+      end
+      end
+
+      assert_equal true, form.errors.of_kind?(:base, :cannot_be_resent)
+      assert_no_enqueued_emails
+    end
+
+    test "save!: transitions an archived_by_organization Membership to pending_reacceptance and stores the underlying membership" do
+      user = users.retired_staff
+      email = user.email
+      organization = organizations.organization_1
+
+      existing_membership = user.memberships.find_by!(organization: organization)
+
+      form = form_class.new(email: email,
+                            current_organization: organizations.organization_1,
+                            sender: users.organization_1_manager,
+                            membership_type: :staff
+                          )
+
+      assert_no_difference "#{membership_invitation_class}.count" do
+      assert_no_difference "#{membership_class}.count" do
+        form.save!
+      end
+      end
+
+      assert_equal existing_membership, form.existing_membership
+      assert_nil form.invitation
+      assert_equal "pending_reacceptance", form.existing_membership.state
+      assert_no_enqueued_emails
+    end
+
+    test "save!: does nothing to an already active Membership and stores the underlying membership" do
+      user = users.works_at_org_1_and_2
+      email = user.email
+      organization = organizations.organization_1
+
+      existing_membership = user.memberships.find_by!(organization: organization)
+
+      form = form_class.new(email: email,
+                            current_organization: organizations.organization_1,
+                            sender: users.organization_1_manager,
+                            membership_type: :staff
+                          )
+
+      assert_no_difference "#{membership_invitation_class}.count" do
+      assert_no_difference "#{membership_class}.count" do
+        form.save!
+      end
+      end
+
+      assert_equal existing_membership, form.existing_membership
+      assert_nil form.invitation
+      assert_equal "active", form.existing_membership.state
+      assert_no_enqueued_emails
+    end
+  end
+end

data/app/lib/practical/test/shared/memberships/forms/user/membership.rb

@@ -0,0 +1,87 @@
+# frozen_string_literal: true
+
+module Practical::Test::Shared::Memberships::Forms::User::Membership
+  extend ActiveSupport::Concern
+
+  included do
+    test "raises a validation error if trying to leave as the only organization_manager" do
+      user = users.organization_2_owner
+      organization = organizations.organization_2
+      membership = user.memberships.find_by!(organization: organization)
+
+      form = form_class.new(current_user: user,
+                            membership: membership,
+                            state: :archived_by_user
+                            )
+
+      assert_raises ActiveModel::ValidationError do
+        form.save!
+      end
+
+      assert_equal true, form.errors.of_kind?(:state, :cannot_be_archived)
+      assert_equal true, membership.reload.active?
+    end
+
+    test "can archive an organization_manager" do
+      user = users.organization_1_manager
+      organization = organizations.organization_1
+      membership = user.memberships.find_by!(organization: organization)
+
+      form = form_class.new(current_user: user,
+                            membership: membership,
+                            state: :archived_by_user
+                          )
+
+      form.save!
+
+      assert_equal true, membership.reload.archived_by_user?
+    end
+
+    test "cannot change an archived_by_user membership" do
+      user = users.retired_staff
+      organization = organizations.organization_1
+      membership = user.memberships.find_by!(organization: organization)
+      membership.update!(state: :archived_by_user)
+
+      form = form_class.new(current_user: user,
+                            membership: membership,
+                            state: :pending_reacceptance
+                          )
+
+      assert_raises ActiveModel::ValidationError do
+        form.save!
+      end
+
+      assert_equal true, form.errors.of_kind?(:state, :inclusion)
+      assert_equal true, membership.reload.archived_by_user?
+    end
+
+    test "can change a pending_reacceptance membership to archived_by_user" do
+      user = users.organization_1_staff
+      organization = organizations.organization_2
+      membership = user.memberships.find_by!(organization: organization)
+
+      form = form_class.new(current_user: user,
+                            membership: membership,
+                            state: :archived_by_user
+                            )
+
+      form.save!
+
+      assert_equal true, membership.reload.archived_by_user?
+    end
+
+    test "cannot change the membership_type" do
+      user = users.organization_2_owner
+      organization = organizations.organization_2
+      membership = user.memberships.find_by!(organization: organization)
+
+      assert_raises ActiveModel::UnknownAttributeError do
+        form = form_class.new(current_user: user,
+                              membership: membership,
+                              membership_type: :staff
+                              )
+      end
+    end
+  end
+end