pra 1.6.0 → 1.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 03c59b837ccbcf54d3ac74f7f8a17f4fcbdb9923
-  data.tar.gz: 8a131655f65e9c78aeefe47437c535effefe9df9
+  metadata.gz: a063ef78ae81ceafd14952d89b66d26d845d273f
+  data.tar.gz: ed692ee5c5c21002c1b2ca6474ee43f49c75c7c4
 SHA512:
-  metadata.gz: df4b092a5dff5a08824616d9e3a5b81abf9a297a322d377ae82dcb34192325d84b8dfe2e9bdc64357ddd48985215fc4528f4404e901b847aaea1da6ec6e682b2
-  data.tar.gz: a89c5bb3946700258e83554aaa35822ef61751955fb4b9adf758cd3bef30c32345315c0f65ab926a2a28748d38b859a86607545eb8720dfebfaa31e91d6a3377
+  metadata.gz: 8037f43d080d52c638a686f28d44098ee7a200653dd0249ce0ded97659ac39aee205ad0c6dd7cffd762bbedda74d70bd4feb11353793e56c475915e1435637ac
+  data.tar.gz: 37c1b7759f3075bbf9dbe4c4c321f5602ffd0f57f78679ace1cbc8cdf801eaf1586ffd0fbf50f395121d702917dfb62653786c5fbc86547179e3e2dee60f199f

data/.ruby-version

@@ -1 +1 @@
-2.1.5
+2.2.3

data/CODE_OF_CONDUCT.md

@@ -0,0 +1,13 @@
+# Contributor Code of Conduct
+
+As contributors and maintainers of this project, we pledge to respect all people who contribute through reporting issues, posting feature requests, updating documentation, submitting pull requests or patches, and other activities.
+
+We are committed to making participation in this project a harassment-free experience for everyone, regardless of level of experience, gender, gender identity and expression, sexual orientation, disability, personal appearance, body size, race, ethnicity, age, or religion.
+
+Examples of unacceptable behavior by participants include the use of sexual language or imagery, derogatory comments or personal attacks, trolling, public or private harassment, insults, or other unprofessional conduct.
+
+Project maintainers have the right and responsibility to remove, edit, or reject comments, commits, code, wiki edits, issues, and other contributions that are not aligned to this Code of Conduct. Project maintainers who do not follow the Code of Conduct may be removed from the project team.
+
+Instances of abusive, harassing, or otherwise unacceptable behavior may be reported by opening an issue or contacting one or more of the project maintainers.
+
+This Code of Conduct is adapted from the [Contributor Covenant](http://contributor-covenant.org), version 1.0.0, available at [http://contributor-covenant.org/version/1/0/0/](http://contributor-covenant.org/version/1/0/0/)

data/ChangeLog.md

@@ -6,6 +6,17 @@ versions as well as provide a rough history.
 
 #### Next Release
 
+#### v1.7.0
+
+* Upgrade to latest gem standards
+* Fix flash on navigation change
+* Switch to default terminal color scheme
+* Add light weight logging with timestamps
+* Add Ruby 2.2.3 support
+* Add Ruby 2.2.2 support
+
+#### v1.6.0
+
 * Switch to using Faraday instead of RestClient.
 
 #### v1.5.1

data/Gemfile

@@ -1,4 +1,4 @@
 source 'https://rubygems.org'
 
-# Specify your gem's dependencies in clipuller.gemspec
+# Specify your gem's dependencies in pra.gemspec
 gemspec

data/bin/console

@@ -0,0 +1,14 @@
+#!/usr/bin/env ruby
+
+require "bundler/setup"
+require "pra"
+
+# You can add fixtures and/or initialization code here to make experimenting
+# with your gem easier. You can also use a different console, if you like.
+
+# (If you use this, don't forget to add pry to your Gemfile!)
+# require "pry"
+# Pry.start
+
+require "irb"
+IRB.start

data/bin/setup

@@ -0,0 +1,7 @@
+#!/bin/bash
+set -euo pipefail
+IFS=$'\n\t'
+
+bundle install
+
+# Do any other automated setup that you need to do here

data/lib/pra/config.rb

@@ -29,6 +29,10 @@ module Pra
       return File.join(self.users_home_directory, '.pra.errors.log')
     end
 
+    def self.log_path
+      return File.join(self.users_home_directory, '.pra.log')
+    end
+
     def self.users_home_directory
       return ENV['HOME']
     end

data/lib/pra/curses_window_system.rb

@@ -69,8 +69,9 @@ module Pra
       Curses.init_screen
       Curses.stdscr.keypad(true)
       Curses.start_color
+      Curses.use_default_colors
       Curses.curs_set(0)
-      Curses.init_pair(1, Curses::COLOR_CYAN, Curses::COLOR_BLACK)
+      Curses.init_pair(Curses::COLOR_CYAN, Curses::COLOR_CYAN, Curses::COLOR_WHITE)
     end
 
     def output_string(row, col, str)
@@ -81,7 +82,7 @@ module Pra
     end
 
     def output_highlighted_string(row, col, str)
-      Curses.attron(Curses.color_pair(1)|Curses::A_NORMAL) {
+      Curses.attron(Curses.color_pair(Curses::COLOR_CYAN)|Curses::A_NORMAL) {
         output_string(row, col, str)
       }
     end
@@ -116,9 +117,14 @@ module Pra
         output_string(HEADER_LINE, 0, "repository      title                   from_reference          to_reference            author                  assignee                service")
         output_string(HEADER_LINE + 1, 0, "-----------------------------------------------------------------------------------------------------------------------------------------------")
 
-        (LIST_START_LINE...LIST_START_LINE+@previous_number_of_pull_requests).each do |i|
-          Curses.setpos(i,0)
-          Curses.clrtoeol
+        if @previous_number_of_pull_requests > @current_pull_requests.length
+          num_left_over = @previous_number_of_pull_requests - @current_pull_requests.length
+          start_line_of_left_overs = LIST_START_LINE+@current_pull_requests.length + 1
+          last_line_of_left_overs = LIST_START_LINE+@previous_number_of_pull_requests
+          (start_line_of_left_oversc...last_line_of_left_overs).each do |i|
+            Curses.setpos(i,0)
+            Curses.clrtoeol
+          end
           Curses.refresh
         end
 

data/lib/pra/error_log.rb

@@ -1,12 +1,13 @@
 require 'pra/config'
+require 'date'
 
 module Pra
   class ErrorLog
     def self.log(error)
       File.open(Pra::Config.error_log_path, 'a') do |f|
-        f.puts(error.message)
+        f.puts("#{DateTime.now.iso8601} - #{error.message}")
         error.backtrace.each { |line| f.puts(line) }
       end
     end
   end
-end
+end

data/lib/pra/log.rb

@@ -0,0 +1,12 @@
+require 'pra/config'
+require 'date'
+
+module Pra
+  class Log
+    def self.log(message)
+      File.open(Pra::Config.log_path, 'a') do |f|
+        f.puts("#{DateTime.now.iso8601} - #{message}")
+      end
+    end
+  end
+end

data/lib/pra/version.rb

@@ -1,3 +1,3 @@
 module Pra
-  VERSION = "1.6.0"
+  VERSION = "1.7.0"
 end

data/pra.gemspec

@@ -10,17 +10,19 @@ Gem::Specification.new do |spec|
   spec.email         = ["cyphactor@gmail.com"]
   spec.description   = %q{Command Line utility to make you aware of open pull-requests across systems at all times.}
   spec.summary       = %q{CLI tool that shows open pull-requests across systems.}
-  spec.homepage      = "http://github.com/reachlocal/pra"
+  spec.homepage      = "http://github.com/codebreakdown/pra"
   spec.license       = "MIT"
 
-  spec.files         = `git ls-files`.split($/)
-  spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
+  spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
+  spec.bindir        = "exe"
+  spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_development_dependency "bundler", "~> 1.5"
+  spec.add_development_dependency "bundler", "~> 1.10"
   spec.add_development_dependency "rake", "~> 10.1"
   spec.add_development_dependency "rspec", "~> 2.14"
+  spec.add_development_dependency "timecop", "~> 0.8"
 
   spec.add_dependency "faraday", "~> 0.9"
   spec.add_dependency "launchy", "~> 2.4"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pra
 version: !ruby/object:Gem::Version
-  version: 1.6.0
+  version: 1.7.0
 platform: ruby
 authors:
 - Andrew De Ponte
 autorequire: 
-bindir: bin
+bindir: exe
 cert_chain: []
-date: 2014-11-18 00:00:00.000000000 Z
+date: 2015-10-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.5'
+        version: '1.10'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.5'
+        version: '1.10'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -52,6 +52,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.14'
+- !ruby/object:Gem::Dependency
+  name: timecop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.8'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.8'
 - !ruby/object:Gem::Dependency
   name: faraday
   requirement: !ruby/object:Gem::Requirement
@@ -105,12 +119,15 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".ruby-version"
+- CODE_OF_CONDUCT.md
 - ChangeLog.md
 - Gemfile
 - LICENSE.txt
 - README.md
 - Rakefile
-- bin/pra
+- bin/console
+- bin/setup
+- exe/pra
 - lib/pra.rb
 - lib/pra/app.rb
 - lib/pra/config.rb
@@ -118,6 +135,7 @@ files:
 - lib/pra/curses_window_system.rb
 - lib/pra/error_log.rb
 - lib/pra/github_pull_source.rb
+- lib/pra/log.rb
 - lib/pra/pull_request.rb
 - lib/pra/pull_request_service.rb
 - lib/pra/pull_request_service/fetch_status.rb
@@ -128,22 +146,7 @@ files:
 - lib/pra/window_system.rb
 - lib/pra/window_system_factory.rb
 - pra.gemspec
-- spec/lib/pra/app_spec.rb
-- spec/lib/pra/config_spec.rb
-- spec/lib/pra/curses_pull_request_presenter_spec.rb
-- spec/lib/pra/curses_window_system_spec.rb
-- spec/lib/pra/error_log_spec.rb
-- spec/lib/pra/github_pull_source_spec.rb
-- spec/lib/pra/pull_request_service/fetch_status_spec.rb
-- spec/lib/pra/pull_request_service_spec.rb
-- spec/lib/pra/pull_request_spec.rb
-- spec/lib/pra/pull_source_factory_spec.rb
-- spec/lib/pra/pull_source_spec.rb
-- spec/lib/pra/stash_pull_source_spec.rb
-- spec/lib/pra/window_system_factory_spec.rb
-- spec/lib/pra/window_system_spec.rb
-- spec/spec_helper.rb
-homepage: http://github.com/reachlocal/pra
+homepage: http://github.com/codebreakdown/pra
 licenses:
 - MIT
 metadata: {}
@@ -163,23 +166,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.5.1
 signing_key: 
 specification_version: 4
 summary: CLI tool that shows open pull-requests across systems.
-test_files:
-- spec/lib/pra/app_spec.rb
-- spec/lib/pra/config_spec.rb
-- spec/lib/pra/curses_pull_request_presenter_spec.rb
-- spec/lib/pra/curses_window_system_spec.rb
-- spec/lib/pra/error_log_spec.rb
-- spec/lib/pra/github_pull_source_spec.rb
-- spec/lib/pra/pull_request_service/fetch_status_spec.rb
-- spec/lib/pra/pull_request_service_spec.rb
-- spec/lib/pra/pull_request_spec.rb
-- spec/lib/pra/pull_source_factory_spec.rb
-- spec/lib/pra/pull_source_spec.rb
-- spec/lib/pra/stash_pull_source_spec.rb
-- spec/lib/pra/window_system_factory_spec.rb
-- spec/lib/pra/window_system_spec.rb
-- spec/spec_helper.rb
+test_files: []

data/spec/lib/pra/app_spec.rb

@@ -1,91 +0,0 @@
-require_relative "../../../lib/pra/app"
-
-describe Pra::App do
-  describe "#run" do
-    it "builds the window system" do
-      subject.stub(:spawn_pull_request_fetcher)
-      window_system_double = double('window system', setup: nil, run_loop: nil)
-      expect(Pra::WindowSystemFactory).to receive(:build).with('curses').and_return(window_system_double)
-      subject.run
-    end
-
-    it "sets up the window system" do
-      subject.stub(:spawn_pull_request_fetcher)
-      window_system_double = double('window system', run_loop: nil)
-      Pra::WindowSystemFactory.stub(:build).and_return(window_system_double)
-      expect(window_system_double).to receive(:setup)
-      subject.run
-    end
-
-    it "spawns the pull request fetcher thread" do
-      window_system_double = double('window system', setup: nil, run_loop: nil)
-      Pra::WindowSystemFactory.stub(:build).and_return(window_system_double)
-      expect(subject).to receive(:spawn_pull_request_fetcher)
-      subject.run
-    end
-
-    it "starts the window system run loop" do
-      subject.stub(:spawn_pull_request_fetcher)
-      window_system_double = double('window system', setup: nil, refresh_pull_requests: nil)
-      Pra::WindowSystemFactory.stub(:build).and_return(window_system_double)
-      expect(window_system_double).to receive(:run_loop)
-      subject.run
-    end
-  end
-
-  describe "#fetch_and_refresh_pull_requests" do
-    let(:pull_request_one) { double }
-    let(:pull_request_two) { double }
-    let(:error) { double('error fetching pull requests', message: double('error message'), backtrace: double('backtrace')) }
-    let(:good_source_one) { double('good pull source one', :pull_requests => [pull_request_one]) }
-    let(:good_source_two) { double('good pull source two', :pull_requests => [pull_request_two])}
-    let(:bad_source) { double('bad pull source') }
-    let(:success_status_one) { Pra::PullRequestService::FetchStatus.success([pull_request_one]) }
-    let(:success_status_two) { Pra::PullRequestService::FetchStatus.success([pull_request_two])}
-    let(:error_status) { Pra::PullRequestService::FetchStatus.error(error) }
-    let(:window_system_double) { double('window system', refresh_pull_requests: nil, fetch_failed: nil, fetching_pull_requests: nil) }
-
-    before do
-      allow(Kernel).to receive(:sleep)
-      allow(Pra::PullRequestService).to receive(:fetch_pull_requests).
-        and_yield(success_status_one).
-        and_yield(error_status).
-        and_yield(success_status_two)
-      allow(Pra::ErrorLog).to receive(:log)
-      subject.instance_variable_set(:@window_system, window_system_double)
-    end
-
-    it "notifies the window system it is starting to fetch pull requests" do
-      expect(window_system_double).to receive(:fetching_pull_requests)
-      subject.fetch_and_refresh_pull_requests
-    end
-
-    it "fetches the pull requests from all of the sources" do
-      expect(Pra::PullRequestService).to receive(:fetch_pull_requests)
-      subject.fetch_and_refresh_pull_requests
-    end
-
-    it "tells the window system to refresh with the fetched pull requests" do
-      expect(window_system_double).to receive(:refresh_pull_requests).with([pull_request_one, pull_request_two])
-      subject.fetch_and_refresh_pull_requests
-    end
-
-    it "tells the window system about failures" do
-      expect(window_system_double).to receive(:fetch_failed)
-      subject.fetch_and_refresh_pull_requests
-    end
-
-    it "logs the errors for pull sources that could not be fetched" do
-      expect(Pra::ErrorLog).to receive(:log).with(error)
-      subject.fetch_and_refresh_pull_requests
-    end
-
-    it "sleeps for the polling frequency" do
-      window_system_double = double('window system', refresh_pull_requests: nil, fetching_pull_requests: nil)
-      subject.instance_variable_set(:@window_system, window_system_double)
-      Pra::PullRequestService.stub(:fetch_pull_requests)
-      expect(Kernel).to receive(:sleep)
-      subject.fetch_and_refresh_pull_requests
-    end
-  end
-end

data/spec/lib/pra/config_spec.rb

@@ -1,154 +0,0 @@
-require_relative "../../../lib/pra/config"
-
-describe Pra::Config do
-  describe "#initialize" do
-    it "assigns the provide default config hash" do
-      config_hash = { some: "hash" }
-      config = Pra::Config.new(config_hash)
-      config.instance_variable_get(:@initial_config).should eq(config_hash)
-    end
-  end
-
-  describe ".load_config" do
-    subject { Pra::Config }
-
-    it "parses the config file" do
-      subject.should_receive(:parse_config_file)
-      subject.load_config
-    end
-
-    it "constructs an instance of the config from the parsed config" do
-      parsed_config = double('parsed config file')
-      subject.stub(:parse_config_file).and_return(parsed_config)
-      subject.should_receive(:new).with(parsed_config)
-      subject.load_config
-    end
-
-    it "returns the instance of the config object" do
-      subject.stub(:parse_config_file)
-      config = double('config')
-      subject.stub(:new).and_return(config)
-      subject.load_config.should eq(config)
-    end
-  end
-
-  describe ".parse_config_file" do
-    subject { Pra::Config }
-
-    it "reads the users config" do
-      subject.stub(:json_parse)
-      subject.should_receive(:read_config_file)
-      subject.parse_config_file
-    end
-
-    it "json parses the config contents" do
-      config_contents = double('config contents')
-      subject.stub(:read_config_file).and_return(config_contents)
-      subject.should_receive(:json_parse).with(config_contents)
-      subject.parse_config_file
-    end
-  end
-
-  describe ".read_config_file" do
-    subject { Pra::Config }
-
-    it "opens the file" do
-      config_path = double('config path')
-      subject.stub(:config_path).and_return(config_path)
-      File.should_receive(:open).with(config_path, "r").and_return(double('config file').as_null_object)
-      subject.read_config_file
-    end
-
-    it "reads the files contents" do
-      subject.stub(:config_path)
-      file = double('config file').as_null_object
-      File.stub(:open).and_return(file)
-      file.should_receive(:read)
-      subject.read_config_file
-    end
-
-    it "closes the file" do
-      subject.stub(:config_path)
-      file = double('config file', read: nil)
-      File.stub(:open).and_return(file)
-      file.should_receive(:close)
-      subject.read_config_file
-    end
-
-    it "returns the file contents" do
-      subject.stub(:config_path)
-      file = double('config file', close: nil)
-      File.stub(:open).and_return(file)
-      file.stub(:read).and_return('some file contents')
-      subject.read_config_file.should eq('some file contents')
-    end
-  end
-
-  describe ".config_path" do
-    subject { Pra::Config }
-
-    it "returns the joined users home directory and .pra.json to create the path" do
-      subject.stub(:users_home_directory).and_return('/home/someuser')
-      subject.config_path.should eq('/home/someuser/.pra.json')
-    end
-  end
-
-  describe ".error_log_path" do
-    subject { Pra::Config }
-
-    it "returns the joined users home directory and .pra.error.log to create the path" do
-      allow(subject).to receive(:users_home_directory).and_return('/home/someuser')
-      expect(subject.error_log_path).to eq('/home/someuser/.pra.errors.log')
-    end
-  end
-
-  describe ".users_home_directory" do
-    subject { Pra::Config }
-
-    it "returns the current users home directory" do
-      ENV['HOME'] = '/home/someuser'
-      subject.users_home_directory.should eq('/home/someuser')
-    end
-  end
-
-  describe ".json_parse" do
-    subject { Pra::Config }
-
-    it "parses the given content as json" do
-      content = double('some json content')
-      JSON.should_receive(:parse).with(content)
-      subject.json_parse(content)
-    end
-
-    it "returns the parsed result" do
-      parsed_json = double('the parsed json')
-      JSON.stub(:parse).and_return(parsed_json)
-      subject.json_parse(double).should eq(parsed_json)
-    end
-  end
-
-  describe "#pull_sources" do
-    it "returns the pull sources value out of the config" do
-      pull_source_configs = double('pull source configs')
-      subject.instance_variable_set(:@initial_config, { "pull_sources" => pull_source_configs })
-      subject.pull_sources.should eq(pull_source_configs)
-    end
-  end
-
-  describe "#assignee_blacklist" do
-    context 'when config has an assignee blacklist' do
-      it "returns the assignee blacklist value out of the config" do
-        assignee_blacklist_configs = [double('assignee blacklist configs')]
-        subject.instance_variable_set(:@initial_config, { "assignee_blacklist" => assignee_blacklist_configs })
-        subject.assignee_blacklist.should eq(assignee_blacklist_configs)
-      end
-    end
-
-    context "when config does not have an assignee blacklist" do
-      it "returns an empty array" do
-        subject.instance_variable_set(:@initial_config, {})
-        subject.assignee_blacklist.should eq([])
-      end
-    end
-  end
-end