ppl 1.22.1 → 1.22.2

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: fc9a9a697a887b27f8b6861bd558f92d14d0e7db
+  data.tar.gz: 76354097c49287e8c92a804bfbc9cf397eafa5fe
+SHA512:
+  metadata.gz: bd847a67287e56e12ea07d0b1cf1d0b902dcddd585bb4e7b5b09a8cb3168de0c10916651dd7f7ec126249a64f4b58b8fc5ff106936564c7d7f9cdd570ae42e74
+  data.tar.gz: 23c4c152e84c421afb380bc687c45db332c326f5c96ec4c91723de998aa299eda024ce773bcfbe5b11c8a1f3483222c53458091b1fcfdc37bcedcbcabecd8632

data/.travis.yml

@@ -3,5 +3,7 @@ language: ruby
 rvm:
   - 1.9.3
   - 2.0.0
-script: bundle exec rspec spec
+script:
+  - bundle exec rspec spec
+  - bundle exec cucumber
 

data/features/add.feature

@@ -0,0 +1,9 @@
+
+Feature: ppl add
+
+  Scenario: Add a new contact
+    Given I am in an empty address book
+    And I run "ppl add alice 'Alice Adams'"
+    Then there should be 1 contact
+    And its name should be "Alice Adams"
+

data/features/email.feature

@@ -0,0 +1,9 @@
+
+Feature: ppl email
+
+  Scenario: Add an email address to a contact
+    Given I am in an address book with a blank contact called bob
+    And I run "ppl email bob bob@example.org"
+    Then bob should have 1 email address
+    And the 1st email address should be "bob@example.org"
+

data/features/init.feature

@@ -0,0 +1,13 @@
+
+Feature: ppl init
+
+  Scenario: Create a new address book
+    Given I am in an empty directory
+    When I run "ppl init ./contacts"
+    Then "./contacts" should be a ppl address book
+
+  Scenario: Incorrect usage
+    Given I am in an empty directory
+    When I run "ppl init --invalid-option 2> /dev/null"
+    Then it should fail
+

data/features/org.feature

@@ -0,0 +1,9 @@
+
+Feature: ppl org
+
+  Scenario: Add an organization to a contact
+    Given I am in an address book with a blank contact called bob
+    And I run "ppl org bob 'Red Hat'"
+    Then bob should have 1 organization
+    And the 1st organization should be "Red Hat"
+

data/features/phone.feature

@@ -0,0 +1,14 @@
+
+Feature: ppl phone
+
+  Scenario: Add a phone number to a contact
+    Given I am in an address book with a blank contact called bob
+    And I run "ppl phone bob 01234567890"
+    Then bob should have 1 phone number
+    And the 1st phone number should be "01234567890"
+
+  Scenario: Remove a phone number from a contact
+    Given I am in the same address book as before
+    And I run "ppl phone bob --delete 01234567890"
+    Then bob should have 0 phone numbers
+

data/features/step_definitions/cwd_steps.rb

@@ -9,3 +9,25 @@ Given /^I am in an empty directory$/ do
   end
 end
 
+Given /^I am in an empty address book$/ do
+  @directory = Dir.mktmpdir
+  Dir.chdir @directory
+  ppl "init"
+  at_exit do
+    FileUtils.rm_rf @directory
+  end
+end
+
+Given /^I am in an address book with a blank contact called bob$/ do
+  @directory = Dir.mktmpdir
+  Dir.chdir @directory
+  ppl "init"
+  ppl "add bob Bob"
+  at_exit do
+    FileUtils.rm_rf @directory
+  end
+end
+
+Given /^I am in the same address book as before$/ do
+end
+

data/features/step_definitions/ppl_steps.rb

@@ -1,5 +1,54 @@
 
-When /^I run "(ppl [^"]+)"$/ do |command|
-  Kernel.system command
+def ppl(command)
+  project_root = File.dirname(File.dirname(File.dirname(__FILE__)))
+  ppl_location = File.join(project_root, "bin", "ppl")
+  real_command = "#{ppl_location} #{command}"
+  `#{real_command}`.strip
 end
 
+When /^I run "ppl ([^"]+)"$/ do |command|
+  ppl command
+end
+
+Then /^it should fail$/ do
+  $?.exitstatus.should_not eq 0
+end
+
+Then /^there should be 1 contact$/ do
+  contact_list = ppl("ls").strip.split("\n")
+  contact_list.length.should eq 1
+  @contact_id = contact_list[0].split(":").first
+end
+
+Then /^(bob) should have (\d+) email addresse?s?$/ do |name, number|
+  @email_addresses = ppl("email #{name}").split("\n")
+  @email_addresses.length.should eq number.to_i
+end
+
+Then /^(bob) should have (\d+) organizations?$/ do |name, number|
+  @organizations = ppl("org #{name}").split("\n")
+  @organizations.length.should eq number.to_i
+end
+
+Then /^(bob) should have (\d+) phone numbers?$/ do |name, number|
+  @phone_numbers = ppl("phone #{name}").split("\n")
+  @phone_numbers.length.should eq number.to_i
+end
+
+And /^its name should be "([^"]+)"$/ do |name|
+  ppl("name #{@contact_id}").should eq name
+end
+
+Then(/^the (\d+).. email address should be "([^"]+)"$/) do |nth, address|
+  @email_addresses[nth.to_i - 1].should eq address
+end
+
+Then(/^the (\d+).. organization should be "([^"]+)"$/) do |nth, organization|
+  @organizations[nth.to_i - 1].should eq organization
+end
+
+Then(/^the (\d+).. phone number should be "([^"]+)"$/) do |nth, phone_number|
+  @phone_numbers[nth.to_i - 1].should eq phone_number
+end
+
+

data/lib/ppl.rb

@@ -1,7 +1,7 @@
 
 module Ppl
 
-  Version = "1.22.1"
+  Version = "1.22.2"
 
   module Adapter
   end

data/lib/ppl/command/phone.rb

@@ -29,6 +29,12 @@ class Ppl::Command::Phone < Ppl::Command::Attribute
     true
   end
 
+  def remove_attribute(input, output)
+    contact = @storage.require_contact(input.arguments[0])
+    contact.phone_numbers.select! { |pn| pn.number != input.arguments[1] }
+    @storage.save_contact(contact)
+  end
+
   def new_number?(contact, input_number)
     matching_numbers = contact.phone_numbers.select do |pn|
       pn.number == input_number

data/ppl.gemspec

@@ -2,8 +2,8 @@
 Gem::Specification.new do |spec|
 
   spec.name        = "ppl"
-  spec.version     = "1.22.1"
-  spec.date        = "2013-04-20"
+  spec.version     = "1.22.2"
+  spec.date        = "2013-04-21"
 
   spec.required_ruby_version = ">= 1.9.3"
 

data/spec/ppl/command/phone_spec.rb

@@ -53,6 +53,16 @@ describe Ppl::Command::Phone do
       @command.execute(@input, @output)
     end
 
+    it "should delete the given number from the contact" do
+      @input.arguments = ["jdoe", "01234567"]
+      @input.options[:delete] = "true"
+      @contact.phone_numbers << Ppl::Entity::PhoneNumber.new("01234567")
+      @storage.should_receive(:save_contact) do |c|
+        c.phone_numbers.length.should eq 0
+      end
+      @command.execute(@input, @output)
+    end
+
   end
 
 end

metadata

@@ -1,20 +1,18 @@
 --- !ruby/object:Gem::Specification
 name: ppl
 version: !ruby/object:Gem::Version
-  version: 1.22.1
-  prerelease: 
+  version: 1.22.2
 platform: ruby
 authors:
 - Henry Smith
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-04-20 00:00:00.000000000 Z
+date: 2013-04-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: colored
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - '='
       - !ruby/object:Gem::Version
@@ -22,7 +20,6 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - '='
       - !ruby/object:Gem::Version
@@ -30,7 +27,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: inifile
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - '='
       - !ruby/object:Gem::Version
@@ -38,7 +34,6 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - '='
       - !ruby/object:Gem::Version
@@ -46,7 +41,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: mail
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - '='
       - !ruby/object:Gem::Version
@@ -54,7 +48,6 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - '='
       - !ruby/object:Gem::Version
@@ -62,7 +55,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: morphine
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - '='
       - !ruby/object:Gem::Version
@@ -70,7 +62,6 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - '='
       - !ruby/object:Gem::Version
@@ -78,7 +69,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: rugged
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - '='
       - !ruby/object:Gem::Version
@@ -86,7 +76,6 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - '='
       - !ruby/object:Gem::Version
@@ -94,7 +83,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: greencard
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - '='
       - !ruby/object:Gem::Version
@@ -102,7 +90,6 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - '='
       - !ruby/object:Gem::Version
@@ -110,65 +97,57 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: cucumber
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: fakefs
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: CLI Address Book
@@ -187,7 +166,11 @@ files:
 - bin/ppl
 - completions/bash
 - completions/zsh
-- features/init/create_repository.feature
+- features/add.feature
+- features/email.feature
+- features/init.feature
+- features/org.feature
+- features/phone.feature
 - features/step_definitions/address_book_steps.rb
 - features/step_definitions/cwd_steps.rb
 - features/step_definitions/ppl_steps.rb
@@ -342,26 +325,25 @@ files:
 homepage: http://ppladdressbook.org
 licenses:
 - GPL-2
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: 1.9.3
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.23
+rubygems_version: 2.0.3
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: CLI Address Book
 test_files: []

data/features/init/create_repository.feature

@@ -1,8 +0,0 @@
-
-Feature: create address book
-
-  Scenario: success
-    Given I am in an empty directory
-    When I run "ppl init ./contacts"
-    Then "./contacts" should be a ppl address book
-