ppl 0.9.0 → 1.0.0

data/lib/ppl/command/bday.rb

@@ -46,8 +46,13 @@ class Ppl::Command::Bday < Ppl::Application::Command
     end
     contact = @storage.require_contact(contact_id)
 
-    line = @show_format.process(contact)
-    output.line(line)
+    birthday = @show_format.process(contact)
+    if birthday != ""
+      output.line(birthday)
+      true
+    else
+      false
+    end
   end
 
   def set_birthday(input, output)

data/lib/ppl/command/email.rb

@@ -42,7 +42,12 @@ class Ppl::Command::Email < Ppl::Application::Command
   def show_email_address(input, output)
     contact       = @storage.require_contact(input.arguments[0])
     email_address = @show_format.process(contact)
-    output.line(email_address)
+    if email_address != ""
+      output.line(email_address)
+      true
+    else
+      false
+    end
   end
 
   def set_email_address(input, output)

data/lib/ppl/command/name.rb

@@ -41,7 +41,12 @@ class Ppl::Command::Name < Ppl::Application::Command
   def show_name(input, output)
     contact = @storage.require_contact(input.arguments[0])
     name    = @show_format.process(contact)
-    output.line(name)
+    if name != ""
+      output.line(name)
+      true
+    else
+      false
+    end
   end
 
   def set_name(input, output)

data/lib/ppl/command/org.rb

@@ -42,7 +42,12 @@ class Ppl::Command::Org < Ppl::Application::Command
   def show_organization(input, output)
     contact      = @storage.require_contact(input.arguments[0])
     organization = @show_format.process(contact)
-    output.line(organization)
+    if organization != ""
+      output.line(organization)
+      true
+    else
+      false
+    end
   end
 
   def set_organization(input, output)

data/lib/ppl/command/phone.rb

@@ -42,7 +42,12 @@ class Ppl::Command::Phone < Ppl::Application::Command
   def show_phone_number(input, output)
     contact = @storage.require_contact(input.arguments[0])
     number  = @show_format.process(contact)
-    output.line(number)
+    if number != ""
+      output.line(number)
+      true
+    else
+      false
+    end
   end
 
   def set_phone_number(input, output)

data/lib/ppl.rb

@@ -1,7 +1,7 @@
 
 module Ppl
 
-  Version = "0.9.0"
+  Version = "1.0.0"
 
   module Adapter
   end

data/ppl.gemspec

@@ -2,7 +2,7 @@
 Gem::Specification.new do |spec|
 
   spec.name        = "ppl"
-  spec.version     = "0.9.0"
+  spec.version     = "1.0.0"
   spec.date        = "2012-11-23"
 
   spec.summary     = "CLI Address Book"

data/spec/ppl/command/bday_spec.rb

@@ -22,23 +22,19 @@ describe Ppl::Command::Bday do
 
   describe "#execute" do
 
-    it "should list all birthdays if no contact is specified" do
-      #@input.arguments = []
-      #@command.execute(@input, @output)
-    end
-
-    it "should raise an error if the date given isn't a valid date" do
-      @storage.should_receive(:require_contact).and_return(@contact)
-      @input.arguments = ["jim", "poiuytrewq"]
-      expect{@command.execute(@input, @output)}.to raise_error(Ppl::Error::IncorrectUsage)
-    end
-
     it "should show the contact's birthday if no date is given" do
       @storage.should_receive(:require_contact).and_return(@contact)
       @show_format.should_receive(:process).and_return("1970-01-01")
       @output.should_receive(:line).with("1970-01-01")
       @input.arguments = ["jim"]
-      @command.execute(@input, @output)
+      @command.execute(@input, @output).should eq true
+    end
+
+    it "should not output anything if there's no birthday to show" do
+      @storage.should_receive(:require_contact).and_return(@contact)
+      @show_format.should_receive(:process).and_return("")
+      @input.arguments = ["jim"]
+      @command.execute(@input, @output).should eq false
     end
 
     it "should change the contact's birthday if a date is given" do

data/spec/ppl/command/email_spec.rb

@@ -38,7 +38,14 @@ describe Ppl::Command::Email do
       @show_format.should_receive(:process).and_return("jdoe@example.org")
       @output.should_receive(:line).with("jdoe@example.org")
       @input.arguments = ["jim"]
-      @command.execute(@input, @output)
+      @command.execute(@input, @output).should eq true
+    end
+
+    it "should not output anything if there's nothing to show" do
+      @storage.should_receive(:require_contact).and_return(@contact)
+      @show_format.should_receive(:process).and_return("")
+      @input.arguments = ["jim"]
+      @command.execute(@input, @output).should eq false
     end
 
     it "should change the contact's email address if an address is given" do

data/spec/ppl/command/name_spec.rb

@@ -41,7 +41,14 @@ describe Ppl::Command::Name do
       @show_format.should_receive(:process).and_return("John Doe")
       @output.should_receive(:line).with("John Doe")
       @input.arguments = ["jim"]
-      @command.execute(@input, @output)
+      @command.execute(@input, @output).should eq true
+    end
+
+    it "should not output anything if there's nothing to show" do
+      @storage.should_receive(:require_contact).and_return(@contact)
+      @show_format.should_receive(:process).and_return("")
+      @input.arguments = ["jim"]
+      @command.execute(@input, @output).should eq false
     end
 
     it "should change the contact's name if a name is given" do

data/spec/ppl/command/org_spec.rb

@@ -39,7 +39,14 @@ describe Ppl::Command::Org do
       @show_format.should_receive(:process).and_return("Example Ltd")
       @output.should_receive(:line).with("Example Ltd")
       @input.arguments = ["jim"]
-      @command.execute(@input, @output)
+      @command.execute(@input, @output).should eq true
+    end
+
+    it "should not output anything if there's nothing to show" do
+      @storage.should_receive(:require_contact).and_return(@contact)
+      @show_format.should_receive(:process).and_return("")
+      @input.arguments = ["jim"]
+      @command.execute(@input, @output).should eq false
     end
 
     it "should change the contact's organization if one is given" do

data/spec/ppl/command/phone_spec.rb

@@ -37,7 +37,14 @@ describe Ppl::Command::Phone do
       @show_format.should_receive(:process).and_return("0123456789")
       @output.should_receive(:line).with("0123456789")
       @input.arguments = ["jim"]
-      @command.execute(@input, @output)
+      @command.execute(@input, @output).should eq true
+    end
+
+    it "should not output anything if there's nothing to show" do
+      @storage.should_receive(:require_contact).and_return(@contact)
+      @show_format.should_receive(:process).and_return("")
+      @input.arguments = ["jim"]
+      @command.execute(@input, @output).should eq false
     end
 
     it "should change the contact's phone number if a number is given" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ppl
 version: !ruby/object:Gem::Version
-  version: 0.9.0
+  version: 1.0.0
   prerelease: 
 platform: ruby
 authors: