power-types 0.5.0 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0d925bbf270d6ba204b3e091b60f5b16a5f02e5c6a76a6cee0ce710ff148f548
-  data.tar.gz: f494be84a510e19471380a1b3163e8ccb5b320f7c3307b272090314297a0491c
+  metadata.gz: 97911d46926a1215cd7a114d6a90f8e6716a9181f0551bed8f74b8ed8718ae84
+  data.tar.gz: 21ca06565fb213947fa263e1e07ebe89348641413ee9d05c566cdd09b697d994
 SHA512:
-  metadata.gz: 8dcbe2f8d896b4f3de9431d79247ce76426528ebc206a8585f33770dab9f110ad9849f8d5a46435c6fcc3fd84493cddcdec5d6b1916ce7f238dd74d4a825f6d3
-  data.tar.gz: 26570fe587be13f151c0ac0627b361de02977ad32c3651ee1f5f6f7135b0357c33d55fe217931cc569a81a09756b8aff0efc7ef30c0d52cb35e9039db5aef87c
+  metadata.gz: f4abc5333d3bdfb2a1f687c31a351894393191ce61806a31f58c54c3dcc561a65d86d8cd9cfdea85041b9d0f4bc091cd040b51fce8bdded07836046f653af460
+  data.tar.gz: 4e7a652ee31cca5e1fa70051f9934813300385a8fcfb96f29d2137cec4b38c9a6ab51b4e3026749923405dccff9a8c5c519c1fdcba1bed0b0843fbfa6a5b954b

data/.circleci/config.yml

@@ -14,10 +14,10 @@ executors:
     parameters:
       ruby-version:
         description: "Ruby version"
-        default: "2.7"
+        default: "3.2"
         type: string
     docker:
-      - image: circleci/ruby:<<parameters.ruby-version>>-node
+      - image: cimg/ruby:<<parameters.ruby-version>>-node
         environment: *env-vars
 
 commands:
@@ -28,8 +28,8 @@ commands:
       - run:
           name: Install bundle dependencies
           command: |
-            gem install bundler:2.2.15
-            bundle install
+            gem install bundler:2.2.34
+            bundle _2.2.34_ install
 
 jobs:
   lint:
@@ -93,7 +93,7 @@ workflows:
       - test:
           matrix:
             parameters:
-              ruby-version: ["2.5", "2.6", "2.7"]
+              ruby-version: ["2.5", "2.6", "2.7", "3.1", "3.2"]
       - deploy:
           context: org-global
           filters:

data/.ruby-version

@@ -1 +1 @@
-2.7
+3.2

data/CHANGELOG.md

@@ -0,0 +1,10 @@
+# Changelog
+
+## 0.7.0
+
+Added
+  - Add after_destroy_commit callback [#25](https://github.com/platanus/power-types/pull/25)
+  - Add Ruby 3.2 support
+
+Fixed
+  - Fix presenter params decoration [#26](https://github.com/platanus/power-types/pull/26)

data/README.md

@@ -257,6 +257,8 @@ end
 ```
 Note: Triggering the event will preserve the order of the methods, so in the example `kill_villain` will be called before `bury_villains_corpse`.
 
+Recently we added four new callbacks, `after_create_commit`, `after_update_commit`, `after_save_commit` and `after_destroy_commit`. With these callbacks we want to reproduce the `after_commit` transactional callback from Active Record. For this implementation we use the gem [After Commit Everywhere](https://github.com/Envek/after_commit_everywhere) to be able to use the `after_commit` callbacks outside the Active Record models.
+
 ### Values
 
 This pattern doesn't have a generator.
@@ -294,7 +296,7 @@ To initialize a presenter inside your controller action you should execute the `
 class UsersController < InheritedResources::Base
   def show
     presenter_params = { param1: 1, param2: 2 }
-    @presenter = present_with(:users_show, presenter_params)
+    @presenter = present_with(:users_show_presenter, presenter_params)
   end
 end
 ```
@@ -315,7 +317,7 @@ You can access `presenter_params` inside the presenter as an `attr_reader`
 class UsersController < InheritedResources::Base
   def show
     presenter_params = { platanus_url: "https://platan.us" }
-    @presenter = present_with(:users_show, presenter_params)
+    @presenter = present_with(:users_show_presenter, presenter_params)
   end
 end
 ```
@@ -334,7 +336,7 @@ If the presenter param has a [decorator](https://github.com/drapergem/draper), t
 class UsersController < InheritedResources::Base
   def show
     presenter_params = { user: user }
-    @presenter = present_with(:users_show, presenter_params)
+    @presenter = present_with(:users_show_presenter, presenter_params)
   end
 
   private

data/lib/power_types/patterns/observer/observer.rb

@@ -1,5 +1,7 @@
 module PowerTypes
   class Observer
+    include AfterCommitEverywhere
+
     attr_reader :object
 
     PowerTypes::Util::OBSERVABLE_EVENTS.each do |event|
@@ -34,5 +36,21 @@ module PowerTypes
     def initialize(_object)
       @object = _object
     end
+
+    PowerTypes::Util::OBSERVABLE_TRANSACTIONAL_EVENTS.each do |event|
+      PowerTypes::Util::OBSERVABLE_TYPES.each do |type|
+        next unless type == :after
+
+        method_name = "#{type}_#{event}"
+        callback = method_name.gsub('_commit', '')
+        define_singleton_method(method_name) do |method|
+          send(callback) { execute_method_after_commit(method) }
+        end
+      end
+    end
+
+    def execute_method_after_commit(method)
+      after_commit { send(method) }
+    end
   end
 end

data/lib/power_types/patterns/presenter/base_presenter.rb

@@ -20,9 +20,9 @@ module PowerTypes
     attr_reader :h
 
     def decorated_value(value)
-      return value unless value.respond_to?(:decorate)
-
       value.decorate
+    rescue NameError
+      value
     end
   end
 end

data/lib/power_types/util.rb

@@ -1,6 +1,8 @@
 module PowerTypes
   module Util
-    OBSERVABLE_EVENTS = [:create, :update, :save, :destroy, :commit]
+    OBSERVABLE_EVENTS = [:create, :update, :save, :destroy]
+    OBSERVABLE_TRANSACTIONAL_EVENTS = [:create_commit, :update_commit, :save_commit,
+                                       :destroy_commit]
     OBSERVABLE_TYPES = [:before, :after]
   end
 end

data/lib/power_types/version.rb

@@ -1,3 +1,3 @@
 module PowerTypes
-  VERSION = '0.5.0'
+  VERSION = '0.7.0'
 end

data/lib/power_types.rb

@@ -1,16 +1,17 @@
-require "active_support/all"
+require 'active_support/all'
+require 'after_commit_everywhere'
 
-require "power_types/version"
-require "power_types/util"
-require "power_types/errors"
-require "power_types/patterns/service"
-require "power_types/patterns/command"
-require "power_types/patterns/observer/observable"
-require "power_types/patterns/observer/observer"
-require "power_types/patterns/observer/trigger"
-require "power_types/patterns/presenter/base_presenter"
-require "power_types/patterns/presenter/presentable"
-require "power_types/patterns/base_util"
+require 'power_types/version'
+require 'power_types/util'
+require 'power_types/errors'
+require 'power_types/patterns/service'
+require 'power_types/patterns/command'
+require 'power_types/patterns/observer/observable'
+require 'power_types/patterns/observer/observer'
+require 'power_types/patterns/observer/trigger'
+require 'power_types/patterns/presenter/base_presenter'
+require 'power_types/patterns/presenter/presentable'
+require 'power_types/patterns/base_util'
 
 module PowerTypes
 end

data/power-types.gemspec

@@ -19,6 +19,7 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   spec.add_dependency "activesupport"
+  spec.add_dependency "after_commit_everywhere", "~> 1.2", ">= 1.2.2"
 
   spec.add_development_dependency "bundler", "~> 2.2.15"
   spec.add_development_dependency "coveralls"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: power-types
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.7.0
 platform: ruby
 authors:
 - Ignacio Baixas
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2022-08-18 00:00:00.000000000 Z
+date: 2023-07-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -25,6 +25,26 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: after_commit_everywhere
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.2'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.2.2
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.2'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.2.2
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -180,6 +200,7 @@ files:
 - ".rspec"
 - ".rubocop.yml"
 - ".ruby-version"
+- CHANGELOG.md
 - CODE_OF_CONDUCT.md
 - Gemfile
 - Guardfile
@@ -235,7 +256,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.6
+rubygems_version: 3.4.10
 signing_key: 
 specification_version: 4
 summary: Power Types for Rails by Platanus