power-compass 0.2.1 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 00b3955c4f359a7370e04976dc68f405189c9493e411f4ed021f7cc5720831ed
-  data.tar.gz: 88f25c58a0461d2977a0dd9307f7004b6d88faf796b74673c2fa2badb586a4cd
+  metadata.gz: b310dc5041bdff68ef213139f0d1c1a05059382b47430f31e9b6024b9e7d6720
+  data.tar.gz: a2e420b773128a5027bf199e5c6384b17ff6fec9bcbaf6ba9ff3427cb35eb9e7
 SHA512:
-  metadata.gz: e059eed884c947fd7ad6ec20a1d5943c603eee8abe3b6b7c1aff04bc8a721e9475248950a3ccec01122b1a8d6df27cc1ec4ea25a105b48751894c5cbea87e7c8
-  data.tar.gz: 273b8db4505662c7d6ebfed38c67524ef2ff7e867ff84dde95b2eda65523884a39b49e1aad6ce97254089fef0dacbfa875a54d23df32c5ce17bb54c383a866f0
+  metadata.gz: b570ab5a2fa7d4da1bf51cac5e2fcaa5e08396dd89a0cb070a6480cca24c4cebbb2f59cc42d3946ab81fbdc554945d1ed9f08574f662e146df5c0127f23c55b1
+  data.tar.gz: 7239db58aeb179be84317182ba7db0359744d52775eb12cc2ff31460400d02a6b96922dbaa5d0fef1fdb0ae2912a8a6111e6c3b4dbb7f91f2ba2ac4cbe2a4f9c

data/app/controllers/compass/notification_controller.rb

@@ -2,14 +2,20 @@ require "compass/notification/provider"
 
 module Compass
   class NotificationController < ApplicationController
+    etag { providers.map(&:hash) }
+
     def index
       set_cache_headers(Compass.config.notification.cache)
 
-      providers = Compass::Notification::Provider.global_notifications(current_context)
-
       return unless stale?(providers, etag: "compass-notification")
 
       render json: providers
     end
+
+  private
+
+    def providers
+      @providers ||= Compass::Notification::Provider.global_notifications(current_context)
+    end
   end
 end

data/lib/compass/notification/provider.rb

@@ -31,6 +31,10 @@ module Compass
         context.each { |key, value| define_singleton_method(key) { value } }
       end
 
+      def hash
+        notifications.pluck(:id).hash
+      end
+
       def fetch_notifications
         retrieve_notifications
       rescue => e
@@ -43,7 +47,7 @@ module Compass
       end
 
       def format_notification(notification)
-        raise NotImplementedError, "#{self.class} must implement #format_notification"
+        raise NotImplementedError, "#{self.class} must implement #format_notification and return a hash with :id, :title, :body, and :url keys"
       end
 
       def label
@@ -57,11 +61,18 @@ module Compass
       def as_json(options = {})
         {
           label: label,
-          notifications: Array(fetch_notifications).map { |notification| format_notification(notification) }.compact
+          notifications: notifications
         }
       end
 
-      private
+    private
+
+      def notifications
+        @notifications ||= Array(fetch_notifications).map do |notification|
+          formatted = format_notification(notification)
+          formatted[:id] ? formatted : raise(ArgumentError, "#{self.class}#format_notification must include :id. Got: #{formatted.inspect}")
+        end.compact
+      end
 
       def log_error(error)
         Compass.logger&.error(

data/lib/compass/version.rb

@@ -1,3 +1,3 @@
 module Compass
-  VERSION = "0.2.1"
+  VERSION = "0.2.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: power-compass
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
 platform: ruby
 authors:
 - Carlos Palhares