postspec 0.5.1 → 0.5.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1a391625a2f772e728fcc9c7eb0626e47a5cdacb43e770afe239da3cac393606
-  data.tar.gz: efc3dd134049aff64eb4f459e22a74ecdae6e8333123baa5433444275e1cdde7
+  metadata.gz: bbef9ecda05ff7deeb013906388668f187ce267a1d173f8b66cf414fa2fbc38b
+  data.tar.gz: 07e283ea4dcf43f3725f6af41f776240c3ed63f537415f1fafc5e29fa5da8ccd
 SHA512:
-  metadata.gz: ac0f2dc6771a9f3949ae02448d6c399f8387647f35fce871543eba99c803a71a6edfdc2ba4fc4c473f3f8837b120f64e152a989fc0e436de6b9995d7409c00d2
-  data.tar.gz: d78238c6edff5869caf9cbba9d4ce34329f1e3fe49dfba31431951092af8df06bc26e164e7372c72c5cd00a14d0dbb612abd980109e288f6b23e47ecdd3cfb63
+  metadata.gz: 8218dd2502c9ba7c4db0f3ca4384a2997571bbee90f75946057ebf7b33e7f2fc6b1c0fc552084f9c1c3c02d5f3bf5f2a53c656540fd87859ef26ba8b73292364
+  data.tar.gz: 03ab635533126ea2fea4711925bfcd3f800344ad9ba57561e3fadbe291046413ac21b8b5d4e573156ab711215b467fbeea49c3b8afad1034bfed8ec5000d355b

data/lib/postspec/environment.rb

@@ -46,7 +46,7 @@ module Postspec
     def create()
 #     puts "Environment#create"
       conn.execute IO.read(Postspec::SHARE_DIR + "/postspec_schema.sql")
-      conn.execute render.change_triggers(:create)
+      conn.execute render.register_triggers(:create)
     end
 
     def drop()
@@ -76,7 +76,7 @@ module Postspec
           case mode
             when :seed
               @uids = table_max_ids
-              render.seed_triggers(:create, @uids)
+              render.readonly_triggers(:create, @uids)
             when :empty
               @uids = {}
               []
@@ -92,7 +92,7 @@ module Postspec
       tables, reset_sql = reset_data
       sql =
           case mode
-            when :seed; render.seed_triggers(:drop) + render.delete_tables(SEED_TABLE_UIDS)
+            when :seed; render.readonly_triggers(:drop) + render.delete_tables(SEED_TABLE_UIDS)
             when :empty; []
           else
             raise ArgumentError
@@ -170,12 +170,12 @@ __END__
     end
 
     def setup_change_environment
-      conn.exec render.change_triggers(:create)
+      conn.exec render.register_triggers(:create)
     end
 
     def teardown_change_environment
       sql =
-          render.change_triggers(:drop) +
+          render.register_triggers(:drop) +
           render.delete_tables(CHANGE_TABLE_UIDS)
       conn.exec render.execution_unit(CHANGE_TABLE_UIDS, sql)
     end
@@ -188,7 +188,7 @@ __END__
 
     def setup_seed_environment()
       @uids = conn.map("select name, id from postspec.sequence_ids()")
-      sql = render.seed_triggers(:create, uids)
+      sql = render.readonly_triggers(:create, uids)
       conn.exec sql
     end
 
@@ -196,7 +196,7 @@ __END__
       @uids = nil
       uids = conn.map "select table_uid, min(record_id) from postspec.inserts"
       sql =
-          render.seed_triggers(:drop) +
+          render.readonly_triggers(:drop) +
           render.delete_tables(uids) +
           render.delete_tables(CHANGE_TABLE_UIDS) +
           render.delete_tables(SEED_TABLE_UIDS)
@@ -316,12 +316,12 @@ __END__
   class SeedEnvironment < Environment
     def create
       uids = @conn.map("select name, id from postspec.sequence_ids()", :name)
-      conn.exec render.seed_triggers(:create, uids)
+      conn.exec render.readonly_triggers(:create, uids)
       conn.exec "delete from postspec.seeds"
     end
 
     def drop
-      conn.exec render.seed_triggers(:drop)
+      conn.exec render.readonly_triggers(:drop)
       conn.exec "delete from postspec.seeds"
     end
 
@@ -452,7 +452,7 @@ __END__
         # meta doesn't know about the postspec schema
         conn.execute(IO.read(SHARE_DIR + "/postspec_schema.sql"))
       end
-      conn.execute(render.change_triggers(:create))
+      conn.execute(render.register_triggers(:create))
     end
 
     def reset()
@@ -460,7 +460,7 @@ __END__
     end
 
     def drop()
-      conn.execute(render.change_triggers(:drop))
+      conn.execute(render.register_triggers(:drop))
       conn.execute("drop schema postspec cascade")
     end
   end

data/lib/postspec/render.rb

@@ -4,27 +4,30 @@ module Postspec
     attr_reader :postspec
     forward_to :postspec, :conn
 
-    SEED_BUD_TRIGGER_NAME = "postspec_readonly_bud_trg"
-    SEED_BT_TRIGGER_NAME = "postspec_readonly_bt_trg"
+    PRIORITY = "95" # Is a string because it needs two digits not matter the value
+
+    READONLY_BUD_TRIGGER_NAME = "p#{PRIORITY}_postspec_readonly_bud_trg"
+    READONLY_BT_TRIGGER_NAME = "p#{PRIORITY}_postspec_readonly_bt_trg"
+    REGISTER_TRIGGER_FORMAT = "p#{PRIORITY}_postspec_register_%s_b%s_trg"
 
     def initialize(postspec)
       constrain postspec, Postspec
       @postspec = postspec
     end
 
-    def truncate_tables(uids) ["truncate #{uids.join(', ')} cascade"] end
-    def delete_tables(uids) uids.map { |uid| "delete from #{uid}" } end # FIXME DUPLICATED
-    def reset_postspec_tables()
-      delete_tables %w(postspec.runs postspec.seeds postspec.inserts postspec.updates postspec.deletes)
-    end
 
     def postspec_schema(state) raise NotYet end
 
-    def change_triggers(state)
+    # Create triggers to register changes in the database. It uses the postgres
+    # function register_EVENT to write the data to the postspec schema
+    #
+    # It is supposed to be called only once and the triggers can't be disabled
+    #
+    def register_triggers(state)
       constrain state, lambda { |state| [:create, :drop].include?(state) }
       postspec.tables.map { |table|
         %w(insert update delete).map { |event|
-          name = "register_#{event}_b#{event[0]}_trg"
+          name = REGISTER_TRIGGER_FORMAT % [event, event[0]]
           exist = postspec.meta.exist?("#{table.uid}.#{name}()")
           if state == :create && !exist
             ref = (event == "insert" ? "new" : "old")
@@ -42,18 +45,21 @@ module Postspec
       }.flatten
     end
 
-    def seed_triggers(state, uids = nil)
+    # Create/drop readonly triggers. The triggers can be disabled because the
+    # tests may occasionally modify seed data
+    #
+    def readonly_triggers(state, uids = nil)
       case state
-        when :create; create_seed_triggers(uids)
-        when :drop; drop_seed_triggers
+        when :create; create_readonly_triggers(uids)
+        when :drop; drop_readonly_triggers
       else
         raise ArgumentError, state.inspect
       end
     end
 
-    def drop_seed_triggers
+    def drop_readonly_triggers
       postspec.tables.map { |uid|
-        [SEED_BUD_TRIGGER_NAME, SEED_BT_TRIGGER_NAME].map { |trigger|
+        [READONLY_BUD_TRIGGER_NAME, READONLY_BT_TRIGGER_NAME].map { |trigger|
           trigger_uid = "#{uid}.#{trigger}()"
           postspec.meta.exist?(trigger_uid) ? "drop trigger #{trigger} on #{uid}" : nil
         }.compact
@@ -64,20 +70,19 @@ module Postspec
     # error when seed data are updated, deleted, or truncated. They all call
     # the common postspec.readonly_failure() function that raises a Postgres
     # exception
-    def create_seed_triggers(uids)
+    def create_readonly_triggers(uids)
       constrain uids, { String => [Integer, NilClass] }
       result = []
       uids.map { |uid, id|
-        bud_trigger = "#{uid}.#{SEED_BUD_TRIGGER_NAME}()"
         bud_sql = <<~EOS1
-            create trigger #{SEED_BUD_TRIGGER_NAME}
+            create trigger #{READONLY_BUD_TRIGGER_NAME}
                 before update or delete on #{uid}
                 for each row
                 when (OLD.id <= #{id})
                 execute function postspec.readonly_failure('#{uid}')
         EOS1
         bt_sql = <<~EOS2
-            create trigger postspec_readonly_bt_trg
+            create trigger #{READONLY_BT_TRIGGER_NAME}
                 before truncate on #{uid}
                 execute function postspec.truncate_failure('#{uid}')
         EOS2
@@ -102,6 +107,8 @@ module Postspec
           materialized_views.map { |uid| "refresh materialized view #{uid}" }
     end
 
+    def truncate_tables(uids) ["truncate #{uids.join(', ')} cascade"] end
+
     def delete_tables(arg)
       constrain arg, Array, Hash
       uids = arg.is_a?(Array) ? arg.map { |uid| [uid, 0] }.to_h : arg
@@ -114,6 +121,10 @@ module Postspec
           }
     end
 
+    def reset_postspec_tables()
+      delete_tables %w(postspec.runs postspec.seeds postspec.inserts postspec.updates postspec.deletes)
+    end
+
     # FIXME: doesn't seem to be any improvement performance-wise
     def delete_tables_new(arg)
       constrain arg, Array, Hash

data/lib/postspec/version.rb

@@ -1,3 +1,3 @@
 module Postspec
-  VERSION = "0.5.1"
+  VERSION = "0.5.3"
 end

data/lib/share/postspec_schema.sql

@@ -57,7 +57,7 @@ $$ language plpgsql immutable leakproof;
 
 create or replace function truncate_failure() returns trigger as $$
   begin
-    raise 'Postspec: Can''t modify truncate %.%', TG_TABLE_SCHEMA, TG_TABLE_NAME;
+    raise 'Postspec: Can''t truncate %.%', TG_TABLE_SCHEMA, TG_TABLE_NAME;
     return null;
   end;
 $$ language plpgsql immutable leakproof;

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: postspec
 version: !ruby/object:Gem::Version
-  version: 0.5.1
+  version: 0.5.3
 platform: ruby
 authors:
 - Claus Rasmussen
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2025-01-11 00:00:00.000000000 Z
+date: 2025-01-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dry-inflector