postqueue 0.5.6 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: dcb53b2cad7afd5da516c06e39f62b7c5f053247
-  data.tar.gz: 4027f325048b199d891323d8b48c7778d34b7418
+  metadata.gz: ad1cc078033356ab3276d5360da442f64c42fc6b
+  data.tar.gz: a79c30543676b7c62679a99d1f9c4380979b9b7a
 SHA512:
-  metadata.gz: 3ed2e40245f59ccda5b82551ed868dc01d605a8bbfc12238205de689e1c06640751baed2dc334d2f81420be430d9f81fcbeba195037b552f9aa8d76ed17154bb
-  data.tar.gz: aaaa025a26e7b5e1129a492199cbbc18b9a691c2567e620fcb96f6c9160389e2e7bff98e3a9cb0cd44073f638f33b1b0ce60ec106fa8394092be09ab9de87f19
+  metadata.gz: 09b7f4b6c07b3eaf17acef7863ee6f940f0f67906d8f4cb112ffad19a46dd1fba7ea9c678f6c5dc418d1170bfa5be67a0600bff1b77454113788ac913ae23b88
+  data.tar.gz: 02b7c4d09582a202a56d12e7fd810da1f1f5334cbd726eb4db2d15cd8fc06b19aeb992c144ae61f050cc50dd46928c901526d9ee40ed5f1e8f804b2925e8bcdf

data/lib/postqueue/item/inserter.rb

@@ -2,7 +2,10 @@ require "active_record"
 
 module Postqueue
   #
-  # An item class.
+  # Postqueue::Item inserter modules.
+  #
+  # This source file provides multiple implementations to insert Postqueue::Items.
+  # Which one will be used depends on the "extend XXXInserter" line below.
   class Item < ActiveRecord::Base
     module ActiveRecordInserter
       def insert_item(op:, entity_id:)
@@ -11,20 +14,45 @@ module Postqueue
     end
 
     module RawInserter
-      def prepared_inserter_statement
-        @prepared_inserter_statement ||= begin
-          name = "postqueue-insert-{table_name}-#{Thread.current.object_id}"
-          connection.raw_connection.prepare(name, "INSERT INTO #{table_name}(op, entity_id) VALUES($1, $2)")
-          name
-        end
+      def insert_sql
+        "INSERT INTO #{table_name}(op, entity_id) VALUES($1, $2)"
+      end
+
+      def insert_item(op:, entity_id:)
+        connection.raw_connection.exec_params(insert_sql, [op, entity_id])
+      end
+    end
+
+    module PreparedRawInserter
+      def insert_sql
+        "INSERT INTO #{table_name}(op, entity_id) VALUES($1, $2)"
+      end
+
+      def prepared_inserter_statement(raw_connection)
+        @prepared_inserter_statements ||= {}
+
+        # a prepared connection is PER DATABASE CONNECTION. It is not shared across
+        # connections, and it is not per thread, since a Thread might use different
+        # connections during its lifetime.
+        @prepared_inserter_statements[raw_connection.object_id] ||= create_prepared_inserter_statement(raw_connection)
+      end
+
+      # prepares the INSERT statement, and returns its name
+      def create_prepared_inserter_statement(raw_connection)
+        name = "postqueue-insert-#{table_name}-#{raw_connection.object_id}"
+        raw_connection.prepare(name, insert_sql)
+        name
       end
 
       def insert_item(op:, entity_id:)
-        connection.raw_connection.exec_prepared(prepared_inserter_statement, [op, entity_id])
+        raw_connection = connection.raw_connection
+        statement_name = prepared_inserter_statement(raw_connection)
+        raw_connection.exec_prepared(statement_name, [op, entity_id])
       end
     end
 
-    # extend RawInserter
-    extend ActiveRecordInserter
+    # extend ActiveRecordInserter   # 600µs per item
+    extend RawInserter              # 100µs per item
+    # extend PreparedRawInserter    # 50µs per item
   end
 end

data/lib/postqueue/version.rb

@@ -1,3 +1,3 @@
 module Postqueue
-  VERSION = "0.5.6"
+  VERSION = "0.6.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: postqueue
 version: !ruby/object:Gem::Version
-  version: 0.5.6
+  version: 0.6.0
 platform: ruby
 authors:
 - radiospiel