postmark 1.21.5 → 1.22.0

data/spec/unit/postmark/error_spec.rb

@@ -97,6 +97,13 @@ describe(Postmark::ApiInputError) do
         it_behaves_like 'api input error'
       end
 
+      context '300' do
+        let(:code) {Postmark::ApiInputError::INVALID_EMAIL_ADDRESS}
+
+        it {is_expected.to be_a(Postmark::InvalidEmailAddressError)}
+        it_behaves_like 'api input error'
+      end
+
       context 'others' do
         let(:code) {'9999'}
 
@@ -142,6 +149,33 @@ describe(Postmark::MailAdapterError) do
   it {is_expected.to be_a(Postmark::Error)}
 end
 
+describe(Postmark::InvalidEmailAddressError) do
+  describe '.new' do
+    let(:response) {{'Message' => message}}
+
+    subject do
+      Postmark::InvalidEmailAddressError.new(
+        Postmark::ApiInputError::INVALID_EMAIL_ADDRESS, Postmark::Json.encode(response), response)
+    end
+
+    let(:message) do
+      "Error parsing 'To': Illegal email address 'johne.xample.com'. It must contain the '@' symbol."
+    end
+
+    it 'body is set' do
+      expect(subject.body).to eq(Postmark::Json.encode(response))
+    end
+
+    it 'parsed body is set' do
+      expect(subject.parsed_body).to eq(response)
+    end
+
+    it 'error code is set' do
+      expect(subject.error_code).to eq(Postmark::ApiInputError::INVALID_EMAIL_ADDRESS)
+    end
+  end
+end
+
 describe(Postmark::InactiveRecipientError) do
   describe '.parse_recipients' do
     let(:recipients) do
@@ -161,6 +195,12 @@ describe(Postmark::InactiveRecipientError) do
       it {is_expected.to eq(recipients.take(1))}
     end
 
+    context 'i/n inactive, n > 1, i < n - new message format' do
+      let(:message) { "Message OK, but will not deliver to these inactive addresses: #{recipients[0...2].join(', ')}" }
+
+      it {is_expected.to eq(recipients.take(2))}
+    end
+
     context 'i/n inactive, n > 1, i < n' do
       let(:message) do
         'Message OK, but will not deliver to these inactive addresses: ' \
@@ -209,6 +249,18 @@ describe(Postmark::InactiveRecipientError) do
     it 'parses recipients from json payload' do
       expect(subject.recipients).to eq([address])
     end
+
+    it 'body is set' do
+      expect(subject.body).to eq(Postmark::Json.encode(response))
+    end
+
+    it 'parsed body is set' do
+      expect(subject.parsed_body).to eq(response)
+    end
+
+    it 'error code is set' do
+      expect(subject.error_code).to eq(Postmark::ApiInputError::INACTIVE_RECIPIENT)
+    end
   end
 end
 

data/spec/unit/postmark/helpers/hash_helper_spec.rb

@@ -2,32 +2,119 @@ require 'spec_helper'
 
 describe Postmark::HashHelper do
   describe ".to_postmark" do
-    let(:source) { {:from => "support@postmarkapp.com", :reply_to => "contact@wildbit.com"} }
-    let(:target) { {"From" => "support@postmarkapp.com", "ReplyTo" => "contact@wildbit.com"} }
+    let(:source) do
+      {
+        :level_one => {
+          :level_two => {
+            :level_three => [{ :array_item => 1 }]
+          }
+        }
+      }
+    end
+
+    describe 'default behaviour' do
+      let(:target) do
+        {
+          'LevelOne' => {
+            :level_two => {
+              :level_three => [{ :array_item => 1 }]
+            }
+          }
+        }
+      end
+
+      it 'does not convert nested elements' do
+        expect(subject.to_postmark(source)).to eq(target)
+      end
+    end
+
+    describe 'deep conversion' do
+      let(:target) do
+        {
+          'LevelOne' => {
+            'LevelTwo' => {
+              'LevelThree' => [{ 'ArrayItem' => 1 }]
+            }
+          }
+        }
+      end
 
-    it 'converts Hash keys to Postmark format' do
-      expect(subject.to_postmark(source)).to eq target
+      it 'converts nested elements when requested' do
+        expect(subject.to_postmark(source, :deep => true)).to eq(target)
+      end
     end
 
-    it 'acts idempotentely' do
-      expect(subject.to_postmark(target)).to eq target
+    it 'leaves CamelCase keys untouched' do
+      expect(subject.to_postmark('ReplyTo' => 'alice@example.com')).to eq('ReplyTo' => 'alice@example.com')
     end
   end
 
   describe ".to_ruby" do
-    let(:source) { {"From" => "support@postmarkapp.com", "ReplyTo" => "contact@wildbit.com"} }
-    let(:target) { {:from => "support@postmarkapp.com", :reply_to => "contact@wildbit.com"} }
+    let(:source) do
+      {
+        'LevelOne' => {
+          'LevelTwo' => {
+            'LevelThree' => [{ 'ArrayItem' => 1 }]
+          }
+        }
+      }
+    end
 
-    it 'converts Hash keys to Ruby format' do
-      expect(subject.to_ruby(source)).to eq target
+    describe 'default behaviour' do
+      let(:target) do
+        {
+          :level_one => {
+            'LevelTwo' => {
+              'LevelThree' => [{ 'ArrayItem' => 1 }]
+            }
+          }
+        }
+      end
+
+      it 'does not convert nested elements' do
+        expect(subject.to_ruby(source)).to eq(target)
+      end
     end
 
-    it 'has compatible mode' do
-      expect(subject.to_ruby(source, true)).to eq target.merge(source)
+    describe 'deep conversion' do
+      let(:target) do
+        {
+          :level_one => {
+            :level_two => {
+              :level_three => [{ :array_item => 1 }]
+            }
+          }
+        }
+      end
+
+      it 'converts nested elements when requested' do
+        expect(subject.to_ruby(source, :deep => true)).to eq(target)
+      end
+    end
+
+    describe 'compatibility mode' do
+      let(:target) do
+        {
+          :level_one => {
+            'LevelTwo' => {
+              'LevelThree' => [{ 'ArrayItem' => 1 }]
+            }
+          },
+          'LevelOne' => {
+            'LevelTwo' => {
+              'LevelThree' => [{ 'ArrayItem' => 1 }]
+            }
+          }
+        }
+      end
+
+      it 'preserves the original structure' do
+        expect(subject.to_ruby(source, :compatible => true)).to eq target
+      end
     end
 
-    it 'acts idempotentely' do
-      expect(subject.to_ruby(target)).to eq target
+    it 'leaves symbol keys untouched' do
+      expect(subject.to_ruby(:reply_to => 'alice@example.com')).to eq(:reply_to => 'alice@example.com')
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: postmark
 version: !ruby/object:Gem::Version
-  version: 1.21.5
+  version: 1.22.0
 platform: ruby
 authors:
 - Tomek Maszkowski
@@ -13,7 +13,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-07-22 00:00:00.000000000 Z
+date: 2021-08-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json
@@ -71,6 +71,8 @@ files:
 - ".gitignore"
 - ".rake_tasks"
 - ".rspec"
+- ".ruby-gemset"
+- ".ruby-version"
 - CHANGELOG.rdoc
 - CONTRIBUTING.md
 - Gemfile
@@ -150,7 +152,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: 1.3.7
 requirements: []
-rubygems_version: 3.2.3
+rubygems_version: 3.0.8
 signing_key:
 specification_version: 4
 summary: Official Postmark API wrapper.