postman_paf 0.4.1 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a8df3549dc47d5facbc891f855f90b63c72ce2203bb872525d9b7d69a72cea88
-  data.tar.gz: 7ebf08d874895032b4260118764728be7a9439c27299b3904fc1c3d0fe412f0a
+  metadata.gz: 00d514b9ff1102fa9beeeba5e76c2e7a2ad435bc720eed4637e8003ea97a35ef
+  data.tar.gz: 45963310c4f5face51845adfa5045347504cf25b5a8cb997798c31ba4602d5d8
 SHA512:
-  metadata.gz: b51477649ffbc240bd15fe7a37a3f45956ed2f815de448b0fb1e60953e638b539e038da3fe137d4fce0a55f3d8ede5d104dcf6385038ace2bbfd426e33db9cd6
-  data.tar.gz: a8d5a5a61e80a040bcf44658befdd4f10307e68a992cb8b4c5b7054ed0f1e6c4fd34d1389984b6e0b49b109d2993b0c83135abf5b69fdd13200cf25d8560901a
+  metadata.gz: 5fd9e05ed8019a6f6f9f7753cb802de922e0481e580025f8c11999d9b30ac52402676d6018185cdd2defbc169fe7bd9f667c9f9cc54b91ce422ba04ef32d8075
+  data.tar.gz: 8970c0e5739d2144ec3327bcefff368813174890fb75d750517138e8e2e952746fc3c6d6a14b6c02a19e8adffc809726524cbe84af9bc7592e8edd538a71db2c

data/.rubocop.yml

@@ -1,5 +1,10 @@
+inherit_gem:
+  dvla-lint: '.rubocop.yml'
+
 AllCops:
   TargetRubyVersion: 3.0.0
+  NewCops: enable
+  SuggestExtensions: false
 
 Layout/LineLength:
   Max: 180
@@ -8,7 +13,7 @@ Metrics/AbcSize:
   Enabled: false
 
 Metrics/BlockLength:
-  IgnoredMethods:
+  AllowedMethods:
     - 'describe'
     - 'context'
 

data/bin/console

@@ -7,9 +7,7 @@ require 'postman_paf'
 # You can add fixtures and/or initialization code here to make experimenting
 # with your gem easier. You can also use a different console, if you like.
 
-# (If you use this, don't forget to add pry to your Gemfile!)
-# require "pry"
-# Pry.start
+# Use binding.irb
 
 require 'irb'
 IRB.start(__FILE__)

data/lib/postman_paf/converter.rb

@@ -18,7 +18,7 @@ module PostmanPAF
       @max_line_length = if max_line_length.is_a?(Integer) || max_line_length.is_a?(String)
                            max_line_length.to_i.positive? ? max_line_length.to_i : nil
                          end
-      @logging = logging.is_a?(TrueClass) ? true : false
+      @logging = logging.is_a?(TrueClass)
     end
 
     # Handles conversion of single or multiple PAF addresses (i.e. single
@@ -34,7 +34,7 @@ module PostmanPAF
       converted_addresses.count.eql?(1) ? converted_addresses.pop : converted_addresses
     end
 
-    private
+  private
 
     # Converts a single PAF address to printable format after determining
     #   applicable rule and exception(s). Truncation and logging optional.

data/lib/postman_paf/exceptions/rule_6_exceptions.rb

@@ -39,7 +39,7 @@ module PostmanPAF
                         :no_exception
                       end
 
-          premise_element_exception = "#{SimpleSymbolize.snakeize(premise_element)}_#{exception}".to_sym
+          premise_element_exception = :"#{SimpleSymbolize.snakeize(premise_element)}_#{exception}"
           exceptions << premise_element_exception
         end
       end

data/lib/postman_paf/printable_address.rb

@@ -28,7 +28,7 @@ module PostmanPAF
         'postcode' => @postcode,
         'country' => @country,
         'language' => @language,
-        'dps' => @dps
+        'dps' => @dps,
       }
     end
   end

data/lib/postman_paf/rules/address_builder.rb

@@ -15,10 +15,10 @@ module PostmanPAF
         lines.each_with_index do |line, index|
           line_number = index + 1
           line = line.to_s if line.is_a?(Integer)
-          printable_address.send("line#{line_number}=", line) unless line_number.eql?(6) || line_number.eql?(7)
+          printable_address.send(:"line#{line_number}=", line) if line_number >= 1 && line_number <= 5
         end
 
-        printable_address.postcode = paf_address[POSTCODE].slice(0..7)
+        printable_address.postcode = paf_address[POSTCODE]
         printable_address.country = paf_address[COUNTRY]
         printable_address.language = paf_address[LANGUAGE]
         printable_address.dps = paf_address[DPS]

data/lib/postman_paf/validator.rb

@@ -29,7 +29,7 @@ module PostmanPAF
       nil
     end
 
-    private
+  private
 
     # Verifies input of single Hash contains required address elements.
     # @raise [ArgumentError] if Hash is missing required address elements.
@@ -59,7 +59,7 @@ module PostmanPAF
     # @return [Boolean] whether both keys were found.
     def criteria_for_paf_address?(hash:)
       hash = hash.transform_keys { |k| SimpleSymbolize.camelize(k).to_s }
-      hash.keys.include?(POST_TOWN) && hash.keys.include?(POSTCODE)
+      hash.key?(POST_TOWN) && hash.key?(POSTCODE)
     end
   end
 end

data/lib/postman_paf/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module PostmanPAF
-  VERSION = '0.4.1'
+  VERSION = '0.5.0'
 end

data/postman_paf.gemspec

@@ -20,16 +20,15 @@ Gem::Specification.new do |spec|
   end
   spec.bindir        = 'exe'
   spec.executables   = spec.files.grep(%r{\Aexe/}) { |f| File.basename(f) }
-  spec.require_paths = ['lib']
+  spec.require_paths = %w[lib]
 
-  spec.add_development_dependency 'bundler-audit', '~> 0.9'
-  spec.add_development_dependency 'hash_miner', '~> 1.1'
-  spec.add_development_dependency 'pry', '~> 0.14'
-  spec.add_development_dependency 'rake', '~> 13.0'
-  spec.add_development_dependency 'rspec', '~> 3.12'
-  spec.add_development_dependency 'rubocop', '~> 1.54'
-  spec.add_development_dependency 'simplecov', '~> 0.22'
-  spec.add_development_dependency 'simplecov-console', '~> 0.9'
-
-  spec.add_runtime_dependency 'simple_symbolize', '~> 4.0'
+  spec.add_dependency 'bundler-audit', '~> 0.9.2'
+  spec.add_dependency 'dvla-lint', '~> 1.8.0'
+  spec.add_dependency 'hash_miner', '~> 1.1.3'
+  spec.add_dependency 'rake', '~> 13.2.1'
+  spec.add_dependency 'rspec', '~> 3.13.0'
+  spec.add_dependency 'rubocop', '~> 1.67.0'
+  spec.add_dependency 'simplecov', '~> 0.22.0'
+  spec.add_dependency 'simplecov-console', '~> 0.9.2'
+  spec.add_dependency 'simple_symbolize', '~> 4.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: postman_paf
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.5.0
 platform: ruby
 authors:
 - Driver and Vehicle Licensing Agency (DVLA)
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2024-03-15 00:00:00.000000000 Z
+date: 2024-10-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler-audit
@@ -17,112 +17,112 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.9'
-  type: :development
+        version: 0.9.2
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.9'
+        version: 0.9.2
 - !ruby/object:Gem::Dependency
-  name: hash_miner
+  name: dvla-lint
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.1'
-  type: :development
+        version: 1.8.0
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.1'
+        version: 1.8.0
 - !ruby/object:Gem::Dependency
-  name: pry
+  name: hash_miner
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.14'
-  type: :development
+        version: 1.1.3
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.14'
+        version: 1.1.3
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '13.0'
-  type: :development
+        version: 13.2.1
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '13.0'
+        version: 13.2.1
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.12'
-  type: :development
+        version: 3.13.0
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.12'
+        version: 3.13.0
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.54'
-  type: :development
+        version: 1.67.0
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.54'
+        version: 1.67.0
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.22'
-  type: :development
+        version: 0.22.0
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.22'
+        version: 0.22.0
 - !ruby/object:Gem::Dependency
   name: simplecov-console
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.9'
-  type: :development
+        version: 0.9.2
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.9'
+        version: 0.9.2
 - !ruby/object:Gem::Dependency
   name: simple_symbolize
   requirement: !ruby/object:Gem::Requirement