posthog-ruby 3.28.0 → 3.28.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 561f4ebad1a6cd75904b800f540c0dbb9352cc081dc57bf5cc0a5dcb82925e89
-  data.tar.gz: 5e9ce62f5e48c5380ce71e454507bafa6825a8e7e6db6c05b8896b8c5a665c62
+  metadata.gz: cadcd587c8b67720c3ce501cf2df4924313a8e585aa2736cb501b43e760108f1
+  data.tar.gz: 44581dc2e70dd510e7dd8668a65f82526e97077f6634fb7062540615dda42b9d
 SHA512:
-  metadata.gz: 41f3fde35a6e73ffa54b09fff2d88990057a3fac677153b2e14e6547fb20dbacebcc7a687bae432a98c62cabad572b5dc64cc57fb0cfbab554d7c72581d84ab8
-  data.tar.gz: e596b42169af511879c3397bc6e42aa2410bee4aa4d519b6958ad87d0800da67e6b208670abd809f4bd34d52616db2fd9a1d1ae3b3b8ebdf4c867edfb5ad186f
+  metadata.gz: 392bc21969769e782adf4b725f499ec0e43c2ce882b9ebdeddc856f7f5543d0de1f047075a0c4f49f8e45f2cd713285e097c69c7250b407452f5dd5e68b6ea77
+  data.tar.gz: 6d08ae49f0c082c44bb6278b8272af13345b37732bf21e8eba34671f97b4279b32caa8292907a8d84599363268280dfbd54350ef12a9d00eb7b7c220b8675fa9

data/lib/posthog/feature_flags.rb

@@ -500,6 +500,21 @@ module PostHog
       end
     end
 
+    def self.parse_finite_number(value)
+      case value
+      when String
+        return unless /\A[+-]?([0-9]+(\.[0-9]*)?|\.[0-9]+)([eE][+-]?[0-9]+)?\z/.match?(value)
+      when Integer, Float
+        # JSON numbers remain supported alongside numeric strings.
+      else
+        return unless defined?(::BigDecimal) && value.is_a?(::BigDecimal)
+      end
+
+      number = value.to_f
+      number if number.finite?
+    end
+    private_class_method :parse_finite_number
+
     def self.relative_date_parse_for_feature_flag_matching(value)
       match = /^-?([0-9]+)([a-z])$/.match(value)
       parsed_dt = DateTime.now.new_offset(0)
@@ -674,6 +689,11 @@ module PostHog
       end.downcase
     end
 
+    def self.string_operand(value)
+      value.nil? ? 'null' : value.to_s
+    end
+    private_class_method :string_operand
+
     def self.exact_property_match?(filter, value, property_matching_version)
       return legacy_truthy?(filter) == legacy_truthy?(value) if property_matching_version != 2 && boolean_like?(filter)
       return legacy_truthy?(value) if filter.is_a?(Array) && filter.empty?
@@ -718,36 +738,29 @@ module PostHog
       when 'is_set'
         property_values.key?(key)
       when 'icontains'
-        override_value.to_s.downcase(:ascii).include?(value.to_s.downcase(:ascii))
+        string_operand(override_value).downcase(:ascii).include?(value.to_s.downcase(:ascii))
       when 'not_icontains'
-        !override_value.to_s.downcase(:ascii).include?(value.to_s.downcase(:ascii))
+        !string_operand(override_value).downcase(:ascii).include?(value.to_s.downcase(:ascii))
       when 'starts_with'
-        override_value.to_s.downcase(:ascii).start_with?(value.to_s.downcase(:ascii))
+        string_operand(override_value).downcase(:ascii).start_with?(value.to_s.downcase(:ascii))
       when 'not_starts_with'
-        !override_value.to_s.downcase(:ascii).start_with?(value.to_s.downcase(:ascii))
+        !string_operand(override_value).downcase(:ascii).start_with?(value.to_s.downcase(:ascii))
       when 'ends_with'
-        override_value.to_s.downcase(:ascii).end_with?(value.to_s.downcase(:ascii))
+        string_operand(override_value).downcase(:ascii).end_with?(value.to_s.downcase(:ascii))
       when 'not_ends_with'
-        !override_value.to_s.downcase(:ascii).end_with?(value.to_s.downcase(:ascii))
+        !string_operand(override_value).downcase(:ascii).end_with?(value.to_s.downcase(:ascii))
       when 'regex'
-        PostHog::Utils.is_valid_regex(value.to_s) && !Regexp.new(value.to_s).match(override_value.to_s).nil?
+        PostHog::Utils.is_valid_regex(value.to_s) && !Regexp.new(value.to_s).match(string_operand(override_value)).nil?
       when 'not_regex'
-        PostHog::Utils.is_valid_regex(value.to_s) && Regexp.new(value.to_s).match(override_value.to_s).nil?
+        PostHog::Utils.is_valid_regex(value.to_s) && Regexp.new(value.to_s).match(string_operand(override_value)).nil?
       when 'gt', 'gte', 'lt', 'lte'
-        parsed_value = nil
-        begin
-          parsed_value = Float(value)
-        rescue StandardError # rubocop:disable Lint/SuppressedException
-        end
-        if !parsed_value.nil? && !override_value.nil?
-          if override_value.is_a?(String)
-            compare(override_value, value.to_s, operator)
-          else
-            compare(override_value, parsed_value, operator)
-          end
-        else
-          compare(override_value.to_s, value.to_s, operator)
-        end
+        parsed_value = parse_finite_number(value)
+        raise InconclusiveMatchError, 'Invalid numeric condition' if parsed_value.nil?
+
+        parsed_override = parse_finite_number(override_value)
+        return false if parsed_override.nil?
+
+        compare(parsed_override, parsed_value, operator)
       when 'is_date_before', 'is_date_after'
         override_date = PostHog::Utils.convert_to_datetime(override_value.to_s)
         parsed_date = relative_date_parse_for_feature_flag_matching(value.to_s)

data/lib/posthog/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module PostHog
-  VERSION = '3.28.0'
+  VERSION = '3.28.2'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: posthog-ruby
 version: !ruby/object:Gem::Version
-  version: 3.28.0
+  version: 3.28.2
 platform: ruby
 authors:
 - ''