postgres_ext 0.0.7 → 0.0.8

data/.gitignore

@@ -18,3 +18,4 @@ tmp
 bin/
 .rbenv-version*
 
+spec/dummy/config/database.yml

data/.travis.yml

@@ -7,6 +7,7 @@ rvm:
 
 before_script:
   - psql -c 'create database postgres_ext_test;' -U postgres
+  - cp spec/dummy/config/database.yml.example spec/dummy/config/database.yml
 
 notifications:
   email: 

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.0.8
+
+Fixes add and change column 
+
 ## 0.0.7
 
 Adds Arel predicate functions for array overlap operator (`&&`) and

data/CONTRIBUTING.md

@@ -0,0 +1,33 @@
+# Contribution Guidelines #
+
+## Submitting a new issue ##
+
+If you need to open a new issue you *must* provide the following:
+
+1. Version of Rails
+
+Failure to include the above mentioned requirements will result in the
+issue being closed.
+
+If you want to ensure that your issue gets fixed *fast* you should
+attempt to reproduce the issue in an isolated example application that
+you can share.
+
+## Making a pull request ##
+
+If you'd like to submit a pull request please adhere to the following:
+
+1. Your code *must* be tested. Please TDD your code!
+2. No single-character variables
+3. Two-spaces instead of tabs
+4. Single-quotes instead of double-quotes unless you are using string
+   interpolation or escapes.
+5. General Rails/Ruby naming conventions for files and classes
+6. *Do not* use Ruby 1.9 hash syntax
+7. *Do not* use Ruby 1.9 stubby proc syntax
+
+Plase note that you must adhere to each of the above mentioned rules.
+Failure to do so will result in an immediate closing of the pull
+request. If you update and rebase the pull request to follow the
+guidelines your pull request will be re-opened and considered for
+inclusion.

data/README.md

@@ -257,10 +257,3 @@ User.where(user_arel[:ip_address].contained_witin('127.0.0.1/24')).to_sql
 
 Dan McClain [twitter](http://twitter.com/_danmcclain) [github](http://github.com/danmcclain)
 
-## Contributing
-
-1. Fork it
-2. Create your feature branch (`git checkout -b my-new-feature`)
-3. Commit your changes (`git commit -am 'Added some feature'`)
-4. Push to the branch (`git push origin my-new-feature`)
-5. Create new Pull Request

data/lib/postgres_ext/active_record/connection_adapters/postgres_adapter.rb

@@ -145,7 +145,7 @@ module ActiveRecord
         end
       end
 
-      class Table
+      class Table < ActiveRecord::ConnectionAdapters::Table
         EXTENDED_TYPES.keys.map(&:to_s).each do |column_type|
           class_eval <<-EOV, __FILE__, __LINE__ + 1
             def #{column_type}(*args)                                          # def string(*args)
@@ -179,6 +179,36 @@ module ActiveRecord
         super
       end
 
+      def change_table(table_name, options = {})
+        if supports_bulk_alter? && options[:bulk]
+          recorder = ActiveRecord::Migration::CommandRecorder.new(self)
+          yield Table.new(table_name, recorder)
+          bulk_change_table(table_name, recorder.commands)
+        else
+          yield Table.new(table_name, self)
+        end
+      end
+
+      if RUBY_PLATFORM =~ /java/
+        # The activerecord-jbdc-adapter implements PostgreSQLAdapter#add_column differently from the active-record version
+        # so we have to patch that version in JRuby, but not in MRI/YARV
+        def add_column(table_name, column_name, type, options = {})
+          default = options[:default]
+          notnull = options[:null] == false
+          sql_type = type_to_sql(type, options[:limit], options[:precision], options[:scale])
+
+          if options[:array]
+            sql_type << '[]'
+          end
+
+          # Add the column.
+          execute("ALTER TABLE #{quote_table_name(table_name)} ADD COLUMN #{quote_column_name(column_name)} #{sql_type}")
+
+          change_column_default(table_name, column_name, default) if options_include_default?(options)
+          change_column_null(table_name, column_name, false, default) if notnull
+        end
+      end
+
       def type_cast_with_extended_types(value, column, part_array = false)
         case value
         when NilClass

data/lib/postgres_ext/version.rb

@@ -1,3 +1,3 @@
 module PostgresExt
-  VERSION = '0.0.7'
+  VERSION = '0.0.8'
 end

data/postgres_ext.gemspec

@@ -26,6 +26,9 @@ Gem::Specification.new do |gem|
   else
     gem.add_development_dependency 'pg', '~> 0.13.2'
   end
-  gem.add_development_dependency 'debugger', '~> 1.1.2' if RUBY_VERSION == '1.9.3'
+  unless ENV['CI']
+    gem.add_development_dependency 'debugger', '~> 1.1.2' if RUBY_VERSION == '1.9.3'
+    gem.add_development_dependency 'ruby-debug' if RUBY_PLATFORM =~ /java/
+  end
   gem.add_development_dependency 'fivemat'
 end

data/spec/migrations/array_spec.rb

@@ -11,15 +11,37 @@ describe 'array migrations' do
       end
     end.should_not raise_exception
 
+    lambda do
+      connection.add_column :data_types, :cidr_5, :cidr, :array => true
+    end.should_not raise_exception
+
+    lambda do
+      connection.change_table :data_types do |t|
+        t.column :cidr_6, :cidr, :array => true
+      end
+    end.should_not raise_exception
+
+    lambda do
+      connection.change_table :data_types do |t|
+        t.cidr :cidr_7, :array => true
+      end
+    end.should_not raise_exception
+
     columns = connection.columns(:data_types)
     cidr_1 = columns.detect { |c| c.name == 'cidr_1'}
     cidr_2 = columns.detect { |c| c.name == 'cidr_2'}
     cidr_3 = columns.detect { |c| c.name == 'cidr_3'}
     cidr_4 = columns.detect { |c| c.name == 'cidr_4'}
+    cidr_5 = columns.detect { |c| c.name == 'cidr_5'}
+    cidr_6 = columns.detect { |c| c.name == 'cidr_6'}
+    cidr_7 = columns.detect { |c| c.name == 'cidr_7'}
 
     cidr_1.sql_type.should eq 'cidr[]'
     cidr_2.sql_type.should eq 'cidr[]'
     cidr_3.sql_type.should eq 'cidr[]'
     cidr_4.sql_type.should eq 'cidr[]'
+    cidr_5.sql_type.should eq 'cidr[]'
+    cidr_6.sql_type.should eq 'cidr[]'
+    cidr_7.sql_type.should eq 'cidr[]'
   end
 end

data/spec/migrations/uuid_spec.rb

@@ -5,21 +5,21 @@ describe 'UUID migrations' do
   it 'creates an uuid column' do
     lambda do
       connection.create_table :data_types do |t|
-        t.uuid :cidr_1
-        t.uuid :cidr_2, :cidr_3
-        t.column :cidr_4, :uuid
+        t.uuid :uuid_1
+        t.uuid :uuid_2, :uuid_3
+        t.column :uuid_4, :uuid
       end
     end.should_not raise_exception
 
     columns = connection.columns(:data_types)
-    cidr_1 = columns.detect { |c| c.name == 'cidr_1'}
-    cidr_2 = columns.detect { |c| c.name == 'cidr_2'}
-    cidr_3 = columns.detect { |c| c.name == 'cidr_3'}
-    cidr_4 = columns.detect { |c| c.name == 'cidr_4'}
+    uuid_1 = columns.detect { |c| c.name == 'uuid_1'}
+    uuid_2 = columns.detect { |c| c.name == 'uuid_2'}
+    uuid_3 = columns.detect { |c| c.name == 'uuid_3'}
+    uuid_4 = columns.detect { |c| c.name == 'uuid_4'}
 
-    cidr_1.sql_type.should eq 'uuid'
-    cidr_2.sql_type.should eq 'uuid'
-    cidr_3.sql_type.should eq 'uuid'
-    cidr_4.sql_type.should eq 'uuid'
+    uuid_1.sql_type.should eq 'uuid'
+    uuid_2.sql_type.should eq 'uuid'
+    uuid_3.sql_type.should eq 'uuid'
+    uuid_4.sql_type.should eq 'uuid'
   end
 end

data/spec/models/array_spec.rb

@@ -7,7 +7,10 @@ describe 'Models with array columns' do
     before do
       adapter.create_table :users, :force => true do |t|
         t.string :nick_names, :array => true
+
+        t.timestamps
       end
+
       class User < ActiveRecord::Base
         attr_accessible :nick_names
       end
@@ -54,6 +57,36 @@ describe 'Models with array columns' do
         end
       end
     end
+
+    context '#update_attribute' do
+      describe 'setting a value via update_attribute' do
+        it 'returns the value set when the record is retrieved' do
+          user = User.create(:nick_names => [])
+          user.reload
+
+          user.update_attribute(:nick_names, ['some', 'values'])
+          user.save
+
+          user.reload
+          user.nick_names.should eq ['some', 'values']
+        end
+      end
+    end
+
+    context '#update_attributes' do
+      describe 'setting a value via update_attributes' do
+        it 'returns the value set when the record is retrieved' do
+          user = User.create(:nick_names => [])
+          user.reload
+
+          user.update_attributes(:nick_names => ['some', 'values'])
+          user.save
+
+          user.reload
+          user.nick_names.should eq ['some', 'values']
+        end
+      end
+    end
   end
 
   context 'default values' do

data/spec/schema_dumper/uuid_spec.rb

@@ -5,7 +5,7 @@ describe 'UUID schema dump' do
   it 'correctly generates uuid column statements' do
     stream = StringIO.new
     connection.create_table :testings do |t|
-      t.uuid :network_column
+      t.uuid :uuid_column
     end
 
     ActiveRecord::SchemaDumper.dump(connection, stream)

data/spec/spec_helper.rb

@@ -3,7 +3,6 @@ ENV['RAILS_ENV'] = 'test'
 require File.expand_path('../dummy/config/environment.rb',  __FILE__)
 
 require 'rspec/rails'
-require 'debugger' if RUBY_VERSION == '1.9.3'
 require 'bourne'
 
 ENGINE_RAILS_ROOT=File.join(File.dirname(__FILE__), '../')

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: postgres_ext
 version: !ruby/object:Gem::Version
-  version: 0.0.7
+  version: 0.0.8
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-09-14 00:00:00.000000000 Z
+date: 2012-09-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -150,6 +150,7 @@ files:
 - .rspec
 - .travis.yml
 - CHANGELOG.md
+- CONTRIBUTING.md
 - Gemfile
 - LICENSE
 - README.md
@@ -186,7 +187,7 @@ files:
 - spec/dummy/config.ru
 - spec/dummy/config/application.rb
 - spec/dummy/config/boot.rb
-- spec/dummy/config/database.yml
+- spec/dummy/config/database.yml.example
 - spec/dummy/config/environment.rb
 - spec/dummy/config/environments/development.rb
 - spec/dummy/config/environments/production.rb
@@ -250,7 +251,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 169599389239444303
+      hash: -830312040655703419
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -259,7 +260,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 169599389239444303
+      hash: -830312040655703419
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.23
@@ -286,7 +287,7 @@ test_files:
 - spec/dummy/config.ru
 - spec/dummy/config/application.rb
 - spec/dummy/config/boot.rb
-- spec/dummy/config/database.yml
+- spec/dummy/config/database.yml.example
 - spec/dummy/config/environment.rb
 - spec/dummy/config/environments/development.rb
 - spec/dummy/config/environments/production.rb