postburner 1.0.0.rc.4 → 1.0.0.rc.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fc5a8c616b4bf393b03fdc5d2bef57eb03e1a9b9dc06fe592f89b3d1238c2606
-  data.tar.gz: 40fe3028ce331e7ecbc6facb5829b845272ce66c14578cdd12b79a4495de85ce
+  metadata.gz: 62187fb2fd681e87e1028c52cbd6f3756b32c895c05390bffca05d51e1287ec7
+  data.tar.gz: 31ab083d1e9d00bfb7dc6fabbf09d7065f5062d73a6cd738835a0b76f54426b6
 SHA512:
-  metadata.gz: 2e3095d5efd3761db840b44461f42f127269608a6070ead2e9b5751054e3875e11098d34ac9232237baa27350ec46fbf8413a80adde99feae0115bedd9b08e68
-  data.tar.gz: 3a38ad87ba8692bae49462dbf6ac8e0013cb64209200c44201a25e5cb5d2c73ea14719753f279da4ce7da016d1af581a446bec7ad97af035f4884d645c12fefe
+  metadata.gz: d2e7a422e53852490b5e2ec8502f3dd69a34f17975ee808f463658f20f2ca228c5467d149987caaf7e905433b364b30c7f92142e07e7f7da3bbd7763d99c6284
+  data.tar.gz: aa6ce11d8f045be5b259a1869339117ddf40fca8e6d3579ced469355d2c89fbd7f19da96903154dac11a0f0efed57db840c1581ba9512c2665300d58d0453e32

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## v1.0.0.rc.5 - 2026-06-26
+
+### Fixed
+- `Postburner::Scheduler#ensure_future_execution!` no longer accumulates duplicate future `Postburner::ScheduleExecution` rows. The watchdog (every `scheduler_interval`, default 300s) created and enqueued one extra future execution on **every** cycle, building up dozens or hundreds of Beanstalkd delayed jobs that all eventually fire.
+
 ## v1.0.0.rc.4 - 2026-06-10
 
 ### Added

data/app/models/postburner/job.rb

@@ -88,6 +88,21 @@ module Postburner
 
     validates :sid, presence: {strict: true}
 
+    # Jobs that have been picked up by a worker but have not yet completed or
+    # been removed, i.e. currently in-flight.
+    #
+    # @note A job whose worker crashed mid-run can remain in this scope even
+    #   though nothing is executing. Beanstalkd's reserved count
+    #   ({Postburner.stats}) is the ground truth for what is actually running.
+    #
+    # @example
+    #   Postburner::Job.processing          # all in-flight tracked jobs
+    #   Postburner::TrackedJob.processing   # in-flight tracked ActiveJobs
+    #
+    scope :processing, -> {
+      where.not(processing_at: nil).where(processed_at: nil, removed_at: nil)
+    }
+
     # Resolves an STI type name to a class, falling back to OrphanedJob when the
     # original class no longer exists. This tolerates rows whose `type` column
     # references a deleted or renamed job class, preventing

data/lib/postburner/scheduler.rb

@@ -484,7 +484,32 @@ module Postburner
         return true
       end
 
-      # Delegate to Schedule - it knows whether a future execution is needed
+      # GUARD: Only create a new future execution if none exists yet (relative to now).
+      #
+      # This guard intentionally uses Time.current, while the inner guard inside
+      # create_next_execution! (schedule.rb:199-200) uses after.run_at. They answer
+      # DIFFERENT questions:
+      #
+      #   Watchdog (here):         "Does ANY execution exist in the future?"
+      #   before_attempt callback: "Does an execution exist AFTER the one now running?"
+      #
+      # The before_attempt callback (job.rb:380) passes `after: current_execution` so
+      # create_next_execution!'s check_time ≈ Time.current — it correctly fires when
+      # the watchdog has already queued a successor. But when this method calls
+      # create_next_execution!(after: last_execution), check_time becomes
+      # last_execution.run_at — the highest run_at in the table by definition — so
+      # the inner guard can never find an execution beyond it and would always create
+      # another, accumulating one extra future execution per watchdog cycle.
+      #
+      # Note: > (not >=) is intentional. A just-fired execution at run_at == Time.current
+      # must NOT block creation of its successor.
+      #
+      # The inner guard in create_next_execution! is STILL REQUIRED for the
+      # before_attempt callback path and must NOT be removed even though it is
+      # effectively bypassed on the watchdog path now that this outer guard fires first.
+      return false if schedule.executions.where('run_at > ?', Time.current).exists?
+
+      # Delegate to Schedule - it knows how to calculate the next run time
       execution = schedule.create_next_execution!(after: last_execution)
 
       if execution

data/lib/postburner/version.rb

@@ -1,3 +1,3 @@
 module Postburner
-  VERSION = '1.0.0.rc.4'
+  VERSION = '1.0.0.rc.5'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: postburner
 version: !ruby/object:Gem::Version
-  version: 1.0.0.rc.4
+  version: 1.0.0.rc.5
 platform: ruby
 authors:
 - Matt Smith