postburner 0.7.1 → 0.7.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 74d577811ded71db9296138442288dd53a0eb46718b8980564a84032c3a7b564
-  data.tar.gz: b97fb1adb55232e5c2293d88c852ab496f3519ad740b2f0d5df8d68f7d663e97
+  metadata.gz: 31329ed53b5479ef4b3963ce4f6faa7ae103986cb68af6777db9c5dbb46a5b28
+  data.tar.gz: 2c115fcdea67de746f3544684377ff66f8f85ec48241b93a6c8f107e9c5bf052
 SHA512:
-  metadata.gz: 995fe1db553b3e2b698427eeb061a6e5463011ed29315dbd5280f8a1d4c46f6f1c4a15607b80c58d2ba393d896e15f38baa4581a616a758f7f57ffda8d57ac70
-  data.tar.gz: d123415e6a7a4329a1897922ab6619a032fc5c61b501fb612dcfa9eb370ec45da97b3ff0787a2baf25101fd7fadee572c620f1fb32dbb202ee76c4f4e67a224d
+  metadata.gz: 213abba743144280c99e4b65b0ad54fa26189a3c7f60c82ac9258642ca50803769b297abb53619f89bd88152e43ac6720881178b154ed45771c1fb252eeda99e
+  data.tar.gz: c01eb3f31553159d442cf9c82e984ca084c83b301df918fe2cfedc4d6d2c508d15ae114ff5402361acf9a2bdeefe0db4ed508183e366ed144ae467aad422a0c3

data/CHANGELOG.md

@@ -2,6 +2,14 @@
 
 ## v0.7.1 - 2022-10-30
 
+### Required Changes
+- rename `enqueue` callbacks to `insert`.
+
+### Changed
+- convert to ActiveModel callbacks.
+
+## v0.7.1 - 2022-10-30
+
 ### Changed
 - return true from insert_if_queued! and log response to Rails logger.
 

data/app/models/postburner/job.rb

@@ -16,7 +16,11 @@ module Postburner
   #
   class Job < ApplicationRecord
     include Backburner::Queue
-    include Callbacks
+
+    define_model_callbacks :insert
+    define_model_callbacks :attempt
+    define_model_callbacks :processing
+    define_model_callbacks :processed, only: :after
 
     LOG_LEVELS = [
       :debug,
@@ -51,9 +55,7 @@ module Postburner
 
       @_insert_options = options
 
-      run_callbacks :enqueue do
-        self.save!
-      end
+      self.save!
     end
 
     def requeue!(options={})
@@ -83,7 +85,7 @@ module Postburner
     end
 
     def perform!(args={})
-      run_callbacks :attempt do
+      _run_attempt_callbacks do
         self.attempting
 
         self.update_columns(
@@ -124,7 +126,7 @@ module Postburner
 
           self.log!("START (bkid #{self.bkid})")
 
-          run_callbacks :processing do
+          _run_processing_callbacks do
             begin
               self.perform(args)
             rescue Exception => exception
@@ -140,7 +142,7 @@ module Postburner
             now = Time.zone.now
             _duration =  (now - self.processing_at) * 1000 rescue nil
 
-            run_callbacks :processed do
+            _run_processed_callbacks do
               persist_metadata!(
                 processed_at: now,
                 duration:     _duration,
@@ -269,16 +271,18 @@ module Postburner
     def insert!(options={})
       response = nil
 
-      Job.transaction do
-        response = Backburner::Worker.enqueue(
-          Postburner::Job,
-          self.id,
-          options
-        )
-
-        persist_metadata!(
-          bkid: response[:id],
-        )
+      _run_insert_callbacks do
+        Job.transaction do
+          response = Backburner::Worker.enqueue(
+            Postburner::Job,
+            self.id,
+            options
+          )
+
+          persist_metadata!(
+            bkid: response[:id],
+          )
+        end
       end
 
       self.log("QUEUED: #{response}")

data/lib/postburner/version.rb

@@ -1,3 +1,3 @@
 module Postburner
-  VERSION = '0.7.1'
+  VERSION = '0.7.2'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: postburner
 version: !ruby/object:Gem::Version
-  version: 0.7.1
+  version: 0.7.2
 platform: ruby
 authors:
 - Matt Smith
@@ -79,7 +79,6 @@ files:
 - Rakefile
 - app/assets/config/postburner_manifest.js
 - app/assets/stylesheets/postburner/application.css
-- app/concerns/postburner/callbacks.rb
 - app/controllers/postburner/application_controller.rb
 - app/controllers/postburner/jobs_controller.rb
 - app/controllers/postburner/static_controller.rb

data/app/concerns/postburner/callbacks.rb

@@ -1,286 +0,0 @@
-# frozen_string_literal: true
-
-require "active_support/callbacks"
-require "active_support/core_ext/object/with_options"
-require "active_support/core_ext/module/attribute_accessors"
-
-module Postburner
-  # = Postburner Job Callbacks
-  #
-  # Postburner Job provides hooks during the life cycle of a job. Callbacks allow you
-  # to trigger logic during this cycle. In called order, available callbacks are:
-  #
-  # * <tt>before_enqueue</tt>
-  # * <tt>after_enqueue</tt>
-  # * <tt>before_attempt</tt>
-  # * <tt>before_processing</tt>
-  # * <tt>after_processing</tt>
-  # * <tt>after_processed</tt>
-  # * <tt>after_attempt</tt>
-  #
-  # Around callbacks are also defined:
-  # * <tt>around_enqueue</tt>
-  # * <tt>around_attempt</tt>
-  # * <tt>around_processing</tt>
-  #
-  # NOTE: Calling the same callback multiple times will overwrite previous callback definitions.
-  #
-  module Callbacks
-    extend  ActiveSupport::Concern
-    include ActiveSupport::Callbacks
-
-    included do
-      cattr_accessor :skip_after_callbacks_if_terminated,
-        instance_accessor: false,
-        default: false
-
-      with_options(skip_after_callbacks_if_terminated: skip_after_callbacks_if_terminated) do
-        define_callbacks :enqueue
-        define_callbacks :attempt
-        define_callbacks :processing
-        define_callbacks :processed
-      end
-    end
-    module ClassMethods
-      def inherited(klass)
-        klass.get_callbacks(:enqueue).
-          config[:skip_after_callbacks_if_terminated] =
-            skip_after_callbacks_if_terminated
-        klass.get_callbacks(:processing).
-          config[:skip_after_callbacks_if_terminated] =
-            skip_after_callbacks_if_terminated
-        klass.get_callbacks(:attempt).
-          config[:skip_after_callbacks_if_terminated] =
-            skip_after_callbacks_if_terminated
-        klass.get_callbacks(:processed).
-          config[:skip_after_callbacks_if_terminated] =
-            skip_after_callbacks_if_terminated
-        super
-      end
-
-      # Defines a callback that will get called right before the
-      # job starts and any metadata is persisted.
-      #
-      #   class VideoProcessJob < Postburner::Base
-      #
-      #     before_attempt do |job|
-      #       $statsd.increment "attempting-video-job.try"
-      #     end
-      #
-      #     def perform(video_id)
-      #       Video.find(video_id).process
-      #     end
-      #   end
-      #
-      def before_attempt(*filters, &blk)
-        set_callback(:attempt, :before, *filters, &blk)
-      end
-
-      # Defines a callback that will get called right after the
-      # job finishes and all metadata is persisted.
-      #
-      # This isn't called unless the attempt finishes without error,
-      # though this is subject to change in the future
-      #
-      #   class VideoProcessJob < Postburner::Base
-      #
-      #     before_attempt do |job|
-      #       $statsd.increment "attempt-complete-video-job.try"
-      #     end
-      #
-      #     def perform(video_id)
-      #       Video.find(video_id).process
-      #     end
-      #   end
-      #
-      def after_attempt(*filters, &blk)
-        set_callback(:attempt, :after, *filters, &blk)
-      end
-
-      # Defines a callback that will get called around the attempt
-      # of the job.
-      #
-      #   class VideoProcessJob < Postburner::Base
-      #
-      #     around_enqueue do |job, block|
-      #       $statsd.time "video-job.process" do
-      #         block.call
-      #       end
-      #     end
-      #
-      #     def perform(video_id)
-      #       Video.find(video_id).process
-      #     end
-      #   end
-      #
-      def around_attempt(*filters, &blk)
-        set_callback(:attempt, :around, *filters, &blk)
-      end
-
-      # Defines a callback that will get called right before the
-      # job's perform method is executed.
-      #
-      #   class VideoProcessJob < Postburner::Base
-      #
-      #     before_processing do |job|
-      #       UserMailer.notify_video_started_processing(job.arguments.first)
-      #     end
-      #
-      #     def perform(video_id)
-      #       Video.find(video_id).process
-      #     end
-      #   end
-      #
-      def before_processing(*filters, &blk)
-        set_callback(:processing, :before, *filters, &blk)
-      end
-
-      # Defines a callback that will get called right after the
-      # job's perform method has finished.
-      #
-      #   class VideoProcessJob < Postburner::Base
-      #
-      #     after_processing do |job|
-      #       UserMailer.notify_video_processed(job.arguments.first)
-      #     end
-      #
-      #     def perform(video_id)
-      #       Video.find(video_id).process
-      #     end
-      #   end
-      #
-      def after_processing(*filters, &blk)
-        set_callback(:processing, :after, *filters, &blk)
-      end
-
-      # Defines a callback that will get called around the job's perform method.
-      #
-      #   class VideoProcessJob < Postburner::Base
-      #
-      #     around_processing do |job, block|
-      #       UserMailer.notify_video_started_processing(job.arguments.first)
-      #       block.call
-      #       UserMailer.notify_video_processed(job.arguments.first)
-      #     end
-      #
-      #     def perform(video_id)
-      #       Video.find(video_id).process
-      #     end
-      #   end
-      #
-      # You can access the return value of the job only if the execution wasn't halted.
-      #
-      #   class VideoProcessJob < Postburner::Base
-      #     around_processing do |job, block|
-      #       value = block.call
-      #       puts value # => "Hello World!"
-      #     end
-      #
-      #     def perform
-      #       "Hello World!"
-      #     end
-      #   end
-      #
-      def around_processing(*filters, &blk)
-        set_callback(:processing, :around, *filters, &blk)
-      end
-
-      # Defines a callback that will get called right after the
-      # job's processed_at timestamp has been persisted, marking the
-      # job as successfully completed, i.e. no errors raised.
-      #
-      # This is rather similar to after_processing but all of the
-      # job's metadata has been set.
-      #
-      #   class VideoProcessJob < Postburner::Base
-      #
-      #     after_processed do |job|
-      #       UserMailer.notify_video_processed(job.arguments.first)
-      #     end
-      #
-      #     def perform(video_id)
-      #       Video.find(video_id).process
-      #     end
-      #   end
-      #
-      def after_processed(*filters, &blk)
-        set_callback(:processed, :after, *filters, &blk)
-      end
-
-      # Defines a callback that will get called right before the
-      # job is enqueued.
-      #
-      #   class VideoProcessJob < Postburner::Base
-      #
-      #     before_enqueue do |job|
-      #       $statsd.increment "enqueue-video-job.try"
-      #     end
-      #
-      #     def perform(video_id)
-      #       Video.find(video_id).process
-      #     end
-      #   end
-      #
-      def before_enqueue(*filters, &blk)
-        set_callback(:enqueue, :before, *filters, &blk)
-      end
-
-      # Defines a callback that will get called right after the
-      # job is enqueued.
-      #
-      #   class VideoProcessJob < Postburner::Base
-      #
-      #     after_enqueue do |job|
-      #       $statsd.increment "enqueue-video-job.success"
-      #     end
-      #
-      #     def perform(video_id)
-      #       Video.find(video_id).process
-      #     end
-      #   end
-      #
-      def after_enqueue(*filters, &blk)
-        set_callback(:enqueue, :after, *filters, &blk)
-      end
-
-      # Defines a callback that will get called around the enqueuing
-      # of the job.
-      #
-      #   class VideoProcessJob < Postburner::Base
-      #
-      #     around_enqueue do |job, block|
-      #       $statsd.time "video-job.process" do
-      #         block.call
-      #       end
-      #     end
-      #
-      #     def perform(video_id)
-      #       Video.find(video_id).process
-      #     end
-      #   end
-      #
-      def around_enqueue(*filters, &blk)
-        set_callback(:enqueue, :around, *filters, &blk)
-      end
-    end
-
-    private
-
-    # NOTE processed / attempt exclueded here -- intentionally
-    #
-    def halted_callback_hook(_filter, name) # :nodoc:
-      return super unless %i(enqueue processing).include?(name.to_sym)
-      callbacks = public_send("_#{name}_callbacks")
-
-      if !self.class.skip_after_callbacks_if_terminated && callbacks.any? { |c| c.kind == :after }
-        ActiveSupport::Deprecation.warn(<<~EOM)
-            In Rails 7.0, `after_enqueue`/`after_work` callbacks no longer run if `before_enqueue`/`before_work` respectively halts with `throw :abort`.
-            To enable this behavior, uncomment the `config.active_job.skip_after_callbacks_if_terminated` config
-            in the new 6.1 framework defaults initializer.
-        EOM
-      end
-
-      super
-    end
-  end
-end