post_clerk 0.4 → 0.5

data/spec/controllers/orders_controller_spec.rb

@@ -0,0 +1,59 @@
+require 'spec_helper'
+
+describe OrdersController do
+  routes { OfficeClerk::Engine.routes }
+
+  before :all do
+    create :admin  unless Clerk.where(:admin => true).first
+  end  
+
+  # This should return the minimal set of values that should be in the session
+  # in order to pass any filters (e.g. authentication) defined in
+  # SuppliersController. Be sure to keep this updated too.
+  let(:valid_session) { { :clerk_email => Clerk.where(:admin => true).first.email } }
+
+  describe "GET index" do
+    it "assigns all orders as @orders" do
+
+      count_before = Order.count
+      basket = create :order
+      get :index, {}, valid_session
+      expect(assigns(:order_scope).count).to be  count_before + 1
+    end
+  end
+
+  describe "GET show" do
+    it "assigns the requested order as @order" do
+      order = create :order
+      get :show, {:id => order.to_param}, valid_session
+      expect(assigns(:order)).to eq(order)
+    end
+  end
+
+  describe "GET new" do
+    it "assigns a new order as @order" do
+      get :new, {}, valid_session
+      expect(assigns(:order)).to be_kind_of(Order)
+    end
+  end
+
+  describe "PUT update" do
+    describe "with valid params" do
+      it "assigns the requested order as @order" do
+        order = create :order
+        put :update, {:id => order.to_param, :order => attributes_for(:order)}, valid_session
+        expect(assigns(:order)).to eq(order)
+      end
+    end
+
+    describe "with invalid params" do
+      it "assigns the order as @order" do
+        order = create :order
+        # Trigger the behavior that occurs when invalid params are submitted
+        #allow(order).to receive(:save).and_return(false)
+        put :update, {:id => order.to_param, :order => {  :paid_on => ""}}, valid_session
+        expect(assigns(:order)).to eq(order)
+      end
+    end
+  end
+end

data/spec/features/orders_spec.rb

@@ -0,0 +1,32 @@
+require 'spec_helper'
+
+describe "Orders" do
+  before(:each) do
+    sign_in
+  end
+  it "lists orders" do
+    visit_path orders_path
+  end
+  it "should render" do
+    order = create :order
+    visit_path order_path order
+  end
+  it "creates order from basket" do
+    basket = create(:basket_with_item)
+    visit_path edit_basket_path(basket)
+    find(".make_order").click
+    ensure_path order_path(basket.reload.kori)
+  end
+  it "orders a order" do
+    order = create(:order_ordered)
+    visit_path order_path(order)
+    find(".pay_now").click
+  end
+  it "inventories a order" do
+    order = create(:order_paid)
+    visit_path order_path(order)
+    start = order.basket.items.first.product.inventory
+    find(".ship_now").click
+#    expect(order.basket.items.first.product.inventory).to be order.basket.items.first.quantity
+  end
+end

data/spec/lib/post_spec.rb

@@ -1,115 +1,114 @@
+require "spec_helper"
+
 RSpec.describe OfficeClerk::Post do
 
-  subject { described_class.new }
+  describe 'using the default weight-price table: [1 2 5 10 20] => [2 5 10 15 18]' do
+    context '.handling fee' do
+      it 'gives handling fee plus min price with defaults and 0 items' do
+        basket = create :basket
+        result = price_for_basket(basket , :handling_fee => 10)
+        expect(result).to eq(12.0)
+      end
 
-  context 'returns description' do
-    %w(en fi).each do |locale|
-      it "in supported language: #{locale}" do
-        I18n.with_locale(locale.to_sym) do
-          expect(described_class.description).to eq I18n.t(:postal_service)
-        end
+      it 'gives handling fee plus min price with defaults and 1 items' do
+        basket = create :basket_with_item
+        result = price_for_basket(basket , :handling_fee => 5)
+        expect(result).to eq(7.0)
       end
-    end
-  end
 
-  describe 'using the default weight-price table: [1 2 5 10 20] => [6 9 12 15 18]' do
-    context '.compute(package)' do
-      it 'gives 15.0 when total price is 100 and weight is 10kg' do
-        create_our_package(weight: 10.0, price: 100.0, quantity: 1)
-        result = subject.compute(@basket)
+      it 'gives no handling fee just min price with defaults and 1 items' do
+        basket = create :basket_with_item
+        result = price_for_basket(basket )
+        expect(result).to eq(2.0)
+      end
+    end
+    context "free shipping " do
+      it "gives 0 for more than 100 cost, default setting " do
+        basket = basket_with({:weight =>  10.0} , { price: 110.0} )
+        result = price_for_basket(basket)
+        expect(result).to eq(0.0)
+      end
+      it "gives non 0 for less than 100 cost, default setting " do
+        basket = basket_with({:weight =>  10.0} , { price: 90.0} )
+        result = price_for_basket(basket)
         expect(result).to eq(15.0)
       end
-
-      it 'gives 25.0 when total price is 40 and weight is 10kg' do
-        create_our_package(weight: 10.0, price: 40.0, quantity: 1)
-        result = subject.compute(@basket)
-        expect(result).to eq(25.0)
+      it 'gives 0 when total price is more than the MAX, for one item (different max)' do
+        basket = basket_with({:weight =>  15.0} , {:price => 350} )
+        result = price_for_basket(basket , :max_price => 300.0)
+        expect(result).to eq(0.0)
+      end
+    end
+    context '.price_for(basket)' do
+      it 'gives next price for 1.5 kg item => 5' do
+        basket = basket_with({:weight =>  1.5}  )
+        result = price_for_basket(basket)
+        expect(result).to eq(5.0)
       end
 
-      it 'gives 6 when total price is 60 and weight is less than 1kg' do
-        create_our_package(weight: 0.5, price: 60.0, quantity: 1)
-        result = subject.compute(@basket)
-        expect(result).to eq(6.0)
+      it 'gives next price for 2.5 kg item => 10' do
+        basket = basket_with({:weight =>  2.5}  )
+        result = price_for_basket(basket)
+        expect(result).to eq(10.0)
       end
 
-      it 'gives 16 when total price is 40 and weight is less than 1kg' do
-        create_our_package(weight: 0.5, price: 40.0, quantity: 1)
-        result = subject.compute(@basket)
-        expect(result).to eq(16.0)
+      it 'gives 15.0 when total price is 100 and weight is 10kg' do
+        basket = basket_with({:weight =>  10.0}  )
+        result = price_for_basket(basket)
+        expect(result).to eq(15.0)
       end
 
-      it 'gives 30 when total price is 200 and weight is 25kg (split into two)' do
-        create_our_package(weight: 25.0, price: 200.0, quantity: 1)
-        subject.preferred_max_price = 250
-        result = subject.compute(@basket)
-        expect(result).to eq(30.0)
+      it 'gives 15.0 when total price is 40 and weight is 10kg' do
+        basket = basket_with({:weight =>  10.0} , { price: 40.0} )
+        result = price_for_basket(basket)
+        expect(result).to eq(15.0)
       end
 
-      it 'gives 12 when total price is 100, there are three items and their weight is unknown' do
-        order   = create(:order)
-        variant = create(:base_variant, weight: nil)
-        [30.0, 40.0, 30.0].each { |price| create_line_item(order, variant, price: price) }
-        order.line_items.reload
-        package = create(:shipment, order: order)
-        result  = subject.compute(package)
-        expect(result).to eq(12.0)
+      it 'gives 6 when total price is 60 and weight is less than 1kg' do
+        basket = basket_with({:weight =>  0.5} , { price: 60.0} )
+        result = price_for_basket(basket)
+        expect(result).to eq(2.0)
       end
 
-      it 'gives 0 when total price is more than the MAX, for any number of items' do
-        create_our_package(weight: 25.0, price: 350.0, quantity: 1)
-        subject.preferred_max_price = 300
-        result = subject.compute(@basket)
-        expect(result).to eq(0.0)
+      it 'gives 30 when total price is 200 and weight is 25kg (split into two)' do
+        basket = basket_with({:weight =>  25.0} , {:price => 200.0} )
+        result = price_for_basket(basket , :max_price => 250)
+        expect(result).to eq(28.0)
       end
     end
   end
 
-  describe 'when preferred max weight, length and width are 18 kg, 120 cm and 60 cm' do
+  describe 'when preferred max is 20 kg' do
     context '.available?(package)' do
-      it 'is false when item weighs more than 18kg' do
-        create_our_package(weight: 20, height: 70, width: 30, depth: 30)
-        expect(subject.available?(@basket)).to be(false)
-      end
-
-      it 'is false when item is longer than 120cm' do
-        create_our_package(weight: 10, height: 130, width: 30, depth: 30)
-        expect(subject.available?(@basket)).to be(false)
-      end
-
-      it 'is false when item is wider than 60cm' do
-        create_our_package(weight: 10, height: 80, width: 70, depth: 30)
-        expect(subject.available?(@basket)).to be(false)
+      it 'is false when item weighs more than 20kg' do
+        basket = basket_with(:weight => 25 )
+        expect(OfficeClerk::Post.new({}).available?(basket)).to be(false)
       end
     end
+  end
+  
+  def basket_with product = {}, item = {}
+    basket = create :basket_with_item
+    basket.items.first.product.update_attributes!(product)
+    basket.items.first.update_attributes!(item)
+    basket.cache_total #TODO after save hook does not work to automatically update the totals
+    basket
+  end
+  def price_for_basket(basket , args = {})
+    OfficeClerk::Post.new(args).price_for(basket)
+  end
 
-    context '.item_oversized?(variant)' do
-      it 'is true if the longest side is more than 120cm' do
-        create_our_package(weight: 10, height: 130, width: 40, depth: 30)
-        expect(subject.item_oversized?(@variant)).to be(true)
-      end
-
-      it 'is true if the second longest side is more than 60cm' do
-        create_our_package(weight: 10, height: 80, width: 70, depth: 30)
-        expect(subject.item_oversized?(@variant)).to be(true)
+  context 'returns description' do
+    %w(en fi).each do |locale|
+      it "in supported language: #{locale}" do
+        I18n.with_locale(locale.to_sym) do
+          OfficeClerk::ShippingMethod.all.each do |name , method|
+            expect(method.description).not_to be_blank
+            expect(method.description).not_to include("missing")
+          end
+        end
       end
     end
   end
 
-  def create_our_package(args = {})
-    @variant = create :base_variant, args.except!(:quantity)
-    order = create :order
-    create_line_item(order, @variant, args)
-    order.line_items.reload
-    @basket = create :shipment, order: order
-  end
-
-  def create_line_item(order, variant, args = {})
-    create(
-      :line_item,
-      price:    args[:price] || BigDecimal.new('10.00'),
-      quantity: args[:quantity] || 1,
-      order:    order,
-      variant:  variant
-    )
-  end
 end

data/spec/spec_helper.rb

@@ -1,40 +1,38 @@
-require 'simplecov'
-require 'coveralls'
-SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
-  SimpleCov::Formatter::HTMLFormatter,
-  Coveralls::SimpleCov::Formatter
-]
-SimpleCov.start do
-  add_filter '/.bundle'
-  add_filter '/spec/'
-  add_filter '/lib/post_clerk/engine'
-  add_group 'Libraries', 'lib'
+if ENV['CODECLIMATE_REPO_TOKEN']
+  require "codeclimate-test-reporter"
+  CodeClimate::TestReporter.start
 end
 
-ENV['RAILS_ENV'] ||= 'test'
+# This file is copied to spec/ when you run 'rails generate rspec:install'
+ENV["RAILS_ENV"] = 'test'
+require File.expand_path("../../test_app/config/environment",  __FILE__)
+Rails.backtrace_cleaner.remove_silencers!
 
-require File.expand_path('../dummy/config/environment.rb',  __FILE__)
-
-require 'pry'
-require 'ffaker'
 require 'rspec/rails'
 
-ActiveRecord::Migration.maintain_test_schema!
-ActiveRecord::Migration.check_pending!
+Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each { |f| require f }
 
-RSpec.configure do |config|
 
-  config.fail_fast = false
-  config.filter_run focus: true
-  config.run_all_when_everything_filtered = true
+RSpec.configure do |config|
+  
+  config.include PageHelper  
+  
+  config.include OfficeClerk::Engine.routes.url_helpers
 
-  config.mock_with :rspec
-  config.raise_errors_for_deprecations!
+  config.infer_base_class_for_anonymous_controllers = false
   config.infer_spec_type_from_file_location!
-
-  config.expect_with :rspec do |expectations|
-    expectations.syntax = :expect
+  
+  # Run specs in random order to surface order dependencies. If you find an
+  # order dependency and want to debug it, you can fix the order by providing
+  # the seed, which is printed after each run.
+  #     --seed 1234
+  config.order = "random"
+
+  if config.files_to_run.one?
+    config.default_formatter = 'doc'
   end
-end
 
-Dir[File.join(File.dirname(__FILE__), 'support/**/*.rb')].each { |file| require file }
+  # Print the 10 slowest examples and example groups at the end of the spec run, 
+  #to help surface which specs are running  particularly slow.
+#  config.profile_examples = 10
+end

data/spec/support/admin.rb

@@ -0,0 +1,4 @@
+unless Clerk.where( :email =>  "admin@important.me").first
+  admin = Clerk.new( :email =>  "admin@important.me" , :admin => true , :password => "password" ) 
+   admin.save!
+end

data/spec/support/capybara.rb

@@ -0,0 +1,14 @@
+require 'capybara/rspec'
+require 'capybara-screenshot/rspec'
+Capybara::Screenshot.prune_strategy = :keep_last_run
+
+#require 'capybara/poltergeist'
+#Capybara.javascript_driver = :poltergeist
+
+Capybara.default_selector = :css
+
+RSpec.configure do |config|
+
+  config.include Capybara::DSL  
+
+end

data/spec/support/cleaner.rb

@@ -0,0 +1,22 @@
+require "database_cleaner"
+
+RSpec.configure do |config|
+  config.use_transactional_fixtures = false
+  config.before(:suite) do
+    DatabaseCleaner.clean_with :truncation
+    DatabaseCleaner.strategy = :transaction
+  end
+  config.before(:each) do |group|
+    DatabaseCleaner.strategy = :transaction
+  end
+
+  config.before(:each, :js => true) do
+    DatabaseCleaner.strategy = :truncation
+  end
+  config.before(:each) do
+    DatabaseCleaner.start
+  end
+  config.after(:each) do
+    DatabaseCleaner.clean
+  end
+end

data/spec/support/email.rb

@@ -0,0 +1,6 @@
+require 'email_spec'
+
+RSpec.configure do |config|
+  config.include(EmailSpec::Helpers)
+  config.include(EmailSpec::Matchers)
+end

data/spec/support/request_helper.rb

@@ -0,0 +1,31 @@
+module PageHelper
+  def ensure_path path
+    expect(page.current_path).to eq path
+  end
+  def visit_path path
+    visit path
+    expect(status_code).to be 200
+    expect(page).not_to have_css(".translation_missing")
+    ensure_path path
+  end
+
+  def ensure_admin
+    admin = Clerk.where(:admin => true).first
+    admin = create :admin unless admin
+    expect(admin).not_to be nil
+    admin
+  end
+  
+  def sign_in
+    admin = ensure_admin
+    visit sign_in_path
+    fill_in "email" , :with => admin.email
+    fill_in "password" , :with => "password"
+    click_button I18n.t(:sign_in)
+    expect(page).to have_content I18n.t(:baskets)
+  end
+
+  def expect_basket_total price
+    expect(find(".total").text).to include( price.round(2).to_s.sub(".",",")) # TODO remove the format hack 
+  end
+end

data/test_app/README.rdoc

@@ -0,0 +1,28 @@
+== README
+
+This README would normally document whatever steps are necessary to get the
+application up and running.
+
+Things you may want to cover:
+
+* Ruby version
+
+* System dependencies
+
+* Configuration
+
+* Database creation
+
+* Database initialization
+
+* How to run the test suite
+
+* Services (job queues, cache servers, search engines, etc.)
+
+* Deployment instructions
+
+* ...
+
+
+Please feel free to use a different markup language if you do not plan to run
+<tt>rake doc:app</tt>.

data/test_app/app/assets/javascripts/application.js

@@ -0,0 +1,15 @@
+// This is a manifest file that'll be compiled into application.js, which will include all the files
+// listed below.
+//
+// Any JavaScript/Coffee file within this directory, lib/assets/javascripts, vendor/assets/javascripts,
+// or vendor/assets/javascripts of plugins, if any, can be referenced here using a relative path.
+//
+// It's not advisable to add code directly here, but if you do, it'll appear at the bottom of the
+// compiled file.
+//
+// Read Sprockets README (https://github.com/sstephenson/sprockets#sprockets-directives) for details
+// about supported directives.
+//
+//= require jquery
+//= require jquery_ujs
+//= require_tree .

data/test_app/app/assets/stylesheets/application.css

@@ -0,0 +1,13 @@
+/*
+ * This is a manifest file that'll be compiled into application.css, which will include all the files
+ * listed below.
+ *
+ * Any CSS and SCSS file within this directory, lib/assets/stylesheets, vendor/assets/stylesheets,
+ * or vendor/assets/stylesheets of plugins, if any, can be referenced here using a relative path.
+ *
+ * You're free to add application-wide styles to this file and they'll appear at the top of the
+ * compiled file, but it's generally better to create a new file per style scope.
+ *
+ *= require_self
+ *= require_tree .
+ */

data/test_app/app/controllers/application_controller.rb

@@ -0,0 +1,5 @@
+class ApplicationController < ActionController::Base
+  # Prevent CSRF attacks by raising an exception.
+  # For APIs, you may want to use :null_session instead.
+  protect_from_forgery with: :exception
+end

data/test_app/app/helpers/application_helper.rb

@@ -0,0 +1,2 @@
+module ApplicationHelper
+end

data/test_app/app/views/layouts/sales_clerk.haml

@@ -0,0 +1,9 @@
+!!!
+%html
+  %head
+    %title TestApp
+    = stylesheet_link_tag    "application", media: "all"
+    = javascript_include_tag "application"
+    = csrf_meta_tags
+  %body
+    = yield

data/test_app/bin/bundle

@@ -0,0 +1,3 @@
+#!/usr/bin/env ruby
+ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../Gemfile', __FILE__)
+load Gem.bin_path('bundler', 'bundle')

data/test_app/bin/rails

@@ -0,0 +1,4 @@
+#!/usr/bin/env ruby
+APP_PATH = File.expand_path('../../config/application',  __FILE__)
+require_relative '../config/boot'
+require 'rails/commands'

data/test_app/bin/rake

@@ -0,0 +1,4 @@
+#!/usr/bin/env ruby
+require_relative '../config/boot'
+require 'rake'
+Rake.application.run

data/test_app/config/application.rb

@@ -0,0 +1,30 @@
+require File.expand_path('../boot', __FILE__)
+
+# Pick the frameworks you want:
+require "active_record/railtie"
+require "action_controller/railtie"
+require "action_mailer/railtie"
+require "sprockets/railtie"
+# require "rails/test_unit/railtie"
+
+# Require the gems listed in Gemfile, including any gems
+# you've limited to :test, :development, or :production.
+Bundler.require(*Rails.groups)
+
+module TestApp
+  class Application < Rails::Application
+    # Settings in config/environments/* take precedence over those specified here.
+    # Application configuration should go into files in config/initializers
+    # -- all .rb files in that directory are automatically loaded.
+
+    # Set Time.zone default to the specified zone and make Active Record auto-convert to this zone.
+    # Run "rake -D time" for a list of tasks for finding time zone names. Default is UTC.
+    # config.time_zone = 'Central Time (US & Canada)'
+
+    # The default locale is :en and all translations from config/locales/*.rb,yml are auto loaded.
+    # config.i18n.load_path += Dir[Rails.root.join('my', 'locales', '*.{rb,yml}').to_s]
+    # config.i18n.default_locale = :de
+
+    config.active_record.raise_in_transactional_callbacks = true
+  end
+end

data/test_app/config/boot.rb

@@ -0,0 +1,4 @@
+# Set up gems listed in the Gemfile.
+ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../../Gemfile', __FILE__)
+
+require 'bundler/setup' if File.exist?(ENV['BUNDLE_GEMFILE'])

data/test_app/config/database.yml

@@ -0,0 +1,25 @@
+# SQLite version 3.x
+#   gem install sqlite3
+#
+#   Ensure the SQLite 3 gem is defined in your Gemfile
+#   gem 'sqlite3'
+development:
+  adapter: sqlite3
+  database: db/development.sqlite3
+  pool: 5
+  timeout: 5000
+
+# Warning: The database defined as "test" will be erased and
+# re-generated from your development database when you run "rake".
+# Do not set this db to the same as development or production.
+test:
+  adapter: sqlite3
+  database: db/test.sqlite3
+  pool: 5
+  timeout: 5000
+
+production:
+  adapter: sqlite3
+  database: db/production.sqlite3
+  pool: 5
+  timeout: 5000

data/test_app/config/environment.rb

@@ -0,0 +1,5 @@
+# Load the Rails application.
+require File.expand_path('../application', __FILE__)
+
+# Initialize the Rails application.
+TestApp::Application.initialize!

data/test_app/config/environments/development.rb

@@ -0,0 +1,32 @@
+TestApp::Application.configure do
+  # Settings specified here will take precedence over those in config/application.rb.
+
+  # In the development environment your application's code is reloaded on
+  # every request. This slows down response time but is perfect for development
+  # since you don't have to restart the web server when you make code changes.
+  config.cache_classes = false
+
+  # Do not eager load code on boot.
+  config.eager_load = false
+
+  # Show full error reports and disable caching.
+  config.consider_all_requests_local       = true
+  config.action_controller.perform_caching = false
+
+  # Don't care if the mailer can't send.
+  config.action_mailer.raise_delivery_errors = false
+
+  # Print deprecation notices to the Rails logger.
+  config.active_support.deprecation = :log
+
+  # Raise an error on page load if there are pending migrations
+  config.active_record.migration_error = :page_load
+
+  # Debug mode disables concatenation and preprocessing of assets.
+  # This option may cause significant delays in view rendering with a large
+  # number of complex assets.
+  config.assets.debug = true
+
+  # Raises error for missing translations
+  # config.action_view.raise_on_missing_translations = true
+end