posix-spawn 0.3.13 → 0.3.14

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 586d0f0f9057e34308bf74b8012308d58554be84
-  data.tar.gz: fc46031fe4302b9c09bac390c758006e06d42a14
+SHA256:
+  metadata.gz: 01e020a90230d321090d2a78ed58f6679b35d11f1a889e1ea4290a6e01ad6ca3
+  data.tar.gz: 60a60a31086a398a9a5c17de2488cf3f4020aadf7f3bbe94a3a558a42404129e
 SHA512:
-  metadata.gz: 41c48ddad2fb6bd679db842a9ab7afb37b0c07963b143e8c3e9537a48216b0b61a7761c2f2214fdfd5f30072c9d0429717aa65cfc2e005e1797a7b2802486391
-  data.tar.gz: f18771b44bff3cf3ce268abb4969ab2a4750df248bcab1ed027fcb84e475b1172aaadfb7051451dda475391cfeabfe8100fd4b1dc818ba82d7e20f9bfcd82188
+  metadata.gz: c1a2c99b5f08c59fb83c53f244e4395336a0aa5ddfc900a4a16ed57f038135ad3384efc6869afd6d4ec06964ecf4f13008db25cd6cb578dff8bfd7bdf5da04ae
+  data.tar.gz: d4ab86a82d93d18de72263d21c3702e7a13eb1b6df27543cc9589429b49ff9046df9018fe6ed08a60ff1ba0ac28e5d1967ad27f4ecb60e4af25830ea89c9ce52

data/.travis.yml

@@ -0,0 +1,9 @@
+sudo: false
+language: ruby
+rvm:
+  - 1.9
+  - 2.0
+  - 2.2
+  - 2.4
+  - 2.6
+  - ruby-head

data/bin/posix-spawn-benchmark

@@ -1,17 +1,117 @@
 #!/usr/bin/env ruby
-# frozen_string_literal: true
-#
-# This file was generated by Bundler.
-#
-# The application 'posix-spawn-benchmark' is installed as part of a gem, and
-# this file is here to facilitate running it.
-#
-
-require "pathname"
-ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile",
-  Pathname.new(__FILE__).realpath)
-
-require "rubygems"
-require "bundler/setup"
-
-load Gem.bin_path("posix-spawn", "posix-spawn-benchmark")
+#/ Usage: posix-spawn-benchmark [-n <count>] [-m <mem-size>]
+#/ Run posix-spawn (Ruby extension) benchmarks and report to standard output.
+#/
+#/ Options:
+#/   -n, --count=NUM         total number of processes to spawn.
+#/   -m, --mem-size=MB       RES size to bloat to before performing benchmarks.
+#/   -g, --graph             benchmark at 10MB itervals up to RES and graph results.
+#/
+#/ Benchmarks run with -n 1000 -m 100 by default.
+require 'optparse'
+require 'posix-spawn'
+require 'benchmark'
+include Benchmark
+
+allocate   = 100 * (1024 ** 2)
+iterations = 1_000
+graphmode  = false
+ARGV.options do |o|
+  o.set_summary_indent('  ')
+  o.on("-n", "--count=num")   { |val| iterations = val.to_i }
+  o.on("-m", "--mem-size=MB") { |val| allocate   = val.to_i * (1024 ** 2) }
+  o.on("-g", "--graph")       { graphmode = true }
+  o.on_tail("-h", "--help")   { exec "grep ^#/ <'#{__FILE__}' |cut -c4-" }
+  o.parse!
+end
+
+if graphmode
+  bloat = []
+  data  = {}
+  chunk = allocate / 10
+  max   = 0
+
+  10.times do
+    puts "allocating #{chunk / (1024 ** 2)}MB (#{(bloat.size+1) * chunk / (1024 ** 2)}MB total)"
+    bloat << ('x' * chunk)
+    # size = bloat.size / (1024 ** 2)
+
+    %w[ fspawn pspawn ].each do |type|
+      print " - benchmarking #{type}... "
+      time = Benchmark.realtime do
+        iterations.times do
+          pid = POSIX::Spawn.send(type, 'true')
+          Process.wait(pid)
+        end
+      end
+      puts "done (#{time})"
+
+      data[type] ||= []
+      data[type] << time
+      max = time if time > max
+    end
+  end
+
+  max = max < 0.5 ? (max * 10).round / 10.0 : max.ceil
+  minmb, maxmb = chunk/(1024**2), allocate/(1024**2)
+  series = %w[ fspawn pspawn ].map{|name| data[name].map{|d| "%.2f" % d }.join(',') }
+
+  chart = {
+    :chs  => '900x200',
+    :cht  => 'bvg', # grouped vertical bar chart
+    :chtt => "posix-spawn-benchmark --graph --count #{iterations} --mem-size #{maxmb} (#{RUBY_PLATFORM})",
+
+    :chf  => 'bg,s,f8f8f8', # background
+    :chbh => 'a,5,25', # 25px between bar groups
+
+    :chd  => "t:#{series.join('|')}", # data
+    :chds => "0,#{max}", # scale
+    :chdl => 'fspawn (fork+exec)|pspawn (posix_spawn)', # legend
+    :chco => '1f77b4,ff7f0e', # colors
+
+    :chxt => 'x,y',
+    :chxr => "1,0,#{max},#{max/5}", # y labels up to max time
+    :chxs => '1N** secs', # y labels are +=' secs'
+    :chxl => "0:|#{minmb.step(maxmb, maxmb/10).map{ |mb| "#{mb} MB"}.join('|')}", # x bucket labels
+  }
+
+  url  = "https://chart.googleapis.com/chart?"
+  url += chart.map do |key, val|
+    "#{key}=#{val.gsub(' ','%20').gsub('(','%28').gsub(')','%29').gsub('+','%2B')}"
+  end.join('&')
+  url += '#.png'
+
+  puts url
+
+  exit!
+end
+
+puts "benchmarking fork/exec vs. posix_spawn over #{iterations} runs" +
+     " at #{allocate / (1024 ** 2)}M res"
+
+# bloat the process
+bloat = 'x' * allocate
+
+# run the benchmarks
+bm 40 do |x|
+  x.report("fspawn (fork/exec):") do
+    iterations.times do
+      pid = POSIX::Spawn.fspawn('true')
+      Process.wait(pid)
+    end
+  end
+  x.report("pspawn (posix_spawn):") do
+    iterations.times do
+      pid = POSIX::Spawn.pspawn('true')
+      Process.wait(pid)
+    end
+  end
+  if Process.respond_to?(:spawn)
+    x.report("spawn (native):") do
+      iterations.times do
+        pid = Process.spawn('true')
+        Process.wait(pid)
+      end
+    end
+  end
+end

data/ext/posix-spawn.c

@@ -61,7 +61,7 @@ posixspawn_obj_to_fd(VALUE obj)
 			 * rb_fix2int takes care of raising if the provided object is a
 			 * Bignum and is out of range of an int
 			 */
-			fd = (int)rb_fix2int(obj);
+			fd = FIX2INT(obj);
 			break;
 
 		case T_SYMBOL:
@@ -283,6 +283,11 @@ each_env_i(VALUE key, VALUE val, VALUE arg)
 		const char *ev = envp[i];
 
 		if (strlen(ev) > name_len && !memcmp(ev, name, name_len) && ev[name_len] == '=') {
+			/* This operates on a duplicated environment -- release the
+			 * existing entry memory before shifting the subsequent entry
+			 * pointers down. */
+			free(envp[i]);
+
 			for (j = i; envp[j]; ++j)
 				envp[j] = envp[j + 1];
 			continue;

data/lib/posix/spawn/version.rb

@@ -1,5 +1,5 @@
 module POSIX
   module Spawn
-    VERSION = '0.3.13'
+    VERSION = '0.3.14'
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: posix-spawn
 version: !ruby/object:Gem::Version
-  version: 0.3.13
+  version: 0.3.14
 platform: ruby
 authors:
 - Ryan Tomayko
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-01-12 00:00:00.000000000 Z
+date: 2020-05-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake-compiler
@@ -52,6 +52,7 @@ extra_rdoc_files:
 - HACKING
 files:
 - ".gitignore"
+- ".travis.yml"
 - COPYING
 - Gemfile
 - HACKING
@@ -91,8 +92,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.5.2
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: posix_spawnp(2) for ruby