positioning 0.4.6 → 0.4.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 88f71996b9993bcc361ea0306aac58481278d85d907a30fb00da09ac69521ea3
-  data.tar.gz: b9e378a4e4a93a20b645138f732dc0031f5cce9210f4ded0122325bc9fde8739
+  metadata.gz: 4b3882c55b3e657ad75fb0cabf586ae890506ba89acc34a198d32c31c2aa8521
+  data.tar.gz: e8a3ffa61736d782745416743cf926daf2170be8beee94189adf9bf962515fd5
 SHA512:
-  metadata.gz: 7bd750e9f02221a4643ecbc590ca46ed133d1ecb2bbfb69162c319997b1e5eb70ceea971f3dd14c7f0e45bb214d56d516a4e2ff160bb8aab916804beba629bfc
-  data.tar.gz: f3e8773fc1984c65662c374066529bbf3bc597e32f4f45f018383ad30d307354ab4c8d85bffee2ca7a5cdabb6d4fac72dda12491228d6cdd6117ec251292fe58
+  metadata.gz: 77acd60a82aef76786848043aeebe7ed58e1f6725592ef21ff0265eed16d1fdc4fd52024988b4e86e7537c990e6f6f1be8c6bb7392250a30dee8901ead8b3179
+  data.tar.gz: ff80e90b8ed3d4d96f24f26c879a0fb4d570d92b22c4159ecc79683e9f56b39df46c0cb524a7a478781905a3e46bdc44012f6cca7d959f9b0d226f69de67d33d

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 ## [Unreleased]
 
+## [0.4.7] - 2025-08-09
+
+- Fix `solidify_position` so that it properly raises an error for an invalid string position.
+
 ## [0.4.6] - 2025-05-01
 
 - Fix healing for positioning with nullable scope (parent in trees, for example). Thanks @pyromaniac!

data/Gemfile

@@ -3,13 +3,13 @@ source "https://rubygems.org"
 # Specify your gem's dependencies in positioning.gemspec
 gemspec
 
-gem "rake", "~> 13.0"
+gem "rake", "~> 13.3"
 
-gem "minitest", "~> 5.0"
-gem "minitest-hooks", "~> 1.5.1"
-gem "mocha", "~> 2.1.0"
+gem "minitest", "~> 6.0"
+gem "minitest-hooks", "~> 1.5.3"
+gem "mocha", "~> 3.0.1"
 
-gem "standard", "~> 1.3"
+gem "standard", "~> 1.52.0"
 
 if ENV["RAILS_VERSION"]
   gem "activerecord", ENV["RAILS_VERSION"]
@@ -18,14 +18,9 @@ end
 
 case ENV["DB"]
 when "sqlite"
-  if ENV["RAILS_VERSION"] &&
-      Gem::Version.new(ENV["RAILS_VERSION"]) >= Gem::Version.new("7.2")
-    gem "sqlite3", "~> 2.2.0"
-  else
-    gem "sqlite3", "~> 1.7.2"
-  end
+  gem "sqlite3", "~> 2.9.0"
 when "postgresql"
-  gem "pg", "~> 1.5.5"
+  gem "pg", "~> 1.6.3"
 else
-  gem "mysql2", "~> 0.5.6"
+  gem "mysql2", "0.5.6"
 end

data/README.md

@@ -1,5 +1,7 @@
 # Positioning
 
+[![Ruby](https://github.com/brendon/positioning/actions/workflows/main.yml/badge.svg)](https://github.com/brendon/positioning/actions/workflows/main.yml)
+
 The aim of this gem is to allow you to easily position Active Record model instances within a scope of your choosing. In an ideal world this gem will give your model instances sequential integer positions beginning with `1`. Attempts are made to make all changes within a transaction so that position integers remain consistent. To this end, directly assigning a position is discouraged, instead you can move items by declaring an item's prior or subsequent item in the list and your item will be moved to be relative to that item.
 
 Positioning supports multiple lists per model with global, simple, and complex scopes.
@@ -267,6 +269,15 @@ item.update list: other_list, position: {after: 11}
 
 It's important to note that in the examples above, `other_item` must already belong to the `other_list` scope.
 
+##### Single Table Inheritance and Abstract Models
+Positioning requires a concrete table to work with and considers all records within that table as being in some scope. Therefore, it currently isn't possible to use `positioned` on abstract subclasses or when using STI. All calls to `position` must be on the base class.
+
+If you must position child models separately, scope their position by the `type` column.
+
+```rb
+positioned on: [:type]
+```
+
 ## Concurrency
 
 The queries that this gem runs (especially those that seek the next position integer available) are vulnerable to race conditions. To this end, we lock the scope records to ensure that our model callbacks that determine and assign positions run sequentially. Previously we used an Advisory Lock for this purpose but this was difficult to test and a bit overkill in most situations. Where a scope doesn't exist, we lock all the records in the table.

data/lib/positioning/mechanisms.rb

@@ -162,9 +162,7 @@ module Positioning
         solidified_position -= 1 if in_positioning_scope? && position_was < solidified_position
 
         self.position = solidified_position
-      end
-
-      unless position.is_a? Integer
+      else
         raise Error.new,
           %(`#{@column}` must be an Integer, :first, :last, ) +
             %{before: (#{base_class.name}, #{primary_key}, nil, or ""), } +
@@ -224,7 +222,7 @@ module Positioning
 
     def destroyed_via_positioning_scope?
       @positioned.destroyed_by_association && scope_columns.any? do |scope_column|
-        @positioned.destroyed_by_association.foreign_key == scope_column
+        Array(@positioned.destroyed_by_association.foreign_key).include?(scope_column)
       end
     end
   end

data/lib/positioning/version.rb

@@ -1,3 +1,3 @@
 module Positioning
-  VERSION = "0.4.6"
+  VERSION = "0.4.8"
 end

data/lib/positioning.rb

@@ -35,7 +35,7 @@ module Positioning
             reflection = reflections[scope_component]
 
             if reflection&.belongs_to?
-              positioning_columns[column][:scope_columns] << reflection.foreign_key
+              positioning_columns[column][:scope_columns].concat Array(reflection.foreign_key)
               positioning_columns[column][:scope_columns] << reflection.foreign_type if reflection.polymorphic?
               positioning_columns[column][:scope_associations] << reflection.name
             else

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: positioning
 version: !ruby/object:Gem::Version
-  version: 0.4.6
+  version: 0.4.8
 platform: ruby
 authors:
 - Brendon Muir
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2025-05-01 00:00:00.000000000 Z
+date: 2026-03-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport