positioning 0.1.5 → 0.1.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1a18c3175781c6d4509ea42db1583e68bb2e7258e9c0b99201b1b551fc50ccd7
-  data.tar.gz: 8ceb46c8c93882d2e82e88f4d9c5bcafb3371830dd6d5169cf23dd76d8ba6cd0
+  metadata.gz: 3287b3ffda224e17c32b5601cc2f14aba284bcac50d7627be46300f1c7473521
+  data.tar.gz: 9027f931d4dc6781241cd80faacf056d320307e94fb0a1ded2e8563bc7d86b59
 SHA512:
-  metadata.gz: 19ced8dddfaefd60c644f19ac576513185e5f3dfa52e8aaabab59f390042f1937bfd3f24874bd228012b337f9f843963b6261b25133d5d1d54f2d606d5c08b7a
-  data.tar.gz: ac66e6a3eeb7ab20d54511640c9c1e1e20090b9cd0d01cf583031944d42e7f517dc603afc9b59b49c35617a437f5ebbdbf406e0b1cc71beff3413fd8cf73d76b
+  metadata.gz: 8f0a3353940e24c88f89835fee413eef989a67e3ef1a984d8cba2611d377be6a68f0743568090cb5a58da2f6c8f2eb17d15cfa2f4880b4f0b209f4ad582b176f
+  data.tar.gz: 975fa2efc49eacb1dc5a96de826ccc9e6db72f8adb82a4d44f72dff57581cd551581c77458c40b06686c90232aebff127006503369cee3faed0ad704160e8c21

data/CHANGELOG.md

@@ -1,5 +1,14 @@
 ## [Unreleased]
 
+## [0.1.7] - 2024-03-06
+
+- Seperated the Concern that is included into ActiveRecord::Base into its own submodule so that Mechanisms isn't also included.
+- Added the RelativePosition Struct and documentation to make it easier to supply relative positions via form helpers.
+
+## [0.1.6] - 2024-03-05
+
+- Allow the position to be passed as a JSON object so that we can pass in complex positions from the browser more easily.
+
 ## [0.1.5] - 2024-03-04
 
 - Allow empty strings to represent nil for the purposes of solidifying a position

data/README.md

@@ -82,11 +82,13 @@ If you don't provide a position when creating a record, your record will be adde
 
 To assign a specific position when creating or updating a record you can simply declare a specific value for the database column tracking the position of records (by default this is `position`). The valid options for this column are:
 
-* A specific integer value. Values are automatically clamped to between `1` and the next available position at the end of the list (inclusive). You should use explicit position values as a last resort, instead you can use:
-* `:first` places the record at the start of the list.
-* `:last` places the record at the end of the list.
-* `nil` also places the record at the end of the list.
-* `before:` and `after:` allow you to define the position relative to other records in the list. You can define the relative record by its primary key (usually `id`) or by providing the record itself. You can also provide `nil` in which case the item will be placed at the start or end of the list (see below).
+* A specific integer value as an `Integer` or a `String`. Values are automatically clamped to between `1` and the next available position at the end of the list (inclusive). You should use explicit position values as a last resort, instead you can use:
+* `:first` or `"first"` places the record at the start of the list.
+* `:last` or `"last"` places the record at the end of the list.
+* `nil` and `""` also places the record at the end of the list.
+* `before:` and `after:` allow you to define the position relative to other records in the list. You can define the relative record by its primary key (usually `id`) or by providing the record itself. You can also provide `nil` or `""` in which case the item will be placed at the start or end of the list (see below).
+
+**You can provide the position value as a JSON string and it will be decoded first. This could be useful if you have no other way to provide `before:` or `after:` as a hash (e.g. `"{\"after\":33}"`). See below for a technique to provide `before:` and `after:` using form helpers.**
 
 Position parameters can be strings or symbols, so you can provide them from the browser.
 
@@ -149,6 +151,42 @@ other_item.id # => 11
 item.update position: {after: 11}
 ```
 
+##### Relative Positining in Forms
+
+It can be tricky to provide the hash forms of relative positining using Rails form helpers, but it is possible. We've declared a special `Struct` for you to use for this purpose.
+
+Firstly you need to allow nested Strong Parameters for the `position` column like so:
+
+```ruby
+def item_params
+  params.require(:item).permit :name, position: [:before]
+end
+```
+
+In the example above we're always declaring what item (by its `id`) we want to position our item **before**. You could change this to `:after` if you'd rather.
+
+Next, in your `new` method you may wish to intialise the `position` column with a value supplied by incoming parameters:
+
+```ruby
+def new
+  item.position = { before: params[:before] }
+end
+```
+
+You can now just pass the `before` parameter (the `id` of the item you want to add this record before) via the URL to the `new` action. For example: `items/new?before=22`.
+
+In the form itself, so that your intended position survives a failed `create` attempt and form redisplay you can declare the `position` value like so:
+
+```erb
+  <% if item.new_record? %>
+    <%= form.fields :position, model: Positioning::RelativePosition.new(item.position_before_type_cast) do |fields| %>
+      <%= fields.hidden_field :before %>
+    <% end %>
+  <% end %>
+```
+
+The key part here is `Positioning::RelativePosition.new(item.position_before_type_cast)`. `Positioning::RelativePosition` is a `Struct` that can take `before` and `after` as parameters. You should only provide one or the other. Because `position` is an `Integer` column, the hash structure is obliterated when it is assigned but we can still access it with `position_before_type_cast`. Remember to adjust the method if your position column has a different name (e.g. `category_position_before_type_cast`). The `Struct` provides the correct methods for `fields` to display the nested value.
+
 #### Destroying
 
 When a record is destroyed, the positions of relative items in the scope will be shuffled to close the gap left by the destroyed record. If we detect that records are being destroyed via a scope dependency (e.g. `has_many :items, dependent: :destroy`) then we skip closing the gaps because all records in the scope will eventually be destroyed anyway.

data/lib/positioning/mechanisms.rb

@@ -96,9 +96,20 @@ module Positioning
     end
 
     def solidify_position
-      position_before_type_cast = @positioned.read_attribute_before_type_cast @column
-      position_before_type_cast.to_sym if position_before_type_cast.is_a? String
-      position_before_type_cast = position_before_type_cast.symbolize_keys if position_before_type_cast.is_a? Hash
+      position_before_type_cast = @positioned.read_attribute_before_type_cast(@column)
+
+      if position_before_type_cast.is_a? String
+        begin
+          position_before_type_cast = JSON.parse(position_before_type_cast, symbolize_names: true)
+        rescue JSON::ParserError
+        end
+
+        if position_before_type_cast.is_a?(String) && position_before_type_cast.present?
+          position_before_type_cast = position_before_type_cast.to_sym
+        end
+      elsif position_before_type_cast.is_a? Hash
+        position_before_type_cast = position_before_type_cast.symbolize_keys
+      end
 
       case position_before_type_cast
       when Integer

data/lib/positioning/version.rb

@@ -1,3 +1,3 @@
 module Positioning
-  VERSION = "0.1.5"
+  VERSION = "0.1.7"
 end

data/lib/positioning.rb

@@ -7,46 +7,50 @@ require "active_support/lazy_load_hooks"
 module Positioning
   class Error < StandardError; end
 
-  extend ActiveSupport::Concern
+  RelativePosition = Struct.new(:before, :after, keyword_init: true)
 
-  class_methods do
-    def positioning_columns
-      @positioning_columns ||= {}
-    end
+  module Behaviour
+    extend ActiveSupport::Concern
 
-    def positioned(on: [], column: :position)
-      unless base_class?
-        raise Error.new "can't be called on an abstract class or STI subclass."
+    class_methods do
+      def positioning_columns
+        @positioning_columns ||= {}
       end
 
-      column = column.to_sym
+      def positioned(on: [], column: :position)
+        unless base_class?
+          raise Error.new "can't be called on an abstract class or STI subclass."
+        end
 
-      if positioning_columns.key? column
-        raise Error.new "The column `#{column}` has already been used by the scope `#{positioning_columns[column]}`."
-      else
-        positioning_columns[column] = Array.wrap(on).map do |scope_component|
-          scope_component = scope_component.to_s
-          reflection = reflections[scope_component]
+        column = column.to_sym
 
-          (reflection && reflection.belongs_to?) ? reflection.foreign_key : scope_component
-        end
+        if positioning_columns.key? column
+          raise Error.new "The column `#{column}` has already been used by the scope `#{positioning_columns[column]}`."
+        else
+          positioning_columns[column] = Array.wrap(on).map do |scope_component|
+            scope_component = scope_component.to_s
+            reflection = reflections[scope_component]
 
-        define_method(:"prior_#{column}") { Mechanisms.new(self, column).prior }
-        define_method(:"subsequent_#{column}") { Mechanisms.new(self, column).subsequent }
+            (reflection && reflection.belongs_to?) ? reflection.foreign_key : scope_component
+          end
 
-        redefine_method(:"#{column}=") do |position|
-          send :"#{column}_will_change!"
-          super(position)
-        end
+          define_method(:"prior_#{column}") { Mechanisms.new(self, column).prior }
+          define_method(:"subsequent_#{column}") { Mechanisms.new(self, column).subsequent }
+
+          redefine_method(:"#{column}=") do |position|
+            send :"#{column}_will_change!"
+            super(position)
+          end
 
-        before_create { Mechanisms.new(self, column).create_position }
-        before_update { Mechanisms.new(self, column).update_position }
-        after_destroy { Mechanisms.new(self, column).destroy_position }
+          before_create { Mechanisms.new(self, column).create_position }
+          before_update { Mechanisms.new(self, column).update_position }
+          after_destroy { Mechanisms.new(self, column).destroy_position }
+        end
       end
     end
   end
 end
 
 ActiveSupport.on_load :active_record do
-  ActiveRecord::Base.send :include, Positioning
+  ActiveRecord::Base.send :include, Positioning::Behaviour
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: positioning
 version: !ruby/object:Gem::Version
-  version: 0.1.5
+  version: 0.1.7
 platform: ruby
 authors:
 - Brendon Muir
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-03-04 00:00:00.000000000 Z
+date: 2024-03-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport