positionable 1.0.3 → 1.0.4

data/lib/positionable.rb

@@ -244,7 +244,8 @@ module Positionable
 
       # All the records that belong to same scope (if any) of this record (including itself).
       def scoped_all
-        self.class.where(scoped_condition)
+        # The range is shared among all subclasses of the base class, which directly extends ActiveRecord::Base
+        self.class.base_class.where(scoped_condition)
       end
 
       # Reorders records between provided positions, unless the destination position is out of range.

data/lib/positionable/version.rb

@@ -1,3 +1,3 @@
 module Positionable
-  VERSION = "1.0.3"
+  VERSION = "1.0.4"
 end

data/spec/factories.rb

@@ -19,6 +19,14 @@ FactoryGirl.define do
   	sequence(:title) { |n| "Default Item #{n}" }
   end
 
+  factory :sub_item_1 do
+    sequence(:title) { |n| "Sub-Item-1 #{n}" }
+  end
+
+  factory :sub_item_2 do
+    sequence(:title) { |n| "Sub-Item-2 #{n}" }
+  end
+
   factory :starting_at_one_item do
     sequence(:title) { |n| "Starting At One Item #{n}" }
   end

data/spec/lib/positionable_spec.rb

@@ -15,12 +15,14 @@ describe Positionable do
       dummy = Dummy.new
       dummy.respond_to?(:previous).should be_false
       dummy.respond_to?(:next).should be_false
+      dummy.respond_to?(:position=).should be_false
     end
 
     it "extends positionable models" do
       item = DefaultItem.new
       item.respond_to?(:previous).should be_true
       item.respond_to?(:next).should be_true
+      item.respond_to?(:position=).should be_true
     end
 
     it "prepends the table name in SQL 'order by' clause" do
@@ -29,6 +31,17 @@ describe Positionable do
       sql.should include("ORDER BY \"#{table}\".\"position\"")
     end
 
+    context "inheritance" do
+
+      it "extends positionable sub-models" do
+        item = SubItem1.new
+        item.respond_to?(:previous).should be_true
+        item.respond_to?(:next).should be_true
+        item.respond_to?(:position=).should be_true
+      end
+
+    end
+
   end
 
   context "ordering" do
@@ -151,6 +164,16 @@ describe Positionable do
       neXt.reload.position.should == position
     end
 
+    context "inheritance" do
+
+      it "inserts contiguously records of all subclasses" do
+        Factory.create(:sub_item_1).position.should == items.count
+        Factory.create(:sub_item_2).position.should == items.count + 1
+        Factory.create(:sub_item_1).position.should == items.count + 2
+      end
+
+    end
+
     describe "moving" do
 
       context "mass-assignement" do

data/spec/support/models.rb

@@ -15,6 +15,12 @@ class DefaultItem < Item
   is_positionable
 end
 
+class SubItem1 < DefaultItem
+end
+
+class SubItem2 < DefaultItem
+end
+
 class StartingAtOneItem < Item
   is_positionable :start => 1
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: positionable
 version: !ruby/object:Gem::Version
-  version: 1.0.3
+  version: 1.0.4
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-03-06 00:00:00.000000000 Z
+date: 2012-03-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
-  requirement: &70099336314860 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,15 @@ dependencies:
         version: 1.0.0
   type: :development
   prerelease: false
-  version_requirements: *70099336314860
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: 1.0.0
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70099336314240 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -32,10 +37,15 @@ dependencies:
         version: '2.3'
   type: :development
   prerelease: false
-  version_requirements: *70099336314240
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '2.3'
 - !ruby/object:Gem::Dependency
   name: sqlite3-ruby
-  requirement: &70099336313540 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +53,15 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70099336313540
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: simplecov
-  requirement: &70099336312400 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,10 +69,15 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70099336312400
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: factory_girl
-  requirement: &70099336311600 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -65,10 +85,15 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70099336311600
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: activerecord
-  requirement: &70099336310240 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -76,7 +101,12 @@ dependencies:
         version: '3.1'
   type: :runtime
   prerelease: false
-  version_requirements: *70099336310240
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '3.1'
 description: This extension provides contiguous positionning capabilities to you ActiveRecord
   models.
 email:
@@ -120,7 +150,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: positionable
-rubygems_version: 1.8.17
+rubygems_version: 1.8.18
 signing_key: 
 specification_version: 3
 summary: A gem for positionning your ActiveRecord models.