positionable 1.0.2 → 1.0.3

data/lib/positionable.rb

@@ -91,9 +91,9 @@ module Positionable
             count = self.class.where("#{scope_id_attr} = ?", target_scope_id).count
             # An additional position is available if this record is new, or if it's moved to another scope
             if new_record? or target_scope_id != scope_id
-              (start..(count + 1))
+              (start..(start + count))
             else
-              (start..count)
+              (start..(start + count - 1))
             end
           end
 

data/lib/positionable/version.rb

@@ -1,3 +1,3 @@
 module Positionable
-  VERSION = "1.0.2"
+  VERSION = "1.0.3"
 end

data/positionable.gemspec

@@ -24,5 +24,5 @@ Gem::Specification.new do |s|
   s.add_development_dependency "simplecov"
   s.add_development_dependency "factory_girl"
 
-  s.add_dependency "activerecord", "~> 3.1"
+  s.add_runtime_dependency "activerecord", "~> 3.1"
 end

data/spec/lib/positionable_spec.rb

@@ -451,20 +451,28 @@ describe Positionable do
         it "gives the range within a scope" do
           folder = Factory.create(:folder_with_documents)
           document = Document.new
-          document.range(folder).should == (0..(folder.documents.count + 1))
+          document.range(folder).should == (0..folder.documents.count)
         end
 
         it "gives the range within its own scope by default" do
-          document = Factory.build(:document)
-          folder = document.folder
-          document.range.should == (0..(folder.documents.count + 1))
+          folder = Factory.create(:folder_with_documents)
+          document = folder.documents.sample
+          document.range.should == (0..(folder.documents.count - 1))
         end
 
         it "gives the range within another scope" do
           document = Factory.build(:document)
           folder = Factory.create(:folder_with_documents)
           document.folder.should_not == folder # Meta!
-          document.range(folder).should == (0..(folder.documents.count + 1))
+          document.range(folder).should == (0..folder.documents.count)
+        end
+
+        it "gives the range within another empty scope" do
+          document = Factory.build(:document)
+          folder = Factory.create(:folder)
+          document.folder.should_not == folder # Meta!
+          folder.documents.should be_empty # Meta!
+          document.range(folder).should == (0..0)
         end
 
       end
@@ -474,14 +482,14 @@ describe Positionable do
         it "gives the range within its own scope" do
           folder = Factory.create(:folder_with_documents)
           document = folder.documents.sample
-          document.range(folder).should == (0..folder.documents.count)
+          document.range(folder).should == (0..(folder.documents.count - 1))
         end
 
         it "gives the range within another scope" do
           document = Factory.create(:document)
           folder = Factory.create(:folder_with_documents)
           document.folder.should_not == folder # Meta!
-          document.range(folder).should == (0..(folder.documents.count + 1))
+          document.range(folder).should == (0..folder.documents.count)
         end
 
       end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: positionable
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.0.3
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-02-16 00:00:00.000000000 Z
+date: 2012-03-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
-  requirement: &70142130433320 !ruby/object:Gem::Requirement
+  requirement: &70099336314860 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: 1.0.0
   type: :development
   prerelease: false
-  version_requirements: *70142130433320
+  version_requirements: *70099336314860
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &70142130421500 !ruby/object:Gem::Requirement
+  requirement: &70099336314240 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -32,10 +32,10 @@ dependencies:
         version: '2.3'
   type: :development
   prerelease: false
-  version_requirements: *70142130421500
+  version_requirements: *70099336314240
 - !ruby/object:Gem::Dependency
   name: sqlite3-ruby
-  requirement: &70142130410640 !ruby/object:Gem::Requirement
+  requirement: &70099336313540 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +43,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70142130410640
+  version_requirements: *70099336313540
 - !ruby/object:Gem::Dependency
   name: simplecov
-  requirement: &70142130403860 !ruby/object:Gem::Requirement
+  requirement: &70099336312400 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,10 +54,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70142130403860
+  version_requirements: *70099336312400
 - !ruby/object:Gem::Dependency
   name: factory_girl
-  requirement: &70142126204520 !ruby/object:Gem::Requirement
+  requirement: &70099336311600 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -65,10 +65,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70142126204520
+  version_requirements: *70099336311600
 - !ruby/object:Gem::Dependency
   name: activerecord
-  requirement: &70142121886120 !ruby/object:Gem::Requirement
+  requirement: &70099336310240 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -76,7 +76,7 @@ dependencies:
         version: '3.1'
   type: :runtime
   prerelease: false
-  version_requirements: *70142121886120
+  version_requirements: *70099336310240
 description: This extension provides contiguous positionning capabilities to you ActiveRecord
   models.
 email:
@@ -120,7 +120,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: positionable
-rubygems_version: 1.8.16
+rubygems_version: 1.8.17
 signing_key: 
 specification_version: 3
 summary: A gem for positionning your ActiveRecord models.
@@ -131,4 +131,3 @@ test_files:
 - spec/support/matchers/contiguity_matcher.rb
 - spec/support/models.rb
 - spec/support/schema.rb
-has_rdoc: