portrayal 0.2.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: eeb24e8ffff128d18963b1b9b35b542b260a2ec3b0e298064201c108a58c0c6c
-  data.tar.gz: 36adc49da54f8a4756d08dd0f33fbff9b6b5366115082682ff9b9fd46bd26687
+  metadata.gz: 577a51dc874a79a5cb7aece4157c2d802005f3fa9c3daba4b807db522c7cd7ae
+  data.tar.gz: b30f1ea6a9438ba5b4574a68935602fce1dd0a447d15dce4227d0a67a10b2e87
 SHA512:
-  metadata.gz: 992c3b99a75e3b0226d55cc6429072be5abac8248aab9e43903352a2aeb50b0ad29acdb3dd28993ae7ddabc46b3784440d5048afef958d1ffdae1bc9e6f4738c
-  data.tar.gz: 4bc0a1cec3d59ae6db9e22e60504accc420e036ab197313e1c0b9f71219e3aae341acf82de1faa2f88984e6af79d19f1c4f825ad1fc5594b12db3497dcdc168c
+  metadata.gz: a02d197cb3c56e88afcda74a58d5d7034ef4739de707380c05b7a1a76c95e8ae1c8aa9341fde97d8efa69e6b5fcc00df429b2ada5e1b18f5dc9c2c51cc73504a
+  data.tar.gz: 4c6f5e4d359551e7420dd4331192f857f8a4518ab679b8052f36c6854a34a100a97bd4af98358589dcd08144cff9ddda071f6b2bd4602dc7495d2fc8467c6994

data/.github/workflows/rspec.yml

@@ -0,0 +1,24 @@
+name: RSpec
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ master ]
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby: [ '2.4', '2.5', '2.6', '2.7' ]
+
+    name: Ruby ${{ matrix.ruby }}
+    steps:
+      - uses: actions/checkout@v2
+      - uses: actions/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+      - run: gem install bundler
+      - run: bundle install
+      - run: bundle exec rake

data/CHANGELOG.md

@@ -1,11 +1,23 @@
 This project follows [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## [0.2.0] - 2019-07-03
+## Unreleased
 
-### Changed
+## 0.3.1 - 2020-05-11
 
-* It's now possible to specify non-lambda default values, like `default: "foo". There is now also a distinction between a proc and a lambda default. Procs are `call`-ed, while lambdas or any other types are returned as-is. In the majority of cases defaults are static values, and there is no need for the performance overhead of making all defaults into anonymous functions.
+* Fix the issue introduced in 0.3.0 where `==` and `eql?` were always treating rhs as another portrayal class.
 
-## [0.1.0]
+## 0.3.0 - 2020-05-09
+
+* No longer compare classes in `==`, use `eql?` for that. [[commit]](https://github.com/scottscheapflights/portrayal/commit/9c5a37e4fb91e35d23b22e208344452930452af7)
+* Define a protected writer for every keyword - useful when applying changes after `dup`/`clone`. [[commit]](https://github.com/scottscheapflights/portrayal/commit/1c0fa6c6357a09760dae39165e864238d231a08e)
+* Add definition of `#hash` to fix hash equality. Now `hash[object]` will match if `object` is of the same class with the same keywords and values. [[commit]](https://github.com/scottscheapflights/portrayal/commit/ba9e390ab4aea4733ba084ac273da448e313ea53)
+* Make `#freeze` propagate to all keyword values. [[commit]](https://github.com/scottscheapflights/portrayal/commit/0a734411a6eac08e2355c4277e09a2a70800d032)
+* Make `#dup` and `#clone` propagate to all keyword values. [[commit]](https://github.com/scottscheapflights/portrayal/commit/010632d87d81a8d5b5ea5ff27d3d209cc667b0a5)
+
+## 0.2.0 - 2019-07-03
+
+* It's now possible to specify non-lambda default values, like `default: "foo"`. There is now also a distinction between a proc and a lambda default. Procs are `call`-ed, while lambdas or any other types are returned as-is. In the majority of cases defaults are static values, and there is no need for the performance overhead of making all defaults into anonymous functions. [[commit]](https://github.com/scottscheapflights/portrayal/commit/a1cc9d0fd40e413210f61b945d37b81c87280fee)
+
+## 0.1.0
 
 First version.

data/Gemfile.lock

@@ -1,41 +1,41 @@
 PATH
   remote: .
   specs:
-    portrayal (0.2.0)
+    portrayal (0.3.1)
 
 GEM
   remote: https://rubygems.org/
   specs:
     coderay (1.1.2)
     diff-lcs (1.3)
-    method_source (0.9.2)
-    pry (0.12.2)
-      coderay (~> 1.1.0)
-      method_source (~> 0.9.0)
-    rake (10.5.0)
-    rspec (3.8.0)
-      rspec-core (~> 3.8.0)
-      rspec-expectations (~> 3.8.0)
-      rspec-mocks (~> 3.8.0)
-    rspec-core (3.8.0)
-      rspec-support (~> 3.8.0)
-    rspec-expectations (3.8.3)
+    method_source (1.0.0)
+    pry (0.13.1)
+      coderay (~> 1.1)
+      method_source (~> 1.0)
+    rake (13.0.1)
+    rspec (3.9.0)
+      rspec-core (~> 3.9.0)
+      rspec-expectations (~> 3.9.0)
+      rspec-mocks (~> 3.9.0)
+    rspec-core (3.9.2)
+      rspec-support (~> 3.9.3)
+    rspec-expectations (3.9.2)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.8.0)
-    rspec-mocks (3.8.0)
+      rspec-support (~> 3.9.0)
+    rspec-mocks (3.9.1)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.8.0)
-    rspec-support (3.8.0)
+      rspec-support (~> 3.9.0)
+    rspec-support (3.9.3)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
-  bundler (~> 2.0)
+  bundler (~> 2.1)
   portrayal!
-  pry (~> 0.12)
-  rake (~> 10.0)
-  rspec (~> 3.0)
+  pry (~> 0.13)
+  rake (~> 13.0)
+  rspec (~> 3.9)
 
 BUNDLED WITH
-   2.0.1
+   2.1.4

data/README.md

@@ -1,3 +1,5 @@
+![RSpec](https://github.com/scottscheapflights/portrayal/workflows/RSpec/badge.svg?branch=master)
+
 # Portrayal
 
 Inspired by:
@@ -6,7 +8,7 @@ Inspired by:
   - Piotr Solnica's [virtus](https://github.com/solnic/virtus)
   - Everything [Michel Martens](https://github.com/soveran)
 
-Portrayal is a minimalist gem (~120 loc, no dependencies) for building struct-like classes. It provides a small yet powerful step up from plain ruby with its one and only `keyword` method.
+Portrayal is a minimalist gem (~115 loc, no dependencies) for building struct-like classes. It provides a small yet powerful step up from plain ruby with its one and only `keyword` method.
 
 ```ruby
 class Person < MySuperClass
@@ -30,8 +32,12 @@ end
 When you call `keyword`:
 
 * It defines an `attr_reader`
+* It defines a protected `attr_writer`
 * It defines `initialize`
 * It defines `==` and `eql?`
+* It defines `#hash` for hash equality
+* It defines `#dup` and `#clone` that propagate to all keyword values
+* It defines `#freeze` that propagates to all keyword values
 * It creates a nested class when you supply a block
 * It inherits parent's superclass when creating a nested class
 
@@ -39,7 +45,8 @@ The code above produces almost exactly the following ruby. There's a lot of boil
 
 ```ruby
 class Person < MySuperClass
-  attr_reader :name, :age, :favorite_fruit, :address
+  attr_accessor :name, :age, :favorite_fruit, :address
+  protected :name=, :age=, :favorite_fruit=, :address=
 
   def initialize(name:, age: nil, favorite_fruit: 'feijoa', address:)
     @name = name
@@ -48,16 +55,46 @@ class Person < MySuperClass
     @address = address
   end
 
+  def eql?(other)
+    self.class == other.class && self == other
+  end
+
   def ==(other)
-    self.class == other.class &&
-      { name: name, age: age, favorite_fruit: favorite_fruit, address: address } ==
+    { name: name, age: age, favorite_fruit: favorite_fruit, address: address } ==
       { name: other.name, age: other.age, favorite_fruit: other.favorite_fruit, address: other.address }
   end
 
-  alias eql? ==
+  def hash
+    [ self.class, { name: name, age: age, favorite_fruit: favorite_fruit, address: address } ].hash
+  end
+
+  def freeze
+    name.freeze
+    age.freeze
+    favorite_fruit.freeze
+    address.freeze
+    super
+  end
+
+  def initialize_dup(source)
+    @name = source.name.dup
+    @age = source.age.dup
+    @favorite_fruit = source.favorite_fruit.dup
+    @address = source.address.dup
+    super
+  end
+
+  def initialize_clone(source)
+    @name = source.name.clone
+    @age = source.age.clone
+    @favorite_fruit = source.favorite_fruit.clone
+    @address = source.address.clone
+    super
+  end
 
   class Address < MySuperClass
-    attr_reader :street, :city
+    attr_accessor :street, :city
+    protected :street=, :city=
 
     def initialize(street:, city:)
       @street = street
@@ -68,12 +105,35 @@ class Person < MySuperClass
       "#{street}, #{city}"
     end
 
+    def eql?(other)
+      self.class == other.class && self == other
+    end
+
     def ==(other)
-      self.class == other.class &&
-        { street: street, city: city } == { street: other.street, city: other.city }
+      { street: street, city: city } == { street: other.street, city: other.city }
     end
 
-    alias eql? ==
+    def hash
+      [ self.class, { street: street, city: city } ].hash
+    end
+
+    def freeze
+      street.freeze
+      city.freeze
+      super
+    end
+
+    def initialize_dup(source)
+      @street = source.street.dup
+      @city = source.city.dup
+      super
+    end
+
+    def initialize_clone(source)
+      @street = source.street.clone
+      @city = source.city.clone
+      super
+    end
   end
 end
 ```

data/lib/portrayal/schema.rb

@@ -7,30 +7,20 @@ module Portrayal
       @equality_defined = false
     end
 
-    def [](name)
-      @schema[name]
-    end
-
-    def keywords
-      @schema.keys
-    end
+    def keywords; @schema.keys end
+    def [](name); @schema[name] end
 
     def attributes(object)
-      Hash[
-        object.class.portrayal.keywords.map { |key| [key, object.send(key)] }
-      ]
+      Hash[object.class.portrayal.keywords.map { |k| [k, object.send(k)] }]
     end
 
     def add_keyword(name, optional, default)
       optional, default =
-        if optional == NULL && default == NULL
-          [false, nil]
-        elsif optional != NULL && default == NULL
-          [optional, optional ? [:return, nil] : nil]
-        elsif optional == NULL && default != NULL
-          [true, [default_strategy(default), default]]
-        else
-          [optional, optional ? [default_strategy(default), default] : nil]
+        case [optional == NULL, default == NULL]
+        when [true,  true];  [false, nil]
+        when [false, true];  [optional, optional ? [:return, nil] : nil]
+        when [true,  false]; [true, [default_strategy(default), default]]
+        else; [optional, optional ? [default_strategy(default), default] : nil]
         end
 
       @schema[name.to_sym] = { optional: optional, default: default }
@@ -50,44 +40,46 @@ module Portrayal
     end
 
     def definition_of_initialize
-      init_args =
-        @schema
-        .map { |name, config|
-          if config[:optional]
-            "#{name}: self.class.portrayal.get_default(:#{name})"
-          else
-            "#{name}:"
-          end
-        }
-        .join(',')
-
-      init_assignments =
-        @schema
-        .keys
-        .map { |name| "@#{name} = #{name}" }
-        .join('; ')
-
-      "def initialize(#{init_args}); #{init_assignments} end"
+      init_args = @schema.map { |name, config|
+        config[:optional] ?
+          "#{name}: self.class.portrayal.get_default(:#{name})" : "#{name}:"
+      }.join(',')
+
+      init_assigns = @schema.keys.map { |name| "@#{name} = #{name}" }.join('; ')
+      "def initialize(#{init_args}); #{init_assigns} end"
     end
 
-    def definition_of_equality
+    def definition_of_object_enhancements
       <<-RUBY
+      def eql?(other); self.class == other.class && self == other end
+      def hash; [self.class, self.class.portrayal.attributes(self)].hash end
+
       def ==(other)
-        self.class == other.class &&
-          self.class.portrayal.attributes(self) ==
+        return super unless other.class.is_a?(Portrayal)
+
+        self.class.portrayal.attributes(self) ==
           self.class.portrayal.attributes(other)
       end
 
-      alias eql? ==
-      RUBY
-    end
+      def freeze
+        self.class.portrayal.attributes(self).values.each(&:freeze)
+        super
+      end
 
-    def equality_defined?
-      @equality_defined
-    end
+      def initialize_dup(source)
+        self.class.portrayal.attributes(source).each do |key, value|
+          instance_variable_set('@' + key.to_s, value.dup)
+        end
+        super
+      end
 
-    def mark_equality_defined
-      @equality_defined = true
+      def initialize_clone(source)
+        self.class.portrayal.attributes(source).each do |key, value|
+          instance_variable_set('@' + key.to_s, value.clone)
+        end
+        super
+      end
+      RUBY
     end
   end
 end

data/lib/portrayal/version.rb

@@ -1,3 +1,3 @@
 module Portrayal
-  VERSION = "0.2.0"
+  VERSION = "0.3.1"
 end

data/lib/portrayal.rb

@@ -8,18 +8,15 @@ module Portrayal
     unless respond_to?(:portrayal)
       class << self; attr_reader :portrayal end
       @portrayal = Schema.new
+      class_eval(portrayal.definition_of_object_enhancements)
     end
 
-    attr_reader name
+    attr_accessor name
+    protected "#{name}="
 
     portrayal.add_keyword(name, optional, default)
     class_eval(portrayal.definition_of_initialize)
 
-    unless portrayal.equality_defined?
-      class_eval(portrayal.definition_of_equality)
-      portrayal.mark_equality_defined
-    end
-
     if block_given?
       keyword_class = Class.new(superclass) { extend Portrayal }
       keyword_class.class_eval(&block)

data/portrayal.gemspec

@@ -9,7 +9,7 @@ Gem::Specification.new do |spec|
   spec.email   = ['madfancier@gmail.com']
 
   spec.summary     = 'A minimal builder for struct-like classes'
-  spec.description = 'Inspired by dry-initializer and virtus, portrayal is a minimalist gem (~120 loc, no dependencies) that takes a somewhat different approach to building struct-like classes. It steps away from types, coersion, and writer methods in favor of encouraging well-designed constructors. Read more in the Philosophy section of the README.'
+  spec.description = 'Inspired by dry-initializer and virtus, portrayal is a minimalist gem that takes a somewhat different approach to building struct-like classes. It steps away from types, coersion, and writer methods in favor of encouraging well-designed constructors. Read more in the Philosophy section of the README.'
   spec.homepage    = 'https://github.com/scottscheapflights/portrayal'
   spec.license     = 'Apache-2.0'
 
@@ -18,8 +18,8 @@ Gem::Specification.new do |spec|
   end
   spec.require_paths = ['lib']
 
-  spec.add_development_dependency 'bundler', '~> 2.0'
-  spec.add_development_dependency 'rake', '~> 10.0'
-  spec.add_development_dependency 'rspec', '~> 3.0'
-  spec.add_development_dependency 'pry', '~> 0.12'
+  spec.add_development_dependency 'bundler', '~> 2.1'
+  spec.add_development_dependency 'rake', '~> 13.0'
+  spec.add_development_dependency 'rspec', '~> 3.9'
+  spec.add_development_dependency 'pry', '~> 0.13'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: portrayal
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.1
 platform: ruby
 authors:
 - Maxim Chernyak
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-07-03 00:00:00.000000000 Z
+date: 2020-05-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -16,70 +16,69 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '2.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '2.1'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '13.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '13.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '3.9'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '3.9'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.12'
+        version: '0.13'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.12'
+        version: '0.13'
 description: Inspired by dry-initializer and virtus, portrayal is a minimalist gem
-  (~120 loc, no dependencies) that takes a somewhat different approach to building
-  struct-like classes. It steps away from types, coersion, and writer methods in favor
-  of encouraging well-designed constructors. Read more in the Philosophy section of
-  the README.
+  that takes a somewhat different approach to building struct-like classes. It steps
+  away from types, coersion, and writer methods in favor of encouraging well-designed
+  constructors. Read more in the Philosophy section of the README.
 email:
 - madfancier@gmail.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/rspec.yml"
 - ".gitignore"
 - ".rspec"
-- ".travis.yml"
 - CHANGELOG.md
 - CODE_OF_CONDUCT.md
 - Gemfile
@@ -112,7 +111,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: A minimal builder for struct-like classes

data/.travis.yml

@@ -1,10 +0,0 @@
----
-sudo: false
-language: ruby
-cache: bundler
-rvm:
-  - 2.3
-  - 2.4
-  - 2.5
-  - 2.6
-before_install: gem install bundler -v 2.0.1