poro_validator 0.2.2 → 0.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7ab2a0ee9dbb6cacf404dd00408207233968b22c
-  data.tar.gz: 5c43eeef7b7be9250b85f3c632648ff9f6cf8ffb
+  metadata.gz: bc2ce1f9233a5b88631a5e1f5ecb5335ac2f4a5d
+  data.tar.gz: a57b11e741fbd0a9fa098b7f3f1836641591a1ad
 SHA512:
-  metadata.gz: d7bd91417be08c22f3a2bedecd8d932ada2e23f3dc6f5b9890a16fbaf2c81ee2cd9d252bece9b0aa4381aa941f70beb4a74d4220c8982cb35a5e4ae56fa24f4c
-  data.tar.gz: b3967f199b60e1778c94fb5e481532858ce451457d7afe4067dae966df0d645c60ea28b6c4e5f1a71afc4ee0cb498103d911d04d2410f086eba10009c3b5a95a
+  metadata.gz: 653ecf3ec4b6cb90db58f483894aab76c8632f34cc5a15bacdf266817ccedf52923288b318d5155b025d9f140c1b7cccfd169ea55ef927b8a7a668161458e4f2
+  data.tar.gz: 341ec4635211d5d825a5253d2172997d1d97fe6be5195a827c9f0d3a12916434dca46a72bd4cce1cd20e1f8f04ca04e92ad553b2385b2247b545aedcf4013e12

data/lib/poro_validator/errors.rb

@@ -40,7 +40,7 @@ module PoroValidator
     end
 
     def clear_errors
-      store.reset
+      self.store.reset
     end
 
     alias_method :[], :on

data/lib/poro_validator/validator.rb

@@ -63,7 +63,7 @@ module PoroValidator
     end
 
     def errors
-      @errors ||= ::PoroValidator::Errors.new
+      @errors
     end
 
     def valid?(entity)
@@ -78,8 +78,8 @@ module PoroValidator
     private
 
     def validate_entity(entity)
-      errors.clear_errors
-      context = Context.new(entity, self, errors)
+      @errors = PoroValidator::Errors.new
+      context = Context.new(entity, self, @errors)
       self.class.validations.run_validations(context)
     end
   end

data/lib/poro_validator/version.rb

@@ -1,3 +1,3 @@
 module PoroValidator
-  VERSION = "0.2.2"
+  VERSION = "0.2.3"
 end

data/poro_validator.gemspec

@@ -72,6 +72,7 @@ Gem::Specification.new do |spec|
     spec/features/configurable_error_messages_spec.rb
     spec/features/inheritable_spec.rb
     spec/features/nested_validations_spec.rb
+    spec/features/reuse_validator_spec.rb
     spec/features/validate_hash_object_spec.rb
     spec/lib/poro_validator/configuration_spec.rb
     spec/lib/poro_validator/error_store_spec.rb

data/spec/features/reuse_validator_spec.rb

@@ -0,0 +1,53 @@
+require 'spec_helper'
+
+RSpec.describe "Allows initialized validations to be reused", type: :feature do
+  it "allows reuse of the validation class" do
+    widget = Struct.new(:name, :size)
+    validator = Class.new do
+      include PoroValidator.validator
+
+      validates :name, inclusion: 'c'..'d'
+      validates :size, numeric: 2..3
+    end
+
+    widgets = ('a'..'d').map.with_index(1) do |n, s|
+      widget.new(n, s)
+    end
+
+    wv = validator.new
+    errors = widgets.map { |w| wv.valid?(w); wv.errors }
+    expect(
+      errors.map(&:empty?)
+    ).to eq([false, false, true, false])
+  end
+
+  # Story:
+  # @pid
+  # Widget = Struct.new(:name, :size)
+  #
+  # class WV
+  #   include PoroValidator.validator
+  #   validates :name, inclusion: 'c'..'d'
+  #   validates :size, numeric: 2..3
+  # end
+  #
+  # widgets = ('a'..'d').map.with_index(1) do |n, s|
+  #   Widget.new(n, s)
+  # end
+  #
+  # # actual validity:
+  # aaa = widgets.map { |w| WV.new.valid?(w) }
+  # puts aaa.join(" ")
+  # #=> [false, false, true, false]
+  #
+  # # but when reusing a validator instance:
+  # wv = WV.new
+  # errors = widgets.map { |w| wv.valid?(w); wv.errors }
+  # puts (errors.map(&:empty?)).join(" ")
+  # #=> [false, false, false, false]
+  #
+  # require 'pry'; binding.pry
+  # # because:
+  # widgets.map { |w| wv.valid?(w); wv.errors.object_id }.uniq.size
+  # #=> 1
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: poro_validator
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.2.3
 platform: ruby
 authors:
 - Kareem Gan
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-01-23 00:00:00.000000000 Z
+date: 2016-01-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -151,6 +151,7 @@ files:
 - spec/features/configurable_error_messages_spec.rb
 - spec/features/inheritable_spec.rb
 - spec/features/nested_validations_spec.rb
+- spec/features/reuse_validator_spec.rb
 - spec/features/validate_hash_object_spec.rb
 - spec/lib/poro_validator/configuration_spec.rb
 - spec/lib/poro_validator/error_store_spec.rb