popolo 0.0.3 → 0.1.0

data/spec/models/popolo/post_spec.rb

@@ -1,5 +1,7 @@
-require 'spec_helper'
+require 'rails_helper'
 
-describe Popolo::Post do
-  it {should validate_presence_of :organization_id}
+module Popolo
+  RSpec.describe Post do
+    it {should validate_presence_of :organization_id}
+  end
 end

data/spec/models/popolo/vote_event_spec.rb

@@ -1,4 +1,6 @@
-require 'spec_helper'
+require 'rails_helper'
 
-describe Popolo::VoteEvent do
+module Popolo
+  RSpec.describe VoteEvent do
+  end
 end

data/spec/models/popolo/vote_spec.rb

@@ -1,4 +1,6 @@
-require 'spec_helper'
+require 'rails_helper'
 
-describe Popolo::Vote do
+module Popolo
+  RSpec.describe Vote do
+  end
 end

data/spec/popolo_spec.rb

@@ -1,10 +1,10 @@
-require 'spec_helper'
+require 'rails_helper'
 
-describe Popolo do
+RSpec.describe Popolo do
   describe '.storage_options' do
     context 'when using default storage options' do
       it 'should use default storage options' do
-        Popolo.storage_options.should == {}
+        expect(Popolo.storage_options).to eq({})
       end
     end
 
@@ -14,13 +14,13 @@ describe Popolo do
       end
 
       it 'should use custom storage options' do
-        Popolo.storage_options.should == {database: :test}
+        expect(Popolo.storage_options).to eq({database: :test})
 
         # We would need to reload the app.
-        # Popolo::Membership.storage_options.should   == {database: :test}
-        # Popolo::Organization.storage_options.should == {database: :test}
-        # Popolo::Person.storage_options.should       == {database: :test}
-        # Popolo::Post.storage_options.should         == {database: :test}
+        # expect(Popolo::Membership.storage_options).to   eq({database: :test})
+        # expect(Popolo::Organization.storage_options).to eq({database: :test})
+        # expect(Popolo::Person.storage_options).to       eq({database: :test})
+        # expect(Popolo::Post.storage_options).to         eq({database: :test})
       end
 
       after do
@@ -32,7 +32,7 @@ describe Popolo do
   describe '.storage_options_per_class' do
     context 'when using default storage options' do
       it 'should use default storage options' do
-        Popolo.storage_options_per_class.should == {}
+        expect(Popolo.storage_options_per_class).to eq({})
       end
     end
 
@@ -47,18 +47,18 @@ describe Popolo do
       end
 
       it 'should use custom storage options' do
-        Popolo.storage_options_per_class.should == {
+        expect(Popolo.storage_options_per_class).to eq({
           :Membership   => {collection: 'a'},
           :Organization => {collection: 'b'},
           :Person       => {collection: 'c'},
           :Post         => {collection: 'd'},
-        }
+        })
 
         # We would need to reload the app.
-        # Popolo::Membership.storage_options.should   == {collection: 'a'}
-        # Popolo::Organization.storage_options.should == {collection: 'b'}
-        # Popolo::Person.storage_options.should       == {collection: 'c'}
-        # Popolo::Post.storage_options.should         == {collection: 'd'}
+        # expect(Popolo::Membership.storage_options).to   eq({collection: 'a'})
+        # expect(Popolo::Organization.storage_options).to eq({collection: 'b'})
+        # expect(Popolo::Person.storage_options).to       eq({collection: 'c'})
+        # expect(Popolo::Post.storage_options).to         eq({collection: 'd'})
       end
 
       after do

data/spec/rails_helper.rb

@@ -0,0 +1,68 @@
+# This file is copied to spec/ when you run 'rails generate rspec:install'
+ENV["RAILS_ENV"] ||= 'test'
+
+require 'coveralls'
+Coveralls.wear!
+
+require 'spec_helper'
+require File.expand_path("../dummy/config/environment", __FILE__)
+require 'rspec/rails'
+
+Rails.backtrace_cleaner.remove_silencers!
+
+# Requires supporting ruby files with custom matchers and macros, etc, in
+# spec/support/ and its subdirectories. Files matching `spec/**/*_spec.rb` are
+# run as spec files by default. This means that files in spec/support that end
+# in _spec.rb will both be required and run as specs, causing the specs to be
+# run twice. It is recommended that you do not name files matching this glob to
+# end with _spec.rb. You can configure this pattern with the --pattern
+# option on the command line or in ~/.rspec, .rspec or `.rspec-local`.
+Dir["./spec/support/**/*.rb"].sort.each { |f| require f}
+
+# Checks for pending migrations before tests are run.
+# If you are not using ActiveRecord, you can remove this line.
+# ActiveRecord::Migration.maintain_test_schema!
+
+require 'database_cleaner'
+require 'mongoid-rspec'
+require 'factory_girl_rails'
+
+RSpec.configure do |config|
+  # Remove this line if you're not using ActiveRecord or ActiveRecord fixtures
+  config.fixture_path = "#{::Rails.root}/spec/fixtures"
+
+  # If you're not using ActiveRecord, or you'd prefer not to run each of your
+  # examples within a transaction, remove the following line or assign false
+  # instead of true.
+  config.use_transactional_fixtures = true
+
+  # RSpec Rails can automatically mix in different behaviours to your tests
+  # based on their file location, for example enabling you to call `get` and
+  # `post` in specs under `spec/controllers`.
+  #
+  # You can disable this behaviour by removing the line below, and instead
+  # explicitly tag your specs with their type, e.g.:
+  #
+  #     RSpec.describe UsersController, :type => :controller do
+  #       # ...
+  #     end
+  #
+  # The different available types are documented in the features, such as in
+  # https://relishapp.com/rspec/rspec-rails/docs
+  config.infer_spec_type_from_file_location!
+
+  config.include Mongoid::Matchers
+
+  config.before(:suite) do
+    DatabaseCleaner.strategy = :truncation
+    DatabaseCleaner.clean_with(:truncation)
+  end
+
+  config.before(:each) do
+    DatabaseCleaner.start
+  end
+
+  config.after(:each) do
+    DatabaseCleaner.clean
+  end
+end

data/spec/routing/popolo/memberships_routing_spec.rb

@@ -1,11 +1,13 @@
-require 'spec_helper'
+require 'rails_helper'
 
-describe Popolo::MembershipsController do
-  describe 'routing' do
-    routes { Popolo::Engine.routes }
+module Popolo
+  RSpec.describe MembershipsController, type: :routing do
+    describe 'routing' do
+      routes { Engine.routes }
 
-    it 'routes to #show' do
-      get('/memberships/1').should route_to('popolo/memberships#show', id: '1')
+      it 'routes to #show' do
+        expect(get: '/memberships/1').to route_to('popolo/memberships#show', id: '1')
+      end
     end
   end
 end

data/spec/routing/popolo/organizations_routing_spec.rb

@@ -1,15 +1,17 @@
-require 'spec_helper'
+require 'rails_helper'
 
-describe Popolo::OrganizationsController do
-  describe 'routing' do
-    routes { Popolo::Engine.routes }
+module Popolo
+  RSpec.describe OrganizationsController, type: :routing do
+    describe 'routing' do
+      routes { Engine.routes }
 
-    it 'routes to #index' do
-      get('/organizations').should route_to('popolo/organizations#index')
-    end
+      it 'routes to #index' do
+        expect(get: '/organizations').to route_to('popolo/organizations#index')
+      end
 
-    it 'routes to #show' do
-      get('/organizations/1').should route_to('popolo/organizations#show', id: '1')
+      it 'routes to #show' do
+        expect(get: '/organizations/1').to route_to('popolo/organizations#show', id: '1')
+      end
     end
   end
 end

data/spec/routing/popolo/people_routing_spec.rb

@@ -1,11 +1,13 @@
-require 'spec_helper'
+require 'rails_helper'
 
-describe Popolo::PeopleController do
-  describe 'routing' do
-    routes { Popolo::Engine.routes }
+module Popolo
+  RSpec.describe PeopleController, type: :routing do
+    describe 'routing' do
+      routes { Engine.routes }
 
-    it 'routes to #show' do
-      get('/people/1').should route_to('popolo/people#show', id: '1')
+      it 'routes to #show' do
+        expect(get: '/people/1').to route_to('popolo/people#show', id: '1')
+      end
     end
   end
 end

data/spec/routing/popolo/posts_routing_spec.rb

@@ -1,11 +1,13 @@
-require 'spec_helper'
+require 'rails_helper'
 
-describe Popolo::PostsController do
-  describe 'routing' do
-    routes { Popolo::Engine.routes }
+module Popolo
+  RSpec.describe PostsController, type: :routing do
+    describe 'routing' do
+      routes { Engine.routes }
 
-    it 'routes to #show' do
-      get('/posts/1').should route_to('popolo/posts#show', id: '1')
+      it 'routes to #show' do
+        expect(get: '/posts/1').to route_to('popolo/posts#show', id: '1')
+      end
     end
   end
 end

data/spec/spec_helper.rb

@@ -1,86 +1,76 @@
-require 'spork'
-
-Spork.prefork do
-  ENV["RAILS_ENV"] ||= 'test'
-
-  require 'coveralls'
-  Coveralls.wear!
-
-  require 'rails/application'
-  # Prevent Spork from caching the routes.
-  Spork.trap_method(Rails::Application::RoutesReloader, :reload!)
-  # Prevent Spork from caching Popolo classes (see below).
-  Spork.trap_method(Rails::Application, :eager_load!)
-
-  require File.expand_path("../dummy/config/environment.rb",  __FILE__)
-  require 'rspec/rails'
-
-  # Requires supporting ruby files with custom matchers and macros, etc,
-  # in spec/support/ and its subdirectories.
-  Dir[File.expand_path("../support/**/*.rb", __FILE__)].each {|f| require f}
-
-  # Prevent Spork from caching Popolo classes (see above).
-  Rails.application.railties.all do |railtie|
-    unless railtie.respond_to?(:engine_name) && railtie.engine_name == 'popolo'
-      railtie.eager_load!
-    end
+# This file was generated by the `rails generate rspec:install` command. Conventionally, all
+# specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.
+# The generated `.rspec` file contains `--require spec_helper` which will cause this
+# file to always be loaded, without a need to explicitly require it in any files.
+#
+# Given that it is always loaded, you are encouraged to keep this file as
+# light-weight as possible. Requiring heavyweight dependencies from this file
+# will add to the boot time of your test suite on EVERY test run, even for an
+# individual file that may not need all of that loaded. Instead, make a
+# separate helper file that requires this one and then use it only in the specs
+# that actually need it.
+#
+# The `.rspec` file also contains a few flags that are not defaults but that
+# users commonly want.
+#
+# See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
+RSpec.configure do |config|
+# The settings below are suggested to provide a good initial experience
+# with RSpec, but feel free to customize to your heart's content.
+  # These two settings work together to allow you to limit a spec run
+  # to individual examples or groups you care about by tagging them with
+  # `:focus` metadata. When nothing is tagged with `:focus`, all examples
+  # get run.
+  config.filter_run :focus
+  config.run_all_when_everything_filtered = true
+
+  # Many RSpec users commonly either run the entire suite or an individual
+  # file, and it's useful to allow more verbose output when running an
+  # individual spec file.
+  if config.files_to_run.one?
+    # Use the documentation formatter for detailed output,
+    # unless a formatter has already been configured
+    # (e.g. via a command-line flag).
+    config.default_formatter = 'doc'
   end
 
-  # Create non-Popolo indexes.
-  Rails.application.railties.engines.each do |engine|
-    unless engine.engine_name == 'popolo'
-      engine.paths["app/models"].expanded.each do |path|
-        Rails::Mongoid.create_indexes("#{path}/**/*.rb")
-      end
-    end
+  # Print the 10 slowest examples and example groups at the
+  # end of the spec run, to help surface which specs are running
+  # particularly slow.
+  # config.profile_examples = 10
+
+  # Run specs in random order to surface order dependencies. If you find an
+  # order dependency and want to debug it, you can fix the order by providing
+  # the seed, which is printed after each run.
+  #     --seed 1234
+  # config.order = :random
+
+  # Seed global randomization in this process using the `--seed` CLI option.
+  # Setting this allows you to use `--seed` to deterministically reproduce
+  # test failures related to randomization by passing the same `--seed` value
+  # as the one that triggered the failure.
+  Kernel.srand config.seed
+
+  # rspec-expectations config goes here. You can use an alternate
+  # assertion/expectation library such as wrong or the stdlib/minitest
+  # assertions if you prefer.
+  config.expect_with :rspec do |expectations|
+    # Enable only the newer, non-monkey-patching expect syntax.
+    # For more details, see:
+    #   - http://myronmars.to/n/dev-blog/2012/06/rspecs-new-expectation-syntax
+    expectations.syntax = :expect
   end
 
-  require 'database_cleaner'
-  require 'mongoid-rspec'
-
-  RSpec.configure do |config|
-    config.include Mongoid::Matchers
-
-    config.mock_with :rspec
-
-    config.after(:each) do
-      DatabaseCleaner.clean
-    end
-
-    # http://railscasts.com/episodes/285-spork
-    config.treat_symbols_as_metadata_keys_with_true_values = true
-    config.run_all_when_everything_filtered = true
-    config.filter_run focus: true
-    config.infer_spec_type_from_file_location!
+  # rspec-mocks config goes here. You can use an alternate test double
+  # library (such as bogus or mocha) by changing the `mock_with` option here.
+  config.mock_with :rspec do |mocks|
+    # Enable only the newer, non-monkey-patching expect syntax.
+    # For more details, see:
+    #   - http://teaisaweso.me/blog/2013/05/27/rspecs-new-message-expectation-syntax/
+    mocks.syntax = :expect
+
+    # Prevents you from mocking or stubbing a method that does not exist on
+    # a real object. This is generally recommended.
+    mocks.verify_partial_doubles = true
   end
 end
-
-Spork.each_run do
-  # DatabaseCleaner will not truncate system.indexes between tests, but it
-  # should be truncated before running the full test suite.
-  Mongoid::Sessions.default.drop
-
-  # It's now okay to load Popolo.
-  Rails.application.railties.engines.each do |engine|
-    if engine.engine_name == 'popolo'
-      engine.eager_load!
-    end
-  end
-
-  # Create Popolo indexes.
-  Rails.application.railties.engines.each do |engine|
-    if engine.engine_name == 'popolo'
-      engine.paths["app/models"].expanded.each do |path|
-        Rails::Mongoid.create_indexes("#{path}/**/*.rb")
-      end
-    end
-  end
-
-  # Create dummy indexes.
-  Rails::Mongoid.create_indexes(File.expand_path("../dummy/app/models/**/*.rb", __FILE__))
-
-  # @todo I18n.backend.reload!
-
-  require 'factory_girl_rails'
-  FactoryGirl.reload
-end

data/spec/support/{shared_examples.rb → shared_examples/date.rb}

@@ -1,4 +1,4 @@
-shared_examples_for 'a model with a date attribute' do |attribute|
+RSpec.shared_examples 'a model with a date attribute' do |attribute|
   it {
     should validate_format_of(attribute).
       # 4.1.2.2 Basic format