popolo 0.0.2 → 0.0.3

data/spec/factories.rb

@@ -1,12 +1,9 @@
 # https://github.com/thoughtbot/factory_girl/blob/master/GETTING_STARTED.md
 FactoryGirl.define do
-  factory :area, class: Popolo::Area do
-    name 'Foo'
-  end
-
   factory :membership, class: Popolo::Membership do
-    person
     organization
+    person
+    post
   end
 
   factory :organization, class: Popolo::Organization do
@@ -18,9 +15,7 @@ FactoryGirl.define do
   end
 
   factory :post, class: Popolo::Post do
-    name 'Marketing Director'
-    role 'Director'
-    person
+    label 'Marketing Director'
     organization
   end
 end

data/spec/models/popolo/{source_spec.rb → contact_detail_spec.rb}

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
-describe Popolo::Source do
-  [:name, :last_modified].each do |attribute|
+describe Popolo::ContactDetail do
+  [:type, :value].each do |attribute|
     it {should validate_presence_of attribute}
   end
 end

data/spec/models/popolo/count_spec.rb

@@ -0,0 +1,7 @@
+require 'spec_helper'
+
+describe Popolo::Count do
+  [:option, :value].each do |attribute|
+    it {should validate_presence_of attribute}
+  end
+end

data/spec/models/popolo/date_string_spec.rb

@@ -0,0 +1,121 @@
+require 'spec_helper'
+
+describe Popolo::DateString do
+  let :date do
+    Date.new(2011, 2, 3)
+  end
+
+  let :date_string_year_month_day do
+    Popolo::DateString.new('2011-02-03')
+  end
+
+  let :date_string_year_month do
+    Popolo::DateString.new('2011-02')
+  end
+
+  let :date_string_year do
+    Popolo::DateString.new('2011')
+  end
+
+  let :date_string_empty do
+    Popolo::DateString.new('')
+  end
+
+  let :year_month_day do
+    '2011-02-03'
+  end
+
+  let :year_month do
+    '2011-02'
+  end
+
+  let :year do
+    '2011'
+  end
+
+  let :empty do
+    ''
+  end
+
+  describe '#mongoize' do
+    it 'returns a string' do
+      date_string_year_month_day.mongoize.should == year_month_day
+    end
+
+    it 'returns a string if day truncated' do
+      date_string_year_month.mongoize.should == year_month
+    end
+
+    it 'returns a string if month and day truncated' do
+      date_string_year.mongoize.should == year
+    end
+
+    it 'returns nil if empty string' do
+      date_string_empty.mongoize.should == nil
+    end
+  end
+
+  describe '.demongoize' do
+    it 'returns a date' do
+      Popolo::DateString.demongoize(year_month_day).mongoize.should == date
+    end
+
+    it 'returns a string if day truncated' do
+      Popolo::DateString.demongoize(year_month).mongoize.should == year_month
+    end
+
+    it 'returns a string if month and day truncated' do
+      Popolo::DateString.demongoize(year).mongoize.should == year
+    end
+
+    it 'returns nil if empty string' do
+      Popolo::DateString.demongoize(empty).mongoize.should == nil
+    end
+  end
+
+  describe '.mongoize' do
+    it 'returns a string when given a date' do
+      Popolo::DateString.mongoize(date).should == year_month_day
+    end
+
+    it 'returns a string when given a date string' do
+      Popolo::DateString.mongoize(date_string_year_month_day).should == year_month_day
+      Popolo::DateString.mongoize(date_string_year_month).should == year_month
+      Popolo::DateString.mongoize(date_string_year).should == year
+    end
+
+    it 'returns a string when given a string' do
+      Popolo::DateString.mongoize(year_month_day).should == year_month_day
+      Popolo::DateString.mongoize(year_month).should == year_month
+      Popolo::DateString.mongoize(year).should == year
+    end
+
+    it 'returns nil when given an empty string' do
+      Popolo::DateString.mongoize(date_string_empty).should == nil
+      Popolo::DateString.mongoize(empty).should == nil
+    end
+  end
+
+  describe '.evolve' do
+    it 'returns a string when given a date' do
+      Popolo::DateString.evolve(date).should == year_month_day
+    end
+
+    it 'returns a string when given a date string' do
+      Popolo::DateString.evolve(date_string_year_month_day).should == year_month_day
+      Popolo::DateString.evolve(date_string_year_month).should == year_month
+      Popolo::DateString.evolve(date_string_year).should == year
+    end
+
+    it 'returns a string when given a string' do
+      Popolo::DateString.evolve(year_month_day).should == year_month_day
+      Popolo::DateString.evolve(year_month).should == year_month
+      Popolo::DateString.evolve(year).should == year
+    end
+
+    it 'returns nil when given an empty string' do
+      Popolo::DateString.evolve(date_string_empty).should == nil
+      Popolo::DateString.evolve(empty).should == nil
+    end
+  end
+end

data/spec/models/popolo/group_result_spec.rb

@@ -0,0 +1,7 @@
+require 'spec_helper'
+
+describe Popolo::GroupResult do
+  [:group, :result].each do |attribute|
+    it {should validate_presence_of attribute}
+  end
+end

data/spec/models/popolo/membership_spec.rb

@@ -6,22 +6,6 @@ describe Popolo::Membership do
   end
 
   [:start_date, :end_date].each do |attribute|
-    it {
-      should validate_format_of(attribute).
-        # 4.1.2.2 Basic format
-        not_to_allow('20041231').
-        # 4.1.2.2 Extended format
-        to_allow('2004-12-31').
-        # 4.1.2.3 a) A specific month
-        to_allow('2004-01').
-        # 4.1.2.3 b) A specific year
-        to_allow('2004').
-        # 4.1.2.3 c) A specific century
-        not_to_allow('20').
-        # Avoid confusion with YYMMDD
-        not_to_allow('200401').
-        # Date and time of day.
-        not_to_allow('2004-12-31T00:00:00Z')
-    }
+    it_should_behave_like 'a model with a date attribute', attribute
   end
 end

data/spec/models/popolo/motion_spec.rb

@@ -0,0 +1,5 @@
+require 'spec_helper'
+
+describe Popolo::Motion do
+  it_should_behave_like 'a model with a date attribute', :date
+end

data/spec/models/popolo/organization_spec.rb

@@ -1,25 +1,7 @@
 require 'spec_helper'
 
 describe Popolo::Organization do
-  it {should validate_presence_of :name}
-
   [:founding_date, :dissolution_date].each do |attribute|
-    it {
-      should validate_format_of(attribute).
-        # 4.1.2.2 Basic format
-        not_to_allow('20041231').
-        # 4.1.2.2 Extended format
-        to_allow('2004-12-31').
-        # 4.1.2.3 a) A specific month
-        to_allow('2004-01').
-        # 4.1.2.3 b) A specific year
-        to_allow('2004').
-        # 4.1.2.3 c) A specific century
-        not_to_allow('20').
-        # Avoid confusion with YYMMDD
-        not_to_allow('200401').
-        # Date and time of day.
-        not_to_allow('2004-12-31T00:00:00Z')
-    }
+    it_should_behave_like 'a model with a date attribute', attribute
   end
 end

data/spec/models/popolo/other_name_spec.rb

@@ -4,22 +4,6 @@ describe Popolo::OtherName do
   it {should validate_presence_of :name}
 
   [:start_date, :end_date].each do |attribute|
-    it {
-      should validate_format_of(attribute).
-        # 4.1.2.2 Basic format
-        not_to_allow('20041231').
-        # 4.1.2.2 Extended format
-        to_allow('2004-12-31').
-        # 4.1.2.3 a) A specific month
-        to_allow('2004-01').
-        # 4.1.2.3 b) A specific year
-        to_allow('2004').
-        # 4.1.2.3 c) A specific century
-        not_to_allow('20').
-        # Avoid confusion with YYMMDD
-        not_to_allow('200401').
-        # Date and time of day.
-        not_to_allow('2004-12-31T00:00:00Z')
-    }
+    it_should_behave_like 'a model with a date attribute', attribute
   end
 end

data/spec/models/popolo/person_spec.rb

@@ -1,25 +1,29 @@
 require 'spec_helper'
 
 describe Popolo::Person do
-  it {should validate_presence_of :name}
-
   [:birth_date, :death_date].each do |attribute|
-    it {
-      should validate_format_of(attribute).
-        # 4.1.2.2 Basic format
-        not_to_allow('20041231').
-        # 4.1.2.2 Extended format
-        to_allow('2004-12-31').
-        # 4.1.2.3 a) A specific month
-        to_allow('2004-01').
-        # 4.1.2.3 b) A specific year
-        to_allow('2004').
-        # 4.1.2.3 c) A specific century
-        not_to_allow('20').
-        # Avoid confusion with YYMMDD
-        not_to_allow('200401').
-        # Date and time of day.
-        not_to_allow('2004-12-31T00:00:00Z')
-    }
+    it_should_behave_like 'a model with a date attribute', attribute
+  end
+
+  describe '#to_s' do
+    it 'should return the name if the name, given name and family name are blank' do
+      FactoryGirl.build(:person, name: nil).to_s.should == nil
+    end
+
+    it 'should return the given name and family name if the name is blank' do
+      FactoryGirl.build(:person, name: nil, given_name: 'John', family_name: 'Public').to_s.should == 'John Public'
+    end
+
+    it 'should return the family name if the name and given name are blank' do
+      FactoryGirl.build(:person, name: nil, family_name: 'Public').to_s.should == 'Public'
+    end
+
+    it 'should return the given name if the name and family name are blank' do
+      FactoryGirl.build(:person, name: nil, given_name: 'John').to_s.should == 'John'
+    end
+
+    it 'should return the name if present' do
+      FactoryGirl.build(:person, given_name: 'John', family_name: 'Public').to_s.should == 'John Q. Public'
+    end
   end
 end

data/spec/models/popolo/post_spec.rb

@@ -1,7 +1,5 @@
 require 'spec_helper'
 
 describe Popolo::Post do
-  [:role, :organization_id].each do |attribute|
-    it {should validate_presence_of attribute}
-  end
+  it {should validate_presence_of :organization_id}
 end

data/spec/models/popolo/vote_event_spec.rb

@@ -0,0 +1,4 @@
+require 'spec_helper'
+
+describe Popolo::VoteEvent do
+end

data/spec/models/popolo/vote_spec.rb

@@ -0,0 +1,4 @@
+require 'spec_helper'
+
+describe Popolo::Vote do
+end

data/spec/popolo_spec.rb

@@ -1,4 +1,69 @@
 require 'spec_helper'
 
 describe Popolo do
+  describe '.storage_options' do
+    context 'when using default storage options' do
+      it 'should use default storage options' do
+        Popolo.storage_options.should == {}
+      end
+    end
+
+    context 'when using custom storage options' do
+      before do
+        Popolo.storage_options = {database: :test}
+      end
+
+      it 'should use custom storage options' do
+        Popolo.storage_options.should == {database: :test}
+
+        # We would need to reload the app.
+        # Popolo::Membership.storage_options.should   == {database: :test}
+        # Popolo::Organization.storage_options.should == {database: :test}
+        # Popolo::Person.storage_options.should       == {database: :test}
+        # Popolo::Post.storage_options.should         == {database: :test}
+      end
+
+      after do
+        Popolo.storage_options = {}
+      end
+    end
+  end
+
+  describe '.storage_options_per_class' do
+    context 'when using default storage options' do
+      it 'should use default storage options' do
+        Popolo.storage_options_per_class.should == {}
+      end
+    end
+
+    context 'when using custom storage options' do
+      before do
+        Popolo.storage_options_per_class = {
+          :Membership   => {collection: 'a'},
+          :Organization => {collection: 'b'},
+          :Person       => {collection: 'c'},
+          :Post         => {collection: 'd'},
+        }
+      end
+
+      it 'should use custom storage options' do
+        Popolo.storage_options_per_class.should == {
+          :Membership   => {collection: 'a'},
+          :Organization => {collection: 'b'},
+          :Person       => {collection: 'c'},
+          :Post         => {collection: 'd'},
+        }
+
+        # We would need to reload the app.
+        # Popolo::Membership.storage_options.should   == {collection: 'a'}
+        # Popolo::Organization.storage_options.should == {collection: 'b'}
+        # Popolo::Person.storage_options.should       == {collection: 'c'}
+        # Popolo::Post.storage_options.should         == {collection: 'd'}
+      end
+
+      after do
+        Popolo.storage_options = {}
+      end
+    end
+  end
 end

data/spec/routing/popolo/memberships_routing_spec.rb

@@ -0,0 +1,11 @@
+require 'spec_helper'
+
+describe Popolo::MembershipsController do
+  describe 'routing' do
+    routes { Popolo::Engine.routes }
+
+    it 'routes to #show' do
+      get('/memberships/1').should route_to('popolo/memberships#show', id: '1')
+    end
+  end
+end

data/spec/routing/popolo/organizations_routing_spec.rb

@@ -2,9 +2,7 @@ require 'spec_helper'
 
 describe Popolo::OrganizationsController do
   describe 'routing' do
-    before :each do
-      @routes = Popolo::Engine.routes
-    end
+    routes { Popolo::Engine.routes }
 
     it 'routes to #index' do
       get('/organizations').should route_to('popolo/organizations#index')
@@ -13,21 +11,5 @@ describe Popolo::OrganizationsController do
     it 'routes to #show' do
       get('/organizations/1').should route_to('popolo/organizations#show', id: '1')
     end
-
-    it 'routes to #nested_index' do
-      get('/organizations/foo/organizations').should route_to('popolo/organizations#nested_index', path: 'foo')
-    end
-
-    it 'routes to #nested_show' do
-      get('/organizations/foo/bar').should route_to('popolo/organizations#nested_show', path: 'foo/bar')
-    end
-
-    it 'routes to #posts' do
-      get('/organizations/foo/posts').should route_to('popolo/organizations#posts', path: 'foo')
-    end
-
-    it 'routes to #post' do
-      get('/organizations/foo/posts/bar').should route_to('popolo/organizations#post', path: 'foo', id: 'bar')
-    end
   end
 end

data/spec/routing/popolo/people_routing_spec.rb

@@ -2,20 +2,10 @@ require 'spec_helper'
 
 describe Popolo::PeopleController do
   describe 'routing' do
-    before :each do
-      @routes = Popolo::Engine.routes
-    end
-
-    it 'routes to #index' do
-      get('/people').should route_to('popolo/people#index')
-    end
+    routes { Popolo::Engine.routes }
 
     it 'routes to #show' do
       get('/people/1').should route_to('popolo/people#show', id: '1')
     end
-
-    it 'routes to #show' do
-      get('/people/foo').should route_to('popolo/people#show', id: 'foo')
-    end
   end
 end

data/spec/routing/popolo/posts_routing_spec.rb

@@ -2,13 +2,7 @@ require 'spec_helper'
 
 describe Popolo::PostsController do
   describe 'routing' do
-    before :each do
-      @routes = Popolo::Engine.routes
-    end
-
-    it 'routes to #index' do
-      get('/posts').should route_to('popolo/posts#index')
-    end
+    routes { Popolo::Engine.routes }
 
     it 'routes to #show' do
       get('/posts/1').should route_to('popolo/posts#show', id: '1')

data/spec/spec_helper.rb

@@ -3,6 +3,9 @@ require 'spork'
 Spork.prefork do
   ENV["RAILS_ENV"] ||= 'test'
 
+  require 'coveralls'
+  Coveralls.wear!
+
   require 'rails/application'
   # Prevent Spork from caching the routes.
   Spork.trap_method(Rails::Application::RoutesReloader, :reload!)
@@ -33,7 +36,6 @@ Spork.prefork do
   end
 
   require 'database_cleaner'
-  require 'factory_girl_rails'
   require 'mongoid-rspec'
 
   RSpec.configure do |config|
@@ -49,6 +51,7 @@ Spork.prefork do
     config.treat_symbols_as_metadata_keys_with_true_values = true
     config.run_all_when_everything_filtered = true
     config.filter_run focus: true
+    config.infer_spec_type_from_file_location!
   end
 end
 
@@ -77,5 +80,7 @@ Spork.each_run do
   Rails::Mongoid.create_indexes(File.expand_path("../dummy/app/models/**/*.rb", __FILE__))
 
   # @todo I18n.backend.reload!
+
+  require 'factory_girl_rails'
   FactoryGirl.reload
 end

data/spec/support/shared_examples.rb

@@ -0,0 +1,19 @@
+shared_examples_for 'a model with a date attribute' do |attribute|
+  it {
+    should validate_format_of(attribute).
+      # 4.1.2.2 Basic format
+      not_to_allow('20041231').
+      # 4.1.2.2 Extended format
+      to_allow('2004-12-31').
+      # 4.1.2.3 a) A specific month
+      to_allow('2004-01').
+      # 4.1.2.3 b) A specific year
+      to_allow('2004').
+      # 4.1.2.3 c) A specific century
+      not_to_allow('20').
+      # Avoid confusion with YYMMDD
+      not_to_allow('200401').
+      # Date and time of day.
+      not_to_allow('2004-12-31T00:00:00Z')
+  }
+end