pools 1.1.0 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ae62a54973d24d74b569f5f8b9f3a5affa38bb302dc866618d1f662f0520705f
-  data.tar.gz: 6f086c672eaf44b059be9ef3ecb94edbd78b8612f8d98bd745242e626ff3bdd7
+  metadata.gz: 460de6de46759d3160426610e1a5fdc6a50b4476e6775dc721949638be980718
+  data.tar.gz: 28bc2c93bebea91f91b43f3a53a8d9a3ca005ad3b574b118a129dcf8d1142a9a
 SHA512:
-  metadata.gz: 276d6e6c33998dfe312010116f17a84296e84192e53b63a673334d1c23a175f0bf1a4b4e3233be3bb53ff1677ca7ede3d8032e83b883e8f2c0efd6e9adb655cd
-  data.tar.gz: d1357f7383545bff1233298d371d9a55e7670587a837910d02e0dab8d8348ec8ee3da95f6687e9fff88be394247add308521be0a8eb8b057c788b58235108901
+  metadata.gz: d1dc435f9830a1bfe54755ed7fca3bebf67b4f334ce5af922db164b44904f5886333edbc379e23938b70768762fc866c86cae281ee014c86be17caf40ebb6a96
+  data.tar.gz: 1431f11e93f2e3cf279a6644c7d62c4e9278fbc82de002676b208c59b981829887f7574ee20e58e4a7cb1950cb4e62c8f060bce65f4ebf7a6a370983675b424e

data/lib/pools/handler.rb

@@ -12,7 +12,9 @@ module Pools
 
     # Add a new connection pool to the mix
     def add(pool, name = nil)
-      @pools[name || pool.object_id] = pool
+      key = name || pool.object_id
+      raise(%Q(Pool "#{name}" already exists)) if @pools[name]
+      @pools[name] = pool
     end
 
     # Returns any connections in use by the current thread back to the

data/lib/pools/pooled.rb

@@ -32,9 +32,15 @@ module Pools
     module ClassMethods
       def connection_methods(*methods)
         methods.each do |method|
-          define_method(method) do |*params, &block|
+          define_method(method) do |*args, **kwargs, &block|
             with_connection do |client|
-              client.send(method, *params, &block)
+              # https://bugs.ruby-lang.org/issues/14415
+              # Needed for pre-2.5 Ruby support
+              if !kwargs.empty?
+                client.send(method, *args, **kwargs, &block)
+              else
+                client.send(method, *args, &block)
+              end
             end
           end
         end
@@ -49,4 +55,4 @@ module Pools
       end
     end
   end
-end
+end

data/lib/redis/pooled.rb

@@ -11,7 +11,11 @@ class Redis
     end
 
     def __connection
-      Redis.connect(@redis_options)
+      if Redis.respond_to?(:connect) # 3.x and earlier
+        Redis.connect(@redis_options)
+      else
+        Redis.new(@redis_options)
+      end
     end
 
     def __disconnect(client)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pools
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 2.0.0
 platform: ruby
 authors:
 - Michael Rykov
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-09-07 00:00:00.000000000 Z
+date: 2022-09-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -17,9 +17,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 3.0.0
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '5.3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -27,9 +24,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 3.0.0
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '5.3'
 description: 'Generalized connection pooling
 
 '