poolparty 0.2.18 → 0.2.69

data/spec/poolparty/aska/aska_spec.rb

@@ -0,0 +1,122 @@
+require File.dirname(__FILE__) + '/../spec_helper'
+
+class Car
+  include Aska
+  rules :names, [
+      "x > 0",
+      "y > 0",
+      "x > y"
+    ]
+end
+describe "Rules" do
+  before(:each) do
+    @car = Car.new
+  end
+  describe "malformed rules" do
+    [
+      "k > 10",
+      "x == 2",
+      "x >= 2",
+      "x <= 4",
+      "y < 10"
+    ].each do |str|
+      eval <<-EOE
+        it "should have the rule #{str} be valid" do
+          (str =~ /(.+)[=\\\<\>](.*)/).nil?.should == false
+        end
+      EOE
+    end
+    [
+      "k running 10",
+      "10 is larger than 2"
+    ].each do |str|
+      eval <<-EOE
+        it "should have the rule #{str} not be valid" do
+          (str =~ /(.+)[=\\\<\>](.*)/).nil?.should == true
+        end
+      EOE
+    end
+  end
+  it "should be able to define rules as an array and they should be set as the rules on the class" do
+    @car.rules.class.should == Hash
+  end
+  it "should be able to look up the rules based on the name into an array" do
+    @car.names.class.should == Aska::Rules
+  end
+  it "should be able to turn them into a string" do
+    @car.names.to_s.should == "'x > 0', 'y > 0', 'x > y'"
+  end
+  it "should be able to say that rules are defined when they are defined" do
+    @car.names.should_not be_nil
+  end
+  it "should be able tos ay that rules are not defined when they are not defined" do
+    @car.look_up_rules(:cars_and_wheels).should be_empty
+  end
+  it "should be able to say if the rules are not rules" do
+    @car.are_rules?(:cars_and_wheels).should be_false
+  end
+  it "should be able to say that rules are rules" do
+    @car.are_rules?(:names).should be_true
+  end
+  describe "parsing" do
+    it "should be able to parse the x > 0 into an array" do
+      @car.names.include?({"x"=>[">","0"]}).should == true
+    end
+    it "should be able to parse y > 0 into an array" do
+      @car.names.include?({"y"=>[">","0"]}).should == true
+    end
+    it "should be able to parse x > y into the hash" do
+      @car.names.include?({"x"=>[">","y"]}).should == true
+    end
+    it "should have 3 rules" do
+      @car.names.size.should == 3
+    end
+    it "should be able to look up the names as a rule" do
+      Car.look_up_rules(:names).should == [{"x"=>[">", "0"]}, {"y"=>[">", "0"]}, {"x"=>[">", "y"]}]
+    end
+  end
+  # it "should use x if available instead of x_aska" do
+  #   @car.x = 6
+  #   @car.get_var(:x).class.should == @car.x_aska.class
+  # end
+  # it "should be able to get the variable associated with the instance and return it" do    
+  #   @car.x_aska = 4
+  #   @car.get_var(:x).class.should == @car.x_aska.class
+  # end
+  it "should be able to get a number with the instance and return it as a float" do
+    @car.__aska_get_var(4).class.should == Float
+  end
+  it "should be able to get the method it's applying as a method symbol" do
+    @car.__aska_get_var(:<).class.should == Symbol
+  end
+  it "should be able to get the method as a symbol" do
+    @car.__aska_get_var("<").class.should == Symbol
+  end
+  it "should be able to retrieve the value of the rule when checking if it's valid" do
+    @car.x = 10
+    @car.valid_rule?({:x => [:==, 10]}).should == true
+  end
+  it "should be able to apply the rules and say that they are not met when they aren't" do
+    @car.valid_rules?(:names).should == false
+  end
+  it "should be able to apply the rules and say they aren't valid when they aren't all met" do
+    @car.x = 5
+    @car.y = 10
+    @car.valid_rules?(:names).should == true
+  end
+  it "should be able to apply the rules and say they aren't valid when they aren't all met" do
+    @car.x = 5
+    @car.y = 0
+    @car.valid_rules?(:names).should == false
+  end
+  it "should be able to apply the rules and say that they are in fact valid" do
+    @car.x = 10
+    @car.y = 5    
+    @car.valid_rules?(:names).should == true
+  end
+  it "should have the rules in an array of hashes" do
+    @car.names.each do |n|
+      
+    end
+  end
+end

data/spec/poolparty/bin/console_spec.rb

@@ -56,6 +56,24 @@ describe "Console" do
       reload!
     end
   end
+  describe "pools" do
+    before(:each) do
+      @filename = "myspec.spec"
+      ::File.stub!(:readable?).with(@filename).and_return true
+      @filename.stub!(:read).and_return "spec contents"
+      self.stub!(:open).with(@filename).and_return @filename
+    end
+    it "should call readable on the string sent in to load_pool" do      
+      lambda {
+        ::File.should_receive(:readable?).with(@filename).and_return false
+        load_pool(@filename)
+      }
+    end
+    it "should call inflate from Script with the poolspec" do
+      PoolParty::Script.should_receive(:inflate).with("spec contents", "myspec.spec")
+      load_pool(@filename)
+    end
+  end
   describe "print" do
     before(:each) do
       reset!

data/spec/poolparty/core/hash_spec.rb

@@ -25,13 +25,13 @@ describe "Hash" do
     @a.to_os.to_hash.should == @a
   end
   it "should not put quotes around integers" do
-    {:a => 10, :b => "q"}.flush_out.should == ["a => 10", "b => 'q'"]
+    {:a => 10, :b => "q"}.flush_out.sort.should == ["a => 10", "b => 'q'"]
   end
   it "should be able to flush out into a string into an array" do
-    @a.flush_out.should == ["a => '10'","b => '20'","c => '30'"]
+    @a.flush_out.sort.should == ["a => '10'","b => '20'","c => '30'"]
   end
   it "should be able to flush out with pre and posts" do
-    @a.flush_out("hi", "ho").should == ["hia => '10'ho","hib => '20'ho","hic => '30'ho"]
+    @a.flush_out("hi", "ho").sort.should == ["hia => '10'ho","hib => '20'ho","hic => '30'ho"]
   end
   describe "select" do
     before(:each) do
@@ -52,7 +52,7 @@ describe "Hash" do
       @rejected_hash.keys.should == [:a]
     end
     it "should return the old array with the other keys" do
-      @a.keys.should == [:b, :c]
+      @a.keys.sort.should == [:b, :c]
     end
     it "should not throw a fit with an empty hash" do
       lambda {

data/spec/poolparty/core/object_spec.rb

@@ -4,6 +4,26 @@ describe "Object" do
   it "should respond to to_os" do
     Object.new.respond_to?(:to_os).should == true
   end
+  describe "methodable object" do
+    before(:each) do
+      @obj.stub!(:run).and_return "true"
+    end
+    it "should run the method :run because it exists" do
+      @obj.send_if_method(:run).should == "true"
+    end
+    it "should not run the method :bah because it doesn't exist" do
+      @obj.send_if_method("bah").should == "bah"
+    end
+    it "should not run the method if it is sent nil" do
+      @obj.send_if_method(nil).should == nil
+    end
+    it "should not run an empty string method" do
+      @obj.send_if_method("").should == ""
+    end
+    it "should not run a method that is an integer" do
+      @obj.send_if_method(2).should == 2
+    end
+  end
   describe "with_options" do
     before(:each) do
       @obj = Class.new
@@ -36,5 +56,14 @@ describe "Object" do
         @b.dude.should == "totally"
       end
     end
+    describe "contextual running" do
+      before(:each) do
+        @obj.stub!(:default_options).and_return {}
+        @a = @obj.run_in_context { @a = "hello world" }
+      end
+      it "should have the method meta_eval" do
+        @obj.respond_to?(:meta_eval).should == true
+      end
+    end
   end
 end

data/spec/poolparty/core/string_spec.rb

@@ -115,6 +115,9 @@ listen web_proxy 127.0.0.1:3000
     it "should be able to get the top level class" do
       "PoolParty::Resources::File".top_level_class.should == "file"
     end
+    it "should turn file into a class" do
+      "file".camelcase.should == "File"
+    end
   end
   describe "to_option_string" do
     it "should not touch a string, but return the string with single quotes" do
@@ -147,6 +150,9 @@ listen web_proxy 127.0.0.1:3000
     it "should remove the periods from the string" do
       "xnot.org".sanitize.should == "xnotorg"
     end
+    it "should be able to turn a string into a dir safe name" do
+      "Rails app/".dir_safe.should == "rails_app/"
+    end
   end
   describe "nice_runnable" do
     before(:each) do

data/spec/poolparty/core/time_spec.rb

@@ -17,9 +17,6 @@ describe "Time" do
     it "should be able to parse weeks" do
       2.weeks.should == 1209600
     end
-    it "should be able to parse months" do
-      1.month.should == 2678400
-    end
   end
   describe "from" do
     it "should be able to find minutes ago" do

data/spec/poolparty/helpers/binary_spec.rb

@@ -16,8 +16,8 @@ describe "Binary" do
   end
   describe "get_existing_spec_location" do
     before(:each) do
-      ::File.stub!(:file?).and_return false
-      ::File.stub!(:file?).with("#{Base.storage_directory}/pool.spec").and_return true
+      ::File.stub!(:readable?).and_return false
+      ::File.stub!(:readable?).with("#{Base.storage_directory}/pool.spec").and_return true
     end
     it "should be a String" do
       Binary.get_existing_spec_location.class.should == String

data/spec/poolparty/helpers/optioner_spec.rb

@@ -4,7 +4,7 @@ require File.dirname(__FILE__) + '/../../../lib/poolparty/helpers/optioner'
 describe "Option Parser" do
   describe "options" do
     before(:each) do
-      @op = PoolParty::Optioner.new
+      @op = PoolParty::Optioner.new({:abstract => true})
       @op.parse_options
     end
     it "should set the options as an Hash" do
@@ -17,9 +17,6 @@ describe "Option Parser" do
       @op.options.should_receive(:[]).with(:verbose).once.and_return true
       @op.verbose
     end
-    it "should be able to display the version" do
-      @op.version.should == PoolParty::VERSION::STRING
-    end
     it "should exit after displaying the help message" do
       hide_output do
         lambda {

data/spec/poolparty/helpers/provisioner_base_spec.rb

@@ -91,6 +91,13 @@ describe "ProvisionerBase" do
     it "should compound the string to be hello \n   \n cruel world" do
       @provisioner.install_string.should == "hello \n   \n cruel world"
     end
+    it "should call the last_install_tasks last" do
+      @provisioner.should_receive(:last_install_tasks).at_least(1).and_return ["pops"]
+    end
+    it "should append the last_install_tasks to the end" do
+      @provisioner.stub!(:last_install_tasks).and_return ["pops"]
+      @provisioner.install_string.should == "hello \n   \n cruel world \n pops"
+    end
     after do
       @provisioner.install_string
     end
@@ -100,8 +107,14 @@ describe "ProvisionerBase" do
         stub_list_from_remote_for(@cloud)
         @cloud.stub!(:keypair).and_return "fake_keypair"
         @cloud.stub!(:keypair_path).and_return "~/.ec2/fake_keypair"
-        Provisioner::Master.stub!(:new).and_return @provisioner
+        @cloud.stub!(:other_clouds).and_return []
+        @cloud.stub!(:expand_when).and_return "cpu > 10"
         @cloud.stub!(:copy_file_to_storage_directory).and_return true
+        @cloud.stub!(:rsync_storage_files_to).and_return true
+        @cloud.stub!(:minimum_runnable_options).and_return []
+        Provisioner::Master.stub!(:new).and_return @provisioner
+        @provisioner.stub!(:build_and_store_new_config_file).and_return true
+        @provisioner.stub!(:process_clean_reconfigure_for!).and_return true
       end
       describe "provision_master" do
         it "should call write_install_file" do

data/spec/poolparty/helpers/provisioners/master_spec.rb

@@ -27,7 +27,7 @@ describe "Master provisioner" do
       @master.should_receive(:setup_fileserver)
     end
     it "should call create_local_node" do
-      @master.should_receive(:create_local_node)      
+      @master.should_receive(:create_local_node).twice
     end
     it "should call the custom_install_tasks" do
       @master.should_receive(:custom_install_tasks)
@@ -39,8 +39,8 @@ describe "Master provisioner" do
   it "should return install_puppet_master as apt-get install puppet factor" do
     @master.install_puppet.should =~ /install -y puppet puppetmaster/
   end
-  it "should return setup basic structure" do
-    @master.setup_basic_structure.should =~ /puppetmasterd --mkusers/
+  it "should return setup basic structure and set classes into the manifest" do
+    @master.setup_basic_structure.should =~ /echo "import 'classes\/\*\.pp'" >> \/etc\/puppet\/manifests\/site\.pp/
   end
   it "should return setup_fileserver with the setup" do
     @master.setup_fileserver.should =~ /\[files\]/

data/spec/poolparty/modules/cloud_resourcer_spec.rb

@@ -73,7 +73,7 @@ describe "CloudResourcer" do
         @tc.respond_to?(:keypair_path).should == true
       end
       it "should set the keypair to the Base.keypair_path" do      
-        @tc.keypair_path.should =~ /#{File.expand_path(Base.base_keypair_path)}/
+        @tc.keypair_path.should =~ /\.ec2\/rangerbob/
       end
       it "should set the keypair to have the keypair set" do
         @tc.keypair.should =~ /rangerbob/
@@ -98,12 +98,12 @@ describe "CloudResourcer" do
         @tc.should_receive(:configure).with(@testparent.options)      
       end
       after do
-        @tc.set_parent(@testparent)
+        @tc.run_setup(@testparent)
       end      
     end
     describe "parent's services" do
       before(:each) do        
-        @tc.set_parent(@testparent)        
+        @tc.run_setup(@testparent)        
       end
       it "should set the parent" do
         @tc.parent.should == @testparent

data/spec/poolparty/modules/configurable_spec.rb

@@ -9,7 +9,6 @@ describe "configurable" do
     @tc = TestClass.new
   end
   it "should set the name as frank" do
-    @tc.name.should == nil
     @tc.configure({:name => "frank"})
     @tc.name.should == "frank"
   end
@@ -23,4 +22,8 @@ describe "configurable" do
     @tc.reconfigure(:name => "dewey")
     @tc.name.should == "dewey"
   end
+  it "should send an array if two arguments are given" do
+    @tc.configure({:name => ["array", "ishere"]})
+    @tc.name.should == ["array", "ishere"]
+  end
 end

data/spec/poolparty/monitors/base_monitor_spec.rb

@@ -1,8 +1,17 @@
 require File.dirname(__FILE__) + '/../spec_helper'
 
-include PoolParty::Monitors
+class TestMonitorClass
+  include PoolParty::Monitors
+  include Configurable
+  def default_options
+    {}
+  end
+end
 
 describe "Monitors" do
+  before(:each) do
+    @tmc = TestMonitorClass.new
+  end
   it "should have a list of available monitors" do
     PoolParty::Monitors.available_monitors.empty?.should == false
   end
@@ -11,9 +20,92 @@ describe "Monitors" do
     PoolParty::Monitors.register_monitor :fake
     size.should == PoolParty::Monitors.available_monitors.size - 1
   end
+  it "should define the mehtod fake when register_monitor :fake" do
+    PoolParty::Monitors.register_monitor :fake
+    TestMonitorClass.new.respond_to?(:fake).should == true
+  end
+  it "should call the Messenger with messenger_send!('get_load fake')" do
+    @tmc.should_receive(:messenger_send!).with("get_current_load fake").and_return true
+    @tmc.fake
+  end
+  it "should have the cpu method on the class" do
+    @tmc.should_receive(:messenger_send!).with("get_current_load cpu").and_return true
+    @tmc.cpu
+  end
+  describe "expansions" do
+    before(:each) do
+      @tmc = TestMonitorClass.new
+      @tmc.instance_eval do
+        expand_when "cpu > 95", "memory > 90"
+        contract_when "cpu < 15", "memory < 10"
+      end
+    end
+    it "should have the method expand_when as a class method" do
+      @tmc.respond_to?(:expand_when).should == true
+    end
+    it "should have expansions as a collection of rules on the object" do
+      @tmc.expand_when.class.should == Aska::Rules
+    end
+    it "should return the expand_when as a set of rules" do
+      @tmc.expand_when.class.should == Aska::Rules
+    end
+    it "should have the expansion in the array on the instance" do
+      @tmc.expand_when.first.should == {"cpu" => [">", "95"]}
+    end
+    it "should have the memory expansion in the array on the instance" do
+      @tmc.expand_when[1].should == {"memory" => [">", "90"]}
+    end
+    it "should have 2 expansions" do
+      @tmc.expand_when.size.should == 2
+    end
+    it "should give us the method cpu for free" do
+      @tmc.respond_to?(:cpu).should == true
+    end
+    describe "when memory is over the limit" do
+      before(:each) do
+        @tmc.stub!(:memory).and_return 99
+      end
+      it "should say it should not expand if the cpu is short of the limit" do
+        @tmc.stub!(:cpu).and_return 43
+        @tmc.valid_rules?(:expand_when).should == false
+      end
+      it "should say that it has the valid expansion rules when the cpu is higher than the limit" do
+        @tmc.stub!(:cpu).and_return 98
+        @tmc.valid_rules?(:expand_when).should == true
+      end
+    end
+    describe "when cpu is over the limit" do
+      before(:each) do
+        @tmc.stub!(:cpu).and_return 98
+      end
+      it "should say it should not expand if the cpu is short of the limit" do
+        @tmc.stub!(:memory).and_return 43
+        @tmc.valid_rules?(:expand_when).should == false
+      end
+      it "should say that it has the valid expansion rules when the cpu is higher than the limit" do
+        @tmc.stub!(:memory).and_return 98
+        @tmc.valid_rules?(:expand_when).should == true
+      end
+    end
+    describe "when neither is over the limits" do
+      before(:each) do
+        @tmc.stub!(:cpu).and_return 87
+        @tmc.stub!(:memory).and_return 40
+      end
+      it "should not expand" do
+        @tmc.valid_rules?(:expand_when).should == false
+      end
+    end
+    it "should be able to turn them into a string" do
+      @tmc.expand_when.to_s.should == "'cpu > 95', 'memory > 90'"
+    end
+    it "should be able to turn them into a string with expand_when" do
+      @tmc.expand_when.to_s.should == "'cpu > 95', 'memory > 90'"
+    end
+  end
 end
 describe "BaseMonitor" do
   it "should have the singleton method run defined" do
-    BaseMonitor.respond_to?(:run).should == true
+    PoolParty::Monitors::BaseMonitor.respond_to?(:run).should == true
   end
 end

data/spec/poolparty/monitors/monitors/cpu_monitor_spec.rb

@@ -5,7 +5,6 @@ include PoolParty::Monitors
 describe "CpuMonitor" do
   before(:each) do
     @mon = CpuMonitor.new
-    CpuMonitor.stub!(:new).and_return @mon
   end
   it "should have the singleton method run defined" do
     CpuMonitor.respond_to?(:run).should == true

data/spec/poolparty/monitors/monitors/memory_monitor_spec.rb

@@ -0,0 +1,47 @@
+require File.dirname(__FILE__) + '/../../spec_helper'
+
+include PoolParty::Monitors
+
+def vm_stat_str
+<<-EOE
+Mach Virtual Memory Statistics: (page size of 4096 bytes)
+Pages free:                    67993.
+Pages active:                 256445.
+Pages inactive:               124392.
+Pages wired down:              73762.
+"Translation faults":     1280661664.
+Pages copy-on-write:        52365921.
+Pages zero filled:         722428360.
+Pages reactivated:            441434.
+Pageins:                     1120320.
+Pageouts:                     285425.
+Object cache: 11159288 hits of 21753237 lookups (51% hit rate)
+EOE
+end
+
+describe "MemoryMonitor" do
+  before(:each) do
+    @mon = MemoryMonitor.new
+    MemoryMonitor.stub!(:new).and_return @mon
+  end
+  it "should have the singleton method run defined" do
+    MemoryMonitor.respond_to?(:run).should == true
+  end
+  it "should call the method new" do
+    MemoryMonitor.should_receive(:new).and_return @mon
+    MemoryMonitor.run
+  end
+  describe "calling" do
+    it "should call uname with %x" do
+      @mon.should_receive(:`).with("uname").and_return "Darwin"
+      @mon.stub!(:`).and_return ""
+    end
+    it "should call vm_stat with when the uname returns Darwin" do
+      @mon.should_receive(:`).with("uname").and_return "Darwin"
+      @mon.should_receive(:`).with("vm_stat").and_return vm_stat_str
+    end
+    after(:each) do
+      @mon.run
+    end
+  end
+end

data/spec/poolparty/{helpers → net}/messenger_spec.rb

@@ -4,11 +4,13 @@ setup_cl
 
 include PoolParty::Messenger
 
+Object.send :undef_method, :messenger_send!
+
 describe "Messenger" do
   it "should have the method messenger_send!" do
     Messenger.respond_to?(:messenger_send!).should == true
   end
   it "should call send_cmd on the client" do
-    Messenger.messenger_send!('send_cmd ["echo hi"]', true).should =~ /-run pm_client send_cmd/
+    hide_output {Messenger.messenger_send!('send_cmd ["echo hi"]', true).should =~ /-run pm_client send_cmd/}
   end
 end

data/spec/poolparty/net/remote_bases/ec2_spec.rb

@@ -1,11 +1,12 @@
 require File.dirname(__FILE__) + '/../../spec_helper'
 
-include Remote
+# include Remote
 
 class TestClass  
-  include RemoterBase
+  include PoolParty::Remote::RemoterBase
   include Ec2
   include CloudResourcer
+  include CloudDsl
   
   def keypair
     "fake_keypair"
@@ -13,24 +14,41 @@ class TestClass
   
   def ami;"ami-abc123";end
   def size; "small";end
-  
+  def verbose
+    false
+  end
   def ec2
     @ec2 ||= EC2::Base.new( :access_key_id => "not_an_access_key", :secret_access_key => "not_a_secret_access_key")
   end
 end
 describe "ec2 remote base" do
   before(:each) do
+    setup
     @tr = TestClass.new
     stub_remoter_for(@tr)
     @tr.stub!(:get_instances_description).and_return response_list_of_instances
   end
-  %w(launch_new_instance! terminate_instance! describe_instance describe_instances).each do |method|
+  %w(launch_new_instance! terminate_instance! describe_instance describe_instances create_snapshot).each do |method|
     eval <<-EOE
       it "should have the method #{method}" do
         @tr.respond_to?(:#{method}).should == true
       end
     EOE
   end
+  describe "helpers" do
+    it "should be able to convert an ec2 ip to a real ip" do
+      "ec2-72-44-36-12.compute-1.amazonaws.com".convert_from_ec2_to_ip.should == "72.44.36.12"
+    end
+    it "should not throw an error if another string is returned" do
+      "72.44.36.12".convert_from_ec2_to_ip.should == "72.44.36.12"
+    end
+    it "should be able to parse the date from the timestamp" do
+      "2008-11-13T09:33:09+0000".parse_datetime.should == DateTime.parse("2008-11-13T09:33:09+0000")
+    end
+    it "should rescue itself and just return the string if it fails" do
+      "thisisthedate".parse_datetime.should == "thisisthedate"
+    end
+  end
   describe "launching" do
     before(:each) do
       @tr.ec2.stub!(:run_instances).and_return true
@@ -39,8 +57,17 @@ describe "ec2 remote base" do
       @tr.ec2.should_receive(:run_instances).and_return true
       @tr.launch_new_instance!
     end
+    it "should use a specific security group if one is specified" do
+      @tr.stub!(:security_group).and_return "web"
+      @tr.ec2.should_receive(:run_instances).with(hash_including(:group_id => ['web'])).and_return true
+      @tr.launch_new_instance!      
+    end
+    it "should use the default security group if none is specified" do
+      @tr.ec2.should_receive(:run_instances).with(hash_including(:group_id => ['default'])).and_return true
+      @tr.launch_new_instance!      
+    end
     it "should get the hash response from EC2ResponseObject" do
-      EC2ResponseObject.should_receive(:get_hash_from_response).with(true).and_return true
+      EC2ResponseObject.should_receive(:get_hash_from_response).and_return true
       @tr.launch_new_instance!
     end
   end
@@ -89,4 +116,18 @@ describe "ec2 remote base" do
       @tr.create_keypair
     end
   end
+  describe "create_snapshot" do
+    # We can assume that create_snapshot on the ec2 gem works
+    before(:each) do
+      @tr.ec2.stub!(:create_snapshot).and_return nil
+    end
+    it "should create a snapshot of the current EBS volume" do
+      @tr.ec2.stub!(:create_snapshot).and_return {{"snapshotId" => "snap-123"}}
+      @tr.stub!(:ebs_volume_id).and_return "vol-123"
+      @tr.create_snapshot.should == {"snapshotId" => "snap-123"}
+    end
+    it "should not create a snapshot if there is no EBS volume" do
+      @tr.create_snapshot.should == nil
+    end
+  end
 end

data/spec/poolparty/net/remote_instance_spec.rb

@@ -4,6 +4,7 @@ include Remote
 
 describe "Remote Instance" do
   before(:each) do
+    setup
     @valid_hash = {:ip => "127.0.0.1", :name => "master", :responding => "true"}
   end
   describe "configurable" do
@@ -69,7 +70,7 @@ describe "Remote Instance" do
       @ri.respond_to?(:puppet_runner_command).should == true
     end
     it "should return the puppet_runner_command with puppetd" do
-      @ri.puppet_runner_command.should =~ /puppetd/
+      @ri.puppet_runner_command.should =~ /puppetrun/
     end
   end
 end