poniard 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b20dd7bc5a80523165730ffd2352ba33036988b2
-  data.tar.gz: 9eb61c3e74958ace02b6865bb2d6ae0ed443b3a4
+  metadata.gz: 9a48046036fef997cfa02d4949ce2a26b1468e47
+  data.tar.gz: 6b452b4fb1adb6349c8523aab280e87a7a9ec4ed
 SHA512:
-  metadata.gz: b5ec064ebc9ed82ca7b3dd47e1e321b062ef153f795513b86feb00d08b0f742cbae5f272dd2ddf4f2c01c2b0b62f62b57e735a8981f3f0eea43587c8eb700ec0
-  data.tar.gz: bb8251380ad780db82f9a15171ba543787d78a25ee4c1368beffab81070d7ea4ff235333b99b74470d413cc34ebd926ee35299f8f43729b490cfe564a03086b6
+  metadata.gz: 81ce29dd7b8e9d5a3a91bad63000cab890fd4372bb2a0202c0ed95998e93def8585a499ee21bcfbd92370f805a91115043e22e0a9544c665403b6ba518af1ae9
+  data.tar.gz: 3a66f8a893495a00f746b0bdf66ae5f02e7c6203867210df41498568fc2b494682583b8afcaf3342a0632ad3a8032e2b7f40b3e9187a6d399c037a26489a097c

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Poniard History
 
+## 1.0.1 - 4 May 2014
+
+* 30% speedup in method dispatch.
+
 ## 1.0.0 - 20 April 2014
 
 * `respond_with` returns 406 for unknown formats.

data/README.md

@@ -204,6 +204,11 @@ Developing
 Not widely used. May be some obvious things missing from built-in controller
 sources that you will have to add.
 
+As far as I know Poniard has not been used on any high traffic applications, and
+I wouldn't be surprised if there is a performance penalty for using it due to
+the use of reflection. Please benchmark (and share!) before using in such an
+environment.
+
 ### Compatibility
 
 Requires 1.9 or above.

data/lib/poniard/injector.rb

@@ -45,8 +45,10 @@ module Poniard
     private
 
     def dispatch_method(method, unknown_param_f, overrides = {})
+      sources = sources_for(overrides)
+
       args = method.parameters.map {|_, name|
-        source = sources_for(overrides).detect {|source|
+        source = sources.detect {|source|
           source.provides?(name)
         }
 

data/lib/poniard/version.rb

@@ -1,5 +1,5 @@
 # Top-level namespace for Poniard. See +README.md+ for library description.
 module Poniard
   # Current version of Poniard, in semantic versioning format.
-  VERSION = '1.0.0'
+  VERSION = '1.0.1'
 end

data/poniard.gemspec

@@ -23,5 +23,4 @@ Gem::Specification.new do |gem|
   gem.require_paths = ["lib"]
   gem.version       = Poniard::VERSION
   gem.has_rdoc      = false
-  gem.add_development_dependency 'rspec', '~> 2.11'
 end

data/spec/injector_spec.rb

@@ -8,7 +8,7 @@ describe Poniard::Injector do
   it 'calls a lambda' do
     called = false
     described_class.new([]).dispatch -> { called = true }
-    called.should == true
+    expect(called).to eq(true)
   end
 
   it 'calls a method' do
@@ -18,7 +18,9 @@ describe Poniard::Injector do
       end
     end.new
 
-    described_class.new([]).dispatch(object.method(:a_number)).should == 12345
+    actual = described_class.new([]).dispatch(object.method(:a_number))
+
+    expect(actual).to eq(12345)
   end
 
   it 'calls a method with a parameter provided by a source' do
@@ -26,7 +28,7 @@ describe Poniard::Injector do
     described_class.new([
       thing: thing
     ]).dispatch ->(thing) { called = thing }
-    called.should == thing
+    expect(called).to eq(thing)
   end
 
   it 'recursively injects sources' do
@@ -41,7 +43,7 @@ describe Poniard::Injector do
       {thing: thing},
       two_source
     ]).dispatch ->(two_things) { called = two_things }
-    called.should == [thing, thing]
+    expect(called).to eq([thing, thing])
   end
 
   it 'uses the first source that provides a parameter' do
@@ -50,7 +52,7 @@ describe Poniard::Injector do
       {thing: thing},
       {thing: nil}
     ]).dispatch ->(thing) { called = thing }
-    called.should == thing
+    expect(called).to eq(thing)
   end
 
   it 'allows sources to be overriden at dispatch' do
@@ -58,36 +60,36 @@ describe Poniard::Injector do
     described_class.new([
       {thing: nil}
     ]).dispatch ->(thing) { called = thing }, thing: thing
-    called.should == thing
+    expect(called).to eq(thing)
   end
 
   it 'provides itself as a source' do
     called = false
     injector = described_class.new
     injector.dispatch ->(injector) { called = injector }
-    called.should == injector
+    expect(called).to eq(injector)
   end
 
   it 'allows nil values in hash sources' do
     value = nil
     injector = described_class.new
     injector.dispatch ->(x) { value = x.nil? }, x: nil
-    value.should == true
+    expect(value).to eq(true)
   end
 
   it 'yields a fail object when source is unknown' do
     called = false
     m = ->(unknown) {
-      ->{
+      expect{
         unknown.bogus
-      }.should raise_error(
+      }.to raise_error(
         Poniard::UnknownParam,
         "Tried to call method on an uninjected param: unknown"
       )
       called = true
     }
     described_class.new.dispatch(m)
-    called.should be_true
+    expect(called).to eq(true)
   end
 
   describe '#eager_dispatch' do

metadata

@@ -1,29 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: poniard
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Xavier Shay
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-20 00:00:00.000000000 Z
-dependencies:
-- !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.11'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.11'
+date: 2014-05-04 00:00:00.000000000 Z
+dependencies: []
 description: A dependency injector for Rails, allows you to write clean controllers.
 email:
 - contact@xaviershay.com
@@ -63,7 +49,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.0
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: A dependency injector for Rails, allows you to write clean controllers.