pomo 2.0.1 → 2.0.2

data/.gitignore

@@ -15,3 +15,4 @@ spec/reports
 test/tmp
 test/version_tmp
 tmp
+.pomo

data/CONTRIBUTING.md

@@ -0,0 +1,20 @@
+We :heart: pull requests. Here's a quick guide:
+
+## Contributing
+
+1. Fork it
+2. Run the tests and make sure they pass :thumbsup: (`bundle && rake`)
+3. Add a test for your change
+4. Make the test pass
+5. Submit a pull request:
+    * Create your feature branch (`git checkout -b my-new-feature`)
+    * Commit your changes (`git commit -am 'Add some feature'`)
+    * Push to the branch (`git push origin my-new-feature`)
+    * Create new Pull Request
+
+## Guidelines
+
+* Include tests that fail without your code, but pass with your code
+* Follow coding conventions found in the current project
+* Update the documentation, examples, and/or anything that is
+affected by your contribution

data/HISTORY.md

@@ -1,3 +1,9 @@
+2.0.2 / 2012-12-18
+==================
+
+  * Fixed Growl support. Closes #29
+  * Removed unused configuration option `pomo_stat` from `.pomorc`
+
 2.0.1 / 2012-12-16
 ==================
 

data/README.md

@@ -1,4 +1,4 @@
-# Pomo
+# Pomo [![Code Climate](https://codeclimate.com/badge.png)](https://codeclimate.com/github/visionmedia/pomo)
 
 Command-line application for the [Pomodoro](http://www.pomodorotechnique.com/)
 time management technique, with notification and tmux status bar support.
@@ -180,10 +180,3 @@ and blue during a break e.g.
 
 ![tmux status bar](http://i.imgur.com/uIzM3.png)
 
-## Contributing
-
-1. Fork it
-2. Create your feature branch (`git checkout -b my-new-feature`)
-3. Commit your changes (`git commit -am 'Add some feature'`)
-4. Push to the branch (`git push origin my-new-feature`)
-5. Create new Pull Request

data/lib/pomo.rb

@@ -1,13 +1,15 @@
+require 'rbconfig'
+require 'pomo/os'
+require 'terminal-notifier' if Pomo::OS.mac?
+require 'growl'             if Pomo::OS.mac? || Pomo::OS.windows?
+require 'libnotify'         if Pomo::OS.linux?
 require 'yaml'
 require 'octokit'
-require 'terminal-notifier' if /darwin/ =~ RUBY_PLATFORM
-require 'growl'             if /darwin/ =~ RUBY_PLATFORM
-require 'libnotify'         if /linux/ =~ RUBY_PLATFORM
 require 'pomo/configuration'
 require 'pomo/notifier'
-require 'pomo/notifier/notification_center'
-require 'pomo/notifier/growl'
-require 'pomo/notifier/libnotify'
+require 'pomo/notifier/notification_center_notifier'
+require 'pomo/notifier/growl_notifier'
+require 'pomo/notifier/libnotify_notifier'
 require 'pomo/list'
 require 'pomo/task'
 require 'pomo/github_task'

data/lib/pomo/configuration.rb

@@ -1,14 +1,3 @@
-if RUBY_PLATFORM =~ /darwin/
-  MACOS_FULL_VERSION = `/usr/bin/sw_vers -productVersion`.chomp
-  MACOS_VERSION = /(10\.\d+)(\.\d+)?/.match(MACOS_FULL_VERSION).captures.first.to_f
-  OS_VERSION = "Mac OS X #{MACOS_FULL_VERSION}"
-  MACOS = true
-else
-  MACOS_FULL_VERSION = MACOS_VERSION = 0
-  OS_VERSION = RUBY_PLATFORM
-  MACOS = false
-end
-
 module Pomo
   class Configuration
     ##
@@ -18,13 +7,6 @@ module Pomo
 
     attr_reader :notifier
 
-    ##
-    # Write ~/.pomo_stat file.
-    #
-    # values: true | false
-
-    attr_accessor :pomo_stat
-
     ##
     # Refresh tmux status bar.
     #
@@ -37,7 +19,6 @@ module Pomo
     def initialize
       options = {
         :notifier  => default_notifier,
-        :pomo_stat => false,
         :tmux      => false
       }
 
@@ -52,21 +33,18 @@ module Pomo
       end
 
       @notifier  = options[:notifier]
-      @pomo_stat = options[:pomo_stat]
       @tmux      = options[:tmux]
     end
 
     private
 
     def default_notifier
-      if MACOS
-        if (10.8 <= MACOS_VERSION)
-          return 'notification_center'
-        else
-          return 'growl'
-        end
-      else
+      if Pomo::OS.has_notification_center?
+        return 'notification_center'
+      elsif Pomo::OS.linux?
         return 'libnotify'
+      else
+        return 'growl'
       end
     end
 

data/lib/pomo/notifier.rb

@@ -6,13 +6,13 @@ module Pomo
     # Initialize notifier library from configuration.
     def initialize(config)
       if config.notifier == 'notification_center'
-        @notifier = Pomo::Notifier::NotificationCenter.new
-      elsif config.notifier == 'libnotify'
-        @notifier = Pomo::Notifier::Growl.new
+        @notifier = Pomo::Notifier::NotificationCenterNotifier.new
       elsif config.notifier == 'growl'
-        @notifier = Pomo::Notifier::Libnotify.new
+        @notifier = Pomo::Notifier::GrowlNotifier.new
+      elsif config.notifier == 'libnotify'
+        @notifier = Pomo::Notifier::LibnotifyNotifier.new
       elsif config.notifier == 'quicksilver'
-        @notifier = Pomo::Notifier::Quicksilver.new
+        @notifier = Pomo::Notifier::QuicksilverNotifier.new
       end
     end
 

data/lib/pomo/notifier/{growl.rb → growl_notifier.rb}

@@ -1,7 +1,7 @@
 
 module Pomo
   class Notifier
-    class Growl
+    class GrowlNotifier
       def notify(message, opts = {})
         full_message = [opts[:header], opts[:message]].join(' ').lstrip
 

data/lib/pomo/notifier/{libnotify.rb → libnotify_notifier.rb}

@@ -1,7 +1,7 @@
 
 module Pomo
   class Notifier
-    class Libnotify
+    class LibnotifyNotifier
       def notify(message, opts = {})
         title = 'Pomo'
         full_message = [opts[:header], opts[:message]].join(' ').lstrip

data/lib/pomo/notifier/{notification_center.rb → notification_center_notifier.rb}

@@ -1,7 +1,7 @@
 
 module Pomo
   class Notifier
-    class NotificationCenter
+    class NotificationCenterNotifier
       def notify(message, opts = {})
         title = 'Pomo'
 

data/lib/pomo/notifier/{quicksilver.rb → quicksilver_notifier.rb}

@@ -1,7 +1,7 @@
 
 module Pomo
   class Notifier
-    class Quicksilver
+    class QuicksilverNotifier
       def notify(message, opts = {})
         `osascript -e 'tell application "Quicksilver" to show large type "#{message.gsub('"', '\"')}"'`
       end

data/lib/pomo/os.rb

@@ -0,0 +1,26 @@
+module Pomo
+  module OS
+    module_function
+
+    def linux?
+      (/linux/ =~ RbConfig::CONFIG['host_os']) !=nil
+    end
+
+    def mac?
+      (/mac|darwin/ =~ RbConfig::CONFIG['host_os']) != nil
+    end
+
+    def windows?
+      (/cygwin|mswin|mingw|bccwin|wince|emx/ =~ RbConfig::CONFIG['host_os']) != nil
+    end
+
+    def has_notification_center?
+      return false unless OS.mac?
+
+      full_version = `/usr/bin/sw_vers -productVersion`.to_s.chomp
+      version = /(10\.\d+)(\.\d+)?/.match(full_version).captures.first.to_f
+      return (version >= 10.8)
+    end
+
+  end
+end

data/lib/pomo/version.rb

@@ -1,4 +1,4 @@
 
 module Pomo
-  VERSION = '2.0.1'
+  VERSION = '2.0.2'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pomo
 version: !ruby/object:Gem::Version
-  version: 2.0.1
+  version: 2.0.2
   prerelease: 
 platform: ruby
 authors:
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-12-16 00:00:00.000000000 Z
+date: 2012-12-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: commander
@@ -102,6 +102,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - .gitignore
+- CONTRIBUTING.md
 - DEVELOPMENT
 - Gemfile
 - HISTORY.md
@@ -115,10 +116,11 @@ files:
 - lib/pomo/github_task.rb
 - lib/pomo/list.rb
 - lib/pomo/notifier.rb
-- lib/pomo/notifier/growl.rb
-- lib/pomo/notifier/libnotify.rb
-- lib/pomo/notifier/notification_center.rb
-- lib/pomo/notifier/quicksilver.rb
+- lib/pomo/notifier/growl_notifier.rb
+- lib/pomo/notifier/libnotify_notifier.rb
+- lib/pomo/notifier/notification_center_notifier.rb
+- lib/pomo/notifier/quicksilver_notifier.rb
+- lib/pomo/os.rb
 - lib/pomo/task.rb
 - lib/pomo/version.rb
 - pomo.gemspec
@@ -153,7 +155,7 @@ rubyforge_project: pomo
 rubygems_version: 1.8.24
 signing_key: 
 specification_version: 3
-summary: pomo-2.0.1
+summary: pomo-2.0.2
 test_files:
 - spec/pomo_spec.rb
 - spec/spec_helper.rb