polyphony 0.73.1 → 0.77

data/ext/polyphony/backend_io_uring.c

@@ -42,6 +42,7 @@ typedef struct Backend_t {
   unsigned int        pending_sqes;
   unsigned int        prepared_limit;
   int                 event_fd;
+  int                 ring_initialized;
 } Backend_t;
 
 static void Backend_mark(void *ptr) {
@@ -80,20 +81,32 @@ static VALUE Backend_initialize(VALUE self) {
 
   backend_base_initialize(&backend->base);
   backend->pending_sqes = 0;
-  backend->prepared_limit = 2048;
+  backend->ring_initialized = 0;
+  backend->event_fd = -1;
 
   context_store_initialize(&backend->store);
-  io_uring_queue_init(backend->prepared_limit, &backend->ring, 0);
-  backend->event_fd = -1;
 
-  return Qnil;
+  backend->prepared_limit = 1024;
+  while (1) {
+    int ret = io_uring_queue_init(backend->prepared_limit, &backend->ring, 0);
+    if (!ret) break;
+    
+    // if ENOMEM is returned, use a smaller limit
+    if (ret == -ENOMEM && backend->prepared_limit > 64)
+      backend->prepared_limit = backend->prepared_limit / 2;
+    else
+      rb_syserr_fail(-ret, strerror(-ret));
+  }
+  backend->ring_initialized = 1;
+
+  return self;
 }
 
 VALUE Backend_finalize(VALUE self) {
   Backend_t *backend;
   GetBackend(self, backend);
 
-  io_uring_queue_exit(&backend->ring);
+  if (backend->ring_initialized) io_uring_queue_exit(&backend->ring);
   if (backend->event_fd != -1) close(backend->event_fd);
   context_store_free(&backend->store);
   return self;
@@ -178,10 +191,14 @@ void io_uring_backend_poll(Backend_t *backend) {
     io_uring_submit(&backend->ring);
   }
 
+wait_cqe:
   backend->base.currently_polling = 1;
   rb_thread_call_without_gvl(io_uring_backend_poll_without_gvl, (void *)&poll_ctx, RUBY_UBF_IO, 0);
   backend->base.currently_polling = 0;
-  if (poll_ctx.result < 0) return;
+  if (poll_ctx.result < 0) {
+    if (poll_ctx.result == -EINTR && runqueue_empty_p(&backend->base.runqueue)) goto wait_cqe;
+    return;
+  }
 
   io_uring_backend_handle_completion(poll_ctx.cqe, backend);
   io_uring_cqe_seen(&backend->ring, poll_ctx.cqe);
@@ -282,9 +299,11 @@ int io_uring_backend_defer_submit_and_await(
   switchpoint_result = backend_await((struct Backend_base *)backend);
 
   if (ctx->ref_count > 1) {
+    struct io_uring_sqe *sqe;
+
     // op was not completed (an exception was raised), so we need to cancel it
     ctx->result = -ECANCELED;
-    struct io_uring_sqe *sqe = io_uring_get_sqe(&backend->ring);
+    sqe = io_uring_get_sqe(&backend->ring);
     io_uring_prep_cancel(sqe, ctx, 0);
     backend->pending_sqes = 0;
     io_uring_submit(&backend->ring);
@@ -316,16 +335,20 @@ VALUE Backend_read(VALUE self, VALUE io, VALUE str, VALUE length, VALUE to_eof,
   long dynamic_len = length == Qnil;
   long buffer_size = dynamic_len ? 4096 : NUM2INT(length);
   long buf_pos = NUM2INT(pos);
+  int shrinkable;
+  char *buf;
+  long total = 0;
+  int read_to_eof = RTEST(to_eof);
+  VALUE underlying_io = rb_ivar_get(io, ID_ivar_io);
+
+
   if (str != Qnil) {
     int current_len = RSTRING_LEN(str);
     if (buf_pos < 0 || buf_pos > current_len) buf_pos = current_len;
   }
   else buf_pos = 0;
-  int shrinkable = io_setstrbuf(&str, buf_pos + buffer_size);
-  char *buf = RSTRING_PTR(str) + buf_pos;
-  long total = 0;
-  int read_to_eof = RTEST(to_eof);
-  VALUE underlying_io = rb_ivar_get(io, ID_ivar_io);
+  shrinkable = io_setstrbuf(&str, buf_pos + buffer_size);
+  buf = RSTRING_PTR(str) + buf_pos;
 
   GetBackend(self, backend);
   if (underlying_io != Qnil) io = underlying_io;
@@ -338,10 +361,13 @@ VALUE Backend_read(VALUE self, VALUE io, VALUE str, VALUE length, VALUE to_eof,
     VALUE resume_value = Qnil;
     op_context_t *ctx = context_store_acquire(&backend->store, OP_READ);
     struct io_uring_sqe *sqe = io_uring_get_sqe(&backend->ring);
+    int result;
+    int completed;
+    
     io_uring_prep_read(sqe, fptr->fd, buf, buffer_size - total, -1);
 
-    int result = io_uring_backend_defer_submit_and_await(backend, sqe, ctx, &resume_value);
-    int completed = context_store_release(&backend->store, ctx);
+    result = io_uring_backend_defer_submit_and_await(backend, sqe, ctx, &resume_value);
+    completed = context_store_release(&backend->store, ctx);
     if (!completed) {
       context_attach_buffers(ctx, 1, &str);
       RAISE_IF_EXCEPTION(resume_value);
@@ -402,10 +428,13 @@ VALUE Backend_read_loop(VALUE self, VALUE io, VALUE maxlen) {
     VALUE resume_value = Qnil;
     op_context_t *ctx = context_store_acquire(&backend->store, OP_READ);
     struct io_uring_sqe *sqe = io_uring_get_sqe(&backend->ring);
+    ssize_t result;
+    int completed;
+
     io_uring_prep_read(sqe, fptr->fd, buf, len, -1);
 
-    ssize_t result = io_uring_backend_defer_submit_and_await(backend, sqe, ctx, &resume_value);
-    int completed = context_store_release(&backend->store, ctx);
+    result = io_uring_backend_defer_submit_and_await(backend, sqe, ctx, &resume_value);
+    completed = context_store_release(&backend->store, ctx);
     if (!completed) {
       context_attach_buffers(ctx, 1, &str);
       RAISE_IF_EXCEPTION(resume_value);
@@ -452,10 +481,13 @@ VALUE Backend_feed_loop(VALUE self, VALUE io, VALUE receiver, VALUE method) {
     VALUE resume_value = Qnil;
     op_context_t *ctx = context_store_acquire(&backend->store, OP_READ);
     struct io_uring_sqe *sqe = io_uring_get_sqe(&backend->ring);
+    ssize_t result;
+    int completed;
+
     io_uring_prep_read(sqe, fptr->fd, buf, len, -1);
 
-    ssize_t result = io_uring_backend_defer_submit_and_await(backend, sqe, ctx, &resume_value);
-    int completed = context_store_release(&backend->store, ctx);
+    result = io_uring_backend_defer_submit_and_await(backend, sqe, ctx, &resume_value);
+    completed = context_store_release(&backend->store, ctx);
     if (!completed) {
       context_attach_buffers(ctx, 1, &str);
       RAISE_IF_EXCEPTION(resume_value);
@@ -482,6 +514,9 @@ VALUE Backend_write(VALUE self, VALUE io, VALUE str) {
   Backend_t *backend;
   rb_io_t *fptr;
   VALUE underlying_io;
+  char *buf = StringValuePtr(str);
+  long len = RSTRING_LEN(str);
+  long left = len;
 
   underlying_io = rb_ivar_get(io, ID_ivar_io);
   if (underlying_io != Qnil) io = underlying_io;
@@ -490,18 +525,17 @@ VALUE Backend_write(VALUE self, VALUE io, VALUE str) {
   GetOpenFile(io, fptr);
   io_unset_nonblock(fptr, io);
 
-  char *buf = StringValuePtr(str);
-  long len = RSTRING_LEN(str);
-  long left = len;
-
   while (left > 0) {
     VALUE resume_value = Qnil;
     op_context_t *ctx = context_store_acquire(&backend->store, OP_WRITE);
     struct io_uring_sqe *sqe = io_uring_get_sqe(&backend->ring);
+    int result;
+    int completed;
+
     io_uring_prep_write(sqe, fptr->fd, buf, left, 0);
 
-    int result = io_uring_backend_defer_submit_and_await(backend, sqe, ctx, &resume_value);
-    int completed = context_store_release(&backend->store, ctx);
+    result = io_uring_backend_defer_submit_and_await(backend, sqe, ctx, &resume_value);
+    completed = context_store_release(&backend->store, ctx);
     if (!completed) {
       context_attach_buffers(ctx, 1, &str);
       RAISE_IF_EXCEPTION(resume_value);
@@ -550,10 +584,13 @@ VALUE Backend_writev(VALUE self, VALUE io, int argc, VALUE *argv) {
     VALUE resume_value = Qnil;
     op_context_t *ctx = context_store_acquire(&backend->store, OP_WRITEV);
     struct io_uring_sqe *sqe = io_uring_get_sqe(&backend->ring);
+    int result;
+    int completed;
+
     io_uring_prep_writev(sqe, fptr->fd, iov_ptr, iov_count, -1);
 
-    int result = io_uring_backend_defer_submit_and_await(backend, sqe, ctx, &resume_value);
-    int completed = context_store_release(&backend->store, ctx);
+    result = io_uring_backend_defer_submit_and_await(backend, sqe, ctx, &resume_value);
+    completed = context_store_release(&backend->store, ctx);
     if (!completed) {
       free(iov);
       context_attach_buffers(ctx, argc, argv);
@@ -604,15 +641,18 @@ VALUE Backend_recv(VALUE self, VALUE io, VALUE str, VALUE length, VALUE pos) {
   long dynamic_len = length == Qnil;
   long len = dynamic_len ? 4096 : NUM2INT(length);
   long buf_pos = NUM2INT(pos);
+  int shrinkable;
+  char *buf;
+  long total = 0;
+  VALUE underlying_io = rb_ivar_get(io, ID_ivar_io);;
+
   if (str != Qnil) {
     int current_len = RSTRING_LEN(str);
     if (buf_pos < 0 || buf_pos > current_len) buf_pos = current_len;
   }
   else buf_pos = 0;
-  int shrinkable = io_setstrbuf(&str, buf_pos + len);
-  char *buf = RSTRING_PTR(str) + buf_pos;
-  long total = 0;
-  VALUE underlying_io = rb_ivar_get(io, ID_ivar_io);
+  shrinkable = io_setstrbuf(&str, buf_pos + len);
+  buf = RSTRING_PTR(str) + buf_pos;
 
   GetBackend(self, backend);
   if (underlying_io != Qnil) io = underlying_io;
@@ -625,10 +665,13 @@ VALUE Backend_recv(VALUE self, VALUE io, VALUE str, VALUE length, VALUE pos) {
     VALUE resume_value = Qnil;
     op_context_t *ctx = context_store_acquire(&backend->store, OP_RECV);
     struct io_uring_sqe *sqe = io_uring_get_sqe(&backend->ring);
+    int result;
+    int completed;
+
     io_uring_prep_recv(sqe, fptr->fd, buf, len - total, 0);
 
-    int result = io_uring_backend_defer_submit_and_await(backend, sqe, ctx, &resume_value);
-    int completed = context_store_release(&backend->store, ctx);
+    result = io_uring_backend_defer_submit_and_await(backend, sqe, ctx, &resume_value);
+    completed = context_store_release(&backend->store, ctx);
     if (!completed) {
       context_attach_buffers(ctx, 1, &str);
       RAISE_IF_EXCEPTION(resume_value);
@@ -675,10 +718,13 @@ VALUE Backend_recv_loop(VALUE self, VALUE io, VALUE maxlen) {
     VALUE resume_value = Qnil;
     op_context_t *ctx = context_store_acquire(&backend->store, OP_RECV);
     struct io_uring_sqe *sqe = io_uring_get_sqe(&backend->ring);
+    int result;
+    int completed;
+
     io_uring_prep_recv(sqe, fptr->fd, buf, len, 0);
 
-    int result = io_uring_backend_defer_submit_and_await(backend, sqe, ctx, &resume_value);
-    int completed = context_store_release(&backend->store, ctx);
+    result = io_uring_backend_defer_submit_and_await(backend, sqe, ctx, &resume_value);
+    completed = context_store_release(&backend->store, ctx);
     if (!completed) {
       context_attach_buffers(ctx, 1, &str);
       RAISE_IF_EXCEPTION(resume_value);
@@ -724,10 +770,13 @@ VALUE Backend_recv_feed_loop(VALUE self, VALUE io, VALUE receiver, VALUE method)
     VALUE resume_value = Qnil;
     op_context_t *ctx = context_store_acquire(&backend->store, OP_RECV);
     struct io_uring_sqe *sqe = io_uring_get_sqe(&backend->ring);
+    int result;
+    int completed;
+
     io_uring_prep_recv(sqe, fptr->fd, buf, len, 0);
 
-    int result = io_uring_backend_defer_submit_and_await(backend, sqe, ctx, &resume_value);
-    int completed = context_store_release(&backend->store, ctx);
+    result = io_uring_backend_defer_submit_and_await(backend, sqe, ctx, &resume_value);
+    completed = context_store_release(&backend->store, ctx);
     if (!completed) {
       context_attach_buffers(ctx, 1, &str);
       RAISE_IF_EXCEPTION(resume_value);
@@ -753,6 +802,10 @@ VALUE Backend_send(VALUE self, VALUE io, VALUE str, VALUE flags) {
   Backend_t *backend;
   rb_io_t *fptr;
   VALUE underlying_io;
+  char *buf;
+  long len;
+  long left;
+  int flags_int;
 
   underlying_io = rb_ivar_get(io, ID_ivar_io);
   if (underlying_io != Qnil) io = underlying_io;
@@ -761,19 +814,22 @@ VALUE Backend_send(VALUE self, VALUE io, VALUE str, VALUE flags) {
   GetOpenFile(io, fptr);
   io_unset_nonblock(fptr, io);
 
-  char *buf = StringValuePtr(str);
-  long len = RSTRING_LEN(str);
-  long left = len;
-  int flags_int = NUM2INT(flags);
+  buf = StringValuePtr(str);
+  len = RSTRING_LEN(str);
+  left = len;
+  flags_int = NUM2INT(flags);
 
   while (left > 0) {
     VALUE resume_value = Qnil;
     op_context_t *ctx = context_store_acquire(&backend->store, OP_SEND);
     struct io_uring_sqe *sqe = io_uring_get_sqe(&backend->ring);
+    int result;
+    int completed;
+
     io_uring_prep_send(sqe, fptr->fd, buf, left, flags_int);
 
-    int result = io_uring_backend_defer_submit_and_await(backend, sqe, ctx, &resume_value);
-    int completed = context_store_release(&backend->store, ctx);
+    result = io_uring_backend_defer_submit_and_await(backend, sqe, ctx, &resume_value);
+    completed = context_store_release(&backend->store, ctx);
     if (!completed) {
       context_attach_buffers(ctx, 1, &str);
       RAISE_IF_EXCEPTION(resume_value);
@@ -807,10 +863,13 @@ VALUE io_uring_backend_accept(Backend_t *backend, VALUE server_socket, VALUE soc
     VALUE resume_value = Qnil;
     op_context_t *ctx = context_store_acquire(&backend->store, OP_ACCEPT);
     struct io_uring_sqe *sqe = io_uring_get_sqe(&backend->ring);
+    int fd;
+    int completed;
+
     io_uring_prep_accept(sqe, fptr->fd, &addr, &len, 0);
 
-    int fd = io_uring_backend_defer_submit_and_await(backend, sqe, ctx, &resume_value);
-    int completed = context_store_release(&backend->store, ctx);
+    fd = io_uring_backend_defer_submit_and_await(backend, sqe, ctx, &resume_value);
+    completed = context_store_release(&backend->store, ctx);
     RAISE_IF_EXCEPTION(resume_value);
     if (!completed) return resume_value;
     RB_GC_GUARD(resume_value);
@@ -861,6 +920,7 @@ VALUE io_uring_backend_splice(Backend_t *backend, VALUE src, VALUE dest, VALUE m
   rb_io_t *dest_fptr;
   VALUE underlying_io;
   int total = 0;
+  VALUE resume_value = Qnil;
 
   underlying_io = rb_ivar_get(src, ID_ivar_io);
   if (underlying_io != Qnil) src = underlying_io;
@@ -873,15 +933,16 @@ VALUE io_uring_backend_splice(Backend_t *backend, VALUE src, VALUE dest, VALUE m
   GetOpenFile(dest, dest_fptr);
   io_unset_nonblock(dest_fptr, dest);
 
-  VALUE resume_value = Qnil;
-
   while (1) {
     op_context_t *ctx = context_store_acquire(&backend->store, OP_SPLICE);
     struct io_uring_sqe *sqe = io_uring_get_sqe(&backend->ring);
+    int result;
+    int completed;
+
     io_uring_prep_splice(sqe, src_fptr->fd, -1, dest_fptr->fd, -1, NUM2INT(maxlen), 0);
 
-    int result = io_uring_backend_defer_submit_and_await(backend, sqe, ctx, &resume_value);
-    int completed = context_store_release(&backend->store, ctx);
+    result = io_uring_backend_defer_submit_and_await(backend, sqe, ctx, &resume_value);
+    completed = context_store_release(&backend->store, ctx);
     RAISE_IF_EXCEPTION(resume_value);
     if (!completed) return resume_value;
 
@@ -909,29 +970,31 @@ VALUE Backend_splice_to_eof(VALUE self, VALUE src, VALUE dest, VALUE chunksize)
   return io_uring_backend_splice(backend, src, dest, chunksize, 1);
 }
 
-
 VALUE Backend_connect(VALUE self, VALUE sock, VALUE host, VALUE port) {
   Backend_t *backend;
   rb_io_t *fptr;
-  struct sockaddr_in addr;
-  char *host_buf = StringValueCStr(host);
+  struct sockaddr *ai_addr;
+  int ai_addrlen;
   VALUE underlying_sock = rb_ivar_get(sock, ID_ivar_io);
+  VALUE resume_value = Qnil;
+  op_context_t *ctx;
+  struct io_uring_sqe *sqe;
+  int result;
+  int completed;
+
+  ai_addrlen = backend_getaddrinfo(host, port, &ai_addr);
+
   if (underlying_sock != Qnil) sock = underlying_sock;
 
   GetBackend(self, backend);
   GetOpenFile(sock, fptr);
   io_unset_nonblock(fptr, sock);
 
-  addr.sin_family = AF_INET;
-  addr.sin_addr.s_addr = inet_addr(host_buf);
-  addr.sin_port = htons(NUM2INT(port));
-
-  VALUE resume_value = Qnil;
-  op_context_t *ctx = context_store_acquire(&backend->store, OP_CONNECT);
-  struct io_uring_sqe *sqe = io_uring_get_sqe(&backend->ring);
-  io_uring_prep_connect(sqe, fptr->fd, (struct sockaddr *)&addr, sizeof(addr));
-  int result = io_uring_backend_defer_submit_and_await(backend, sqe, ctx, &resume_value);
-  int completed = context_store_release(&backend->store, ctx);
+  ctx = context_store_acquire(&backend->store, OP_CONNECT);
+  sqe = io_uring_get_sqe(&backend->ring);
+  io_uring_prep_connect(sqe, fptr->fd, ai_addr, ai_addrlen);
+  result = io_uring_backend_defer_submit_and_await(backend, sqe, ctx, &resume_value);
+  completed = context_store_release(&backend->store, ctx);
   RAISE_IF_EXCEPTION(resume_value);
   if (!completed) return resume_value;
   RB_GC_GUARD(resume_value);
@@ -944,17 +1007,54 @@ VALUE Backend_wait_io(VALUE self, VALUE io, VALUE write) {
   Backend_t *backend;
   rb_io_t *fptr;
   VALUE underlying_io = rb_ivar_get(io, ID_ivar_io);
+  VALUE resume_value;
+
   if (underlying_io != Qnil) io = underlying_io;
   GetBackend(self, backend);
   GetOpenFile(io, fptr);
   io_unset_nonblock(fptr, io);
 
-  VALUE resume_value = io_uring_backend_wait_fd(backend, fptr->fd, RTEST(write));
+  resume_value = io_uring_backend_wait_fd(backend, fptr->fd, RTEST(write));
+
   RAISE_IF_EXCEPTION(resume_value);
   RB_GC_GUARD(resume_value);
   return self;
 }
 
+// VALUE Backend_close(VALUE self, VALUE io) {
+//   Backend_t *backend;
+//   rb_io_t *fptr;
+//   VALUE underlying_io = rb_ivar_get(io, ID_ivar_io);
+//   VALUE resume_value = Qnil;
+//   op_context_t *ctx;
+//   struct io_uring_sqe *sqe;
+//   int result;
+//   int completed;
+
+//   if (underlying_io != Qnil) io = underlying_io;
+//   GetBackend(self, backend);
+//   GetOpenFile(io, fptr);
+
+//   if (fptr->fd < 0) return Qnil;
+
+//   io_unset_nonblock(fptr, io);
+
+//   ctx = context_store_acquire(&backend->store, OP_CLOSE);
+//   sqe = io_uring_get_sqe(&backend->ring);
+//   io_uring_prep_close(sqe, fptr->fd);
+//   result = io_uring_backend_defer_submit_and_await(backend, sqe, ctx, &resume_value);
+//   completed = context_store_release(&backend->store, ctx);
+//   RAISE_IF_EXCEPTION(resume_value);
+//   if (!completed) return resume_value;
+//   RB_GC_GUARD(resume_value);
+
+//   if (result < 0) rb_syserr_fail(-result, strerror(-result));
+
+//   fptr_finalize(fptr);
+//   // fptr->fd = -1;
+//   return io;
+// }
+
 inline struct __kernel_timespec double_to_timespec(double duration) {
   double duration_integral;
   double duration_fraction = modf(duration, &duration_integral);
@@ -972,18 +1072,18 @@ inline struct __kernel_timespec duration_to_timespec(VALUE duration) {
 int io_uring_backend_submit_timeout_and_await(Backend_t *backend, double duration, VALUE *resume_value) {
   struct __kernel_timespec ts = double_to_timespec(duration);
   struct io_uring_sqe *sqe = io_uring_get_sqe(&backend->ring);
-
   op_context_t *ctx = context_store_acquire(&backend->store, OP_TIMEOUT);
+  
   io_uring_prep_timeout(sqe, &ts, 0, 0);
   io_uring_backend_defer_submit_and_await(backend, sqe, ctx, resume_value);
   return context_store_release(&backend->store, ctx);
 }
 
 VALUE Backend_sleep(VALUE self, VALUE duration) {
+  VALUE resume_value = Qnil;
   Backend_t *backend;
   GetBackend(self, backend);
 
-  VALUE resume_value = Qnil;
   io_uring_backend_submit_timeout_and_await(backend, NUM2DBL(duration), &resume_value);
   RAISE_IF_EXCEPTION(resume_value);
   RB_GC_GUARD(resume_value);
@@ -1028,12 +1128,13 @@ struct Backend_timeout_ctx {
 };
 
 VALUE Backend_timeout_ensure(VALUE arg) {
-    struct Backend_timeout_ctx *timeout_ctx = (struct Backend_timeout_ctx *)arg;
-    if (timeout_ctx->ctx->ref_count) {
-    timeout_ctx->ctx->result = -ECANCELED;
+  struct Backend_timeout_ctx *timeout_ctx = (struct Backend_timeout_ctx *)arg;
+  if (timeout_ctx->ctx->ref_count) {
+    struct io_uring_sqe *sqe;
 
+    timeout_ctx->ctx->result = -ECANCELED;
     // op was not completed, so we need to cancel it
-    struct io_uring_sqe *sqe = io_uring_get_sqe(&timeout_ctx->backend->ring);
+    sqe = io_uring_get_sqe(&timeout_ctx->backend->ring);
     io_uring_prep_cancel(sqe, timeout_ctx->ctx, 0);
     timeout_ctx->backend->pending_sqes = 0;
     io_uring_submit(&timeout_ctx->backend->ring);
@@ -1046,24 +1147,30 @@ VALUE Backend_timeout(int argc, VALUE *argv, VALUE self) {
   VALUE duration;
   VALUE exception;
   VALUE move_on_value = Qnil;
-  rb_scan_args(argc, argv, "21", &duration, &exception, &move_on_value);
-
-  struct __kernel_timespec ts = duration_to_timespec(duration);
+  struct Backend_timeout_ctx timeout_ctx;
+  op_context_t *ctx;
+  struct io_uring_sqe *sqe;
   Backend_t *backend;
-  GetBackend(self, backend);
+  struct __kernel_timespec ts;
   VALUE result = Qnil;
-  VALUE timeout = rb_funcall(cTimeoutException, ID_new, 0);
+  VALUE timeout;
 
-  struct io_uring_sqe *sqe = io_uring_get_sqe(&backend->ring);
+  rb_scan_args(argc, argv, "21", &duration, &exception, &move_on_value);
 
-  op_context_t *ctx = context_store_acquire(&backend->store, OP_TIMEOUT);
+  ts = duration_to_timespec(duration);
+  GetBackend(self, backend);
+  timeout = rb_funcall(cTimeoutException, ID_new, 0);
+
+  sqe = io_uring_get_sqe(&backend->ring);
+  ctx = context_store_acquire(&backend->store, OP_TIMEOUT);
   ctx->resume_value = timeout;
   io_uring_prep_timeout(sqe, &ts, 0, 0);
   io_uring_sqe_set_data(sqe, ctx);
   io_uring_backend_defer_submit(backend);
   backend->base.op_count++;
 
-  struct Backend_timeout_ctx timeout_ctx = {backend, ctx};
+  timeout_ctx.backend = backend;
+  timeout_ctx.ctx = ctx;
   result = rb_ensure(Backend_timeout_ensure_safe, Qnil, Backend_timeout_ensure, (VALUE)&timeout_ctx);
 
   if (result == timeout) {
@@ -1080,19 +1187,21 @@ VALUE Backend_timeout(int argc, VALUE *argv, VALUE self) {
 VALUE Backend_waitpid(VALUE self, VALUE pid) {
   int pid_int = NUM2INT(pid);
   int fd = pidfd_open(pid_int, 0);
+  int status;
+  pid_t ret;
 
   if (fd >= 0) {
+    VALUE resume_value;
     Backend_t *backend;
     GetBackend(self, backend);
 
-    VALUE resume_value = io_uring_backend_wait_fd(backend, fd, 0);
+    resume_value = io_uring_backend_wait_fd(backend, fd, 0);
     close(fd);
     RAISE_IF_EXCEPTION(resume_value);
     RB_GC_GUARD(resume_value);
   }
 
-  int status;
-  pid_t ret = waitpid(pid_int, &status, WNOHANG);
+  ret = waitpid(pid_int, &status, WNOHANG);
   if (ret < 0) {
     int e = errno;
     if (e == ECHILD)
@@ -1105,6 +1214,8 @@ VALUE Backend_waitpid(VALUE self, VALUE pid) {
 
 VALUE Backend_wait_event(VALUE self, VALUE raise) {
   Backend_t *backend;
+  VALUE resume_value;
+
   GetBackend(self, backend);
 
   if (backend->event_fd == -1) {
@@ -1115,7 +1226,7 @@ VALUE Backend_wait_event(VALUE self, VALUE raise) {
     }
   }
 
-  VALUE resume_value = io_uring_backend_wait_fd(backend, backend->event_fd, 0);
+  resume_value = io_uring_backend_wait_fd(backend, backend->event_fd, 0);
   if (RTEST(raise)) RAISE_IF_EXCEPTION(resume_value);
   RB_GC_GUARD(resume_value);
   return resume_value;
@@ -1128,6 +1239,7 @@ VALUE Backend_kind(VALUE self) {
 struct io_uring_sqe *Backend_chain_prepare_write(Backend_t *backend, VALUE io, VALUE str) {
   rb_io_t *fptr;
   VALUE underlying_io;
+  struct io_uring_sqe *sqe;
 
   underlying_io = rb_ivar_get(io, ID_ivar_io);
   if (underlying_io != Qnil) io = underlying_io;
@@ -1135,17 +1247,15 @@ struct io_uring_sqe *Backend_chain_prepare_write(Backend_t *backend, VALUE io, V
   GetOpenFile(io, fptr);
   io_unset_nonblock(fptr, io);
 
-  char *buf = StringValuePtr(str);
-  long len = RSTRING_LEN(str);
-
-  struct io_uring_sqe *sqe = io_uring_get_sqe(&backend->ring);
-  io_uring_prep_write(sqe, fptr->fd, buf, len, 0);
+  sqe = io_uring_get_sqe(&backend->ring);
+  io_uring_prep_write(sqe, fptr->fd, StringValuePtr(str), RSTRING_LEN(str), 0);
   return sqe;
 }
 
 struct io_uring_sqe *Backend_chain_prepare_send(Backend_t *backend, VALUE io, VALUE str, VALUE flags) {
   rb_io_t *fptr;
   VALUE underlying_io;
+  struct io_uring_sqe *sqe;
 
   underlying_io = rb_ivar_get(io, ID_ivar_io);
   if (underlying_io != Qnil) io = underlying_io;
@@ -1153,12 +1263,8 @@ struct io_uring_sqe *Backend_chain_prepare_send(Backend_t *backend, VALUE io, VA
   GetOpenFile(io, fptr);
   io_unset_nonblock(fptr, io);
 
-  char *buf = StringValuePtr(str);
-  long len = RSTRING_LEN(str);
-  int flags_int = NUM2INT(flags);
-
-  struct io_uring_sqe *sqe = io_uring_get_sqe(&backend->ring);
-  io_uring_prep_send(sqe, fptr->fd, buf, len, flags_int);
+  sqe = io_uring_get_sqe(&backend->ring);
+  io_uring_prep_send(sqe, fptr->fd, StringValuePtr(str), RSTRING_LEN(str), NUM2INT(flags));
   return sqe;
 }
 
@@ -1166,6 +1272,7 @@ struct io_uring_sqe *Backend_chain_prepare_splice(Backend_t *backend, VALUE src,
   rb_io_t *src_fptr;
   rb_io_t *dest_fptr;
   VALUE underlying_io;
+  struct io_uring_sqe *sqe;
 
   underlying_io = rb_ivar_get(src, ID_ivar_io);
   if (underlying_io != Qnil) src = underlying_io;
@@ -1178,7 +1285,7 @@ struct io_uring_sqe *Backend_chain_prepare_splice(Backend_t *backend, VALUE src,
   GetOpenFile(dest, dest_fptr);
   io_unset_nonblock(dest_fptr, dest);
 
-  struct io_uring_sqe *sqe = io_uring_get_sqe(&backend->ring);
+  sqe = io_uring_get_sqe(&backend->ring);
   io_uring_prep_splice(sqe, src_fptr->fd, -1, dest_fptr->fd, -1, NUM2INT(maxlen), 0);
   return sqe;
 }
@@ -1206,14 +1313,19 @@ VALUE Backend_chain(int argc,VALUE *argv, VALUE self) {
   unsigned int sqe_count = 0;
   struct io_uring_sqe *last_sqe = 0;
   Backend_t *backend;
+  int result;
+  int completed;
+  op_context_t *ctx;
+
   GetBackend(self, backend);
   if (argc == 0) return resume_value;
 
-  op_context_t *ctx = context_store_acquire(&backend->store, OP_CHAIN);
+  ctx = context_store_acquire(&backend->store, OP_CHAIN);
   for (int i = 0; i < argc; i++) {
     VALUE op = argv[i];
     VALUE op_type = RARRAY_AREF(op, 0);
     VALUE op_len = RARRAY_LEN(op);
+    unsigned int flags;
 
     if (op_type == SYM_write && op_len == 3) {
       last_sqe = Backend_chain_prepare_write(backend, RARRAY_AREF(op, 1), RARRAY_AREF(op, 2));
@@ -1223,13 +1335,16 @@ VALUE Backend_chain(int argc,VALUE *argv, VALUE self) {
     else if (op_type == SYM_splice && op_len == 4)
       last_sqe = Backend_chain_prepare_splice(backend, RARRAY_AREF(op, 1), RARRAY_AREF(op, 2), RARRAY_AREF(op, 3));
     else {
+
       if (sqe_count) {
+        struct io_uring_sqe *sqe;
+        
         io_uring_sqe_set_data(last_sqe, ctx);
         io_uring_sqe_set_flags(last_sqe, IOSQE_ASYNC);
 
         ctx->ref_count = sqe_count;
         ctx->result = -ECANCELED;
-        struct io_uring_sqe *sqe = io_uring_get_sqe(&backend->ring);
+        sqe = io_uring_get_sqe(&backend->ring);
         io_uring_prep_cancel(sqe, ctx, 0);
         backend->pending_sqes = 0;
         io_uring_submit(&backend->ring);
@@ -1242,7 +1357,7 @@ VALUE Backend_chain(int argc,VALUE *argv, VALUE self) {
     }
 
     io_uring_sqe_set_data(last_sqe, ctx);
-    unsigned int flags = (i == (argc - 1)) ? IOSQE_ASYNC : IOSQE_ASYNC | IOSQE_IO_LINK;
+    flags = (i == (argc - 1)) ? IOSQE_ASYNC : IOSQE_ASYNC | IOSQE_IO_LINK;
     io_uring_sqe_set_flags(last_sqe, flags);
     sqe_count++;
   }
@@ -1251,14 +1366,16 @@ VALUE Backend_chain(int argc,VALUE *argv, VALUE self) {
   ctx->ref_count = sqe_count + 1;
   io_uring_backend_defer_submit(backend);
   resume_value = backend_await((struct Backend_base *)backend);
-  int result = ctx->result;
-  int completed = context_store_release(&backend->store, ctx);
+  result = ctx->result;
+  completed = context_store_release(&backend->store, ctx);
   if (!completed) {
+    struct io_uring_sqe *sqe;
+    
     Backend_chain_ctx_attach_buffers(ctx, argc, argv);
 
     // op was not completed (an exception was raised), so we need to cancel it
     ctx->result = -ECANCELED;
-    struct io_uring_sqe *sqe = io_uring_get_sqe(&backend->ring);
+    sqe = io_uring_get_sqe(&backend->ring);
     io_uring_prep_cancel(sqe, ctx, 0);
     backend->pending_sqes = 0;
     io_uring_submit(&backend->ring);
@@ -1322,8 +1439,10 @@ static inline void splice_chunks_get_sqe(
 }
 
 static inline void splice_chunks_cancel(Backend_t *backend, op_context_t *ctx) {
+  struct io_uring_sqe *sqe;
+  
   ctx->result = -ECANCELED;
-  struct io_uring_sqe *sqe = io_uring_get_sqe(&backend->ring);
+  sqe = io_uring_get_sqe(&backend->ring);
   io_uring_prep_cancel(sqe, ctx, 0);
   backend->pending_sqes = 0;
   io_uring_submit(&backend->ring);
@@ -1336,9 +1455,11 @@ static inline int splice_chunks_await_ops(
   VALUE *switchpoint_result
 )
 {
+  int completed;
   int res = io_uring_backend_defer_submit_and_await(backend, 0, *ctx, switchpoint_result);
+
   if (result) (*result) = res;
-  int completed = context_store_release(&backend->store, *ctx);
+  completed = context_store_release(&backend->store, *ctx);
   if (!completed) {
     splice_chunks_cancel(backend, *ctx);
     if (TEST_EXCEPTION(*switchpoint_result)) return 1;
@@ -1352,17 +1473,22 @@ static inline int splice_chunks_await_ops(
 
 VALUE Backend_splice_chunks(VALUE self, VALUE src, VALUE dest, VALUE prefix, VALUE postfix, VALUE chunk_prefix, VALUE chunk_postfix, VALUE chunk_size) {
   Backend_t *backend;
-  GetBackend(self, backend);
   int total = 0;
   int err = 0;
   VALUE switchpoint_result = Qnil;
   op_context_t *ctx = 0;
   struct io_uring_sqe *sqe = 0;
-
+  int maxlen;
+  VALUE underlying_io;
+  VALUE str = Qnil;
+  VALUE chunk_len_value = Qnil;
   rb_io_t *src_fptr;
   rb_io_t *dest_fptr;
+  int pipefd[2] = { -1, -1 };
+
+  GetBackend(self, backend);
 
-  VALUE underlying_io = rb_ivar_get(src, ID_ivar_io);
+  underlying_io = rb_ivar_get(src, ID_ivar_io);
   if (underlying_io != Qnil) src = underlying_io;
   GetOpenFile(src, src_fptr);
   io_verify_blocking_mode(src_fptr, src, Qtrue);
@@ -1373,11 +1499,8 @@ VALUE Backend_splice_chunks(VALUE self, VALUE src, VALUE dest, VALUE prefix, VAL
   GetOpenFile(dest, dest_fptr);
   io_verify_blocking_mode(dest_fptr, dest, Qtrue);
 
-  int maxlen = NUM2INT(chunk_size);
-  VALUE str = Qnil;
-  VALUE chunk_len_value = Qnil;
+  maxlen = NUM2INT(chunk_size);
 
-  int pipefd[2] = { -1, -1 };
   if (pipe(pipefd) == -1) {
     err = errno;
     goto syscallerror;
@@ -1521,6 +1644,7 @@ void Init_Backend() {
   rb_define_method(cBackend, "wait_io", Backend_wait_io, 2);
   rb_define_method(cBackend, "waitpid", Backend_waitpid, 1);
   rb_define_method(cBackend, "write", Backend_write_m, -1);
+  // rb_define_method(cBackend, "close", Backend_close, 1);
 
   SYM_io_uring = ID2SYM(rb_intern("io_uring"));
   SYM_send = ID2SYM(rb_intern("send"));