polyphony 0.44.0 → 0.45.5

data/lib/polyphony/extensions/fiber.rb

@@ -7,20 +7,6 @@ require_relative '../core/exceptions'
 module Polyphony
   # Fiber control API
   module FiberControl
-    def await
-      if @running == false
-        return @result.is_a?(Exception) ? (Kernel.raise @result) : @result
-      end
-
-      fiber = Fiber.current
-      @waiting_fibers ||= {}
-      @waiting_fibers[fiber] = true
-      suspend
-    ensure
-      @waiting_fibers&.delete(fiber)
-    end
-    alias_method :join, :await
-
     def interrupt(value = nil)
       return if @running == false
 
@@ -117,7 +103,7 @@ module Polyphony
       suspend
       fibers.map(&:result)
     ensure
-      await_select_cleanup(state)
+      await_select_cleanup(state) if state
     end
     alias_method :join, :await
 
@@ -179,21 +165,19 @@ module Polyphony
         state[:selected] = true
       end
     end
-  end
 
-  # Messaging functionality
-  module FiberMessaging
-    def <<(value)
-      @mailbox << value
-    end
-    alias_method :send, :<<
-
-    def receive
-      @mailbox.shift
-    end
-
-    def receive_pending
-      @mailbox.shift_all
+    # Creates and schedules with priority an out-of-band fiber that runs the
+    # supplied block. If any uncaught exception is raised while the fiber is
+    # running, it will bubble up to the main thread's main fiber, which will
+    # also be scheduled with priority. This method is mainly used trapping
+    # signals (see also the patched `Kernel#trap`)
+    def schedule_priority_oob_fiber(&block)
+      f = Fiber.new do
+        block.call
+      rescue Exception => e
+        Thread.current.break_out_of_ev_loop(Thread.main.main_fiber, e)
+      end
+      Thread.current.break_out_of_ev_loop(f, nil)
     end
   end
 
@@ -225,14 +209,14 @@ module Polyphony
     def await_all_children
       return unless @children && !@children.empty?
 
-      @results = @children.dup
+      results = @children.dup
       @on_child_done = proc do |c, r|
-        @results[c] = r
-        self.schedule if @children.empty?
+        results[c] = r
+        schedule if @children.empty?
       end
       suspend
       @on_child_done = nil
-      @results.values
+      results.values
     end
 
     def shutdown_all_children
@@ -249,7 +233,6 @@ module Polyphony
       @parent = parent
       @caller = caller
       @block = block
-      @mailbox = Polyphony::Queue.new
       __fiber_trace__(:fiber_create, self)
       schedule
     end
@@ -279,7 +262,6 @@ module Polyphony
     # allows the fiber to be scheduled and to receive messages.
     def setup_raw
       @thread = Thread.current
-      @mailbox = Polyphony::Queue.new
     end
 
     def setup_main_fiber
@@ -288,11 +270,10 @@ module Polyphony
       @thread = Thread.current
       @running = true
       @children&.clear
-      @mailbox = Polyphony::Queue.new
     end
 
     def restart_self(first_value)
-      @mailbox = Polyphony::Queue.new
+      @mailbox = nil
       @when_done_procs = nil
       @waiting_fibers = nil
       run(first_value)
@@ -324,13 +305,10 @@ module Polyphony
     def inform_dependants(result, uncaught_exception)
       @parent&.child_done(self, result)
       @when_done_procs&.each { |p| p.(result) }
-      @waiting_fibers&.each_key do |f|
-        f.schedule(result)
-      end
-      return unless uncaught_exception && !@waiting_fibers
-
+      @waiting_fibers&.each_key { |f| f.schedule(result) }
+      
       # propagate unaught exception to parent
-      @parent&.schedule(result)
+      @parent&.schedule_with_priority(result) if uncaught_exception && !@waiting_fibers
     end
 
     def when_done(&block)
@@ -344,14 +322,13 @@ end
 class ::Fiber
   prepend Polyphony::FiberControl
   include Polyphony::FiberSupervision
-  include Polyphony::FiberMessaging
   include Polyphony::ChildFiberControl
   include Polyphony::FiberLifeCycle
 
   extend Polyphony::FiberControlClassMethods
 
   attr_accessor :tag, :thread, :parent
-  attr_reader :result
+  attr_reader :result, :mailbox
 
   def running?
     @running

data/lib/polyphony/extensions/io.rb

@@ -90,16 +90,27 @@ class ::IO
   # def each_codepoint
   # end
 
-  # def getbyte
-  # end
+  alias_method :orig_getbyte, :getbyte
+  def getbyte
+    char = getc
+    char ? char.getbyte(0) : nil
+  end
 
-  # def getc
-  # end
+  alias_method :orig_getc, :getc
+  def getc
+    return @read_buffer.slice!(0) if @read_buffer && !@read_buffer.empty?
+    
+    @read_buffer ||= +''
+    Thread.current.backend.read(self, @read_buffer, 8192, false)
+    return @read_buffer.slice!(0) if !@read_buffer.empty?
+
+    nil
+  end
 
   alias_method :orig_read, :read
   def read(len = nil)
     @read_buffer ||= +''
-    result = Thread.current.agent.read(self, @read_buffer, len, true)
+    result = Thread.current.backend.read(self, @read_buffer, len, true)
     return nil unless result
 
     already_read = @read_buffer
@@ -110,7 +121,7 @@ class ::IO
   alias_method :orig_readpartial, :read
   def readpartial(len, str = nil)
     @read_buffer ||= +''
-    result = Thread.current.agent.read(self, @read_buffer, len, false)
+    result = Thread.current.backend.read(self, @read_buffer, len, false)
     raise EOFError unless result
 
     if str
@@ -124,12 +135,12 @@ class ::IO
 
   alias_method :orig_write, :write
   def write(str, *args)
-    Thread.current.agent.write(self, str, *args)
+    Thread.current.backend.write(self, str, *args)
   end
 
   alias_method :orig_write_chevron, :<<
   def <<(str)
-    Thread.current.agent.write(self, str)
+    Thread.current.backend.write(self, str)
     self
   end
 
@@ -163,20 +174,29 @@ class ::IO
   # def putc(obj)
   # end
 
+  LINEFEED = "\n"
+  LINEFEED_RE = /\n$/.freeze
+
   alias_method :orig_puts, :puts
   def puts(*args)
     if args.empty?
-      write "\n"
+      write LINEFEED
       return
     end
 
-    strs = args.inject([]) do |m, a|
-      a = a.to_s
-      m << a
-      m << "\n" unless a =~ /\n$/
-      m
+    idx = 0
+    while idx < args.size
+      arg = args[idx]
+      args[idx] = arg = arg.to_s unless arg.is_a?(String)
+      if arg =~ LINEFEED_RE
+        idx += 1
+      else
+        args.insert(idx + 1, LINEFEED)
+        idx += 2
+      end
     end
-    write *strs
+
+    write(*args)
     nil
   end
 
@@ -203,7 +223,7 @@ class ::IO
   end
 
   def read_loop(&block)
-    Thread.current.agent.read_loop(self, &block)
+    Thread.current.backend.read_loop(self, &block)
   end
 
   # alias_method :orig_read, :read
@@ -218,4 +238,28 @@ class ::IO
   #   end
   #   outbuf
   # end
+
+  def wait_readable(timeout = nil)
+    if timeout
+      move_on_after(timeout) do
+        Thread.current.backend.wait_io(self, false)
+        self
+      end
+    else
+      Thread.current.backend.wait_io(self, false)
+      self
+    end
+  end
+
+  def wait_writable(timeout = nil)
+    if timeout
+      move_on_after(timeout) do
+        Thread.current.backend.wait_io(self, true)
+        self
+      end
+    else
+      Thread.current.backend.wait_io(self, true)
+      self
+    end
+  end
 end

data/lib/polyphony/extensions/openssl.rb

@@ -28,8 +28,8 @@ class ::OpenSSL::SSL::SSLSocket
     loop do
       result = accept_nonblock(exception: false)
       case result
-      when :wait_readable then Thread.current.agent.wait_io(io, false)
-      when :wait_writable then Thread.current.agent.wait_io(io, true)
+      when :wait_readable then Thread.current.backend.wait_io(io, false)
+      when :wait_writable then Thread.current.backend.wait_io(io, true)
       else
         return result
       end
@@ -40,8 +40,8 @@ class ::OpenSSL::SSL::SSLSocket
   def sysread(maxlen, buf = +'')
     loop do
       case (result = read_nonblock(maxlen, buf, exception: false))
-      when :wait_readable then Thread.current.agent.wait_io(io, false)
-      when :wait_writable then Thread.current.agent.wait_io(io, true)
+      when :wait_readable then Thread.current.backend.wait_io(io, false)
+      when :wait_writable then Thread.current.backend.wait_io(io, true)
       else return result
       end
     end
@@ -51,8 +51,8 @@ class ::OpenSSL::SSL::SSLSocket
   def syswrite(buf)
     loop do
       case (result = write_nonblock(buf, exception: false))
-      when :wait_readable then Thread.current.agent.wait_io(io, false)
-      when :wait_writable then Thread.current.agent.wait_io(io, true)
+      when :wait_readable then Thread.current.backend.wait_io(io, false)
+      when :wait_writable then Thread.current.backend.wait_io(io, true)
       else
         return result
       end

data/lib/polyphony/extensions/socket.rb

@@ -5,26 +5,17 @@ require 'socket'
 require_relative './io'
 require_relative '../core/thread_pool'
 
-class ::BasicSocket
-  def write_nonblock(string, _options = {})
-    write(string)
-  end
-
-  def read_nonblock(maxlen, str = nil, _options = {})
-    readpartial(maxlen, str)
-  end
-end
-
 # Socket overrides (eventually rewritten in C)
 class ::Socket
   def accept
-    Thread.current.agent.accept(self)
+    Thread.current.backend.accept(self)
   end
 
   NO_EXCEPTION = { exception: false }.freeze
 
-  def connect(remotesockaddr)
-    Thread.current.agent.connect(self, remotesockaddr.ip_address, remotesockaddr.ip_port)
+  def connect(addr)
+    addr = Addrinfo.new(addr) if addr.is_a?(String)
+    Thread.current.backend.connect(self, addr.ip_address, addr.ip_port)
   end
 
   def recv(maxlen, flags = 0, outbuf = nil)
@@ -33,7 +24,7 @@ class ::Socket
       result = recv_nonblock(maxlen, flags, outbuf, **NO_EXCEPTION)
       case result
       when nil then raise IOError
-      when :wait_readable then Thread.current.agent.wait_io(self, false)
+      when :wait_readable then Thread.current.backend.wait_io(self, false)
       else
         return result
       end
@@ -46,7 +37,7 @@ class ::Socket
       result = recvfrom_nonblock(maxlen, flags, @read_buffer, **NO_EXCEPTION)
       case result
       when nil then raise IOError
-      when :wait_readable then Thread.current.agent.wait_io(self, false)
+      when :wait_readable then Thread.current.backend.wait_io(self, false)
       else
         return result
       end
@@ -128,6 +119,14 @@ class ::TCPSocket
   def reuse_port
     setsockopt(::Socket::SOL_SOCKET, ::Socket::SO_REUSEPORT, 1)
   end
+
+  def read_nonblock(len, str = nil, exception: true)
+    @io.read_nonblock(len, str, exception: exception)
+  end
+
+  def write_nonblock(buf, exception: true)
+    @io.write_nonblock(buf, exception: exception)
+  end
 end
 
 # Override stock TCPServer code by encapsulating a Socket instance.

data/lib/polyphony/extensions/thread.rb

@@ -16,21 +16,22 @@ class ::Thread
   end
 
   def execute
-    # agent must be created in the context of the new thread, therefore it
+    # backend must be created in the context of the new thread, therefore it
     # cannot be created in Thread#initialize
-    @agent = Polyphony::Agent.new
+    @backend = Polyphony::Backend.new
     setup
     @ready = true
     result = @block.(*@args)
   rescue Polyphony::MoveOn, Polyphony::Terminate => e
     result = e.value
-  rescue Exception => result
+  rescue Exception => e
+    result = e
   ensure
     @ready = true
     finalize(result)
   end
 
-  attr_accessor :agent
+  attr_accessor :backend
 
   def setup
     @main_fiber = Fiber.current
@@ -48,7 +49,7 @@ class ::Thread
       @result = result
       signal_waiters(result)
     end
-    @agent.finalize
+    @backend.finalize
   end
 
   def signal_waiters(result)

data/lib/polyphony/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Polyphony
-  VERSION = '0.44.0'
+  VERSION = '0.45.5'
 end

data/polyphony.gemspec

@@ -21,19 +21,21 @@ Gem::Specification.new do |s|
   s.require_paths = ["lib"]
   s.required_ruby_version = '>= 2.6'
 
-  s.add_development_dependency  'httparty',             '0.17.0'
-  s.add_development_dependency  'localhost',            '1.1.4'
+  s.add_development_dependency  'rake-compiler',        '1.1.1'
   s.add_development_dependency  'minitest',             '5.13.0'
   s.add_development_dependency  'minitest-reporters',   '1.4.2'
   s.add_development_dependency  'simplecov',            '0.17.1'
   s.add_development_dependency  'rubocop',              '0.85.1'
+  s.add_development_dependency  'pry',                  '0.13.1'
+  
   s.add_development_dependency  'pg',                   '1.1.4'
-  s.add_development_dependency  'rake-compiler',        '1.0.5'
   s.add_development_dependency  'redis',                '4.1.0'
   s.add_development_dependency  'hiredis',              '0.6.3'
   s.add_development_dependency  'http_parser.rb',       '~>0.6.0'
+  s.add_development_dependency  'rack',                 '>=2.0.8', '<2.3.0'
   s.add_development_dependency  'mysql2',               '0.5.3'
   s.add_development_dependency  'sequel',               '5.34.0'
+  s.add_development_dependency  'httparty',             '0.17.1'
 
   s.add_development_dependency  'jekyll',               '~>3.8.6'
   s.add_development_dependency  'jekyll-remote-theme',  '~>0.4.1'

data/test/helper.rb

@@ -31,7 +31,7 @@ class MiniTest::Test
     end
     Fiber.current.setup_main_fiber
     Fiber.current.instance_variable_set(:@auto_watcher, nil)
-    Thread.current.agent = Polyphony::Agent.new
+    Thread.current.backend = Polyphony::Backend.new
     sleep 0 # apparently this helps with timer accuracy
   end
 

data/test/{test_agent.rb → test_backend.rb}

@@ -2,39 +2,39 @@
 
 require_relative 'helper'
 
-class AgentTest < MiniTest::Test
+class BackendTest < MiniTest::Test
   def setup
     super
-    @prev_agent = Thread.current.agent
-    @agent = Polyphony::Agent.new
-    Thread.current.agent = @agent
+    @prev_backend = Thread.current.backend
+    @backend = Polyphony::Backend.new
+    Thread.current.backend = @backend
   end
 
   def teardown
-    @agent.finalize
-    Thread.current.agent = @prev_agent
+    @backend.finalize
+    Thread.current.backend = @prev_backend
   end
 
   def test_sleep
     count = 0
     t0 = Time.now
     spin {
-      @agent.sleep 0.01
+      @backend.sleep 0.01
       count += 1
-      @agent.sleep 0.01
+      @backend.sleep 0.01
       count += 1
-      @agent.sleep 0.01
+      @backend.sleep 0.01
       count += 1
     }.await
-    assert Time.now - t0 >= 0.03
+    assert_in_delta 0.03, Time.now - t0, 0.005
     assert_equal 3, count
   end
 
   def test_write_read_partial
     i, o = IO.pipe
     buf = +''
-    f = spin { @agent.read(i, buf, 5, false) }
-    @agent.write(o, 'Hello world')
+    f = spin { @backend.read(i, buf, 5, false) }
+    @backend.write(o, 'Hello world')
     return_value = f.await
     
     assert_equal 'Hello', buf
@@ -44,10 +44,10 @@ class AgentTest < MiniTest::Test
   def test_write_read_to_eof_limited_buffer
     i, o = IO.pipe
     buf = +''
-    f = spin { @agent.read(i, buf, 5, true) }
-    @agent.write(o, 'Hello')
+    f = spin { @backend.read(i, buf, 5, true) }
+    @backend.write(o, 'Hello')
     snooze
-    @agent.write(o, ' world')
+    @backend.write(o, ' world')
     snooze
     o.close
     return_value = f.await
@@ -59,10 +59,10 @@ class AgentTest < MiniTest::Test
   def test_write_read_to_eof
     i, o = IO.pipe
     buf = +''
-    f = spin { @agent.read(i, buf, 10**6, true) }
-    @agent.write(o, 'Hello')
+    f = spin { @backend.read(i, buf, 10**6, true) }
+    @backend.write(o, 'Hello')
     snooze
-    @agent.write(o, ' world')
+    @backend.write(o, ' world')
     snooze
     o.close
     return_value = f.await
@@ -73,11 +73,11 @@ class AgentTest < MiniTest::Test
 
   def test_waitpid
     pid = fork do
-      @agent.post_fork
+      @backend.post_fork
       exit(42)
     end
     
-    result = @agent.waitpid(pid)
+    result = @backend.waitpid(pid)
     assert_equal [pid, 42], result
   end
 
@@ -87,7 +87,7 @@ class AgentTest < MiniTest::Test
     buf = []
     spin do
       buf << :ready
-      @agent.read_loop(i) { |d| buf << d }
+      @backend.read_loop(i) { |d| buf << d }
       buf << :done
     end
 
@@ -107,7 +107,7 @@ class AgentTest < MiniTest::Test
 
     clients = []
     server_fiber = spin do
-      @agent.accept_loop(server) { |c| clients << c }
+      @backend.accept_loop(server) { |c| clients << c }
     end
 
     c1 = TCPSocket.new('127.0.0.1', 1234)