polymorphic_integer_type 3.2.0 → 3.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e0a0c496105cf4f71bbb7d8e37f4b7d5464a155c6d69adc32860a42f57b54ce2
-  data.tar.gz: 6b91ce4961f8ff169c8a106bc258d25ff8f59aff0c59a97ed7488c9d708851bd
+  metadata.gz: cfa2f9c68364a27168180b5dfeaae71b6ea2a9e74c313a8f42658b6e3a562dcd
+  data.tar.gz: b4f0b2225be4e6d8270f1e4d1755a15d791aec80a3f20afd3cd2c6d9f4923603
 SHA512:
-  metadata.gz: 224efc3b41dc88ba440de3a87398a6422e817cc6adcedb216145d9fdfe004c9d3c5da733f81e547d27481dae3806290173dd4db65d4b72759084d0c4132a48d0
-  data.tar.gz: 91168a3fa7ed06b8de0c51b15d5199a66ede9e0b3265a7ea23861a796219f2948e9eef18b51c8c349fe23706ebfb9c9131fbec181a175c703c6d701061205a84
+  metadata.gz: 12fa770fcb992eb05270b971a8f1ff88d881318d09bccc9f3e7d139e01396054873a68f1083238db0af4d7dc32bf3a715a51d848df2d9432e060580a6b524cf8
+  data.tar.gz: ca0d6e461f1543b2f47476d53e679d24de1420e60acaa8c51119f1bfa05ac962f5ac189912d9a7ae12e63f9568af91e6e0550dbc448efc3b2e75c6f655a8e0c5

data/.gitignore

@@ -20,3 +20,4 @@ tmp
 .byebug_history
 polymorphic_integer_type_test
 gemfiles/*.lock
+.idea/

data/CHANGELOG.md

@@ -0,0 +1,19 @@
+### Changed
+
+## v3.2.1 (2023-12-14)
+
+### Fixed
+
+- Not proper assigning polymorphic value with `has_many` and `has_one` reflection.
+
+### Added
+
+- Added .idea/ folder to .gitignore
+
+## v3.2.2 (2023-12-21)
+
+### Fixed
+
+- Fixed polymorphic_foreign_association_extension.rb to be compatible with other reflection than `has_many` and `has_one`.
+
+### Changed

data/lib/polymorphic_integer_type/extensions.rb

@@ -2,6 +2,10 @@ module PolymorphicIntegerType
 
   module Extensions
     module ClassMethods
+      ActiveRecord::Reflection::HasManyReflection.attr_accessor(:foreign_integer_type)
+      ActiveRecord::Reflection::HasManyReflection.attr_accessor(:integer_type)
+      ActiveRecord::Reflection::HasOneReflection.attr_accessor(:foreign_integer_type)
+      ActiveRecord::Reflection::HasOneReflection.attr_accessor(:integer_type)
 
       def belongs_to(name, scope = nil, **options)
         options = scope if scope.kind_of? Hash
@@ -64,8 +68,10 @@ module PolymorphicIntegerType
             condition = instance_exec(&scope).merge(condition) if scope.is_a?(Proc)
             condition
           }
+          return foreign_type, klass_mapping.to_i
         else
           options[:scope] ||= scope
+          return nil, nil
         end
       end
 
@@ -86,8 +92,10 @@ module PolymorphicIntegerType
           scope = nil
         end
 
-        remove_type_and_establish_mapping(name, options, scope)
-        super(name, options.delete(:scope), **options, &extension)
+        integer_type_values = remove_type_and_establish_mapping(name, options, scope)
+        super(name, options.delete(:scope), **options, &extension).tap do
+          remove_integer_type_and_set_attributes_and_extension(integer_type_values, reflections[name.to_s])
+        end
       end
 
       def has_one(name, scope = nil, **options)
@@ -96,8 +104,27 @@ module PolymorphicIntegerType
           scope = nil
         end
 
-        remove_type_and_establish_mapping(name, options, scope)
-        super(name, options.delete(:scope), **options)
+        integer_type_values = remove_type_and_establish_mapping(name, options, scope)
+        super(name, options.delete(:scope), **options).tap do
+          remove_integer_type_and_set_attributes_and_extension(integer_type_values, reflections[name.to_s])
+        end
+      end
+
+      def remove_integer_type_and_set_attributes_and_extension(integer_type_values, reflection)
+        foreign_integer_type = integer_type_values[0]
+        integer_type = integer_type_values[1]
+        is_polymorphic_integer = foreign_integer_type && integer_type
+
+        if is_polymorphic_integer
+          reflection.foreign_integer_type = foreign_integer_type
+          reflection.integer_type = integer_type
+
+          if Gem::Version.new(ActiveRecord::VERSION::STRING) < Gem::Version.new("6.1")
+            ActiveRecord::Associations::Association.prepend(PolymorphicIntegerType::PolymorphicForeignAssociationExtension)
+          else
+            ActiveRecord::Associations::ForeignAssociation.prepend(PolymorphicIntegerType::PolymorphicForeignAssociationExtension)
+          end
+        end
       end
 
 

data/lib/polymorphic_integer_type/polymorphic_foreign_association_extension.rb

@@ -0,0 +1,11 @@
+module PolymorphicIntegerType
+  module PolymorphicForeignAssociationExtension
+
+    def set_owner_attributes(record)
+      super
+      if reflection.try(:foreign_integer_type) && reflection.try(:integer_type)
+        record._write_attribute(reflection.foreign_integer_type, reflection.integer_type)
+      end
+    end
+  end
+end

data/lib/polymorphic_integer_type/version.rb

@@ -1,3 +1,3 @@
 module PolymorphicIntegerType
-  VERSION = "3.2.0"
+  VERSION = "3.2.2"
 end

data/lib/polymorphic_integer_type.rb

@@ -6,6 +6,7 @@ require "polymorphic_integer_type/mapping"
 require "polymorphic_integer_type/module_generator"
 require "polymorphic_integer_type/belongs_to_polymorphic_association_extension"
 require "polymorphic_integer_type/activerecord_5_0_0/polymorphic_array_value_extension"
+require "polymorphic_integer_type/polymorphic_foreign_association_extension"
 
 if ACTIVE_RECORD_VERSION < Gem::Version.new("5.2.0")
   require "polymorphic_integer_type/activerecord_5_0_0/association_query_handler_extension"

data/spec/polymorphic_integer_type_spec.rb

@@ -26,6 +26,28 @@ describe PolymorphicIntegerType do
       expect(link.target_type).to eq("Food")
     end
 
+    context "from HasManyReflection" do
+      it "sets the source properly HasManyReflection" do
+        link_1 = Link.create()
+        link_2 = Link.create()
+        dog.source_links = [link_1, link_2]
+        expect(link_1.source_type).to eq("Animal")
+        expect(link_1.source_id).to eq(dog.id)
+        expect(link_2.source_type).to eq("Animal")
+        expect(link_1.source_id).to eq(dog.id)
+      end
+    end
+
+    context "from HasOneReflection" do
+      it "sets the source properly HasOneReflection" do
+        link = Link.create()
+        dog.source_link = link
+
+        expect(link.source_type).to eq("Animal")
+        expect(link.source_id).to eq(dog.id)
+      end
+    end
+
     context "when models are namespaced" do
       context "and mappings include namespaces" do
         it "sets the source_type" do
@@ -340,9 +362,22 @@ describe PolymorphicIntegerType do
       expect(link[:target_type]).to eq(13)
     end
 
+    it "pulls mapping from given hash" do
+      animal.source_links.new
+    end
+
     it "doesn't break string type polymorphic associations" do
       expect(link.normal_target).to eq(drink)
       expect(link.normal_target_type).to eq("InlineDrink2")
     end
   end
+
+  context "when using other reflection" do
+    it "owner able to association ActiveRecord::Reflection::ThroughReflection successfully" do
+      profile_history = ProfileHistory.new
+      owner.profile_histories << profile_history
+
+      expect(owner.profile_histories).to eq([profile_history])
+    end
+  end
 end

data/spec/spec_helper.rb

@@ -10,6 +10,8 @@ require 'support/dog'
 require 'support/person'
 require 'support/food'
 require 'support/drink'
+require 'support/profile'
+require 'support/profile_history'
 require 'support/namespaced_activity'
 require 'byebug'
 require 'pry'

data/spec/support/animal.rb

@@ -3,5 +3,5 @@ class Animal < ActiveRecord::Base
 
   belongs_to :owner, class_name: "Person"
   has_many :source_links, as: :source, integer_type: true, class_name: "Link"
-
+  has_one :source_link, as: :source, integer_type: true, class_name: "Link"
 end

data/spec/support/migrations/8_create_profile_table.rb

@@ -0,0 +1,16 @@
+class CreateProfileTable < ActiveRecord::Migration[5.0]
+
+  def up
+    create_table :profiles do |t|
+      t.integer :person_id
+      t.integer :profile_history_id
+    end
+  end
+
+  def down
+    drop_table :profiles
+  end
+
+end
+
+

data/spec/support/migrations/9_create_profile_history_table.rb

@@ -0,0 +1,14 @@
+class CreateProfileHistoryTable < ActiveRecord::Migration[5.0]
+
+  def up
+    create_table :profile_histories do |t|
+    end
+  end
+
+  def down
+    drop_table :profile_histories
+  end
+
+end
+
+

data/spec/support/person.rb

@@ -5,4 +5,6 @@ class Person < ActiveRecord::Base
   has_many :source_links, as: :source, integer_type: true, class_name: "Link"
 
   has_many :pet_source_links, class_name: "Link", through: :pets, source: :source_links
+  has_many :profiles
+  has_many :profile_histories, class_name: "ProfileHistory", through: :profiles
 end

data/spec/support/profile.rb

@@ -0,0 +1,4 @@
+class Profile < ActiveRecord::Base
+  belongs_to :person
+  belongs_to :profile_history
+end

data/spec/support/profile_history.rb

@@ -0,0 +1,3 @@
+class ProfileHistory < ActiveRecord::Base
+  has_many :profiles
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: polymorphic_integer_type
 version: !ruby/object:Gem::Version
-  version: 3.2.0
+  version: 3.2.2
 platform: ruby
 authors:
 - Kyle d'Oliveira
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-06-09 00:00:00.000000000 Z
+date: 2023-12-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -103,6 +103,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- CHANGELOG.md
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -121,6 +122,7 @@ files:
 - lib/polymorphic_integer_type/extensions.rb
 - lib/polymorphic_integer_type/mapping.rb
 - lib/polymorphic_integer_type/module_generator.rb
+- lib/polymorphic_integer_type/polymorphic_foreign_association_extension.rb
 - lib/polymorphic_integer_type/version.rb
 - polymorphic_integer_type.gemspec
 - spec/polymorphic_integer_type_spec.rb
@@ -139,10 +141,14 @@ files:
 - spec/support/migrations/5_create_drink_table.rb
 - spec/support/migrations/6_create_plant_table.rb
 - spec/support/migrations/7_create_activity_table.rb
+- spec/support/migrations/8_create_profile_table.rb
+- spec/support/migrations/9_create_profile_history_table.rb
 - spec/support/namespaced_activity.rb
 - spec/support/namespaced_animal.rb
 - spec/support/namespaced_plant.rb
 - spec/support/person.rb
+- spec/support/profile.rb
+- spec/support/profile_history.rb
 homepage: ''
 licenses:
 - MIT
@@ -183,7 +189,11 @@ test_files:
 - spec/support/migrations/5_create_drink_table.rb
 - spec/support/migrations/6_create_plant_table.rb
 - spec/support/migrations/7_create_activity_table.rb
+- spec/support/migrations/8_create_profile_table.rb
+- spec/support/migrations/9_create_profile_history_table.rb
 - spec/support/namespaced_activity.rb
 - spec/support/namespaced_animal.rb
 - spec/support/namespaced_plant.rb
 - spec/support/person.rb
+- spec/support/profile.rb
+- spec/support/profile_history.rb