polyamorous 1.3.3 → 2.3.0

data/lib/polyamorous/activerecord_4.1_ruby_1.9/join_association.rb

@@ -1,2 +0,0 @@
-# active_record_4.1_ruby_1.9/join_association.rb
-require 'polyamorous/activerecord_4.2_ruby_1.9/join_association'

data/lib/polyamorous/activerecord_4.1_ruby_1.9/join_dependency.rb

@@ -1,4 +0,0 @@
-# active_record_4.1_ruby_1.9/join_dependency.rb
-require 'polyamorous/activerecord_4.2_ruby_2/join_dependency'
-require 'polyamorous/activerecord_4.2_ruby_1.9/join_dependency'
-require 'polyamorous/activerecord_4.1_ruby_2/make_polyamorous_inner_joins'

data/lib/polyamorous/activerecord_4.1_ruby_2/join_association.rb

@@ -1,2 +0,0 @@
-# active_record_4.1_ruby_2/join_association.rb
-require 'polyamorous/activerecord_5.0_ruby_2/join_association'

data/lib/polyamorous/activerecord_4.1_ruby_2/join_dependency.rb

@@ -1,3 +0,0 @@
-# active_record_4.1_ruby_2/join_dependency.rb
-require 'polyamorous/activerecord_4.2_ruby_2/join_dependency'
-require 'polyamorous/activerecord_4.1_ruby_2/make_polyamorous_inner_joins'

data/lib/polyamorous/activerecord_4.1_ruby_2/make_polyamorous_inner_joins.rb

@@ -1,14 +0,0 @@
-module Polyamorous
-  module JoinDependencyExtensions
-    # Replaces ActiveRecord::Associations::JoinDependency#make_inner_joins
-    #
-    def make_polyamorous_inner_joins(parent, child)
-      make_constraints(
-        parent, child, child.tables, child.join_type || Arel::Nodes::InnerJoin
-      )
-      .concat child.children.flat_map { |c|
-        make_polyamorous_inner_joins(child, c)
-      }
-    end
-  end
-end

data/lib/polyamorous/activerecord_4.2_ruby_1.9/join_association.rb

@@ -1,46 +0,0 @@
-# active_record_4.2_ruby_1.9/join_association.rb
-module Polyamorous
-  module JoinAssociationExtensions
-    include SwappingReflectionClass
-    def self.included(base)
-      base.class_eval do
-        attr_reader :join_type
-        alias_method_chain :initialize, :polymorphism
-        alias_method_chain :build_constraint, :polymorphism
-      end
-    end
-
-    def initialize_with_polymorphism(reflection, children,
-      polymorphic_class = nil, join_type = Arel::Nodes::InnerJoin)
-      @join_type = join_type
-      if polymorphic_class && ::ActiveRecord::Base > polymorphic_class
-        swapping_reflection_klass(reflection, polymorphic_class) do |reflection|
-          initialize_without_polymorphism(reflection, children)
-          self.reflection.options[:polymorphic] = true
-        end
-      else
-        initialize_without_polymorphism(reflection, children)
-      end
-    end
-
-    # Reference https://github.com/rails/rails/commit/9b15db51b78028bfecdb85595624de4b838adbd1
-    def ==(other)
-      base_klass == other.base_klass
-    end
-
-    def build_constraint_with_polymorphism(
-      klass, table, key, foreign_table, foreign_key
-    )
-      if reflection.polymorphic?
-        build_constraint_without_polymorphism(
-          klass, table, key, foreign_table, foreign_key
-        )
-        .and(foreign_table[reflection.foreign_type].eq(reflection.klass.name))
-      else
-        build_constraint_without_polymorphism(
-          klass, table, key, foreign_table, foreign_key
-        )
-      end
-    end
-  end
-end

data/lib/polyamorous/activerecord_4.2_ruby_1.9/join_dependency.rb

@@ -1,87 +0,0 @@
-# active_record_4.2_ruby_1.9/join_dependency.rb
-require 'polyamorous/activerecord_4.2_ruby_2/join_dependency'
-
-module Polyamorous
-  module JoinDependencyExtensions
-    def self.included(base)
-      base.extend ClassMethods
-      base.class_eval do
-        class << self
-          alias_method :walk_tree_without_polymorphism, :walk_tree
-          alias_method :walk_tree, :walk_tree_with_polymorphism
-        end
-
-        alias_method :build_without_polymorphism, :build
-        alias_method :build, :build_with_polymorphism
-
-        alias_method :join_constraints_without_polymorphism, :join_constraints
-        alias_method :join_constraints, :join_constraints_with_polymorphism
-      end
-    end
-
-    # Replaces ActiveRecord::Associations::JoinDependency#build
-    #
-    def build_with_polymorphism(associations, base_klass)
-      associations.map do |name, right|
-        if name.is_a? Join
-          reflection = find_reflection base_klass, name.name
-          reflection.check_validity!
-          klass = if reflection.polymorphic?
-            name.klass || base_klass
-          else
-            reflection.klass
-          end
-          JoinAssociation.new(reflection, build(right, klass), name.klass, name.type)
-        else
-          reflection = find_reflection base_klass, name
-          reflection.check_validity!
-          if reflection.polymorphic?
-            raise ActiveRecord::EagerLoadPolymorphicError.new(reflection)
-          end
-          JoinAssociation.new reflection, build(right, reflection.klass)
-        end
-      end
-    end
-
-    # Replaces ActiveRecord::Associations::JoinDependency#join_constraints
-    # to call #make_polyamorous_inner_joins instead of #make_inner_joins
-    #
-    def join_constraints_with_polymorphism(outer_joins)
-      joins = join_root.children.flat_map { |child|
-        make_polyamorous_inner_joins join_root, child
-      }
-      joins.concat outer_joins.flat_map { |oj|
-        if join_root.match? oj.join_root
-          walk(join_root, oj.join_root)
-        else
-          oj.join_root.children.flat_map { |child|
-            make_outer_joins(oj.join_root, child)
-          }
-        end
-      }
-    end
-
-    module ClassMethods
-      # Replaces ActiveRecord::Associations::JoinDependency#self.walk_tree
-      #
-      def walk_tree_with_polymorphism(associations, hash)
-        case associations
-        when TreeNode
-          associations.add_to_tree(hash)
-        when Hash
-          associations.each do |k, v|
-            cache =
-              if TreeNode === k
-                k.add_to_tree(hash)
-              else
-                hash[k] ||= {}
-              end
-            walk_tree(v, cache)
-         end
-        else
-          walk_tree_without_polymorphism(associations, hash)
-        end
-      end
-    end
-  end
-end

data/lib/polyamorous/activerecord_4.2_ruby_2/join_association.rb

@@ -1,2 +0,0 @@
-# active_record_4.2_ruby_2/join_association.rb
-require 'polyamorous/activerecord_5.0_ruby_2/join_association'

data/lib/polyamorous/activerecord_4.2_ruby_2/join_dependency.rb

@@ -1,24 +0,0 @@
-# active_record_4.2_ruby_2/join_dependency.rb
-require 'polyamorous/activerecord_5.0_ruby_2/join_dependency'
-
-module Polyamorous
-  module JoinDependencyExtensions
-    # Replaces ActiveRecord::Associations::JoinDependency#join_constraints
-    # to call #make_polyamorous_inner_joins instead of #make_inner_joins.
-    #
-    def join_constraints(outer_joins)
-      joins = join_root.children.flat_map { |child|
-        make_polyamorous_inner_joins join_root, child
-      }
-      joins.concat outer_joins.flat_map { |oj|
-        if join_root.match? oj.join_root
-          walk(join_root, oj.join_root)
-        else
-          oj.join_root.children.flat_map { |child|
-            make_outer_joins(oj.join_root, child)
-          }
-        end
-      }
-    end
-  end
-end

data/spec/blueprints/articles.rb

@@ -1,5 +0,0 @@
-Article.blueprint do
-  person
-  title
-  body
-end

data/spec/blueprints/comments.rb

@@ -1,5 +0,0 @@
-Comment.blueprint do
-  article
-  person
-  body
-end

data/spec/blueprints/notes.rb

@@ -1,3 +0,0 @@
-Note.blueprint do
-  note
-end

data/spec/blueprints/people.rb

@@ -1,4 +0,0 @@
-Person.blueprint do
-  name
-  salary
-end

data/spec/blueprints/tags.rb

@@ -1,3 +0,0 @@
-Tag.blueprint do
-  name    { Sham.tag_name }
-end

data/spec/helpers/polyamorous_helper.rb

@@ -1,26 +0,0 @@
-module PolyamorousHelper
-  if ActiveRecord::VERSION::STRING >= "4.1"
-    def new_join_association(reflection, children, klass)
-      Polyamorous::JoinAssociation.new reflection, children, klass
-    end
-  else
-    def new_join_association(reflection, join_dependency, parent, klass)
-      Polyamorous::JoinAssociation.new reflection, join_dependency, parent, klass
-    end
-  end
-
-  if ActiveRecord::VERSION::STRING >= "5.2"
-    def new_join_dependency(klass, associations = {})
-      alias_tracker = ::ActiveRecord::Associations::AliasTracker.create(klass.connection, klass.table_name, [])
-      Polyamorous::JoinDependency.new klass, klass.arel_table, associations, alias_tracker
-    end
-  else
-    def new_join_dependency(klass, associations = {})
-      Polyamorous::JoinDependency.new klass, associations, []
-    end
-  end
-
-  def new_join(name, type = Polyamorous::InnerJoin, klass = nil)
-    Polyamorous::Join.new name, type, klass
-  end
-end

data/spec/polyamorous/join_association_spec.rb

@@ -1,54 +0,0 @@
-require 'spec_helper'
-
-module Polyamorous
-  describe JoinAssociation do
-
-    join_base, join_association_args, polymorphic =
-      if ActiveRecord::VERSION::STRING >= '4.1'
-        [:join_root, 'parent.children', 'reflection.options[:polymorphic]']
-      else
-        [:join_base, 'join_dependency, parent', 'options[:polymorphic]']
-      end
-
-    let(:join_dependency) { new_join_dependency Note, {} }
-    let(:reflection) { Note.reflect_on_association(:notable) }
-    let(:parent) { join_dependency.send(join_base) }
-    let(:join_association) {
-      eval("new_join_association(reflection, #{join_association_args}, Article)")
-    }
-
-    subject {
-      join_dependency.build_join_association_respecting_polymorphism(
-        reflection, parent, Person
-      )
-    }
-
-    it 'respects polymorphism on equality test' do
-      expect(subject).to eq(
-        join_dependency.build_join_association_respecting_polymorphism(
-          reflection, parent, Person
-        )
-      )
-      expect(subject).not_to eq(
-        join_dependency.build_join_association_respecting_polymorphism(
-          reflection, parent, Article
-        )
-      )
-    end
-
-    it 'leaves the orginal reflection intact for thread safety' do
-      reflection.instance_variable_set(:@klass, Article)
-      join_association
-      .swapping_reflection_klass(reflection, Person) do |new_reflection|
-        expect(new_reflection.options).not_to equal reflection.options
-        expect(new_reflection.options).not_to have_key(:polymorphic)
-        expect(new_reflection.klass).to eq(Person)
-        expect(reflection.klass).to eq(Article)
-      end
-    end
-
-    it 'sets the polymorphic option to true after initializing' do
-      expect(join_association.instance_eval(polymorphic)).to be true
-    end
-  end
-end

data/spec/polyamorous/join_dependency_spec.rb

@@ -1,102 +0,0 @@
-require 'spec_helper'
-
-module Polyamorous
-  describe JoinDependency do
-
-    method, join_associations, join_base =
-      if ActiveRecord::VERSION::STRING >= '4.1'
-        [:instance_eval, 'join_root.drop(1)', :join_root]
-      else
-        [:send, 'join_associations', :join_base]
-      end
-
-    context 'with symbol joins' do
-      subject { new_join_dependency Person, articles: :comments }
-
-      specify { expect(subject.send(method, join_associations).size)
-        .to eq(2) }
-      specify { expect(subject.send(method, join_associations).map(&:join_type))
-        .to be_all { Polyamorous::InnerJoin } }
-    end
-
-    context 'with has_many :through association' do
-      subject { new_join_dependency Person, :authored_article_comments }
-
-      specify { expect(subject.send(method, join_associations).size)
-        .to eq 1 }
-      specify { expect(subject.send(method, join_associations).first.table_name)
-        .to eq 'comments' }
-    end
-
-    context 'with outer join' do
-      subject { new_join_dependency Person, new_join(:articles, :outer) }
-
-      specify { expect(subject.send(method, join_associations).size)
-        .to eq 1 }
-      specify { expect(subject.send(method, join_associations).first.join_type)
-        .to eq Polyamorous::OuterJoin }
-    end
-
-    context 'with nested outer joins' do
-      subject { new_join_dependency Person,
-        new_join(:articles, :outer) => new_join(:comments, :outer) }
-
-      specify { expect(subject.send(method, join_associations).size)
-        .to eq 2 }
-      specify { expect(subject.send(method, join_associations).map(&:join_type))
-        .to eq [Polyamorous::OuterJoin, Polyamorous::OuterJoin] }
-      specify { expect(subject.send(method, join_associations).map(&:join_type))
-        .to be_all { Polyamorous::OuterJoin } }
-    end
-
-    context 'with polymorphic belongs_to join' do
-      subject { new_join_dependency Note, new_join(:notable, :inner, Person) }
-
-      specify { expect(subject.send(method, join_associations).size)
-        .to eq 1 }
-      specify { expect(subject.send(method, join_associations).first.join_type)
-        .to eq Polyamorous::InnerJoin }
-      specify { expect(subject.send(method, join_associations).first.table_name)
-        .to eq 'people' }
-
-      it 'finds a join association respecting polymorphism' do
-        parent = subject.send(join_base)
-        reflection = Note.reflect_on_association(:notable)
-
-        expect(subject.find_join_association_respecting_polymorphism(
-          reflection, parent, Person))
-          .to eq subject.send(method, join_associations).first
-      end
-    end
-
-    context 'with polymorphic belongs_to join and nested symbol join' do
-      subject { new_join_dependency Note,
-        new_join(:notable, :inner, Person) => :comments }
-
-      specify { expect(subject.send(method, join_associations).size)
-        .to eq 2 }
-      specify { expect(subject.send(method, join_associations).map(&:join_type))
-        .to be_all { Polyamorous::InnerJoin } }
-      specify { expect(subject.send(method, join_associations).first.table_name)
-        .to eq 'people' }
-      specify { expect(subject.send(method, join_associations)[1].table_name)
-        .to eq 'comments' }
-    end
-
-    context '#left_outer_join in Rails 5 overrides join type specified',
-            if: ActiveRecord::VERSION::MAJOR >= 5 && ActiveRecord::VERSION::MINOR < 2 do
-
-      let(:join_type_class) do
-        new_join_dependency(
-          Person,
-          new_join(:articles)
-        ).join_constraints(
-          [],
-          Arel::Nodes::OuterJoin
-        ).first.joins.map(&:class)
-      end
-
-      specify { expect(join_type_class).to eq [Arel::Nodes::OuterJoin] }
-    end
-  end
-end

data/spec/polyamorous/join_spec.rb

@@ -1,19 +0,0 @@
-require 'spec_helper'
-
-module Polyamorous
-  describe Join do
-    it 'is a tree node' do
-      join = new_join(:articles, :outer)
-      expect(join).to be_kind_of(TreeNode)
-    end
-
-    it 'can be added to a tree' do
-      join = new_join(:articles, :outer)
-
-      tree_hash = {}
-      join.add_to_tree(tree_hash)
-
-      expect(tree_hash[join]).to be {}
-    end
-  end
-end

data/spec/spec_helper.rb

@@ -1,43 +0,0 @@
-require 'machinist/active_record'
-require 'sham'
-require 'faker'
-require 'polyamorous'
-
-Time.zone = 'Eastern Time (US & Canada)'
-
-Dir[File.expand_path('../{helpers,support,blueprints}/**/*.rb', __FILE__)]
-.each do |f|
-  require f
-end
-
-Sham.define do
-  name     { Faker::Name.name }
-  title    { Faker::Lorem.sentence }
-  body     { Faker::Lorem.paragraph }
-  salary   { |index| 30000 + (index * 1000) }
-  tag_name { Faker::Lorem.words(3).join(' ') }
-  note     { Faker::Lorem.words(7).join(' ') }
-end
-
-RSpec.configure do |config|
-  config.before(:suite) do
-    message = "Running Polyamorous specs with #{
-      ActiveRecord::Base.connection.adapter_name
-      }, Active Record #{::ActiveRecord::VERSION::STRING}, Arel #{Arel::VERSION
-      } and Ruby #{RUBY_VERSION}"
-    line = '=' * message.length
-    puts line, message, line
-    Schema.create
-  end
-  config.before(:all)   { Sham.reset(:before_all) }
-  config.before(:each)  { Sham.reset(:before_each) }
-
-  config.include PolyamorousHelper
-end
-
-RSpec::Matchers.define :be_like do |expected|
-  match do |actual|
-    actual.gsub(/^\s+|\s+$/, '').gsub(/\s+/, ' ').strip ==
-      expected.gsub(/^\s+|\s+$/, '').gsub(/\s+/, ' ').strip
-  end
-end