poly_belongs_to 0.2.8 → 0.2.9

data/test/dummy/test/fixtures/events.yml

@@ -0,0 +1,8 @@
+# Read about fixtures at
+# http://api.rubyonrails.org/classes/ActiveRecord/Fixtures.html
+
+one:
+  work_order_id: 1
+
+two:
+  work_order_id: 1

data/test/dummy/test/fixtures/work_orders.yml

@@ -0,0 +1,12 @@
+# Read about fixtures at
+# http://api.rubyonrails.org/classes/ActiveRecord/Fixtures.html
+
+# This model initially had no columns defined.  If you add columns to the
+# model remove the '{}' from the fixture names and add the columns immediately
+# below each fixture, per the syntax in the comments below
+#
+one: {}
+# column: value
+#
+two: {}
+#  column: value

data/test/dummy/test/models/address_book_test.rb

@@ -0,0 +1,13 @@
+require "test_helper"
+
+class AddressBookTest < ActiveSupport::TestCase
+
+  def address_book
+    @address_book ||= AddressBook.new
+  end
+
+  def test_valid
+    assert address_book.valid?
+  end
+
+end

data/test/dummy/test/models/event_test.rb

@@ -0,0 +1,13 @@
+require "test_helper"
+
+class EventTest < ActiveSupport::TestCase
+
+  def event
+    @event ||= Event.new
+  end
+
+  def test_valid
+    assert event.valid?
+  end
+
+end

data/test/dummy/test/models/work_order_test.rb

@@ -0,0 +1,13 @@
+require "test_helper"
+
+class WorkOrderTest < ActiveSupport::TestCase
+
+  def work_order
+    @work_order ||= WorkOrder.new
+  end
+
+  def test_valid
+    assert work_order.valid?
+  end
+
+end

data/test/faked_collection_test.rb

@@ -35,6 +35,7 @@ class FakedCollectionTest < ActiveSupport::TestCase
       [nil, photos(:steve_photo).id].must_include steve_photos.id
       nil_steve.id.must_be_nil
       nil_photo.id.must_be_nil
+      null_object.id.must_be_nil
     end
 
     it "#all is an Array" do
@@ -105,16 +106,25 @@ class FakedCollectionTest < ActiveSupport::TestCase
       steve_photos.ancestors.must_include(ActiveRecord::Base)
     end
 
+    it "#ancestors has NilClass if empty" do
+      null_object.ancestors.must_include(NilClass)
+      nil_steve.ancestors.must_include(NilClass)
+      nil_photo.ancestors.must_include(NilClass)
+    end
+
     it "build #kind_of? FakedCollection object" do
       steve_photos.must_be_kind_of(PolyBelongsTo::FakedCollection)
+      null_object.must_be_kind_of(PolyBelongsTo::FakedCollection)
     end
 
     it "build #is_a? FakedCollection object" do
       steve_photos.is_a?(PolyBelongsTo::FakedCollection).must_be_same_as true
+      null_object.is_a?(PolyBelongsTo::FakedCollection).must_be_same_as true
     end
 
     it "build #instance_of? FakedCollection object" do
       steve_photos.must_be_instance_of(PolyBelongsTo::FakedCollection)
+      null_object.must_be_instance_of(PolyBelongsTo::FakedCollection)
     end
     
     it "#build builds appropriately" do
@@ -154,6 +164,7 @@ class FakedCollectionTest < ActiveSupport::TestCase
 
     it "has method_missing forward appropriate calls" do
       steve_photos.method_missing(:nil?).must_equal false
+      null_object.method_missing(:nil?).must_equal true
     end
 
     it "will not initialize on has_many" do
@@ -173,6 +184,12 @@ class FakedCollectionTest < ActiveSupport::TestCase
       nil_steve.must_be :empty?
       nil_steve.instance_eval {@instance}.must_be_nil
       nil_steve.wont_be :valid?
+
+      null_object.all.must_equal []
+      null_object.size.must_be_same_as 0
+      null_object.must_be :empty?
+      null_object.instance_eval {@instance}.must_be_nil
+      null_object.wont_be :valid?
     end
 
   end

data/test/fixtures/address_books.yml

@@ -0,0 +1,9 @@
+# Read about fixtures at
+# http://api.rubyonrails.org/classes/ActiveRecord/Fixtures.html
+
+# This model initially had no columns defined.  If you add columns to the
+# model remove the '{}' from the fixture names and add the columns immediately
+# below each fixture, per the syntax in the comments below
+bob_address_book: {}
+steve_address_book: {}
+susan_address_book: {}

data/test/fixtures/contacts.yml

@@ -0,0 +1,18 @@
+bob_contact:
+  user_id:          <%= ActiveRecord::FixtureSet.identify(:bob) %>
+  contactable_id:   <%= ActiveRecord::FixtureSet.identify(:bob_address_book) %>
+  contactable_type: AddressBook
+  content:          <%= SecureRandom.hex %>
+
+#steve_contact:
+#  user_id:          <%= ActiveRecord::FixtureSet.identify(:steve) %>
+#  contactable_id:   <%= ActiveRecord::FixtureSet.identify(:steve_address_book) %>
+#  contactable_type: AddressBook
+#  content:          <%= SecureRandom.hex %>
+#
+#susan_contact:
+#  user_id:          <%= ActiveRecord::FixtureSet.identify(:susan) %>
+#  contactable_id:   <%= ActiveRecord::FixtureSet.identify(:susan_address_book) %>
+#  contactable_type: AddressBook
+#  content:          <%= SecureRandom.hex %>
+#

data/test/major_version_changes_test.rb

@@ -0,0 +1,66 @@
+require 'test_helper'
+require 'minitest/autorun'
+
+class MajorVersionChangesTest < ActiveSupport::TestCase
+  fixtures :all
+
+  describe "Test breaking changes between major versions" do
+
+    let(:contact) { contacts(:bob_contact) }
+
+    case PolyBelongsTo::VERSION.split('.').take(3).join.to_i
+    when ->v{ v < 100 }
+      it "pre 1.0.0 first parent relation" do
+        contact.pbt.must_be_same_as :user
+        Contact.pbt.must_be_same_as :user
+
+        contact.pbts.must_include :user
+        contact.pbts.must_include :contactable
+        contact.pbts.first.must_be_same_as :user
+        Contact.pbts.must_include :user
+        Contact.pbts.must_include :contactable
+        Contact.pbts.first.must_be_same_as :user
+      end
+      
+      it "pre 1.0.0 :poly? on dual ownership with non-polymorphic first" do
+        contact.poly?.must_be_same_as false
+        Contact.poly?.must_be_same_as false
+      end
+
+      it "pre 1.0.0 :pbt_type_sym on dual ownership with non-polymorphic first" do
+        contact.pbt_id_sym.must_be_same_as :user_id
+        Contact.pbt_id_sym.must_be_same_as :user_id
+      end
+
+      it "pre 1.0.0 :pbt_parent returns first parent" do
+        contact.pbt_parent.id.must_be_same_as users(:bob).id
+      end
+    when ->v { v >= 100 }
+      it "post 1.0.0 first polymorphic parent relation" do
+        contact.pbt.must_be_same_as :contactable
+        Contact.pbt.must_be_same_as :contactable
+
+        contact.pbts.must_include :user
+        contact.pbts.must_include :contactable
+        contact.pbts.first.must_be_same_as :contactable
+        Contact.pbts.must_include :user
+        Contact.pbts.must_include :contactable
+        Contact.pbts.first.must_be_same_as :contactable
+      end
+
+      it "post 1.0.0 :poly? on dual ownership with non-polymorphic first" do
+        contact.poly?.must_be_same_as true
+        Contact.poly?.must_be_same_as true
+      end
+
+      it "pre 1.0.0 :pbt_type_sym on dual ownership with non-polymorphic first" do
+        contact.pbt_id_sym.must_be_same_as :addressable_id
+        Contact.pbt_id_sym.must_be_same_as :addressable_id
+      end
+
+      it "post 1.0.0 :pbt_parent gives polymorphic parent precedence" do
+        contact.pbt_parent.id.wont_equal users(:bob).id
+      end
+    end
+  end
+end

data/test/test_helper.rb

@@ -1,6 +1,8 @@
 ENV["RAILS_ENV"] = "test"
-require "codeclimate-test-reporter"
-CodeClimate::TestReporter.start
+#require "codeclimate-test-reporter"
+#CodeClimate::TestReporter.start
+require 'simplecov'
+SimpleCov.start
 require File.expand_path("../../test/dummy/config/environment.rb",  __FILE__)
 
 ActiveRecord::Migrator.migrations_paths = [File.expand_path("../../test/dummy/db/migrate", __FILE__)]

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: poly_belongs_to
 version: !ruby/object:Gem::Version
-  version: 0.2.8
+  version: 0.2.9
 platform: ruby
 authors:
 - Daniel P. Clark
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-13 00:00:00.000000000 Z
+date: 2016-12-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -108,6 +108,7 @@ files:
 - test/dummy/app/controllers/application_controller.rb
 - test/dummy/app/helpers/application_helper.rb
 - test/dummy/app/models/address.rb
+- test/dummy/app/models/address_book.rb
 - test/dummy/app/models/alpha.rb
 - test/dummy/app/models/beta.rb
 - test/dummy/app/models/capa.rb
@@ -115,6 +116,7 @@ files:
 - test/dummy/app/models/coffee.rb
 - test/dummy/app/models/contact.rb
 - test/dummy/app/models/delta.rb
+- test/dummy/app/models/event.rb
 - test/dummy/app/models/geo_location.rb
 - test/dummy/app/models/phone.rb
 - test/dummy/app/models/photo.rb
@@ -124,6 +126,7 @@ files:
 - test/dummy/app/models/tag.rb
 - test/dummy/app/models/tire.rb
 - test/dummy/app/models/user.rb
+- test/dummy/app/models/work_order.rb
 - test/dummy/app/views/layouts/application.html.erb
 - test/dummy/bin/bundle
 - test/dummy/bin/rails
@@ -165,17 +168,28 @@ files:
 - test/dummy/db/migrate/20150322233743_create_capas.rb
 - test/dummy/db/migrate/20150322233755_create_delta.rb
 - test/dummy/db/migrate/20150511161648_create_coffees.rb
+- test/dummy/db/migrate/20160120224015_add_contactable_to_contacts.rb
+- test/dummy/db/migrate/20160120231645_create_address_books.rb
+- test/dummy/db/migrate/20161209115003_create_events.rb
+- test/dummy/db/migrate/20161209115212_create_work_orders.rb
 - test/dummy/db/schema.rb
 - test/dummy/db/test.sqlite3
 - test/dummy/log/development.log
 - test/dummy/log/test.log
 - test/dummy/public/favicon.ico
 - test/dummy/test/fixtures/coffees.yml
+- test/dummy/test/fixtures/events.yml
+- test/dummy/test/fixtures/work_orders.yml
+- test/dummy/test/models/address_book_test.rb
 - test/dummy/test/models/coffee_test.rb
+- test/dummy/test/models/event_test.rb
+- test/dummy/test/models/work_order_test.rb
 - test/dup_test.rb
 - test/faked_collection_test.rb
+- test/fixtures/address_books.yml
 - test/fixtures/addresses.yml
 - test/fixtures/cars.yml
+- test/fixtures/contacts.yml
 - test/fixtures/geo_locations.yml
 - test/fixtures/phones.yml
 - test/fixtures/photos.yml
@@ -185,6 +199,7 @@ files:
 - test/fixtures/tags.yml
 - test/fixtures/tires.yml
 - test/fixtures/users.yml
+- test/major_version_changes_test.rb
 - test/pbt_test.rb
 - test/singleton_set_test.rb
 - test/test_helper.rb
@@ -208,7 +223,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.6
+rubygems_version: 2.5.2
 signing_key: 
 specification_version: 4
 summary: Uniform Omni-Relational ActiveRecord Tools
@@ -224,6 +239,8 @@ test_files:
 - test/fixtures/users.yml
 - test/fixtures/cars.yml
 - test/fixtures/tags.yml
+- test/fixtures/contacts.yml
+- test/fixtures/address_books.yml
 - test/fixtures/ssns.yml
 - test/singleton_set_test.rb
 - test/test_helper.rb
@@ -232,6 +249,8 @@ test_files:
 - test/dummy/db/test.sqlite3
 - test/dummy/db/schema.rb
 - test/dummy/db/migrate/20150220230146_create_squishies.rb
+- test/dummy/db/migrate/20161209115003_create_events.rb
+- test/dummy/db/migrate/20161209115212_create_work_orders.rb
 - test/dummy/db/migrate/20150322233755_create_delta.rb
 - test/dummy/db/migrate/20150322233743_create_capas.rb
 - test/dummy/db/migrate/20150216092449_create_contacts.rb
@@ -240,7 +259,9 @@ test_files:
 - test/dummy/db/migrate/20150322233720_create_alphas.rb
 - test/dummy/db/migrate/20150216092218_create_addresses.rb
 - test/dummy/db/migrate/20150211224225_create_phones.rb
+- test/dummy/db/migrate/20160120224015_add_contactable_to_contacts.rb
 - test/dummy/db/migrate/20150220213422_create_geo_locations.rb
+- test/dummy/db/migrate/20160120231645_create_address_books.rb
 - test/dummy/db/migrate/20150216092519_create_ssns.rb
 - test/dummy/db/migrate/20150211224157_create_tags.rb
 - test/dummy/db/migrate/20150211224139_create_users.rb
@@ -270,7 +291,10 @@ test_files:
 - test/dummy/app/helpers/application_helper.rb
 - test/dummy/app/models/coffee.rb
 - test/dummy/app/models/ssn.rb
+- test/dummy/app/models/event.rb
 - test/dummy/app/models/capa.rb
+- test/dummy/app/models/work_order.rb
+- test/dummy/app/models/address_book.rb
 - test/dummy/app/models/contact.rb
 - test/dummy/app/models/alpha.rb
 - test/dummy/app/models/car.rb
@@ -295,6 +319,12 @@ test_files:
 - test/dummy/bin/rails
 - test/dummy/bin/bundle
 - test/dummy/bin/setup
+- test/dummy/test/fixtures/work_orders.yml
+- test/dummy/test/fixtures/events.yml
 - test/dummy/test/fixtures/coffees.yml
 - test/dummy/test/models/coffee_test.rb
+- test/dummy/test/models/address_book_test.rb
+- test/dummy/test/models/work_order_test.rb
+- test/dummy/test/models/event_test.rb
 - test/pbt_test.rb
+- test/major_version_changes_test.rb