poly_belongs_to 0.1.4 → 0.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 295e7bd5fc23bc91323e6bf9d8650e1e4b6f59ab
-  data.tar.gz: 9cfbad7a6779856a5950b7410737ee524b8ef29c
+  metadata.gz: 070f2956135ec77c1f784a3291f8aa3d0af97a4e
+  data.tar.gz: 6e8a8b16efb10063d55460b609d1239bc7f956cb
 SHA512:
-  metadata.gz: b3421897cbce5956b73d3ff9339c2ec3755d36ed03c830eef435dce662e83f2ece03604b9bfa50357023267c66d7fb82dba76a0ac7845712dcaa76a1b8634b93
-  data.tar.gz: babae7be384227bb9ee4b181f08598d97b3963d926bae0da03a80d89ccb2758fccfbabdd07a1ca95b223a2c7bdb11e2a1cc705d7828fb0f9e1f1e2ad645a17c8
+  metadata.gz: c74a9a9dd7082aa50375bb07fc488ecf5b7c02513f5a29c7aec2d3690aaa3d19551b85bf60b1b0a4d3b9fe16fa05d610584d5470e7c5456c4314b281c57e6bd0
+  data.tar.gz: a86708d178b640ab44c96514c192b4f335d0ad1c755c9d601105cff1de6ea1c101a04ff038ad59b438e27a3ee7d40db580c88b08102e1778c36f152ab356e4b6

data/README.md

@@ -1,7 +1,7 @@
 #PolyBelongsTo
 [![Gem Version](https://badge.fury.io/rb/poly_belongs_to.svg)](http://badge.fury.io/rb/poly_belongs_to)
-[![Code Climate](https://codeclimate.com/github/danielpclark/PolyBelongsTo/badges/gpa.svg)](https://codeclimate.com/github/danielpclark/PolyBelongsTo)
 [![Build Status](https://travis-ci.org/danielpclark/PolyBelongsTo.svg)](https://travis-ci.org/danielpclark/PolyBelongsTo)
+[![Test Coverage](https://codeclimate.com/github/danielpclark/PolyBelongsTo/badges/coverage.svg)](https://codeclimate.com/github/danielpclark/PolyBelongsTo)
 
 A standard way to check belongs_to relations on any belongs_to Object and let you check your DB Objects polymorphism in a more across-the-board meta-programatically friendly way.
 
@@ -57,7 +57,7 @@ MyObject.first.pbt_parent
 # => #<User id: 123 ... >
 ```
 
-##Also Availabe
+##Also Available
 ```ruby
 # --- Model Instances ---
 # NOTE: touches db if object isn't already instantiated
@@ -90,7 +90,7 @@ MyObject.new.pbt_type_sym       # nil for non polymorphic Objects
 ##Internal Methods Available
 
 ```ruby
-# For cleaning attributs for use with build
+# For cleaning attributes for use with build
 PolyBelongsTo::Pbt::AttrSanitizer[ obj ]
 
 # Returns string of either 'child.build' or 'build_child'
@@ -114,7 +114,9 @@ PolyBelongsTo::Pbt::IsSingular[ obj, child ]
 # Returns true if obj->child relationship is has_many
 PolyBelongsTo::Pbt::IsPlural[ obj, child ]
 
-# Returns the simbol for the CollectionProxy the child belongs to in relation to obj
+# Returns the symbol for the CollectionProxy the child belongs to in relation to obj
+# NOTE: This returns a collection proxy for has_many.
+#       For has_one it's the object ref itself.
 PolyBelongsTo::Pbt::CollectionProxy[ obj, child ]
 
 ```
@@ -130,8 +132,9 @@ know what's involved when using this.  It's purposefully done this way to lead t
 the documentation for PolyBelongsTo's duplication methods.
 
 ####Known Issues
- - Carrierwave records won't duplicate.  To ensure other records to still save and prevent
-rollback use .save(validate: false) ... I'm considering possible options to remedy this and
+ - Carrierwave records won't duplicate.  To ensure that other records will still save and
+prevent any rollback issues use .save(validate: false) ... I'm considering possible options
+to remedy this and
 other scenarios.
  - For deep duplication you need to be very aware of the potential for infinite loops with
 your records if there are any circular references.

data/lib/poly_belongs_to/dup.rb

@@ -16,14 +16,25 @@ module PolyBelongsTo
         pbt_dup_build(item_to_build_on, item_to_duplicate)
         PolyBelongsTo::Pbt::Reflects[item_to_duplicate].each do |ref|
           child = eval("item_to_duplicate.#{ref}")
+          core  = eval("item_to_build_on.#{PolyBelongsTo::Pbt::CollectionProxy[item_to_build_on, item_to_duplicate]}")
           if child.respond_to?(:build)
-            child.each do |obj|
-              eval("item_to_build_on.#{PolyBelongsTo::Pbt::CollectionProxy[item_to_build_on, item_to_duplicate]}").
-                pbt_deep_dup_build(obj)
+            child.each do |spawn|
+              if core.respond_to?(:build)
+                core.each do |subscore|
+                  subscore.pbt_deep_dup_build(spawn)
+                end
+              else
+                core.pbt_deep_dup_build(spawn)
+              end
             end
           else
-            eval("item_to_build_on.#{PolyBelongsTo::Pbt::CollectionProxy[item_to_build_on, item_to_duplicate]}").
-              pbt_deep_dup_build(child)
+            if core.respond_to?(:build)
+              core.each do |subcore|
+                subcore.pbt_deep_dup_build(child)
+              end
+            else
+              core.pbt_deep_dup_build(child)
+            end
           end
         end
         item_to_build_on       

data/lib/poly_belongs_to/poly_belongs_to.rb

@@ -40,27 +40,19 @@ module PolyBelongsTo
     }
 
     IsSingular = lambda {|obj, child|
-      eval(obj.class.name).reflect_on_all_associations(:has_one).
-        map(&:name).map(&:to_sym).include? ActiveModel::Naming.singular(child).to_sym
+      SingularOrPlural[obj, child] == :singular
     }
 
     IsPlural = lambda {|obj,child|
-      eval(obj.class.name).reflect_on_all_associations(:has_many).
-        map(&:name).map(&:to_sym).include? ActiveModel::Naming.plural(child).to_sym
+      SingularOrPlural[obj, child] == :plural
     }
 
     CollectionProxy = lambda {|obj, child|
       reflects = Reflects[obj]
       proxy = ActiveModel::Naming.singular(child).to_sym
-      if reflects.include? proxy
-        return proxy
-      end
+      return proxy if reflects.include? proxy
       proxy = ActiveModel::Naming.plural(child).to_sym
-      if reflects.include? proxy
-        proxy
-      else
-        nil
-      end
+      reflects.include?(proxy) ? proxy : nil
     }
   end
 end

data/lib/poly_belongs_to/version.rb

@@ -1,3 +1,3 @@
 module PolyBelongsTo
-  VERSION = "0.1.4"
+  VERSION = "0.1.5"
 end

data/lib/poly_belongs_to.rb

@@ -4,7 +4,6 @@
 $: << File.join(File.dirname(__FILE__), "/poly_belongs_to")
 require 'poly_belongs_to/version'
 require 'poly_belongs_to/dup'
-require 'poly_belongs_to/hierarchy'
 require 'poly_belongs_to/poly_belongs_to'
 require 'active_support/concern'
 

data/test/dummy/app/models/address.rb

@@ -1,3 +1,5 @@
 class Address < ActiveRecord::Base
   belongs_to :addressable, polymorphic: true
+  has_one :geo_location
+  has_many :squishies, as: :squishable, dependent: :destroy
 end

data/test/dummy/app/models/geo_location.rb

@@ -0,0 +1,4 @@
+class GeoLocation < ActiveRecord::Base
+  belongs_to :address
+  has_many :squishies, as: :squishable, dependent: :destroy
+end

data/test/dummy/app/models/squishy.rb

@@ -0,0 +1,3 @@
+class Squishy < ActiveRecord::Base
+  belongs_to :squishable, polymorphic: true
+end

data/test/dummy/db/migrate/20150220213422_create_geo_locations.rb

@@ -0,0 +1,11 @@
+class CreateGeoLocations < ActiveRecord::Migration
+  def change
+    create_table :geo_locations do |t|
+      t.integer :address_id
+      t.string :content
+
+      t.timestamps
+    end
+    add_index :geo_locations, :address_id
+  end
+end

data/test/dummy/db/migrate/20150220230146_create_squishies.rb

@@ -0,0 +1,10 @@
+class CreateSquishies < ActiveRecord::Migration
+  def change
+    create_table :squishies do |t|
+      t.string :content
+      t.references :squishable, polymorphic: true, index: true
+
+      t.timestamps
+    end
+  end
+end

data/test/dummy/db/schema.rb

@@ -11,7 +11,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema.define(version: 20150216092519) do
+ActiveRecord::Schema.define(version: 20150220230146) do
 
   create_table "addresses", force: true do |t|
     t.integer  "addressable_id"
@@ -32,6 +32,15 @@ ActiveRecord::Schema.define(version: 20150216092519) do
 
   add_index "contacts", ["user_id"], name: "index_contacts_on_user_id"
 
+  create_table "geo_locations", force: true do |t|
+    t.integer  "address_id"
+    t.string   "content"
+    t.datetime "created_at"
+    t.datetime "updated_at"
+  end
+
+  add_index "geo_locations", ["address_id"], name: "index_geo_locations_on_address_id"
+
   create_table "phones", force: true do |t|
     t.integer  "phoneable_id"
     t.string   "phoneable_type"
@@ -62,6 +71,16 @@ ActiveRecord::Schema.define(version: 20150216092519) do
 
   add_index "profiles", ["profileable_id", "profileable_type"], name: "index_profiles_on_profileable_id_and_profileable_type"
 
+  create_table "squishies", force: true do |t|
+    t.string   "content"
+    t.integer  "squishable_id"
+    t.string   "squishable_type"
+    t.datetime "created_at"
+    t.datetime "updated_at"
+  end
+
+  add_index "squishies", ["squishable_id", "squishable_type"], name: "index_squishies_on_squishable_id_and_squishable_type"
+
   create_table "ssns", force: true do |t|
     t.integer  "user_id"
     t.string   "content"

data/test/dummy/log/development.log

@@ -53,3 +53,119 @@ Migrating to CreateSsns (20150216092519)
   ActiveRecord::SchemaMigration Load (0.2ms)  SELECT "schema_migrations".* FROM "schema_migrations"
   User Load (0.5ms)  SELECT "users".* FROM "users" ORDER BY "users"."id" ASC LIMIT 1
 SQLite3::SQLException: no such table: users: SELECT  "users".* FROM "users"   ORDER BY "users"."id" ASC LIMIT 1
+   (26.7ms)  CREATE TABLE "schema_migrations" ("version" varchar(255) NOT NULL) 
+   (15.6ms)  CREATE UNIQUE INDEX "unique_schema_migrations" ON "schema_migrations" ("version")
+  ActiveRecord::SchemaMigration Load (0.3ms)  SELECT "schema_migrations".* FROM "schema_migrations"
+Migrating to CreateUsers (20150211224139)
+   (0.1ms)  begin transaction
+   (0.8ms)  CREATE TABLE "users" ("id" INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, "content" varchar(255), "created_at" datetime NOT NULL, "updated_at" datetime NOT NULL) 
+  SQL (0.1ms)  INSERT INTO "schema_migrations" ("version") VALUES (?)  [["version", "20150211224139"]]
+   (13.0ms)  commit transaction
+Migrating to CreateTags (20150211224157)
+   (0.1ms)  begin transaction
+   (0.6ms)  CREATE TABLE "tags" ("id" INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, "user_id" integer, "content" varchar(255), "created_at" datetime NOT NULL, "updated_at" datetime NOT NULL) 
+   (0.3ms)  CREATE INDEX "index_tags_on_user_id" ON "tags" ("user_id")
+  SQL (0.3ms)  INSERT INTO "schema_migrations" ("version") VALUES (?)  [["version", "20150211224157"]]
+   (17.4ms)  commit transaction
+Migrating to CreatePhones (20150211224225)
+   (0.1ms)  begin transaction
+   (0.7ms)  CREATE TABLE "phones" ("id" INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, "phoneable_id" integer, "phoneable_type" varchar(255), "content" varchar(255), "created_at" datetime NOT NULL, "updated_at" datetime NOT NULL) 
+   (0.3ms)  CREATE INDEX "index_phones_on_phoneable_id_and_phoneable_type" ON "phones" ("phoneable_id", "phoneable_type")
+  SQL (0.3ms)  INSERT INTO "schema_migrations" ("version") VALUES (?)  [["version", "20150211224225"]]
+   (30.0ms)  commit transaction
+Migrating to CreateAddresses (20150216092218)
+   (0.1ms)  begin transaction
+   (0.3ms)  CREATE TABLE "addresses" ("id" INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, "addressable_id" integer, "addressable_type" varchar(255), "content" varchar(255), "created_at" datetime, "updated_at" datetime) 
+   (0.1ms)  CREATE INDEX "index_addresses_on_addressable_id_and_addressable_type" ON "addresses" ("addressable_id", "addressable_type")
+  SQL (0.2ms)  INSERT INTO "schema_migrations" ("version") VALUES (?)  [["version", "20150216092218"]]
+   (31.0ms)  commit transaction
+Migrating to CreateProfiles (20150216092338)
+   (0.1ms)  begin transaction
+   (0.3ms)  CREATE TABLE "profiles" ("id" INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, "profileable_id" integer, "profileable_type" varchar(255), "content" varchar(255), "created_at" datetime, "updated_at" datetime) 
+   (0.1ms)  CREATE INDEX "index_profiles_on_profileable_id_and_profileable_type" ON "profiles" ("profileable_id", "profileable_type")
+  SQL (0.1ms)  INSERT INTO "schema_migrations" ("version") VALUES (?)  [["version", "20150216092338"]]
+   (15.5ms)  commit transaction
+Migrating to CreatePhotos (20150216092411)
+   (0.1ms)  begin transaction
+   (0.3ms)  CREATE TABLE "photos" ("id" INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, "photoable_id" integer, "photoable_type" varchar(255), "content" varchar(255), "created_at" datetime, "updated_at" datetime) 
+   (0.2ms)  CREATE INDEX "index_photos_on_photoable_id_and_photoable_type" ON "photos" ("photoable_id", "photoable_type")
+  SQL (0.1ms)  INSERT INTO "schema_migrations" ("version") VALUES (?)  [["version", "20150216092411"]]
+   (13.2ms)  commit transaction
+Migrating to CreateContacts (20150216092449)
+   (0.1ms)  begin transaction
+   (0.3ms)  CREATE TABLE "contacts" ("id" INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, "user_id" integer, "content" varchar(255), "created_at" datetime, "updated_at" datetime) 
+   (0.1ms)  CREATE INDEX "index_contacts_on_user_id" ON "contacts" ("user_id")
+  SQL (0.1ms)  INSERT INTO "schema_migrations" ("version") VALUES (?)  [["version", "20150216092449"]]
+   (12.9ms)  commit transaction
+Migrating to CreateSsns (20150216092519)
+   (0.1ms)  begin transaction
+   (0.6ms)  CREATE TABLE "ssns" ("id" INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, "user_id" integer, "content" varchar(255), "created_at" datetime, "updated_at" datetime) 
+   (0.3ms)  CREATE INDEX "index_ssns_on_user_id" ON "ssns" ("user_id")
+  SQL (0.3ms)  INSERT INTO "schema_migrations" ("version") VALUES (?)  [["version", "20150216092519"]]
+   (18.5ms)  commit transaction
+Migrating to CreateGeoLocations (20150220213422)
+   (0.1ms)  begin transaction
+   (0.4ms)  CREATE TABLE "geo_locations" ("id" INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, "address_id" integer, "content" varchar(255), "created_at" datetime, "updated_at" datetime) 
+   (0.4ms)  CREATE INDEX "index_geo_locations_on_address_id" ON "geo_locations" ("address_id")
+  SQL (0.1ms)  INSERT INTO "schema_migrations" ("version") VALUES (?)  [["version", "20150220213422"]]
+   (12.6ms)  commit transaction
+  ActiveRecord::SchemaMigration Load (0.1ms)  SELECT "schema_migrations".* FROM "schema_migrations"
+  ActiveRecord::SchemaMigration Load (0.1ms)  SELECT "schema_migrations".* FROM "schema_migrations"
+  ActiveRecord::SchemaMigration Load (0.1ms)  SELECT "schema_migrations".* FROM "schema_migrations"
+   (17.9ms)  CREATE TABLE "schema_migrations" ("version" varchar(255) NOT NULL) 
+   (25.0ms)  CREATE UNIQUE INDEX "unique_schema_migrations" ON "schema_migrations" ("version")
+  ActiveRecord::SchemaMigration Load (0.2ms)  SELECT "schema_migrations".* FROM "schema_migrations"
+Migrating to CreateUsers (20150211224139)
+   (0.1ms)  begin transaction
+   (0.8ms)  CREATE TABLE "users" ("id" INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, "content" varchar(255), "created_at" datetime NOT NULL, "updated_at" datetime NOT NULL) 
+  SQL (0.2ms)  INSERT INTO "schema_migrations" ("version") VALUES (?)  [["version", "20150211224139"]]
+   (12.1ms)  commit transaction
+Migrating to CreateTags (20150211224157)
+   (0.1ms)  begin transaction
+   (0.4ms)  CREATE TABLE "tags" ("id" INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, "user_id" integer, "content" varchar(255), "created_at" datetime NOT NULL, "updated_at" datetime NOT NULL) 
+   (0.3ms)  CREATE INDEX "index_tags_on_user_id" ON "tags" ("user_id")
+  SQL (0.3ms)  INSERT INTO "schema_migrations" ("version") VALUES (?)  [["version", "20150211224157"]]
+   (12.3ms)  commit transaction
+Migrating to CreatePhones (20150211224225)
+   (0.1ms)  begin transaction
+   (0.5ms)  CREATE TABLE "phones" ("id" INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, "phoneable_id" integer, "phoneable_type" varchar(255), "content" varchar(255), "created_at" datetime NOT NULL, "updated_at" datetime NOT NULL) 
+   (0.3ms)  CREATE INDEX "index_phones_on_phoneable_id_and_phoneable_type" ON "phones" ("phoneable_id", "phoneable_type")
+  SQL (0.2ms)  INSERT INTO "schema_migrations" ("version") VALUES (?)  [["version", "20150211224225"]]
+   (12.1ms)  commit transaction
+Migrating to CreateAddresses (20150216092218)
+   (0.1ms)  begin transaction
+   (0.6ms)  CREATE TABLE "addresses" ("id" INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, "addressable_id" integer, "addressable_type" varchar(255), "content" varchar(255), "created_at" datetime, "updated_at" datetime) 
+   (0.4ms)  CREATE INDEX "index_addresses_on_addressable_id_and_addressable_type" ON "addresses" ("addressable_id", "addressable_type")
+  SQL (0.1ms)  INSERT INTO "schema_migrations" ("version") VALUES (?)  [["version", "20150216092218"]]
+   (12.5ms)  commit transaction
+Migrating to CreateProfiles (20150216092338)
+   (0.1ms)  begin transaction
+   (0.6ms)  CREATE TABLE "profiles" ("id" INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, "profileable_id" integer, "profileable_type" varchar(255), "content" varchar(255), "created_at" datetime, "updated_at" datetime) 
+   (0.2ms)  CREATE INDEX "index_profiles_on_profileable_id_and_profileable_type" ON "profiles" ("profileable_id", "profileable_type")
+  SQL (0.2ms)  INSERT INTO "schema_migrations" ("version") VALUES (?)  [["version", "20150216092338"]]
+   (12.4ms)  commit transaction
+Migrating to CreatePhotos (20150216092411)
+   (0.1ms)  begin transaction
+   (0.4ms)  CREATE TABLE "photos" ("id" INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, "photoable_id" integer, "photoable_type" varchar(255), "content" varchar(255), "created_at" datetime, "updated_at" datetime) 
+   (0.2ms)  CREATE INDEX "index_photos_on_photoable_id_and_photoable_type" ON "photos" ("photoable_id", "photoable_type")
+  SQL (0.1ms)  INSERT INTO "schema_migrations" ("version") VALUES (?)  [["version", "20150216092411"]]
+   (12.6ms)  commit transaction
+Migrating to CreateContacts (20150216092449)
+   (0.1ms)  begin transaction
+   (0.8ms)  CREATE TABLE "contacts" ("id" INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, "user_id" integer, "content" varchar(255), "created_at" datetime, "updated_at" datetime) 
+   (0.4ms)  CREATE INDEX "index_contacts_on_user_id" ON "contacts" ("user_id")
+  SQL (0.2ms)  INSERT INTO "schema_migrations" ("version") VALUES (?)  [["version", "20150216092449"]]
+   (18.4ms)  commit transaction
+Migrating to CreateSsns (20150216092519)
+   (0.2ms)  begin transaction
+   (0.6ms)  CREATE TABLE "ssns" ("id" INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, "user_id" integer, "content" varchar(255), "created_at" datetime, "updated_at" datetime) 
+   (0.3ms)  CREATE INDEX "index_ssns_on_user_id" ON "ssns" ("user_id")
+  SQL (0.2ms)  INSERT INTO "schema_migrations" ("version") VALUES (?)  [["version", "20150216092519"]]
+   (12.6ms)  commit transaction
+Migrating to CreateGeoLocations (20150220213422)
+   (0.1ms)  begin transaction
+   (0.7ms)  CREATE TABLE "geo_locations" ("id" INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, "address_id" integer, "content" varchar(255), "created_at" datetime, "updated_at" datetime) 
+   (0.5ms)  CREATE INDEX "index_geo_locations_on_address_id" ON "geo_locations" ("address_id")
+  SQL (0.3ms)  INSERT INTO "schema_migrations" ("version") VALUES (?)  [["version", "20150220213422"]]
+   (13.0ms)  commit transaction
+  ActiveRecord::SchemaMigration Load (0.1ms)  SELECT "schema_migrations".* FROM "schema_migrations"