polleverywhere-cops 1.1.0 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1b6628dcdc0949ab8a9a4c961e344b535069f610
-  data.tar.gz: 0f91e16f0da73b121b83b11c091720156592e158
+  metadata.gz: 7913672b2b360707923e231046ee3eede74a07fe
+  data.tar.gz: 94779a03f3ca7d87a23dcf0001b3911925120c93
 SHA512:
-  metadata.gz: 2e0208d41d0f39cb125cebfec70724d2d47db9e229df366335a433c43b5fe788c460dfcaf10eb827cbdcaf70a1ead9bb5fec7480e1f21a35ccc7265ee378c279
-  data.tar.gz: a827b5bbe9930667bc197666c5b0352b7a6e160cb286a083a3b3a6a59499b919567b189b716b537fb7b474c1e2d89212b7b06ce777dfacb7809fe750f96a71d0
+  metadata.gz: 13bfdb335a3c9f6decb4aaafb7eebc0bbb2b5fcd16f6daec2556dac79fbb26fede8797eab3f9ca3398132cc20abe05b67908c2e9deec855a867d9291e81f11f2
+  data.tar.gz: 782401cd2d8262c2b1fd9102f6947e5f63a49e481b84419aeee520457061d78570efdf35759d5354e13e3a0e840adfd311bf40ff78451aa4d8b94d3973af5a15

data/README.md

@@ -4,8 +4,9 @@ Custom RuboCop cops for Poll Everywhere
 
 ## Cops
 
-- *NullableBoolean*: Boolean database columns cannot be nullable.
+- _NullableBoolean_: Boolean database columns cannot be nullable.
 - _Constantize_: Don't call String#constantize.
+- _RenderViews_: Don't call `render_views` in controller specs.
 
 ## Instructions
 

data/lib/polleverywhere-cops.rb

@@ -4,3 +4,4 @@ require "rubocop/polleverywhere/version"
 # cops
 require "rubocop/cop/polleverywhere/nullable_boolean"
 require "rubocop/cop/polleverywhere/constantize"
+require "rubocop/cop/polleverywhere/render_views"

data/lib/rubocop/cop/polleverywhere/render_views.rb

@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module PollEverywhere
+      class RenderViews < Cop
+        MSG = 'Do not use `render_views` in controller tests because it is an order of magnitude slower. If view rendering needs to be tested, write a different type of test.'.freeze
+
+        def_node_matcher :render_views?, <<-PATTERN
+          (send nil? :render_views)
+        PATTERN
+
+        def on_send(node)
+          return unless render_views?(node)
+
+          add_offense(node, location: :selector)
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/polleverywhere/version.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module PollEverywhere
     module Version
-      STRING = "1.1.0".freeze
+      STRING = "1.2.0".freeze
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: polleverywhere-cops
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.2.0
 platform: ruby
 authors:
 - Poll Everywhere
@@ -40,6 +40,7 @@ files:
 - lib/polleverywhere-cops.rb
 - lib/rubocop/cop/polleverywhere/constantize.rb
 - lib/rubocop/cop/polleverywhere/nullable_boolean.rb
+- lib/rubocop/cop/polleverywhere/render_views.rb
 - lib/rubocop/polleverywhere/version.rb
 - polleverywhere-cops.gemspec
 homepage: https://github.com/polleverywhere/polleverywhere-cops