polleverywhere-cops 1.0.2 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4491c9d4396f33d23ef6aeb72acf71d0639cd12e
-  data.tar.gz: c405752669d59847d55706a71ecfc24adfedfc61
+  metadata.gz: 1b6628dcdc0949ab8a9a4c961e344b535069f610
+  data.tar.gz: 0f91e16f0da73b121b83b11c091720156592e158
 SHA512:
-  metadata.gz: 9c3e0ea336644d67eb12209f66224ea26ca28d15a5c4e4373e11047409211b642b551740e333892d1f2eca5cc8be15d66e1714533906b748ec7100c2ea26f4a3
-  data.tar.gz: c0218b1960b550ee04b5ab813b12cd5a365876d9cfe27450ff476ebc838148104bd59b310b37010ae30f827ccbc95aaf0d3ea811d32d48634b5a2debb8ff6a7d
+  metadata.gz: 2e0208d41d0f39cb125cebfec70724d2d47db9e229df366335a433c43b5fe788c460dfcaf10eb827cbdcaf70a1ead9bb5fec7480e1f21a35ccc7265ee378c279
+  data.tar.gz: a827b5bbe9930667bc197666c5b0352b7a6e160cb286a083a3b3a6a59499b919567b189b716b537fb7b474c1e2d89212b7b06ce777dfacb7809fe750f96a71d0

data/CHANGELOG.md

@@ -0,0 +1,6 @@
+# Change Log
+
+## Version 1.1.0
+- Added Constantize cop
+- Updated all cops to support rubocop v 0.51.0
+- Now requires at least version 0.51.0 of rubocop

data/README.md

@@ -5,6 +5,7 @@ Custom RuboCop cops for Poll Everywhere
 ## Cops
 
 - *NullableBoolean*: Boolean database columns cannot be nullable.
+- _Constantize_: Don't call String#constantize.
 
 ## Instructions
 
@@ -20,3 +21,11 @@ Add to `.rubocop.yml`:
 require:
 - polleverywhere-cops
 ```
+
+## Publishing to RubyGems
+
+```
+$EDITOR lib/rubocop/polleverywhere/version.rb
+gem build polleverywhere-cops.gemspec
+gem push polleverywhere-cops-x.x.x.gem
+```

data/TODO.md

@@ -0,0 +1,5 @@
+# TODO
+
+- Boolean columns that begin with `is_`
+- `render json:` calls without an explicit `serializer:` option
+- Items from Poll Everywhere's [code conventions](https://playbook.polleverywhere.com/conventions/)

data/lib/polleverywhere-cops.rb

@@ -3,3 +3,4 @@ require "rubocop/polleverywhere/version"
 
 # cops
 require "rubocop/cop/polleverywhere/nullable_boolean"
+require "rubocop/cop/polleverywhere/constantize"

data/lib/rubocop/cop/polleverywhere/constantize.rb

@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+
+module RuboCop
+  module Cop
+    module PollEverywhere
+      class Constantize < Cop
+        MSG = 'The use of `constantize` is a potential security risk.'.freeze
+
+        def_node_matcher :constantize?, <<-PATTERN
+          (send (...) :constantize)
+        PATTERN
+
+        def on_send(node)
+          return unless constantize?(node)
+
+          add_offense(node, location: :selector)
+        end
+      end
+    end
+  end
+end

data/lib/rubocop/cop/polleverywhere/nullable_boolean.rb

@@ -8,7 +8,7 @@ module RuboCop
 
         def on_send(node)
           if adding_boolean?(node) && nullable?(node)
-            add_offense(node, :expression, MSG)
+            add_offense(node, location: :expression, message: MSG)
           end
         end
 

data/lib/rubocop/polleverywhere/version.rb

@@ -3,7 +3,7 @@
 module RuboCop
   module PollEverywhere
     module Version
-      STRING = "1.0.2".freeze
+      STRING = "1.1.0".freeze
     end
   end
 end

data/polleverywhere-cops.gemspec

@@ -15,5 +15,5 @@ Gem::Specification.new do |gem|
   gem.extra_rdoc_files = ["README.md"]
   gem.rdoc_options     = ["--main", "README.md"]
 
-  gem.add_runtime_dependency "rubocop", ">= 0.48.1"
+  gem.add_runtime_dependency "rubocop", ">= 0.51.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: polleverywhere-cops
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.1.0
 platform: ruby
 authors:
 - Poll Everywhere
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-08 00:00:00.000000000 Z
+date: 2018-09-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.48.1
+        version: 0.51.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.48.1
+        version: 0.51.0
 description: Custom RuboCop cops for Poll Everywhere
 email:
 - geeks@polleverywhere.com
@@ -33,9 +33,12 @@ extra_rdoc_files:
 - README.md
 files:
 - ".gitignore"
+- CHANGELOG.md
 - LICENSE
 - README.md
+- TODO.md
 - lib/polleverywhere-cops.rb
+- lib/rubocop/cop/polleverywhere/constantize.rb
 - lib/rubocop/cop/polleverywhere/nullable_boolean.rb
 - lib/rubocop/polleverywhere/version.rb
 - polleverywhere-cops.gemspec
@@ -61,7 +64,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.13
+rubygems_version: 2.6.14
 signing_key: 
 specification_version: 4
 summary: Custom RuboCop cops for Poll Everywhere