polishgeeks-dev-tools 1.0.0

data/spec/lib/polishgeeks/dev-tools/command/expires_in_spec.rb

@@ -0,0 +1,69 @@
+require 'spec_helper'
+
+RSpec.describe PolishGeeks::DevTools::Command::ExpiresIn do
+  subject { described_class.new }
+
+  let(:config) { double }
+
+  describe '#execute' do
+    it 'should execute the command' do
+      subject.execute
+    end
+  end
+
+  describe '#label' do
+    it { expect(subject.label).to eq 'Expires in' }
+  end
+
+  describe '#error_message' do
+    context 'when output is not empty' do
+      let(:file_name) { rand.to_s }
+      let(:output) { [file_name] }
+      let(:expected) { "Following files use expire_in instead of expires_in:\n\n#{file_name}\n" }
+      before do
+        subject.instance_variable_set('@output', output)
+      end
+      it { expect(subject.error_message).to eq expected }
+    end
+  end
+
+  describe '#valid?' do
+    context 'when output is empty' do
+      before do
+        subject.instance_variable_set('@output', '')
+      end
+      it { expect(subject.valid?).to eq true }
+    end
+  end
+
+  describe '#excludes' do
+    context 'when expire_files_ignored is not set' do
+      let(:config) { double(expires_in_files_ignored: nil) }
+
+      before do
+        expect(PolishGeeks::DevTools)
+          .to receive(:config)
+          .and_return(config)
+      end
+
+      it { expect(subject.send(:excludes)).to eq [] }
+    end
+
+    context 'when expire_files_ignored is set' do
+      let(:expires_in_files_ignored) { rand }
+      let(:config) do
+        double(
+          expires_in_files_ignored: expires_in_files_ignored
+        )
+      end
+
+      before do
+        expect(PolishGeeks::DevTools)
+          .to receive(:config)
+          .and_return(config)
+      end
+
+      it { expect(subject.send(:excludes)).to eq expires_in_files_ignored }
+    end
+  end
+end

data/spec/lib/polishgeeks/dev-tools/command/haml_lint_spec.rb

@@ -0,0 +1,79 @@
+require 'spec_helper'
+
+RSpec.describe PolishGeeks::DevTools::Command::HamlLint do
+  subject { described_class.new }
+
+  describe '#execute' do
+    let(:path) { '/' }
+    before do
+      expect(ENV)
+        .to receive(:[])
+        .with('BUNDLE_GEMFILE')
+        .and_return(path)
+    end
+
+    context 'when app config exists' do
+      before do
+        expect(File)
+          .to receive(:exist?)
+          .and_return(true)
+        expect_any_instance_of(PolishGeeks::DevTools::Shell)
+          .to receive(:execute)
+          .with("bundle exec haml-lint -c #{path}.haml-lint.yml app/views")
+      end
+
+      it 'should execute the command' do
+        subject.execute
+      end
+    end
+
+    context 'when app config does not exist' do
+      let(:path) { Dir.pwd }
+      before do
+        expect(PolishGeeks::DevTools)
+          .to receive(:gem_root)
+          .and_return(path)
+        expect(File)
+          .to receive(:exist?)
+          .and_return(false)
+        expect_any_instance_of(PolishGeeks::DevTools::Shell)
+          .to receive(:execute)
+          .with("bundle exec haml-lint -c #{path}/config/haml-lint.yml app/views")
+      end
+
+      it 'should execute the command' do
+        subject.execute
+      end
+    end
+  end
+
+  describe '#valid?' do
+    context 'when there are some issues' do
+      before do
+        subject.instance_variable_set('@output', '[W] SpaceInsideHashAttributes')
+      end
+
+      it 'should be false' do
+        expect(subject.valid?).to eq false
+      end
+    end
+
+    context 'when there are no issues' do
+      before do
+        subject.instance_variable_set('@output', '')
+      end
+
+      it 'should be true' do
+        expect(subject.valid?).to eq true
+      end
+    end
+  end
+
+  describe '.generator?' do
+    it { expect(described_class.generator?).to eq false }
+  end
+
+  describe '.validator?' do
+    it { expect(described_class.validator?).to eq true }
+  end
+end

data/spec/lib/polishgeeks/dev-tools/command/readme_spec.rb

@@ -0,0 +1,38 @@
+require 'spec_helper'
+
+RSpec.describe PolishGeeks::DevTools::Command::Readme do
+  subject { described_class.new }
+
+  let(:config) { double }
+
+  describe '#execute' do
+    it 'should execute the command' do
+      subject.execute
+    end
+  end
+
+  describe '#label' do
+    let(:expected) { 'README.rb required' }
+
+    it { expect(subject.label).to eq expected }
+  end
+
+  describe '#error_message' do
+    let(:expected) { "README.rb doesn't exist!" }
+    let(:output) { false }
+
+    it { expect(subject.error_message).to eq expected }
+  end
+
+  describe '#valid?' do
+    context 'when README.md exist' do
+      before do
+        subject.instance_variable_set('@output', true)
+      end
+
+      it 'should return true' do
+        expect(subject.valid?).to be true
+      end
+    end
+  end
+end

data/spec/lib/polishgeeks/dev-tools/command/rspec_files_names_spec.rb

@@ -0,0 +1,91 @@
+require 'spec_helper'
+
+RSpec.describe PolishGeeks::DevTools::Command::RspecFilesNames do
+  subject { described_class.new }
+
+  let(:config) { double }
+
+  describe '#execute' do
+    let(:path) { rand.to_s }
+
+    before do
+      described_class::CHECKED_DIRS.each do |name|
+        expect(File)
+          .to receive(:join)
+          .with(::PolishGeeks::DevTools.app_root, 'spec', name)
+          .and_return(path)
+      end
+
+      expect(Dir)
+        .to receive(:glob)
+        .with("#{path}/**/*")
+        .exactly(described_class::CHECKED_DIRS.count).times
+        .and_return(files)
+
+      expect(File)
+        .to receive(:file?)
+        .and_return(true)
+        .exactly(described_class::CHECKED_DIRS.count).times
+
+      subject.execute
+    end
+
+    context 'when we dont have invalid files' do
+      let(:files) { ['test_spec.rb'] }
+
+      it 'should set appropriate variables' do
+        expect(subject.output).to eq []
+        expect(subject.counter).to eq(described_class::CHECKED_DIRS.count * files.count)
+      end
+    end
+
+    context 'when we have invalid files' do
+      let(:files) { ['test_spe.rb'] }
+
+      it 'should set appropriate variables' do
+        expect(subject.output).to eq(files * described_class::CHECKED_DIRS.count)
+        expect(subject.counter).to eq(described_class::CHECKED_DIRS.count * files.count)
+      end
+    end
+  end
+
+  describe '#valid?' do
+    before do
+      subject.instance_variable_set('@output', output)
+    end
+
+    context 'when output is empty' do
+      let(:output) { [] }
+
+      it { expect(subject.valid?).to eq true }
+    end
+
+    context 'when output is not empty' do
+      let(:output) { ['file_name'] }
+
+      it { expect(subject.valid?).to eq false }
+    end
+  end
+
+  describe '#label' do
+    let(:counter) { rand(1000) }
+    let(:expected) { "Rspec files names: #{counter} files checked" }
+
+    before do
+      subject.instance_variable_set('@counter', counter)
+    end
+
+    it { expect(subject.label).to eq expected }
+  end
+
+  describe '#error_message' do
+    let(:output) { [rand.to_s, rand.to_s] }
+    let(:expected) { "Following files have invalid name: \n #{output.join("\n")}\n" }
+
+    before do
+      subject.instance_variable_set('@output', output)
+    end
+
+    it { expect(subject.error_message).to eq expected }
+  end
+end

data/spec/lib/polishgeeks/dev-tools/command/rspec_files_structure_spec.rb

@@ -0,0 +1,262 @@
+require 'spec_helper'
+
+RSpec.describe PolishGeeks::DevTools::Command::RspecFilesStructure do
+  subject { described_class.new }
+
+  describe '#execute' do
+    let(:analyzed_files_result) { double }
+    let(:rspec_files_result) { double }
+    let(:substract_result) { double }
+    let(:substract_rspec_result) { double }
+    let(:expected) { Hash(app: substract_result, rspec: substract_rspec_result) }
+
+    before do
+      expect(subject)
+        .to receive(:analyzed_files)
+        .twice
+        .and_return(analyzed_files_result)
+
+      expect(subject)
+        .to receive(:rspec_files)
+        .exactly(2).times
+        .and_return(rspec_files_result)
+
+      expect(analyzed_files_result)
+        .to receive(:-)
+        .and_return(substract_result)
+
+      expect(rspec_files_result)
+        .to receive(:-)
+        .and_return(substract_rspec_result)
+    end
+
+    it 'should be subtraction' do
+      subject.execute
+
+      expect(subject.instance_variable_get(:@output)).to eq expected
+    end
+  end
+
+  describe '#analyzed_files' do
+    let(:config) { double(rspec_files_structure_ignored: nil) }
+
+    before do
+      expect(PolishGeeks::DevTools)
+        .to receive(:config)
+        .and_return(config)
+        .at_least(:once)
+    end
+
+    it { expect(subject.send(:analyzed_files)).to_not be_empty }
+
+    context 'when we gather files for analyze' do
+      let(:file) { double }
+      let(:files_collection) { [file] }
+
+      before do
+        expect(described_class::FILES_CHECKED)
+          .to receive(:map)
+          .and_return(files_collection)
+      end
+
+      it 'should flatten, uniq and sanitize' do
+        expect(files_collection)
+          .to receive(:flatten!)
+
+        expect(files_collection)
+          .to receive(:uniq!)
+
+        expect(subject)
+          .to receive(:sanitize)
+          .with(file)
+
+        subject.send(:analyzed_files)
+      end
+    end
+  end
+
+  describe '#rspec_files' do
+    let(:config) { double(rspec_files_structure_ignored: nil) }
+
+    before do
+      expect(PolishGeeks::DevTools)
+        .to receive(:config)
+        .and_return(config)
+        .at_least(:once)
+    end
+
+    it { expect(subject.send(:rspec_files)).to_not be_empty }
+
+    context 'when we gather rspec files' do
+      let(:file) { double }
+      let(:files_collection) { [file] }
+
+      before do
+        expect(described_class::RSPEC_FILES)
+          .to receive(:map)
+          .and_return(files_collection)
+      end
+
+      it 'should flatten, uniq and sanitize' do
+        expect(files_collection)
+          .to receive(:flatten!)
+
+        expect(files_collection)
+          .to receive(:uniq!)
+
+        expect(subject)
+          .to receive(:sanitize)
+          .with(file)
+
+        subject.send(:rspec_files)
+      end
+    end
+  end
+
+  describe '#valid?' do
+    before do
+      subject.instance_variable_set('@output', output)
+    end
+
+    context 'when output is empty' do
+      let(:output) { Hash(app: [], rspec: []) }
+
+      it { expect(subject.valid?).to eq true }
+    end
+
+    context 'when output is not empty' do
+      let(:output) { Hash(app: [double], rspec: [double]) }
+
+      it { expect(subject.valid?).to eq false }
+    end
+  end
+
+  describe '#label' do
+    context 'when we run rspec_files_structure' do
+      let(:analyzed_files_result) { double(count: rand(1000)) }
+
+      before do
+        expect(subject)
+          .to receive(:analyzed_files)
+          .and_return(analyzed_files_result)
+      end
+
+      it 'should return the label' do
+        expected = "Rspec files structure (#{analyzed_files_result.count} checked)"
+        expect(subject.label).to eq expected
+      end
+    end
+  end
+
+  describe '#error_message' do
+    context 'when files don\'t have corresponding Rspec files' do
+      let(:message) { rand.to_s }
+      let(:expected) { message + message }
+      before do
+        expect(subject)
+          .to receive(:files_error_message)
+          .and_return(message)
+        expect(subject)
+          .to receive(:rspec_error_message)
+          .and_return(message)
+      end
+
+      it 'should return the error message' do
+        expect(subject.error_message).to eq expected
+      end
+    end
+  end
+
+  describe '#excludes' do
+    context 'when rspec_files_structure_ignored is not set' do
+      let(:config) { double(rspec_files_structure_ignored: nil) }
+
+      before do
+        expect(PolishGeeks::DevTools)
+          .to receive(:config)
+          .and_return(config)
+      end
+
+      it { expect(subject.send(:excludes)).to eq [] }
+    end
+
+    context 'when rspec_files_structure_ignored is set' do
+      let(:rspec_files_structure_ignored) { rand }
+      let(:config) do
+        double(
+          rspec_files_structure_ignored: rspec_files_structure_ignored
+        )
+      end
+
+      before do
+        expect(PolishGeeks::DevTools)
+          .to receive(:config)
+          .and_return(config)
+      end
+
+      it { expect(subject.send(:excludes)).to eq rspec_files_structure_ignored }
+    end
+  end
+
+  describe '#sanitize' do
+    let(:base) { rand.to_s }
+
+    context 'app root' do
+      let(:string) { "#{PolishGeeks::DevTools.app_root}/#{base}" }
+
+      it ' should be removed' do
+        expect(subject.send(:sanitize, string)).to eq base
+      end
+    end
+
+    context '_spec' do
+      let(:string) { "#{base}_spec.rb" }
+
+      it ' should be removed' do
+        expect(subject.send(:sanitize, string)).to eq "#{base}.rb"
+      end
+    end
+
+    context 'spec/' do
+      let(:string) { "spec/#{base}" }
+
+      it ' should be removed' do
+        expect(subject.send(:sanitize, string)).to eq base
+      end
+    end
+
+    context 'app/' do
+      let(:string) { "app/#{base}" }
+
+      it ' should be removed' do
+        expect(subject.send(:sanitize, string)).to eq base
+      end
+    end
+  end
+
+  describe '#files_error_message' do
+    let(:output) { Hash(app: ['test.rb'], rspec: ['test_rspec.rb']) }
+
+    before do
+      subject.instance_variable_set(:@output, output)
+    end
+
+    it 'should return the error message' do
+      expect(subject.send(:files_error_message))
+        .to eq "Following files don't have corresponding Rspec files:\n\ntest.rb\n"
+    end
+  end
+
+  describe '#rspec_error_message' do
+    let(:output) { Hash(app: ['test.rb'], rspec: ['test_rspec.rb']) }
+
+    before do
+      subject.instance_variable_set(:@output, output)
+    end
+
+    it 'should return the error message' do
+      expect(subject.send(:rspec_error_message))
+        .to eq "\n\nFollowing Rspec don't have corresponding files:\n\ntest_rspec_spec.rb\n"
+    end
+  end
+end