polisher 0.6.1 → 0.7.1

data/spec/koji_spec.rb

@@ -1,7 +1,7 @@
 # Polisher Koji Spec
 #
 # Licensed under the MIT license
-# Copyright (C) 2013 Red Hat, Inc.
+# Copyright (C) 2013-2014 Red Hat, Inc.
 
 require 'polisher/koji'
 

data/spec/rpmspec_spec.rb

@@ -1,7 +1,7 @@
 # Polisher RPMSpec Specs
 #
 # Licensed under the MIT license
-# Copyright (C) 2013 Red Hat, Inc.
+# Copyright (C) 2013-2014 Red Hat, Inc.
 
 require 'spec_helper'
 
@@ -9,6 +9,342 @@ require 'polisher/rpmspec'
 require 'polisher/gem'
 
 module Polisher
+  describe RPMSpec::Requirement do
+    describe "#str" do
+      it "returns requirement in string format" do
+        req = described_class.new :name => 'rubygem(activesupport)'
+        req.str.should == 'rubygem(activesupport)'
+
+        req = described_class.new :name => 'rubygem(activesupport)',
+                                  :condition => '>=', :version => '4.0'
+        req.str.should == 'rubygem(activesupport) >= 4.0'
+      end
+    end
+
+    describe "#specifier" do
+      it "returns specifier in string format" do
+        req = described_class.new :condition => '>=', :version => '10.0'
+        req.specifier.should == '>= 10.0'
+      end
+
+      context "version is nil" do
+        it "returns nil" do
+          req = described_class.new
+          req.specifier.should be_nil
+        end
+      end
+    end
+
+    describe "#parse" do
+      it "parses requirement string" do
+        req = described_class.parse "Requires: rubygem(foo)"
+        req.br.should be_false
+        req.name.should == "rubygem(foo)"
+        req.gem_name.should == "foo"
+        req.condition.should be_nil
+        req.version.should be_nil
+
+        req = described_class.parse "BuildRequires: rubygem(foo)"
+        req.br.should be_true
+
+        req = described_class.parse "rubygem(rake)"
+        req.br.should be_false
+        req.name.should == "rubygem(rake)"
+
+        req = described_class.parse "rubygem(rake) < 5"
+        req.condition.should == "<"
+        req.version.should == "5"
+      end
+    end
+
+    describe "#gcd" do
+      it "selects / returns max version less than local version" do
+        req = described_class.new :version => "5.0.0"
+        req.gcd(['1.0', '2.0', '5.0', '5.1', '6.1']).should == '2.0'
+      end
+    end
+
+    describe "#min_satisfying_version" do
+      context "no version req" do
+        it "returns 0" do
+          req = described_class.new
+          req.min_satisfying_version.should == "0.0"
+        end
+      end
+
+      context "= req" do
+        it "returns local version" do
+          req = described_class.new :condition => '=', :version => '5.0.0'
+          req.min_satisfying_version.should == '5.0.0'
+        end
+      end
+
+      context "> req" do
+        it "returns next version" do
+          req = described_class.new :condition => '>', :version => '5.0.0'
+          req.min_satisfying_version.should == '5.0.1'
+        end
+      end
+
+      context ">= req" do
+        it "returns local version" do
+          req = described_class.new :condition => '>=', :version => '5.0.0'
+          req.min_satisfying_version.should == '5.0.0'
+        end
+      end
+
+      context "< req" do
+        it "returns 0" do
+          req = described_class.new :condition => '<', :version => '5.0.0'
+          req.min_satisfying_version.should == "0.0"
+        end
+      end
+
+      context "<= req" do
+        it "returns 0" do
+          req = described_class.new :condition => '<=', :version => '5.0.0'
+          req.min_satisfying_version.should == "0.0"
+        end
+      end
+    end
+
+    describe "#max_version_satisfying" do
+      context "no version req" do
+        it "returns infinity" do
+          req = described_class.new
+          req.max_satisfying_version.should == Float::INFINITY
+        end
+      end
+
+      context "= req" do
+        it "returns version" do
+          req = described_class.new :condition => '=', :version => '1.2.3'
+          req.max_satisfying_version.should == '1.2.3'
+        end
+      end
+
+      context "> req" do
+        it "returns infinity" do
+          req = described_class.new :condition => '>', :version => '1.2.3'
+          req.max_satisfying_version.should == Float::INFINITY
+        end
+      end
+
+      context ">= req" do
+        it "returns infinity" do
+          req = described_class.new :condition => '>=', :version => '1.2.3'
+          req.max_satisfying_version.should == Float::INFINITY
+        end
+      end
+
+      context "< req" do
+        context "versions list not specified" do
+          it "raises argument error" do
+            req = described_class.new :condition => '<', :version => '1.2.3'
+            lambda {
+              req.max_satisfying_version
+            }.should raise_error(ArgumentError)
+          end
+        end
+
+        it "returns gcd of list" do
+          req = described_class.new :condition => '<', :version => '1.2.3'
+          req.should_receive(:gcd).and_return('3')
+          req.max_satisfying_version(['1', '2']).should == '3'
+        end
+      end
+
+      context "<= req" do
+        it "returns version" do
+          req = described_class.new :condition => '<=', :version => '1.2.3'
+          req.max_satisfying_version.should == '1.2.3'
+        end
+      end
+    end
+
+    describe "#min_failing_version" do
+      context "no version req" do
+        it "raises argument error" do
+          req = described_class.new
+          lambda{
+            req.min_failing_version
+          }.should raise_error(ArgumentError)
+        end
+      end
+
+      context "= req" do
+        it "returns next version" do
+          req = described_class.new :condition => '=', :version => '5.0.0'
+          req.min_failing_version.should == '5.0.1'
+        end
+      end
+
+      context "> req" do
+        it "returns 0" do
+          req = described_class.new :condition => '>', :version => '5.0.0'
+          req.min_failing_version.should == '0.0'
+        end
+      end
+
+      context ">= req" do
+        it "returns 0" do
+          req = described_class.new :condition => '>=', :version => '5.0.0'
+          req.min_failing_version.should == '0.0'
+        end
+      end
+
+      context "< req" do
+        it "returns version" do
+          req = described_class.new :condition => '<', :version => '5.0.0'
+          req.min_failing_version.should == '5.0.0'
+        end
+      end
+
+      context "<= req" do
+        it "returns next version" do
+          req = described_class.new :condition => '<=', :version => '5.0.0'
+          req.min_failing_version.should == '5.0.1'
+        end
+      end
+    end
+
+    describe "#max_failing_version" do
+      context "no version req" do
+        it "raises argument error" do
+          req = described_class.new
+          lambda {
+            req.max_failing_version
+          }.should raise_error(ArgumentError)
+        end
+      end
+
+      context "= req" do
+        context "versions are nil" do
+          it "raises ArgumentError" do
+            req = described_class.new :condition => '=', :version => '2.0'
+            lambda {
+              req.max_failing_version
+            }.should raise_error(ArgumentError)
+          end
+        end
+
+        it "returns gcd of list" do
+          req = described_class.new :condition => '=', :version => '2.0'
+          req.should_receive(:gcd).and_return('abc')
+          req.max_failing_version(['1.2']).should == 'abc'
+        end
+      end
+
+      context "> req" do
+        it "returns version" do
+          req = described_class.new :condition => '>', :version => '2.0'
+          req.max_failing_version.should == '2.0'
+        end
+      end
+
+      context ">= req" do
+        context "versions are nil" do
+          it "raises ArgumentError" do
+            req = described_class.new :condition => '>=', :version => '2.0'
+            lambda {
+              req.max_failing_version
+            }.should raise_error(ArgumentError)
+          end
+        end
+
+        it "returns gcd of list" do
+          req = described_class.new :condition => '>=', :version => '2.0'
+          req.should_receive(:gcd).and_return('abc')
+          req.max_failing_version(['1.2']).should == 'abc'
+        end
+      end
+
+      context "< req" do
+        it "raises argument error" do
+          req = described_class.new :condition => '<', :version => '2.0'
+          lambda {
+            req.max_failing_version
+          }.should raise_error(ArgumentError)
+        end
+      end
+
+      context "<= req" do
+        it "raises argument error" do
+          req = described_class.new :condition => '<', :version => '2.0'
+          lambda {
+            req.max_failing_version
+          }.should raise_error(ArgumentError)
+        end
+      end
+    end
+
+    describe "#==" do
+      context "requirements are equal" do
+        it "returns true" do
+          req1 = described_class.new
+          req2 = described_class.new
+          req1.should == req2
+
+          req1 = described_class.parse 'rubygem(rails)'
+          req2 = described_class.parse 'rubygem(rails)'
+          req1.should == req2
+
+          req1 = described_class.parse 'rubygem(rails) >= 1.0.0'
+          req2 = described_class.parse 'rubygem(rails) >= 1.0.0'
+          req1.should == req2
+        end
+      end
+
+      context "requirements are not equal" do
+        it "returns true" do
+          req1 = described_class.parse 'rubygem(rails)'
+          req2 = described_class.parse 'rubygem(rake)'
+          req1.should_not == req2
+
+          req1 = described_class.parse 'rubygem(rake) > 1'
+          req2 = described_class.parse 'rubygem(rake) > 2'
+          req1.should_not == req2
+        end
+      end
+    end
+
+    describe "#matches?" do
+      context "requirement is same as dep requirement" do
+        it "returns true"
+      end
+
+      context "requirement is not same as dep requirement" do
+        it "returns false"
+      end
+    end
+
+    describe "#gem?" do
+      context "requirement matches gem dep matcher" do
+        it "returns true" do
+          described_class.parse("rubygem(rails)").gem?.should be_true
+        end
+      end
+
+      context "requirement does not match gem dep matcher" do
+        it "returns false" do
+          described_class.parse("something").gem?.should be_false
+        end
+      end
+    end
+
+    describe "#gem_name" do
+      it "returns gem name" do
+        described_class.parse("rubygem(rails)").gem_name.should == "rails"
+      end
+
+      context "requirement is not a gem" do
+        it "returns nil" do
+          described_class.parse("something").gem_name.should be_nil
+        end
+      end
+    end
+  end
+
   describe RPMSpec do
     describe "#initialize" do
       it "sets gem metadata" do
@@ -24,6 +360,38 @@ module Polisher
       end
     end
 
+    describe "#has_check?" do
+      context "package spec has %check section" do
+        it "returns true" do
+          spec = described_class.new :has_check => true
+          spec.has_check?.should be_true
+        end
+      end
+
+      context "package spec does not have a %check section" do
+        it "returns false" do
+          spec = described_class.new
+          spec.has_check?.should be_false
+        end
+      end
+    end
+
+
+    describe "#requirements_for_gem" do
+      it "returns requirements for specified gem name" do
+        spec = Polisher::RPMSpec.new :requires =>
+          [Polisher::RPMSpec::Requirement.new(:name => 'rubygem(rake)')]
+        spec.requirements_for_gem('rake').should == [spec.requires.first]
+      end
+
+      context "spec has no requirement with specified name" do
+        it "returns empty array" do
+          spec = Polisher::RPMSpec.new
+          spec.requirements_for_gem('rake').should be_empty
+        end
+      end
+    end
+
     describe "#parse" do
       before(:each) do
         @spec  = Polisher::Test::RPM_SPEC
@@ -70,25 +438,39 @@ module Polisher
         pspec = Polisher::RPMSpec.parse @spec[:contents]
         pspec.files.should == @spec[:files]
       end
+
+      it "parses %check from spec" do
+        pspec = Polisher::RPMSpec.parse @spec[:contents]
+        pspec.has_check?.should be_true
+
+        pspec = Polisher::RPMSpec.parse ""
+        pspec.has_check?.should be_false
+      end
     end
 
     describe "#update_to" do
       it "updates dependencies from gem" do
-        spec = Polisher::RPMSpec.new :requires => ['rubygem(rake)', 'rubygem(activerecord)'],
+        spec = Polisher::RPMSpec.new :requires => [Polisher::RPMSpec::Requirement.parse('rubygem(rake)'),
+                                                   Polisher::RPMSpec::Requirement.parse('rubygem(activerecord)')],
                                      :build_requires => []
         gem  = Polisher::Gem.new :deps => [::Gem::Dependency.new('rake'),
                                            ::Gem::Dependency.new('rails', '~> 10')],
                                  :dev_deps => [::Gem::Dependency.new('rspec', :development)]
 
+        spec.should_receive(:update_files_from) # stub out files update
         spec.update_to(gem)
-          spec.requires.should == ['rubygem(activerecord)', 'rubygem(rake) >= 0',
-                                   'rubygem(rails) => 10', 'rubygem(rails) < 11']
-        spec.build_requires.should == ['rubygem(rspec) >= 0']
+          spec.requires.should == [Polisher::RPMSpec::Requirement.parse('rubygem(activerecord)'),
+                                   Polisher::RPMSpec::Requirement.parse('rubygem(rake) >= 0'),
+                                   Polisher::RPMSpec::Requirement.parse('rubygem(rails) => 10'),
+                                   Polisher::RPMSpec::Requirement.parse('rubygem(rails) < 11')]
+        spec.build_requires.should == [Polisher::RPMSpec::Requirement.parse('rubygem(rspec) >= 0', :br => true)]
       end
 
       it "adds new files from gem" do
         spec = Polisher::RPMSpec.new :files => {'pkg' => ['/foo']}
-        gem  = Polisher::Gem.new :files => ['/foo', '/foo/bar', '/baz']
+        gem  = Polisher::Gem.new
+        gem.should_receive(:file_paths).at_least(:once).
+            and_return(['/foo', '/foo/bar', '/baz'])
         spec.update_to(gem)
         spec.new_files.should == ['/baz']
       end
@@ -96,6 +478,7 @@ module Polisher
       it "updates metadata from gem" do
         spec = Polisher::RPMSpec.new
         gem  = Polisher::Gem.new :version => '1.0.0'
+        spec.should_receive(:update_files_from) # stub out files update
         spec.update_to(gem)
         spec.version.should == '1.0.0'
         spec.release.should == '1%{?dist}'
@@ -107,5 +490,51 @@ module Polisher
     describe "#to_string" do
       it "returns string representation of spec"
     end
+
+    describe "#compare" do
+      it "returns requirements in spec but not in gem" do
+        req  = Polisher::RPMSpec::Requirement.parse 'rubygem(rails) > 3.0.0'
+        spec = Polisher::RPMSpec.new :requires => [req]
+        gem  = Polisher::Gem.new
+
+        spec.compare(gem).should ==
+          {:same => {}, :diff => {'rails' =>
+                  {:spec => '> 3.0.0', :upstream => nil}}}
+      end
+
+      it "returns requirements in gem but not in spec" do
+        req = ::Gem::Dependency.new('rails', '> 3.0.0')
+        spec = Polisher::RPMSpec.new
+        gem  = Polisher::Gem.new :deps => [req]
+
+        spec.compare(gem).should ==
+          {:same => {}, :diff => {'rails' =>
+                  {:spec => nil, :upstream => '> 3.0.0'}}}
+      end
+
+      it "returns shared requirements with different specifiers" do
+        greq = ::Gem::Dependency.new('rails', '< 5.0.0')
+        gem  = Polisher::Gem.new :deps => [greq]
+
+        sreq = Polisher::RPMSpec::Requirement.parse 'rubygem(rails) > 3.0.0'
+        spec = Polisher::RPMSpec.new :requires => [sreq]
+
+        spec.compare(gem).should ==
+          {:same => {}, :diff => {'rails' =>
+                  {:spec => '> 3.0.0', :upstream => '< 5.0.0'}}}
+      end
+
+      it "returns shared requirements" do
+        greq = ::Gem::Dependency.new('rails', '< 3.0.0')
+        gem  = Polisher::Gem.new :deps => [greq]
+
+        sreq = Polisher::RPMSpec::Requirement.parse 'rubygem(rails) < 3.0.0'
+        spec = Polisher::RPMSpec.new :requires => [sreq]
+
+        spec.compare(gem).should ==
+          {:diff => {}, :same => {'rails' =>
+                  {:spec => '< 3.0.0', :upstream => '< 3.0.0'}}}
+      end
+    end
   end # describe RPMSpec
 end # module Polisher