polisher 0.5.1 → 0.6.1

data/spec/fedora_spec.rb

@@ -10,5 +10,20 @@ module Polisher
     describe "#gems_owned_by" do
       it "retrieves gems owned by the specified user"
     end
+
+    describe "#versions_for" do
+      it "dispatches to bodhi to retrieve / return versions" do
+        Polisher::Bodhi.should_receive(:versions_for).with('rails').and_return(['1.0.0'])
+        described_class.versions_for('rails').should == ['1.0.0']
+      end
+
+      it "should invoke callback" do
+        Polisher::Bodhi.should_receive(:versions_for).with('rails').
+                        and_yield(:bodhi, 'rails', ['1.0.0'])
+        cb = proc {}
+        cb.should_receive(:call).with(:fedora, 'rails', ['1.0.0'])
+        described_class.versions_for('rails', &cb)
+      end
+    end
   end # describe Fedora
 end # module Polisher

data/spec/git_spec.rb

@@ -28,20 +28,67 @@ module Polisher
       end
     end
 
-    describe "#clone" do
+    describe "::clone" do
       context "package directory does not exist" do
-        it "uses package command to clone package"
+        it "uses package command to clone package" do
+          File.should_receive(:directory?).with('rubygem-rails').and_return(false)
+          AwesomeSpawn.should_receive(:run).with("/usr/bin/fedpkg clone rubygem-rails")
+          Dir.should_receive(:chdir) # stub out chdir
+          AwesomeSpawn.should_receive(:run).at_least(3).times
+          described_class.clone "rails"
+        end
+      end
+
+      it "changes dir to the pkg dir" do
+        File.should_receive(:directory?).and_return(true) # stub out pull
+        Dir.should_receive(:chdir).with('rubygem-rails')
+        AwesomeSpawn.should_receive(:run).at_least(3).times # stub out calls to run
+        described_class.clone "rails"
       end
 
       context "dead.package file exists" do
-        it "raises Exception"
+        it "raises Exception" do
+          File.should_receive(:directory?).and_return(true) # stub out pull
+          Dir.should_receive(:chdir) # stub out chdir
+          File.should_receive(:exists?).with('dead.package').and_return(true)
+          lambda{
+            described_class.clone "rails"
+          }.should raise_error(Exception)
+        end
+      end
+
+      it "checks out master branch" do
+        File.should_receive(:directory?).and_return(true) # stub out pull
+        Dir.should_receive(:chdir).with('rubygem-rails')
+        AwesomeSpawn.should_receive(:run).with("/usr/bin/git checkout master")
+        AwesomeSpawn.should_receive(:run).at_least(2).times # stub out calls to run
+        described_class.clone "rails"
+      end
+
+      it "resets head" do
+        File.should_receive(:directory?).and_return(true) # stub out pull
+        Dir.should_receive(:chdir).with('rubygem-rails')
+        AwesomeSpawn.should_receive(:run).with("/usr/bin/git reset HEAD~ --hard")
+        AwesomeSpawn.should_receive(:run).at_least(2).times # stub out calls to run
+        described_class.clone "rails"
       end
 
-      it "checks out master branch"
-      it "resets head"
-      it "pulls from remote"
+      it "pulls from remote" do
+        File.should_receive(:directory?).and_return(true) # stub out pull
+        Dir.should_receive(:chdir).with('rubygem-rails')
+        AwesomeSpawn.should_receive(:run).with("/usr/bin/git pull")
+        AwesomeSpawn.should_receive(:run).at_least(2).times # stub out calls to run
+        described_class.clone "rails"
+      end
 
-      it "returns new GitPackage instance"
+      it "returns new GitPackage instance" do
+        File.should_receive(:directory?).and_return(true) # stub out pull
+        Dir.should_receive(:chdir).with('rubygem-rails')
+        AwesomeSpawn.should_receive(:run).at_least(3).times # stub out calls to run
+        pkg = described_class.clone("rails")
+        pkg.should be_an_instance_of(described_class)
+        pkg.name.should == 'rails'
+      end
     end
 
     describe "#update_to" do
@@ -51,23 +98,80 @@ module Polisher
     end
 
     describe "#build" do
-      it "uses package command to build srpm"
-      it "uses build command to build srpm"
+      it "uses package command to build srpm" do
+        AwesomeSpawn.should_receive(:run).with("/usr/bin/fedpkg srpm")
+        AwesomeSpawn.should_receive(:run).at_least(:once)
+        described_class.new.build
+      end
+
+      it "uses build command to build srpm" do
+        AwesomeSpawn.should_receive(:run).with("/usr/bin/koji build --scratch rawhide rubygem-rails-1.0.0-1.*.src.rpm")
+        AwesomeSpawn.should_receive(:run).at_least(:once)
+        described_class.new(:name => 'rails', :version => '1.0.0').build
+      end
     end
 
     describe "#has_check?" do
       context "package spec has %check section" do
-        it "returns true"
+        it "returns true" do
+          File.should_receive(:open).with("rubygem-rails.spec", "r").and_yield("%check")
+          described_class.new(:name => "rails").has_check?.should be_true
+        end
       end
 
       context "package spec does not have a %check section" do
-        it "returns false"
+        it "returns false" do
+          File.should_receive(:open).with("rubygem-rails.spec", "r").and_yield("")
+          described_class.new(:name => "rails").has_check?.should be_false
+        end
       end
     end
 
     describe "#commit" do
-      it "git adds the sources, .gitignore, and spec files"
-      it "commits the package"
+      it "git adds the sources, .gitignore, and spec files" do
+        AwesomeSpawn.should_receive(:run).with("/usr/bin/git add rubygem-rails.spec sources .gitignore")
+        AwesomeSpawn.should_receive(:run).at_least(:once)
+        described_class.new(:name => 'rails').commit
+      end
+
+      it "commits the package" do
+        AwesomeSpawn.should_receive(:run).with("/usr/bin/git commit -m 'updated to 1.0.0'")
+        AwesomeSpawn.should_receive(:run).at_least(:once)
+        described_class.new(:name => 'rails', :version => '1.0.0').commit
+      end
+    end
+
+    describe "#version_for" do
+      it "uses git to retrieve the package" do
+        AwesomeSpawn.should_receive(:run).with("/usr/bin/git clone #{described_class::DIST_GIT_URL}rubygem-rails.git .")
+        described_class.version_for 'rails'
+      end
+
+      it "parses version from spec in git" do
+        AwesomeSpawn.should_receive(:run) # stub out run
+        File.should_receive(:read).with("rubygem-rails.spec").and_return("contents")
+        Polisher::RPMSpec.should_receive(:parse).with("contents").and_return(Polisher::RPMSpec.new)
+        described_class.version_for 'rails'
+      end
+
+      it "returns version of the package" do
+        spec = Polisher::RPMSpec.new :version => '1.0.0'
+        AwesomeSpawn.should_receive(:run) # stub out run
+        File.should_receive(:read).with("rubygem-rails.spec") # stub out read
+        Polisher::RPMSpec.should_receive(:parse).and_return(spec)
+        described_class.version_for('rails').should == '1.0.0'
+      end
+
+      it "invokes callback with version of package" do
+        spec = Polisher::RPMSpec.new :version => '1.0.0'
+        AwesomeSpawn.should_receive(:run) # stub out run
+        File.should_receive(:read).with("rubygem-rails.spec") # stub out read
+        Polisher::RPMSpec.should_receive(:parse).and_return(spec)
+
+        cb = proc {}
+        cb.should_receive(:call).with(:git, 'rails', ['1.0.0'])
+        described_class.version_for('rails', &cb)
+      end
     end
 
   end # describe GitPackage

data/spec/koji_spec.rb

@@ -0,0 +1,71 @@
+# Polisher Koji Spec
+#
+# Licensed under the MIT license
+# Copyright (C) 2013 Red Hat, Inc.
+
+require 'polisher/koji'
+
+module Polisher
+  describe Koji do
+    describe "::has_build?" do
+      context "retrieved versions includes the specified version" do
+        it "returns true" do
+          described_class.should_receive(:versions_for).and_return(['1.0.0'])
+          described_class.has_build?('foobar', '1.0.0').should be_true
+        end
+      end
+
+      context "retrieved versions does not include the specified version" do
+        it "returns false" do
+          described_class.should_receive(:versions_for).and_return(['1.0.1'])
+          described_class.has_build?('foobar', '1.0.1').should be_true
+        end
+      end
+    end
+
+    describe "#has_build_satisfying?" do
+      context "retrieved versions satisfy the specified dependency" do
+        it "returns true" do
+          described_class.should_receive(:versions_for).and_return(['1.0.0'])
+          described_class.has_build_satisfying?('foobar', '> 0.9.0').should be_true
+        end
+      end
+
+      context "retrieved versions does not satisfy the specified dependency" do
+        it "returns false" do
+          described_class.should_receive(:versions_for).and_return(['1.0.0'])
+          described_class.has_build_satisfying?('foobar', '< 0.9.0').should be_false
+        end
+      end
+    end
+
+    describe "#versions_for" do
+      before(:each) do
+        @client = double(XMLRPC::Client)
+        described_class.should_receive(:client).and_return(@client)
+      end
+
+      it "uses xmlrpc client to retreive versions" do
+        expected = ['listTagged', described_class.koji_tag, nil, false,
+                    nil, false, "rubygem-rails"]
+        @client.should_receive(:call).with(*expected).and_return([])
+        described_class.versions_for 'rails'
+      end
+
+      it "returns versions" do
+        versions = [{'version' => '1.0.0'}]
+        @client.should_receive(:call).and_return(versions)
+        described_class.versions_for('rails').should == ['1.0.0']
+      end
+
+      it "invokes block with versions" do
+        versions = [{'version' => '1.0.0'}]
+        @client.should_receive(:call).and_return(versions)
+
+        cb = proc {}
+        cb.should_receive(:call).with(:koji, 'rails', ['1.0.0'])
+        described_class.versions_for('rails', &cb)
+      end
+    end
+  end # describe Koji
+end # module Polisher

data/spec/rpmspec_spec.rb

@@ -3,7 +3,10 @@
 # Licensed under the MIT license
 # Copyright (C) 2013 Red Hat, Inc.
 
+require 'spec_helper'
+
 require 'polisher/rpmspec'
+require 'polisher/gem'
 
 module Polisher
   describe RPMSpec do
@@ -73,11 +76,14 @@ module Polisher
       it "updates dependencies from gem" do
         spec = Polisher::RPMSpec.new :requires => ['rubygem(rake)', 'rubygem(activerecord)'],
                                      :build_requires => []
-        gem  = Polisher::Gem.new :deps => ['rake', 'rails'], :dev_deps => ['rspec']
+        gem  = Polisher::Gem.new :deps => [::Gem::Dependency.new('rake'),
+                                           ::Gem::Dependency.new('rails', '~> 10')],
+                                 :dev_deps => [::Gem::Dependency.new('rspec', :development)]
 
         spec.update_to(gem)
-        spec.requires.should == ['rubygem(activerecord)', 'rubygem(rake)', 'rubygem(rails)']
-        spec.build_requires.should == ['rubygem(rspec)']
+          spec.requires.should == ['rubygem(activerecord)', 'rubygem(rake) >= 0',
+                                   'rubygem(rails) => 10', 'rubygem(rails) < 11']
+        spec.build_requires.should == ['rubygem(rspec) >= 0']
       end
 
       it "adds new files from gem" do

data/spec/spec_helper.rb

@@ -12,7 +12,9 @@ module Polisher
       :name     => 'mysql',
       :version  => '2.9.1',
       :deps     => [],
-      :dev_deps => ['rdoc', 'rake-compiler', 'hoe']
+      :dev_deps => [::Gem::Dependency.new('rdoc', '~> 3.10', :development),
+                    ::Gem::Dependency.new('rake-compiler', '~> 0.8.1', :development),
+                    ::Gem::Dependency.new('hoe', '~> 3.5', :development)]
     }
 
     GEM_JSON = {
@@ -20,7 +22,13 @@ module Polisher
       :json     => File.read("#{SPEC_DIR}/data/rails.json"),
       :name     => 'rails',
       :version  => '4.0.1',
-      :deps     => ["actionmailer", "actionpack", "activerecord", "activesupport", "bundler", "railties", "sprockets-rails"],
+      :deps     => [::Gem::Dependency.new("actionmailer", '= 4.0.1'),
+                    ::Gem::Dependency.new("actionpack", '= 4.0.1'),
+                    ::Gem::Dependency.new("activerecord", '= 4.0.1'),
+                    ::Gem::Dependency.new("activesupport", '= 4.0.1'),
+                    ::Gem::Dependency.new("bundler", "< 2.0", ">= 1.3.0"),
+                    ::Gem::Dependency.new("railties", '= 4.0.1'),
+                    ::Gem::Dependency.new("sprockets-rails", '~> 2.0.0')],
       :dev_deps => []
     }
 
@@ -31,7 +39,9 @@ module Polisher
       :contents => File.read("#{SPEC_DIR}/data/rspec-2.12.0.gem"),
       :name     => 'rspec',
       :version  => '2.12.0',
-      :deps     => ['rspec-core', 'rspec-expectations', 'rspec-mocks'],
+      :deps     => [::Gem::Dependency.new('rspec-core', '~> 2.14.0'),
+                    ::Gem::Dependency.new('rspec-expectations', '~> 2.14.0'),
+                    ::Gem::Dependency.new('rspec-mocks', '~> 2.14.0')],
       :dev_deps => [],
       :files    => ['/License.txt', '/README.md', '/lib', '/lib/rspec', '/lib/rspec/version.rb', '/lib/rspec.rb']
     }

data/spec/yum_spec.rb

@@ -0,0 +1,37 @@
+# Polisher Yum Spec
+#
+# Licensed under the MIT license
+# Copyright (C) 2013 Red Hat, Inc.
+
+require 'polisher/yum'
+
+module Polisher
+  describe Yum do
+    describe "#versions_for" do
+      before(:each) do
+      end
+
+      it "uses yum to retreive versions" do
+        expected = "/usr/bin/yum info rubygem-rails"
+        result = AwesomeSpawn::CommandResult.new expected, "", "", 0
+        AwesomeSpawn.should_receive(:run).with(expected).and_return(result)
+        described_class.version_for "rails"
+      end
+
+      it "returns versions" do
+        result = AwesomeSpawn::CommandResult.new "", "Version: 1.0.0", "", 0
+        AwesomeSpawn.should_receive(:run).and_return(result)
+        described_class.version_for("rails") == '1.0.0'
+      end
+
+      it "invokes block with versions" do
+        cb = proc {}
+        cb.should_receive(:call).with(:yum, 'rails', ['1.0.0'])
+
+        result = AwesomeSpawn::CommandResult.new "", "Version: 1.0.0", "", 0
+        AwesomeSpawn.should_receive(:run).and_return(result)
+        described_class.version_for("rails", &cb)
+      end
+    end
+  end # describe Koji
+end # module Polisher

metadata

@@ -1,15 +1,17 @@
 --- !ruby/object:Gem::Specification
 name: polisher
 version: !ruby/object:Gem::Version
-  version: 0.5.1
+  version: 0.6.1
 platform: ruby
 authors:
 - Jason Frey
 - Mo Morsi
+- Joe Rafaniello
+- Ken Dreyer
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-12-05 00:00:00.000000000 Z
+date: 2014-01-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json
@@ -109,6 +111,34 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: awesome_spawn
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: gem2rpm
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -123,10 +153,13 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: 2.0.0
-description: Ruby Project Post-Publishing Processor
+description: General API and utility scripts to manipulate and query ruby gems and
+  projects after being published
 email:
 - Fryguy@users.noreply.github.com
-- mmorsi@redhat.com
+- mo@morsi.org
+- jrafanie@redhat.com
+- ktdreyer@ktdreyer.com
 executables:
 - binary_gem_resolver.rb
 - gem_dependency_checker.rb
@@ -138,6 +171,7 @@ files:
 - lib/polisher/core.rb
 - lib/polisher/bodhi.rb
 - lib/polisher/fedora.rb
+- lib/polisher/version.rb
 - lib/polisher/apt.rb
 - lib/polisher/version_checker.rb
 - lib/polisher/vendor.rb
@@ -154,13 +188,23 @@ files:
 - lib/polisher/yum.rb
 - lib/polisher.rb
 - spec/git_spec.rb
+- spec/bodhi_spec.rb
 - spec/spec_helper.rb
+- spec/errata_spec.rb
 - spec/gemfile_spec.rb
+- spec/koji_spec.rb
 - spec/gem_spec.rb
+- spec/yum_spec.rb
 - spec/upstream_spec.rb
 - spec/rpmspec_spec.rb
 - spec/fedora_spec.rb
 - spec/core_spec.rb
+- spec/data/rails.json
+- spec/data/rubygem-activesupport.spec
+- spec/data/Gemfile
+- spec/data/rspec.json
+- spec/data/mysql-2.9.1.gemspec
+- spec/data/rspec-2.12.0.gem
 - LICENSE
 - Rakefile
 - README.md
@@ -168,7 +212,7 @@ files:
 - bin/gem_dependency_checker.rb
 - bin/git_gem_updater.rb
 - bin/ruby_rpm_spec_updater.rb
-homepage: http://github.com/ManageIQ/polisher
+homepage: https://github.com/ManageIQ/polisher
 licenses:
 - MIT
 metadata: {}
@@ -191,7 +235,6 @@ rubyforge_project:
 rubygems_version: 2.0.11
 signing_key: 
 specification_version: 4
-summary: General API and utility scripts to manipulate and query ruby gems and projects
-  after being published
+summary: Ruby Project Post-Publishing Processor
 test_files: []
 has_rdoc: