polish_invoicer 0.0.25 → 0.0.28

data/test/invoice_test.rb

@@ -1,14 +1,18 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 module PolishInvoicer
   class InvoiceTest < Minitest::Test
     def test_init
       i = Invoice.new
-      assert i.is_a?(Invoice)
+
+      assert_kind_of Invoice, i
     end
 
     def test_set_available_param
       i = Invoice.new(number: '1/2014')
+
       assert_equal '1/2014', i.number
     end
 
@@ -18,86 +22,111 @@ module PolishInvoicer
 
     def test_validation_delegation
       i = Invoice.new
-      assert_equal false, i.valid?
+
+      refute_predicate i, :valid?
       assert i.errors[:number]
       i.number = '1/2014'
       i.valid?
+
       assert_nil i.errors[:number]
     end
 
     def test_net_value
       i = Invoice.new(price: 123.45, gross_price: false)
       i.vat = 23
+
       assert_in_delta 123.45, i.net_value, 0.01
 
       i.gross_price = true
       i.vat = 23
+
       assert_in_delta 100.37, i.net_value, 0.01
       i.vat = 5.5
+
       assert_in_delta 117.01, i.net_value, 0.01
       i.vat = 0
+
       assert_in_delta 123.45, i.net_value, 0.01
       i.vat = -1
+
       assert_in_delta 123.45, i.net_value, 0.01
 
       i.gross_price = false
       i.vat = 0
+
       assert_in_delta 123.45, i.net_value, 0.01
       i.vat = -1
+
       assert_in_delta 123.45, i.net_value, 0.01
       i.vat = 5.5
+
       assert_in_delta 123.45, i.net_value, 0.01
     end
 
     def test_vat_value
       i = Invoice.new(price: 123.45, gross_price: false)
       i.vat = 23
+
       assert_in_delta 28.39, i.vat_value, 0.01
       i.vat = 5.5
+
       assert_in_delta 6.79, i.vat_value, 0.01
 
       i.gross_price = true
       i.vat = 23
+
       assert_in_delta 23.08, i.vat_value, 0.01
       i.vat = 5.5
+
       assert_in_delta 6.44, i.vat_value, 0.01
       i.vat = 0
-      assert_equal 0.00, i.vat_value
+
+      assert_in_delta(0.00, i.vat_value)
       i.vat = -1
-      assert_equal 0.00, i.vat_value
+
+      assert_in_delta(0.00, i.vat_value)
     end
 
     def test_gross_value
       i = Invoice.new(price: 123.45, gross_price: false)
       i.vat = 23
+
       assert_in_delta 151.84, i.gross_value, 0.01
 
       i.gross_price = true
       i.vat = 23
+
       assert_in_delta 123.45, i.gross_value, 0.01
       i.vat = 5.5
+
       assert_in_delta 123.45, i.gross_value, 0.01
       i.vat = 0
+
       assert_in_delta 123.45, i.gross_value, 0.01
       i.vat = -1
+
       assert_in_delta 123.45, i.gross_value, 0.01
 
       i.gross_price = false
       i.vat = 5.5
+
       assert_in_delta 130.24, i.gross_value, 0.01
       i.vat = 0
+
       assert_in_delta 123.45, i.gross_value, 0.01
       i.vat = -1
+
       assert_in_delta 123.45, i.gross_value, 0.01
     end
 
     def test_defaults
       i = Invoice.new
+
       assert i.gross_price
-      assert 23, i.vat
-      assert 'Przelew', i.payment_type
+      assert_equal 23, i.vat
+      assert_equal 'Przelew', i.payment_type
       assert i.paid
-      assert_equal false, i.proforma
+      refute i.proforma
     end
 
     def test_raise_when_save_to_html_and_not_valid
@@ -114,7 +143,8 @@ module PolishInvoicer
       i = create_valid_invoice
       path = '/tmp/test.html'
       i.save_to_html(path)
-      assert File.exist?(path)
+
+      assert_path_exists path
       File.unlink(path)
     end
 
@@ -122,15 +152,17 @@ module PolishInvoicer
       i = create_valid_invoice
       path = '/tmp/test.pdf'
       i.save_to_pdf(path)
-      assert File.exist?(path)
+
+      assert_path_exists path
       File.unlink(path)
     end
 
     def test_to_hash
       i = Invoice.new(price: 123.45, gross_price: false)
       h = i.to_hash
+
       assert h[:paid] # default
-      assert_equal false, h[:gross_price] # params
+      refute h[:gross_price] # params
       assert_equal '123,45', h[:net_value] # presenter
     end
 
@@ -159,6 +191,7 @@ module PolishInvoicer
 
     def test_gross_and_net_price
       gross_invoice = Invoice.new(price: 123, price_paid: 60, paid: false)
+
       assert_equal 100, gross_invoice.net_value
       assert_equal 23, gross_invoice.vat_value
       assert_equal 123, gross_invoice.gross_value
@@ -167,6 +200,7 @@ module PolishInvoicer
       assert_equal 63, gross_invoice.to_pay_value
 
       net_invoice = Invoice.new(price: 100, price_paid: 60, paid: false, gross_price: false)
+
       assert_equal 100, net_invoice.net_value
       assert_equal 23, net_invoice.vat_value
       assert_equal 123, net_invoice.gross_value
@@ -177,6 +211,7 @@ module PolishInvoicer
 
     def test_reverse_charge
       gross_invoice = Invoice.new(price: 123, price_paid: 60, paid: false, reverse_charge: true)
+
       assert_equal 100, gross_invoice.net_value
       assert_equal 23, gross_invoice.vat_value
       assert_equal 123, gross_invoice.gross_value
@@ -185,6 +220,7 @@ module PolishInvoicer
       assert_equal 40, gross_invoice.to_pay_value
 
       net_invoice = Invoice.new(price: 100, price_paid: 60, paid: false, gross_price: false, reverse_charge: true)
+
       assert_equal 100, net_invoice.net_value
       assert_equal 23, net_invoice.vat_value
       assert_equal 123, net_invoice.gross_value
@@ -192,5 +228,51 @@ module PolishInvoicer
       assert_equal 60, net_invoice.paid_value
       assert_equal 40, net_invoice.to_pay_value
     end
+
+    def test_template_lang
+      i = Invoice.new
+
+      assert_equal 'pl', i.template_lang
+      i.foreign_buyer = true
+
+      assert_equal 'pl_en', i.template_lang
+      i.lang = 'en'
+
+      assert_equal 'en', i.template_lang
+    end
+
+    def test_template_file
+      i = Invoice.new(proforma: true)
+
+      assert_equal 'proforma-pl.slim', i.template_file
+      i.foreign_buyer = true
+
+      assert_equal 'proforma-pl_en.slim', i.template_file
+      i.lang = 'en'
+
+      assert_equal 'proforma-en.slim', i.template_file
+      i.lang = 'pl'
+
+      assert_equal 'proforma-pl.slim', i.template_file
+      i.lang = 'pl_en'
+
+      assert_equal 'proforma-pl_en.slim', i.template_file
+
+      i = Invoice.new
+
+      assert_equal 'invoice-pl.slim', i.template_file
+      i.foreign_buyer = true
+
+      assert_equal 'invoice-pl_en.slim', i.template_file
+      i.lang = 'en'
+
+      assert_equal 'invoice-en.slim', i.template_file
+      i.lang = 'pl'
+
+      assert_equal 'invoice-pl.slim', i.template_file
+      i.lang = 'pl_en'
+
+      assert_equal 'invoice-pl_en.slim', i.template_file
+    end
   end
 end

data/test/presenter_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 module PolishInvoicer
@@ -13,6 +15,7 @@ module PolishInvoicer
       @invoice.create_date = Date.parse('2014-01-15')
       @invoice.payment_date = Date.parse('2014-01-30')
       data = Presenter.new(@invoice).data
+
       assert_equal '01.01.2014', data[:trade_date]
       assert_equal '15.01.2014', data[:create_date]
       assert_equal '30.01.2014', data[:payment_date]
@@ -23,6 +26,7 @@ module PolishInvoicer
       @invoice.vat_value = 23.9876
       @invoice.gross_value = 456.3378
       data = Presenter.new(@invoice).data
+
       assert_equal '123,46', data[:net_value]
       assert_equal '23,99', data[:vat_value]
       assert_equal '456,34', data[:gross_value]
@@ -31,24 +35,30 @@ module PolishInvoicer
     def test_format_comments
       @invoice.comments = nil
       data = Presenter.new(@invoice).data
-      assert_equal [], data[:comments]
+
+      assert_empty data[:comments]
       @invoice.comments = 'Test'
       data = Presenter.new(@invoice).data
+
       assert_equal ['Test'], data[:comments]
       @invoice.comments = %w[A B]
       data = Presenter.new(@invoice).data
+
       assert_equal %w[A B], data[:comments]
     end
 
     def test_vat
       @invoice.vat = 23
       data = Presenter.new(@invoice).data
+
       assert_equal '23%', data[:vat]
       @invoice.vat = 0
       data = Presenter.new(@invoice).data
+
       assert_equal '0%', data[:vat]
       @invoice.vat = -1
       data = Presenter.new(@invoice).data
+
       assert_equal 'zw.', data[:vat]
     end
   end

data/test/test_generator.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'polish_invoicer'
 
 i = PolishInvoicer::Invoice.new(

data/test/test_helper.rb

@@ -1,9 +1,11 @@
+# frozen_string_literal: true
+
 require 'simplecov'
 SimpleCov.start do
   add_filter '/test/'
 end
 
-$LOAD_PATH.unshift File.expand_path('../../lib', __FILE__)
+$LOAD_PATH.unshift File.expand_path('../lib', __dir__)
 require 'polish_invoicer'
 require 'minitest/autorun'
 
@@ -14,6 +16,7 @@ def create_valid_invoice
     seller_nip: '123-123-22-33', buyer_nip: '554-333-22-11',
     item_name: 'Title', price: 123.45, payment_date: Date.today
   )
-  assert invoice.valid?
+
+  assert_predicate invoice, :valid?
   invoice
 end

data/test/validator_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 module PolishInvoicer
@@ -111,10 +113,12 @@ module PolishInvoicer
       @invoice.proforma = true
       v = Validator.new(@invoice)
       v.valid?
+
       assert v.errors[:paid]
       @invoice.paid = false
       v = Validator.new(@invoice)
       v.valid?
+
       assert_nil v.errors[:paid]
     end
 
@@ -129,14 +133,17 @@ module PolishInvoicer
       @invoice.vat = 23
       v = Validator.new(@invoice)
       v.valid?
+
       assert_nil v.errors[:no_vat_reason]
       @invoice.vat = -1
       v = Validator.new(@invoice)
       v.valid?
+
       assert v.errors[:no_vat_reason]
       @invoice.no_vat_reason = 'reason'
       v = Validator.new(@invoice)
       v.valid?
+
       assert_nil v.errors[:no_vat_reason]
     end
 
@@ -145,10 +152,12 @@ module PolishInvoicer
       @invoice.payment_date = Date.parse('2018-04-01')
       v = Validator.new(@invoice)
       v.valid?
+
       assert v.errors[:payment_date]
       @invoice.payment_date = Date.parse('2018-04-17')
       v = Validator.new(@invoice)
       v.valid?
+
       assert_nil v.errors[:payment_date]
     end
 
@@ -156,14 +165,17 @@ module PolishInvoicer
       @invoice.currency = nil
       v = Validator.new(@invoice)
       v.valid?
+
       assert v.errors[:currency]
       @invoice.currency = 'XYZ'
       v = Validator.new(@invoice)
       v.valid?
+
       assert v.errors[:currency]
       @invoice.currency = 'EUR'
       v = Validator.new(@invoice)
       v.valid?
+
       refute v.errors[:currency]
     end
 
@@ -171,19 +183,39 @@ module PolishInvoicer
       @invoice.exchange_rate = nil
       v = Validator.new(@invoice)
       v.valid?
+
       assert v.errors[:exchange_rate]
-      @invoice.exchange_rate = 4,1234
+      @invoice.exchange_rate = 4.1234
       v = Validator.new(@invoice)
       v.valid?
+
       refute v.errors[:exchange_rate]
     end
 
+    def test_lang
+      v = Validator.new(@invoice)
+      v.valid?
+
+      refute v.errors[:lang]
+      @invoice.lang = 'xx'
+      v = Validator.new(@invoice)
+      v.valid?
+
+      assert v.errors[:lang]
+      @invoice.lang = 'en'
+      v = Validator.new(@invoice)
+      v.valid?
+
+      refute v.errors[:lang]
+    end
+
     private
 
     def check_error(field, value = nil)
       @invoice.send("#{field}=", value)
       v = Validator.new(@invoice)
       v.valid?
+
       assert v.errors[field]
     end
 
@@ -191,6 +223,7 @@ module PolishInvoicer
       @invoice.send("#{field}=", value)
       v = Validator.new(@invoice)
       v.valid?
+
       assert_nil v.errors[field]
     end
   end

data/test/vat_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 module PolishInvoicer
@@ -31,7 +33,7 @@ module PolishInvoicer
 
     def test_to_i
       assert_equal 0, Vat.to_i(-1)
-      assert_equal 5.5, Vat.to_i(5.5)
+      assert_in_delta(5.5, Vat.to_i(5.5))
       assert_equal 20, Vat.to_i(20)
     end
   end

data/test/writer_test.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'test_helper'
 
 module PolishInvoicer
@@ -7,7 +9,8 @@ module PolishInvoicer
       writer = Writer.new(invoice)
       path = '/tmp/test.html'
       writer.save_to_html(path)
-      assert File.exist?(path)
+
+      assert_path_exists path
       File.unlink(path)
     end
 
@@ -16,7 +19,8 @@ module PolishInvoicer
       writer = Writer.new(invoice)
       path = '/tmp/test.pdf'
       writer.save_to_pdf(path)
-      assert File.exist?(path)
+
+      assert_path_exists path
       File.unlink(path)
     end
 
@@ -26,6 +30,7 @@ module PolishInvoicer
       invoice.logger = 'FakeLogger'
       invoice.wkhtmltopdf_command = 'wkhtmltopdf_fake_command'
       writer = Writer.new(invoice)
+
       assert_equal 'tpl.slim', writer.template_path
       assert_equal 'FakeLogger', writer.logger
       assert_equal 'wkhtmltopdf_fake_command', writer.wkhtmltopdf_command