polish_banks 1.0.0 → 1.1.3

data/lib/data/8834.yml

@@ -6,3 +6,5 @@ name: Bank Spółdzielczy w Nidzicy
   branch: Oddział w Janowie
 88341022:
   branch: Oddział w Kozłowie
+88341035:
+  branch: Oddział w Janowcu Kościelnym

data/lib/data/8922.yml

@@ -1,6 +1,6 @@
 ---
-name: Bank Spółdzielczy w Ostrołęce
+name: Bank Spółdzielczy w Brodnicy
 89220009:
-  branch: Centrala
+  branch: Oddział Ostrołęka
 89221019:
-  branch: Oddział w Czerwinie
+  branch: Oddział operacyjny Czerwin

data/lib/data/8965.yml

@@ -1,6 +1,6 @@
 ---
-name: Bank Spółdzielczy w Bełchatowie
+name: Łódzki Bank Spółdzielczy
 89650008:
-  branch: Centrala
+  branch: Łódzki Bank Spółdzielczy Oddział w Bełchatowie
 89651018:
-  branch: Oddział w Zelowie
+  branch: Łódzki Bank Spółdzielczy Oddział w Zelowie

data/lib/data/9015.yml

@@ -1,4 +1,4 @@
 ---
-name: Sierpecki Bank Spółdzielczy
+name: Bank Spółdzielczy w Starej Białej
 90150001:
-  branch: Centrala
+  branch: Oddział

data/lib/data/9022.yml

@@ -1,4 +1,4 @@
 ---
-name: Bank Spółdzielczy w Żychlinie
+name: Bank Spółdzielczy w Starej Białej
 90220007:
-  branch: Centrala
+  branch: Oddział w Żychlinie

data/lib/data/9023.yml

@@ -1,4 +1,4 @@
 ---
-name: Bank Spółdzielczy w Krośniewicach
+name: Łódzki Bank Spółdzielczy
 90230006:
-  branch: Centrala
+  branch: Łódzki Bank Spółdzielczy Oddział w Krośniewicach

data/lib/data/9035.yml

@@ -1,4 +1,4 @@
 ---
-name: Bank Spółdzielczy w Żychlinie
+name: Bank Spółdzielczy w Starej Białej
 90350007:
   branch: Oddział w Strzelcach

data/lib/data/9094.yml

@@ -1,4 +1,4 @@
 ---
-name: Powiatowy Bank Spółdzielczy w Lubaczowie
+name: Bank Spółdzielczy w Lubaczowie
 90940006:
   branch: Oddział w Starym Dzikowie

data/lib/data/9101.yml

@@ -1,5 +1,5 @@
 ---
-name: Powiatowy Bank Spółdzielczy w Lubaczowie
+name: Bank Spółdzielczy w Lubaczowie
 91010003:
   branch: Centrala
 91011013:

data/lib/data/9141.yml

@@ -5,4 +5,4 @@ name: Bank Spółdzielczy w Pionkach
 91411015:
   branch: Oddział w Jedlni Letnisko
 91411028:
-  branch: Oddział w Kozienicach
+  branch: Filia w Kozienicach

data/lib/data/9321.yml

@@ -4,5 +4,3 @@ name: Bank Spółdzielczy w Bytowie
   branch: Centrala
 93211024:
   branch: Oddział w Miastku
-93211037:
-  branch: Oddział w Kołczygłowach

data/lib/data/9387.yml

@@ -9,4 +9,4 @@ name: Pyrzycko-Stargardzki Bank Spółdzielczy
 93871039:
   branch: Oddział w Warnicach
 93871042:
-  branch: Oddział w Stargardzie Szczecińskim
+  branch: Oddział w Stargardzie

data/lib/data/9396.yml

@@ -1,4 +1,4 @@
 ---
 name: Zachodniopomorski Bank Spółdzielczy
 93960007:
-  branch: Centrala
+  branch: Oddział w Szczecinie

data/lib/data/9500.yml

@@ -2,5 +2,3 @@
 name: Bank Spółdzielczy w Łasinie
 95000008:
   branch: Centrala
-95001018:
-  branch: Oddział Świecie n/Osą

data/lib/data/9603.yml

@@ -1,7 +1,7 @@
 ---
-name: Bank Spółdzielczy w Dołhobyczowie
+name: Powiatowy Bank Spółdzielczy w Zamościu
 96030006:
-  branch: Centrala
+  branch: Oddział
 96031016:
   branch: Oddział Mircze
 96031029:

data/lib/data/9639.yml

@@ -9,4 +9,4 @@ name: Bank Spółdzielczy w Tomaszowie Lubelskim
 96391051:
   branch: Oddział w Suścu
 96391064:
-  branch: Oddział w Tarnawatce
+  branch: Oddział w Tomaszowie Lubelskim Filia w Tarnawatce

data/lib/data_generator.rb

@@ -1,24 +1,28 @@
+#!/usr/bin/env ruby
+
 require 'fileutils'
 require 'yaml'
 
 BANK_NAME_COL = 1
 BRANCH_IDENTIFIER_COL = 4
 BRANCH_NAME_COL = 5
-DATA_DIR_NAME = 'data'.freeze
-FILE_NAME = 'plewibnra.txt'.freeze
+DATA_DIR_NAME = 'data'
+FILENAMES = ['plewibnra.txt', 'PlainDok.txt'].freeze
+
+filename = FILENAMES.detect { |file| File.exist?(file) }
 
 FileUtils.mkdir_p(DATA_DIR_NAME) unless File.directory?(DATA_DIR_NAME)
 
-file = File.open(FILE_NAME, 'r', encoding: 'CP852')
+file = File.open(filename, 'r', encoding: 'CP852')
 
 file.each_line do |row|
-  row = row.encode('UTF-8').split("\t").map(&:strip)
+  row = row.encode(Encoding.find('UTF-8'), invalid: :replace, undef: :replace, replace: '').split("\t").map(&:strip)
 
   branch_identifier = row[BRANCH_IDENTIFIER_COL]
   bank_identifier = branch_identifier.slice(0, 4)
   branch_name = row[BRANCH_NAME_COL]
 
-  file_name = "#{DATA_DIR_NAME}/#{bank_identifier}.yml"
+  data_file = "#{DATA_DIR_NAME}/#{bank_identifier}.yml"
 
   content = {
     branch_identifier.to_i => {
@@ -26,19 +30,19 @@ file.each_line do |row|
     }
   }
 
-  if File.exist?(file_name)
-    yaml_string = File.read(file_name)
+  if File.exist?(data_file)
+    yaml_string = File.read(data_file)
     data = YAML.safe_load(yaml_string)
 
     content = data.merge(content)
   else
-    File.new(file_name, 'w+')
+    File.new(data_file, 'w+')
 
     bank_name = row[BANK_NAME_COL].strip
     content = { 'name' => bank_name }.merge(content)
   end
 
-  File.open(file_name, 'r+') do |f|
+  File.open(data_file, 'r+') do |f|
     f.write(content.to_yaml(line_width: -1))
   end
 end

data/lib/polish_banks.rb

@@ -1,9 +1,11 @@
+# frozen_string_literal: true
+
 require 'yaml'
 require 'errors/bank_not_found'
 require 'errors/unsupported_country'
 
 class PolishBank
-  attr_reader :bank, :branch
+  attr_reader :name, :branch
 
   def initialize(iban)
     @iban = iban
@@ -33,6 +35,7 @@ class PolishBank
 
   def check_country
     return if integer?(country_code)
+
     raise UnsupportedCountry, "Iban #{iban} is not Polish" if country_code.casecmp('PL') != 0
   end
 

data/polish_banks.gemspec

@@ -1,7 +1,7 @@
 Gem::Specification.new do |s|
   s.name        = 'polish_banks'
-  s.version     = '1.0.0'
-  s.date        = '2019-01-13'
+  s.version     = '1.1.3'
+  s.date        = '2021-07-04'
   s.summary     = 'Polish bank detector'
   s.description = 'Get information about a Polish bank based on IBAN or account number.'
   s.authors     = ['Maciej Czuchnowski']
@@ -9,4 +9,6 @@ Gem::Specification.new do |s|
   s.files       = `git ls-files -z`.split("\x0")
   s.homepage    = 'https://github.com/mczuchnowski/polish_banks'
   s.license     = 'MIT'
+  s.add_development_dependency 'rspec', '~> 3.0'
+  s.add_development_dependency 'simplecov'
 end

data/spec/polish_banks_spec.rb

@@ -0,0 +1,82 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+require 'polish_banks'
+
+RSpec.describe PolishBank do
+  subject { described_class.new(iban) }
+
+  describe "standard iban check" do
+    let(:iban) { "PL9912406999" }
+
+    it "detects bank name" do
+      expect(subject.name).to be_a String
+      expect(subject.name.length).to be_positive
+    end
+
+    it "detects bank branch" do
+      expect(subject.branch).to be_a String
+      expect(subject.branch.length).to be_positive
+    end
+
+    context "with only partial match" do
+      let(:iban) { "PL9912406666" }
+
+      it "detects bank name" do
+        expect(subject.name).to be_a String
+        expect(subject.name.length).to be_positive
+      end
+
+      it "detects bank branch" do
+        expect(subject.branch).to be_a String
+        expect(subject.branch.length).to be_zero
+      end
+    end
+
+    context "with special characters" do
+      let(:iban) { "99-1240 6999" }
+
+      it "detects bank name" do
+        expect(subject.name).to be_a String
+        expect(subject.name.length).to be_positive
+      end
+
+      it "detects bank branch" do
+        expect(subject.branch).to be_a String
+        expect(subject.branch.length).to be_positive
+      end
+    end
+  end
+
+  describe "account number check" do
+    let(:iban) { "9912406999" }
+
+    it "detects bank name" do
+      expect(subject.name).to be_a String
+      expect(subject.name.length).to be_positive
+    end
+
+    it "detects bank branch" do
+      expect(subject.branch).to be_a String
+      expect(subject.branch.length).to be_positive
+    end
+  end
+
+  describe "error raising" do
+    context "foreign iban" do
+      let(:iban) { "DE9912406999" }
+
+      it "raises UnsupportedCountry error" do
+        expect { subject }.to raise_error(UnsupportedCountry, "Iban #{iban} is not Polish")
+      end
+    end
+
+    context "unknown bank" do
+      let(:iban) { "PL6666666666" }
+
+      it "raises BankNotFound error" do
+        expect { subject }.to raise_error(BankNotFound, "Polish bank not found for #{iban}")
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,5 @@
+require 'simplecov'
+
+SimpleCov.start do
+  add_filter '/spec/'
+end

metadata

@@ -1,22 +1,55 @@
 --- !ruby/object:Gem::Specification
 name: polish_banks
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.3
 platform: ruby
 authors:
 - Maciej Czuchnowski
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-01-13 00:00:00.000000000 Z
-dependencies: []
+date: 2021-07-04 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Get information about a Polish bank based on IBAN or account number.
 email: maciej.czuchnowski@gmail.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".gitignore"
+- ".travis.yml"
+- Gemfile
+- LICENSE
 - README.md
+- Rakefile
 - lib/data/1010.yml
 - lib/data/1020.yml
 - lib/data/1030.yml
@@ -42,7 +75,6 @@ files:
 - lib/data/1580.yml
 - lib/data/1600.yml
 - lib/data/1610.yml
-- lib/data/1670.yml
 - lib/data/1680.yml
 - lib/data/1710.yml
 - lib/data/1750.yml
@@ -70,7 +102,6 @@ files:
 - lib/data/2260.yml
 - lib/data/2270.yml
 - lib/data/2290.yml
-- lib/data/2320.yml
 - lib/data/2340.yml
 - lib/data/2350.yml
 - lib/data/2360.yml
@@ -101,10 +132,46 @@ files:
 - lib/data/2730.yml
 - lib/data/2740.yml
 - lib/data/2750.yml
+- lib/data/2780.yml
+- lib/data/2790.yml
+- lib/data/2810.yml
+- lib/data/2850.yml
+- lib/data/2870.yml
+- lib/data/2880.yml
+- lib/data/2890.yml
+- lib/data/2900.yml
+- lib/data/2910.yml
 - lib/data/6000.yml
 - lib/data/6040.yml
+- lib/data/6070.yml
+- lib/data/6110.yml
 - lib/data/6200.yml
 - lib/data/6300.yml
+- lib/data/7003.yml
+- lib/data/7005.yml
+- lib/data/7011.yml
+- lib/data/7014.yml
+- lib/data/7037.yml
+- lib/data/7039.yml
+- lib/data/7041.yml
+- lib/data/7042.yml
+- lib/data/7046.yml
+- lib/data/7048.yml
+- lib/data/7052.yml
+- lib/data/7056.yml
+- lib/data/7061.yml
+- lib/data/7065.yml
+- lib/data/7079.yml
+- lib/data/7089.yml
+- lib/data/7099.yml
+- lib/data/7105.yml
+- lib/data/7115.yml
+- lib/data/7118.yml
+- lib/data/7119.yml
+- lib/data/7144.yml
+- lib/data/7183.yml
+- lib/data/7189.yml
+- lib/data/7190.yml
 - lib/data/7999.yml
 - lib/data/8001.yml
 - lib/data/8002.yml
@@ -169,7 +236,6 @@ files:
 - lib/data/8140.yml
 - lib/data/8141.yml
 - lib/data/8142.yml
-- lib/data/8143.yml
 - lib/data/8144.yml
 - lib/data/8146.yml
 - lib/data/8147.yml
@@ -219,7 +285,6 @@ files:
 - lib/data/8264.yml
 - lib/data/8265.yml
 - lib/data/8267.yml
-- lib/data/8269.yml
 - lib/data/8273.yml
 - lib/data/8276.yml
 - lib/data/8277.yml
@@ -234,8 +299,6 @@ files:
 - lib/data/8309.yml
 - lib/data/8310.yml
 - lib/data/8313.yml
-- lib/data/8316.yml
-- lib/data/8317.yml
 - lib/data/8319.yml
 - lib/data/8320.yml
 - lib/data/8324.yml
@@ -278,7 +341,6 @@ files:
 - lib/data/8438.yml
 - lib/data/8441.yml
 - lib/data/8442.yml
-- lib/data/8443.yml
 - lib/data/8444.yml
 - lib/data/8445.yml
 - lib/data/8446.yml
@@ -341,7 +403,6 @@ files:
 - lib/data/8597.yml
 - lib/data/8600.yml
 - lib/data/8602.yml
-- lib/data/8606.yml
 - lib/data/8612.yml
 - lib/data/8614.yml
 - lib/data/8619.yml
@@ -372,7 +433,6 @@ files:
 - lib/data/8693.yml
 - lib/data/8702.yml
 - lib/data/8707.yml
-- lib/data/8710.yml
 - lib/data/8717.yml
 - lib/data/8721.yml
 - lib/data/8724.yml
@@ -500,7 +560,6 @@ files:
 - lib/data/9021.yml
 - lib/data/9022.yml
 - lib/data/9023.yml
-- lib/data/9025.yml
 - lib/data/9029.yml
 - lib/data/9035.yml
 - lib/data/9038.yml
@@ -526,7 +585,6 @@ files:
 - lib/data/9096.yml
 - lib/data/9101.yml
 - lib/data/9103.yml
-- lib/data/9105.yml
 - lib/data/9106.yml
 - lib/data/9107.yml
 - lib/data/9108.yml
@@ -618,15 +676,11 @@ files:
 - lib/data/9359.yml
 - lib/data/9364.yml
 - lib/data/9367.yml
-- lib/data/9368.yml
 - lib/data/9370.yml
-- lib/data/9371.yml
 - lib/data/9375.yml
 - lib/data/9376.yml
 - lib/data/9377.yml
-- lib/data/9378.yml
 - lib/data/9383.yml
-- lib/data/9386.yml
 - lib/data/9387.yml
 - lib/data/9393.yml
 - lib/data/9395.yml
@@ -683,7 +737,6 @@ files:
 - lib/data/9602.yml
 - lib/data/9603.yml
 - lib/data/9604.yml
-- lib/data/9606.yml
 - lib/data/9610.yml
 - lib/data/9614.yml
 - lib/data/9615.yml
@@ -712,6 +765,8 @@ files:
 - lib/errors/unsupported_country.rb
 - lib/polish_banks.rb
 - polish_banks.gemspec
+- spec/polish_banks_spec.rb
+- spec/spec_helper.rb
 homepage: https://github.com/mczuchnowski/polish_banks
 licenses:
 - MIT
@@ -731,8 +786,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.3
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: Polish bank detector