polint 0.0.3 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d287c6785e99e624589ae4ac2b01308c7469c9d1
-  data.tar.gz: 152df4d5a346490c23aac535ca0b6c0e18817608
+  metadata.gz: d183c6f2819c7036fef793ace5644f76349b3f24
+  data.tar.gz: e8a9bcda101105ce78e492790021fae4643cc015
 SHA512:
-  metadata.gz: 13caed3a5b182a0c401d40a3ac09d423e232a7226db0dac6c45b54c29a485f06e8b7b9d4d8fb74dc09e220986fe831841b720ede161ef42cda687a2efa4862a5
-  data.tar.gz: 31f8801ab58bfd387fbba735b0985fb27d4640752ac79f9a5f87c2e7dd0787b99350b265e07874a1899b0aa82cf526461a4d273d2364d80c7450204b3ef112ad
+  metadata.gz: 0dbb533fad098c6a220f317b8e88c910e2c80fa8fee04902b934c0f067b66d1f278b77c99319d1f3566d35329362ec5e30d22d14fada4e16b93706eb5b002ce4
+  data.tar.gz: 14b55b4f3a1d6078fe003ff097d6a574c7a77a483b2bcc7d513d8654b565258c375715531c82ccc420753d3bb4e30cde10788986e2a57811bd259948d5c72772

data/.rspec

@@ -0,0 +1,3 @@
+--color
+--require spec_helper
+--format documentation

data/Gemfile.lock

@@ -1,29 +1,86 @@
 PATH
   remote: .
   specs:
-    polint (0.0.3)
+    polint (0.1.0)
+      parslet (~> 1.7, >= 1.7.1)
       term-ansicolor
 
 GEM
   remote: https://rubygems.org/
   specs:
-    coderay (1.1.0)
+    blankslate (3.1.3)
+    byebug (9.0.5)
+    coderay (1.1.1)
+    diff-lcs (1.2.5)
+    ffi (1.9.10)
+    formatador (0.2.5)
+    guard (2.14.0)
+      formatador (>= 0.2.4)
+      listen (>= 2.7, < 4.0)
+      lumberjack (~> 1.0)
+      nenv (~> 0.1)
+      notiffany (~> 0.0)
+      pry (>= 0.9.12)
+      shellany (~> 0.0)
+      thor (>= 0.18.1)
+    guard-compat (1.2.1)
+    guard-rspec (4.7.2)
+      guard (~> 2.1)
+      guard-compat (~> 1.1)
+      rspec (>= 2.99.0, < 4.0)
+    listen (3.1.5)
+      rb-fsevent (~> 0.9, >= 0.9.4)
+      rb-inotify (~> 0.9, >= 0.9.7)
+      ruby_dep (~> 1.2)
+    lumberjack (1.0.10)
     method_source (0.8.2)
-    pry (0.10.1)
+    nenv (0.3.0)
+    notiffany (0.1.0)
+      nenv (~> 0.1)
+      shellany (~> 0.0)
+    parslet (1.7.1)
+      blankslate (>= 2.0, <= 4.0)
+    pry (0.10.3)
       coderay (~> 1.1.0)
       method_source (~> 0.8.1)
       slop (~> 3.4)
-    rake (10.4.2)
+    pry-byebug (3.4.0)
+      byebug (~> 9.0)
+      pry (~> 0.10)
+    rake (10.5.0)
+    rb-fsevent (0.9.7)
+    rb-inotify (0.9.7)
+      ffi (>= 0.5.0)
+    rspec (3.4.0)
+      rspec-core (~> 3.4.0)
+      rspec-expectations (~> 3.4.0)
+      rspec-mocks (~> 3.4.0)
+    rspec-core (3.4.4)
+      rspec-support (~> 3.4.0)
+    rspec-expectations (3.4.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.4.0)
+    rspec-mocks (3.4.1)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.4.0)
+    rspec-support (3.4.1)
+    ruby_dep (1.3.1)
+    shellany (0.0.1)
     slop (3.6.0)
-    term-ansicolor (1.3.0)
+    term-ansicolor (1.3.2)
       tins (~> 1.0)
-    tins (1.3.5)
+    thor (0.19.1)
+    tins (1.10.2)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
   bundler (~> 1.7)
+  guard-rspec
   polint!
-  pry
+  pry-byebug
   rake (~> 10.0)
+
+BUNDLED WITH
+   1.12.5

data/Guardfile

@@ -0,0 +1,14 @@
+guard :rspec, cmd: "bundle exec rspec" do
+  require "guard/rspec/dsl"
+  dsl = Guard::RSpec::Dsl.new(self)
+
+  rspec = dsl.rspec
+  watch(rspec.spec_helper) { rspec.spec_dir }
+  watch(rspec.spec_support) { rspec.spec_dir }
+  watch(rspec.spec_files)
+
+  ruby = dsl.ruby
+  dsl.watch_spec_files_for(ruby.lib_files)
+
+  watch(%r{^spec/data/.*\.po}) { 'spec/lib/polint_spec.rb' }
+end

data/lib/polint.rb

@@ -1,5 +1,8 @@
 # coding: utf-8
 require 'polint/version'
+require 'polint/parser'
+require 'polint/transform'
+require 'term/ansicolor'
 require 'singleton'
 
 module Polint
@@ -38,6 +41,34 @@ module Polint
 
   private
 
+    def error(key, val, contexts, message)
+      log key, val, contexts, "Error: #{message}", :red
+    end
+
+    def warn(key, val, contexts, message)
+      log key, val, contexts, "Warning: #{message}", :yellow
+    end
+
+    def log(key, val, contexts, message, color)
+      if key =~ /(\d+):(.*)/
+        lineno = $1
+        file_and_line = "#{@pofile}:#{$1}:"
+        key = $2
+      else
+        lineno = nil
+        file_and_line = "#{@pofile}:"
+      end
+      puts "#{file_and_line}#{term.public_send(color)} #{message}.#{term.clear}"
+      if @verbose
+        contexts.each do |context|
+          puts "#{term.blue}CONTEXT:#{term.clear} #{context}"
+        end
+        puts "#{term.blue}KEY:#{term.clear} #{key}"
+        puts "#{term.blue}TRN:#{term.clear} #{val}"
+        puts "–" * 80
+      end
+    end
+
     def term
       @term ||= ENV['NOCOLOR'] ? BlackHole.instance : Term::ANSIColor
     end
@@ -77,39 +108,49 @@ module Polint
         io.write data.join
         io.flush
         io.close_write
-        data = io.read.split(/\n/)
+        data = io.read
       end
       success and return data
       die "Error while loading the PO file '#{@pofile}', aborting."
     end
 
-    def parse_data(lines)
-      current = []
-      context = []
-      next_is_fuzzy = false
-
-      lines.each do |line|
-        case line
+    def parse_data(data)
+      return if data.nil? || data.empty?
 
-        when /^#, fuzzy/
-          next_is_fuzzy = true
+      tree = Polint::Parser.new.parse(data)
+      tree = Polint::Transform.new.apply(tree)
 
-        when /^#: (.*)/
-          context << $1
+      die 'No Plural-Forms header found' unless tree[:headers].key?('Plural-Forms')
+      nplurals = tree[:headers]['Plural-Forms'][:nplurals]
 
-        when /^(msgid|msgid_plural)\s+"(.*)"$/
-          current << $2
+      tree[:translations].each do |translation|
+        msgid, msgid_plural = translation[:msgid][:text], translation[:msgid_plural][:text]
+        contexts = translation[:references]
+        fuzzy = translation[:flags].include?(:fuzzy)
 
-        when /^(msgstr(?:\[([01])\])?)\s+"(.*)"$/
-          index = $2.to_i # $2 will be nil for non-plural, so index will be 0
-          check_pair(current[index], $3, context, next_is_fuzzy)
+        if msgid_plural.nil?
+          if translation[:msgstrs].size != 1
+            error msgid, nil, contexts, "#{translation[:msgstrs].size} plurals found but none expected"
+            @errors += 1
+          end
 
+          check_pair(msgid, translation[:msgstrs][0][:text], translation[:references], fuzzy)
         else
-          current = []
-          context = []
-          next_is_fuzzy = false
+          if translation[:msgstrs].size != nplurals
+            error msgid, nil, contexts, "#{translation[:msgstrs].size} plurals found but #{nplurals} expected"
+            @errors += 1
+          end
+
+          plural_attr = (msgid_plural.scan(AttributeRe).uniq - msgid.scan(AttributeRe).uniq).first
+          translation[:msgstrs].each do |msgstr|
+            val = msgstr[:text]
+            msgid_check = val.scan(AttributeRe).include?(plural_attr) ? msgid_plural : msgid
+            check_pair(msgid_check, val, contexts, fuzzy)
+          end
         end
       end
+    rescue Parslet::ParseFailed => e
+      die e.cause.ascii_tree
     end
 
     # Check for errors in a key/translation pair.
@@ -129,36 +170,18 @@ module Polint
       @errors  += 1 if not_in_val.any? || not_in_key.any? || is_empty
       @fuzzies += 1 if is_fuzzy
 
-      if key =~ /(\d+):(.*)/
-        lineno = $1
-        file_and_line = "#{@pofile}:#{$1}:"
-        key = $2
-      else
-        lineno = nil
-        file_and_line = "#{@pofile}:"
-      end
-
       if is_empty
-        puts "#{file_and_line}#{term.red} Error: translated string empty.#{term.clear}"
+        error key, val, contexts, "translated string empty"
       elsif not_in_key.any?
         not_in_key.each do |name|
-          puts "#{file_and_line}#{term.red} Error: #{name} absent from reference string.#{term.clear}"
+          error key, val, contexts, "#{name} absent from reference string"
         end
       elsif not_in_val.any?
         not_in_val.each do |name|
-          puts "#{file_and_line}#{term.yellow} Warning: #{name} absent from translated string.#{term.clear}"
+          warn key, val, contexts, "#{name} absent from translated string"
         end
       elsif is_fuzzy
-        puts "#{file_and_line}#{term.yellow} Warning: translation is fuzzy.#{term.clear}"
-      end
-
-      if @verbose
-        contexts.each do |context|
-          puts "#{term.blue}CONTEXT:#{term.clear} #{context}"
-        end
-        puts "#{term.blue}KEY:#{term.clear} #{key}"
-        puts "#{term.blue}TRN:#{term.clear} #{val}"
-        puts "–" * 80
+        warn key, val, contexts, "translation is fuzzy"
       end
     end
   end

data/lib/polint/parser.rb

@@ -0,0 +1,52 @@
+require 'parslet'
+
+module Polint
+  class Parser < Parslet::Parser
+
+    rule(:endl) { str("\n").maybe }
+    rule(:sp) { str(' ') }
+    rule(:htab) { str("\t") }
+    rule(:wsp) { sp | htab }
+    rule(:lwsp) { wsp.repeat }
+    rule(:tcase) { match(/[A-Z]/).repeat(1) >> match(/[a-z]/).repeat }
+    rule(:blank_line) { endl }
+
+    rule(:quote) { str('"') }
+    rule(:quoted_char) { match(/[^"]/) }
+    rule(:quoted_pair) { str('\\') >> quote }
+    rule(:quoted_string) { quote >> (quoted_pair | quoted_char).repeat.as(:quoted_string) >> quote >> lwsp }
+    rule(:quoted_strings) { (quoted_string >> endl).repeat(1) }
+
+    rule(:header_sep) { str(':') >> lwsp }
+    rule(:header_name) { (tcase >> (str('-') >> tcase).repeat).as(:name) >> header_sep }
+    rule(:header_value) { match(/[^\n"]/).repeat.as(:value) }
+    rule(:raw_header) { header_name >> header_value }
+    rule(:nplurals) { str('nplurals=') >> match(/[0-9]/).repeat.as(:nplurals) >> str(';') >> lwsp }
+    rule(:plural) { str('plural=') >> match(/[^\n"]/).repeat.as(:plural) }
+    rule(:plural_forms_header) { str('Plural-Forms').as(:name) >> header_sep >> (nplurals >> plural).as(:value) }
+    rule(:unquoted_header) { plural_forms_header | raw_header }
+    rule(:header) { quote >> unquoted_header >> quote >> lwsp }
+    rule(:header_lines) { (header >> endl).repeat(1) }
+    rule(:headers) { str('msgid') >> lwsp >> quote >> quote >> endl >> str('msgstr') >> lwsp >> ((quoted_string >> endl).maybe >> header_lines).as(:headers) >> blank_line }
+
+    rule(:start_comment) { str('#') }
+    rule(:flag) { str(',') >> lwsp >> match(/[a-z\-]/).repeat(1).as(:flag) >> lwsp }
+    rule(:flag_comment) { start_comment >> flag.repeat(1).as(:flags) >> endl }
+    rule(:reference_comment) { start_comment >> str(':') >> lwsp >> match(/[^\n]/).repeat.as(:reference) >> endl }
+    rule(:comment) { flag_comment | reference_comment }
+    rule(:comments) { comment.repeat }
+
+    rule(:msgid) { str('msgid') >> lwsp >> quoted_strings.as(:msgid) }
+    rule(:msgid_plural) { str('msgid_plural') >> lwsp >> quoted_strings.as(:msgid_plural) }
+
+    rule(:index) { str('[') >> match(/[0-9]/).repeat(1).as(:index) >> str(']') }
+    rule(:msgstr) { str('msgstr') >> (index.maybe >> lwsp >> quoted_strings).as(:msgstr) }
+
+    rule(:translation) { (comments >> msgid >> msgid_plural.maybe >> msgstr.repeat(1)).as(:translation) >> blank_line }
+    rule(:translations) { translation.repeat }
+
+    rule(:file) { (headers >> translations).as(:file) }
+    root(:file)
+
+  end
+end

data/lib/polint/transform.rb

@@ -0,0 +1,64 @@
+require 'parslet'
+
+module Polint
+  class Transform < Parslet::Transform
+
+    rule(flag: simple(:f)) { f.to_sym }
+
+    rule(quoted_string: simple(:qs)) { qs }
+    rule(quoted_string: sequence(:qs)) { '' } # empty string is parsed as []
+
+    rule(name: simple(:k), value: simple(:v)) { [k.to_s, v.to_s] }
+    rule(name: simple(:k), value: subtree(:v)) { [k.to_s, v] }
+    rule(nplurals: simple(:n), plural: simple(:p)) { { nplurals: n.to_i, plural: p } }
+    rule(headers: subtree(:items)) do
+      items.shift if items.first == ''
+      { headers: items.to_h }
+    end
+
+    rule(msgid: sequence(:items)) { { msgid: { text: items.join("\n") } } }
+    rule(msgid_plural: sequence(:items)) { { msgid_plural: { text: items.join("\n") } } }
+    rule(msgstr: subtree(:items)) do
+      msgstr = {}
+      msgstr[:index] = items.shift[:index].to_i if items.first.is_a?(Hash)
+      msgstr[:text] = items.join("\n")
+      { msgstr: msgstr }
+    end
+
+    rule(translation: subtree(:items)) do
+      translation = {
+        flags: [],
+        references: [],
+        msgid: {},
+        msgid_plural: {},
+        msgstrs: []
+      }
+      items.each do |hash|
+        k, v = hash.to_a.first
+        case k
+        when :flags then translation[:flags] |= v
+        when :reference then translation[:references] << v
+        when :msgid, :msgid_plural then translation[k] = v
+        when :msgstr then translation[:msgstrs] << v
+        end
+      end
+      { translation: translation }
+    end
+
+    rule(file: subtree(:items)) do
+      file = {
+        headers: {},
+        translations: []
+      }
+      items.each do |hash|
+        k, v = hash.to_a.first
+        case k
+        when :headers then file[:headers] = v
+        when :translation then file[:translations] << v
+        end
+      end
+      file
+    end
+
+  end
+end

data/lib/polint/version.rb

@@ -1,3 +1,3 @@
 module Polint
-  VERSION = "0.0.3"
+  VERSION = "0.2.0"
 end

data/polint.gemspec

@@ -6,8 +6,8 @@ require 'polint/version'
 Gem::Specification.new do |spec|
   spec.name          = "polint"
   spec.version       = Polint::VERSION
-  spec.authors       = ["Julien Letessier"]
-  spec.email         = ["julien.letessier@gmail.com"]
+  spec.authors       = ["Julien Letessier", "Greg Beech"]
+  spec.email         = ["julien.letessier@gmail.com", "greg@gregbeech.com"]
   spec.summary       = %q{A linter for Uniforum PO files.}
   spec.homepage      = ""
   spec.license       = "MIT"
@@ -19,7 +19,9 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency "bundler", "~> 1.7"
   spec.add_development_dependency "rake", "~> 10.0"
-  spec.add_development_dependency "pry"
+  spec.add_development_dependency "pry-byebug"
+  spec.add_development_dependency "guard-rspec"
 
   spec.add_dependency "term-ansicolor"
+  spec.add_dependency "parslet", "~> 1.7", ">= 1.7.1"
 end

data/spec/data/ar-valid.po

@@ -0,0 +1,22 @@
+msgid ""
+msgstr ""
+"Language: ar\n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Transfer-Encoding: 8bit\n"
+"Plural-Forms: nplurals=6; plural= n==0 ? 0 : n==1 ? 1 : n==2 ? 2 : n%100>=3 && n%100<=10 ? 3 : n%100>=11 ? 4 : 5;\n"
+"X-Generator: PhraseApp (phraseapp.com)\n"
+
+#: ../some_file.rb:51
+msgid "Hello World"
+msgstr "مرحبا بالعالم"
+
+#: ../some_file.rb:51
+msgid "Hello World Plural"
+msgid_plural "Hello %{n} Worlds Plural"
+msgstr[0] "مرحبا العالمي الجمع"
+msgstr[1] "مرحبا %{n} العالمين الجمع"
+msgstr[2] "مرحبا %{n} العالمين الجمع"
+msgstr[3] "مرحبا %{n} العالمين الجمع"
+msgstr[4] "مرحبا %{n} العالمين الجمع"
+msgstr[5] "مرحبا %{n} العالمين الجمع"

data/spec/data/en-valid.po

@@ -0,0 +1,18 @@
+msgid ""
+msgstr ""
+"Language: en\n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Transfer-Encoding: 8bit\n"
+"Plural-Forms: nplurals=2; plural=(n != 1);\n"
+"X-Generator: PhraseApp (phraseapp.com)\n"
+
+#: ../some_file.rb:51
+msgid "Hello World"
+msgstr "Hello World"
+
+#: ../some_file.rb:51
+msgid "Hello World Plural"
+msgid_plural "Hello %{n} Worlds Plural"
+msgstr[0] "Hello World Plural"
+msgstr[1] "Hello %{n} Worlds Plural"

data/spec/data/fr-valid.po

@@ -0,0 +1,18 @@
+msgid ""
+msgstr ""
+"Language: fr\n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Transfer-Encoding: 8bit\n"
+"Plural-Forms: nplurals=2; plural=(n > 1);\n"
+"X-Generator: PhraseApp (phraseapp.com)\n"
+
+#: ../some_file.rb:51
+msgid "Hello World"
+msgstr "Bonjour le monde"
+
+#: ../some_file.rb:51
+msgid "Hello World Plural"
+msgid_plural "Hello %{n} Worlds Plural"
+msgstr[0] "Bonjour tout le monde pluriel"
+msgstr[1] "Bonjour %{n} mondes pluriels"

data/spec/data/zh-valid.po

@@ -0,0 +1,17 @@
+msgid ""
+msgstr ""
+"Language: zh\n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Transfer-Encoding: 8bit\n"
+"Plural-Forms: nplurals=1; plural=0;\n"
+"X-Generator: PhraseApp (phraseapp.com)\n"
+
+#: ../some_file.rb:51
+msgid "Hello World"
+msgstr "你好，世界"
+
+#: ../some_file.rb:51
+msgid "Hello World Plural"
+msgid_plural "Hello %{n} Worlds Plural"
+msgstr[0] "你好%{n}世界多元"

data/spec/lib/polint/parser_spec.rb

@@ -0,0 +1,258 @@
+require 'polint/parser'
+
+RSpec.describe Polint::Parser do
+  let(:parser) { described_class.new }
+  let(:rule) { :translation }
+  let(:line) { '' }
+  let(:tree) { parser.send(rule).parse(line) }
+
+  describe 'rule(:quoted_string)' do
+    let(:rule) { :quoted_string }
+
+    context 'when matching a simple string' do
+      let(:line) { '"Hello World"' }
+      it { expect(tree).to eq quoted_string: 'Hello World' }
+    end
+
+    context 'when matching a string with embedded quotes' do
+      let(:line) { '"Hello \\"my\\" World"' }
+      it { expect(tree).to eq quoted_string: 'Hello \\"my\\" World' }
+    end
+  end
+
+  describe 'rule(:headers)' do
+    let(:rule) { :headers }
+    let(:line) { lines.join("\n") }
+
+    context 'when matching a plural forms header' do
+      let(:lines) {
+        [
+          'msgid ""',
+          'msgstr ""',
+          '"Language: ar\n"',
+          '"MIME-Version: 1.0\n"',
+          '"Content-Type: text/plain; charset=UTF-8\n"',
+          '"Content-Transfer-Encoding: 8bit\n"',
+          '"Plural-Forms: nplurals=6; plural= n==0 ? 0 : n==1 ? 1 : n==2 ? 2 : n%100>=3 && n%100<=10 ? 3 : n%100>=11 ? 4 : 5;\n"',
+          '"X-Generator: PhraseApp (phraseapp.com)\n"'
+        ]
+      }
+      it {
+        expect(tree).to eq headers: [
+          { quoted_string: [] },
+          { name: 'Language', value: 'ar\n' },
+          { name: 'MIME-Version', value: '1.0\n' },
+          { name: 'Content-Type', value: 'text/plain; charset=UTF-8\n' },
+          { name: 'Content-Transfer-Encoding', value: '8bit\n' },
+          { name: 'Plural-Forms', value: { nplurals: '6', plural: ' n==0 ? 0 : n==1 ? 1 : n==2 ? 2 : n%100>=3 && n%100<=10 ? 3 : n%100>=11 ? 4 : 5;\n' } },
+          { name: 'X-Generator', value: 'PhraseApp (phraseapp.com)\n' }
+        ]
+      }
+    end
+
+    context 'when matching an unquoted header' do
+      let(:line) { 'Plural-Forms: nplurals=6; plural= n==0 ? 0 : n==1 ? 1 : n==2 ? 2 : n%100>=3 && n%100<=10 ? 3 : n%100>=11 ? 4 : 5;\n' }
+      it { expect{ tree }.to raise_error Parslet::ParseFailed }
+    end
+  end
+
+  describe 'rule(:flag_comment)' do
+    let(:rule) { :flag_comment }
+
+    context 'when matching a fuzzy comment' do
+      let(:line) { '#, fuzzy' }
+      it { expect(tree).to eq flags: [{ flag: 'fuzzy' }] }
+    end
+
+    context 'when matching a multi-flag comment' do
+      let(:line) { '#, java-format, fuzzy' }
+      it { expect(tree).to eq flags: [{ flag: 'java-format' }, { flag: 'fuzzy' }] }
+    end
+
+    context 'when matching a non-flags comment' do
+      let(:line) { '#: ../../some_file.rb:34' }
+      it { expect{ tree }.to raise_error Parslet::ParseFailed }
+    end
+  end
+
+  describe 'rule(:reference_comment)' do
+    let(:rule) { :reference_comment }
+
+    context 'when matching a reference comment' do
+      let(:line) { '#: ../../some_file.rb:34' }
+      it { expect(tree).to eq reference: '../../some_file.rb:34' }
+    end
+
+    context 'when matching a non-reference comment' do
+      let(:line) { '#, fuzzy' }
+      it { expect{ tree }.to raise_error Parslet::ParseFailed }
+    end
+  end
+
+  describe 'rule(:msgid)' do
+    let(:rule) { :msgid }
+
+    context 'when matching a single-line msgid' do
+      let(:line) { 'msgid "Hello World"' }
+      it { expect(tree).to eq msgid: [{ quoted_string: 'Hello World' }] }
+    end
+
+    context 'when matching a multi-line msgid' do
+      let(:line) { %{msgid ""\n"Hello World"\n"Hello Again"} }
+      it { expect(tree).to eq msgid: [{ quoted_string: [] }, { quoted_string: 'Hello World' }, { quoted_string: 'Hello Again'}] }
+    end
+
+    context 'when matching a msgid with embedded quotes' do
+      let(:line) { 'msgid "Hello \\"my\\" World"' }
+      it { expect(tree).to eq msgid: [{ quoted_string: 'Hello \\"my\\" World' }] }
+    end
+
+    context 'when matching an unquoted msgid' do
+      let(:line) { 'msgid Unquoted String' }
+      it { expect{ tree }.to raise_error Parslet::ParseFailed }
+    end
+  end
+
+  describe 'rule(:msgid_plural)' do
+    let(:rule) { :msgid_plural }
+
+    context 'when matching a single-line msgid_plural' do
+      let(:line) { 'msgid_plural "Hello %{n} Worlds"' }
+      it { expect(tree).to eq msgid_plural: [{ quoted_string: 'Hello %{n} Worlds' }] }
+    end
+
+    context 'when matching a multi-line msgid_plural' do
+      let(:line) { %{msgid_plural ""\n"Hello %{n} Worlds"\n"Hello Again"} }
+      it { expect(tree).to eq msgid_plural: [{ quoted_string: [] }, { quoted_string: 'Hello %{n} Worlds' }, { quoted_string: 'Hello Again'}] }
+    end
+
+    context 'when matching an unquoted msgid_plural' do
+      let(:line) { 'msgid_plural Unquoted String' }
+      it { expect{ tree }.to raise_error Parslet::ParseFailed }
+    end
+  end
+
+  describe 'rule(:msgstr)' do
+    let(:rule) { :msgstr }
+
+    context 'when matching a single-line msgstr' do
+      let(:line) { 'msgstr "Hello World"' }
+      it { expect(tree).to eq msgstr: [{ quoted_string: 'Hello World' }] }
+    end
+
+    context 'when matching a single-line msgstr with an index' do
+      let(:line) { 'msgstr[3] "Hello World"' }
+      it { expect(tree).to eq msgstr: [{ index: '3' }, { quoted_string: 'Hello World' }] }
+    end
+
+    context 'when matching a multi-line msgstr' do
+      let(:line) { %{msgstr ""\n"Hello World"\n"Hello Again"} }
+      it { expect(tree).to eq msgstr: [{ quoted_string: [] }, { quoted_string: 'Hello World' }, { quoted_string: 'Hello Again'}] }
+    end
+
+    context 'when matching a multi-line msgstr with an index' do
+      let(:line) { %{msgstr[1] ""\n"Hello World"\n"Hello Again"} }
+      it { expect(tree).to eq msgstr: [{ index: '1' }, { quoted_string: [] }, { quoted_string: 'Hello World' }, { quoted_string: 'Hello Again'}] }
+    end
+
+    context 'when matching an unquoted msgstr' do
+      let(:line) { 'msgstr Unquoted String' }
+      it { expect{ tree }.to raise_error Parslet::ParseFailed }
+    end
+  end
+
+  describe 'rule(:translation)' do
+    let(:rule) { :translation }
+    let(:line) { lines.join("\n") }
+
+    context 'when matching a singular single-line msgstr with comments' do
+      let(:lines) {
+        [
+          '#, fuzzy',
+          '#: ../../some_file.rb:34',
+          'msgid "Hello World"',
+          'msgstr "Hello World"'
+        ]
+      }
+      it {
+        expect(tree).to eq translation: [
+          { flags: [{ flag: 'fuzzy' }] },
+          { reference: '../../some_file.rb:34' },
+          { msgid: [{ quoted_string: 'Hello World' }] },
+          { msgstr: [{ quoted_string: 'Hello World' }] }
+        ]
+      }
+    end
+
+    context 'when matching a plural single-line msgstr with comments' do
+      let(:lines) {
+        [
+          '#, fuzzy',
+          '#: ../../some_file.rb:34',
+          'msgid "Hello World"',
+          'msgid_plural "Hello %{n} Worlds"',
+          'msgstr[0] "Hello World"',
+          'msgstr[1] "Hello %{n} Worlds"'
+        ]
+      }
+      it {
+        expect(tree).to eq translation: [
+          { flags: [{ flag: 'fuzzy' }] },
+          { reference: '../../some_file.rb:34' },
+          { msgid: [{ quoted_string: 'Hello World' }] },
+          { msgid_plural: [{ quoted_string: 'Hello %{n} Worlds' }] },
+          { msgstr: [{ index: '0' }, { quoted_string: 'Hello World' }] },
+          { msgstr: [{ index: '1' }, { quoted_string: 'Hello %{n} Worlds' }] }
+        ]
+      }
+    end
+
+    # TODO: Multiline strings and negative cases
+  end
+
+  describe 'rule(:translations)' do
+    let(:rule) { :translations }
+    let(:line) { lines.join("\n") }
+
+    context 'when matching multiple translations' do
+      let(:lines) {
+        [
+          '#, fuzzy',
+          '#: ../../some_file.rb:34',
+          'msgid "Hello World"',
+          'msgstr "Hello World"',
+          '',
+          '#, fuzzy',
+          '#: ../../some_file.rb:34',
+          'msgid "Hello World"',
+          'msgid_plural "Hello %{n} Worlds"',
+          'msgstr[0] "Hello World"',
+          'msgstr[1] "Hello %{n} Worlds"'
+        ]
+      }
+      it {
+        expect(tree).to eq [
+          {
+            translation: [
+              { flags: [{ flag: 'fuzzy' }] },
+              { reference: '../../some_file.rb:34' },
+              { msgid: [{ quoted_string: 'Hello World' }] },
+              { msgstr: [{ quoted_string: 'Hello World' }] }
+            ]
+          },
+          {
+            translation: [
+              { flags: [{ flag: 'fuzzy' }] },
+              { reference: '../../some_file.rb:34' },
+              { msgid: [{ quoted_string: 'Hello World' }] },
+              { msgid_plural: [{ quoted_string: 'Hello %{n} Worlds' }] },
+              { msgstr: [{ index: '0' }, { quoted_string: 'Hello World' }] },
+              { msgstr: [{ index: '1' }, { quoted_string: 'Hello %{n} Worlds' }] }
+            ]
+          }
+        ]
+      }
+    end
+  end
+
+end

data/spec/lib/polint/transform_spec.rb

@@ -0,0 +1,61 @@
+require 'polint/transform'
+
+RSpec.describe Polint::Transform do
+  let(:transform) { described_class.new }
+  let(:output) { transform.apply(tree) }
+
+  context 'with a headers tree' do
+    let(:tree) {
+      {
+        headers: [
+          { quoted_string: [] },
+          { name: 'Language', value: 'ar\n' },
+          { name: 'MIME-Version', value: '1.0\n' },
+          { name: 'Content-Type', value: 'text/plain; charset=UTF-8\n' },
+          { name: 'Content-Transfer-Encoding', value: '8bit\n' },
+          { name: 'Plural-Forms', value: { nplurals: '6', plural: ' n==0 ? 0 : n==1 ? 1 : n==2 ? 2 : n%100>=3 && n%100<=10 ? 3 : n%100>=11 ? 4 : 5;\n' } },
+          { name: 'X-Generator', value: 'PhraseApp (phraseapp.com)\n' }
+        ]
+      }
+    }
+    it {
+      expect(output).to eq headers: {
+        'Language' => 'ar\n',
+        'MIME-Version' => '1.0\n',
+        'Content-Type' => 'text/plain; charset=UTF-8\n',
+        'Content-Transfer-Encoding' => '8bit\n',
+        'Plural-Forms' => { nplurals: 6, plural: ' n==0 ? 0 : n==1 ? 1 : n==2 ? 2 : n%100>=3 && n%100<=10 ? 3 : n%100>=11 ? 4 : 5;\n' },
+        'X-Generator' => 'PhraseApp (phraseapp.com)\n'
+      }
+    }
+  end
+
+  context 'with a plural tree' do
+    let(:tree) {
+      {
+        translation: [
+          { flags: [{ flag: 'fuzzy' }] },
+          { reference: '../../some_file.rb:34' },
+          { reference: '../../some_other_file.rb:283' },
+          { msgid: [{ quoted_string: [] }, { quoted_string: 'Hello World' }, { quoted_string: 'Hello Again'}] },
+          { msgid_plural: [{ quoted_string: [] }, { quoted_string: 'Hello %{n} Worlds' }, { quoted_string: 'Hello Again'}] },
+          { msgstr: [{ index: '0' }, { quoted_string: [] }, { quoted_string: 'Hello World' }, { quoted_string: 'Hello Again'}] },
+          { msgstr: [{ index: '1' }, { quoted_string: [] }, { quoted_string: 'Hello %{n} Worlds' }, { quoted_string: 'Hello Again'}] }
+        ]
+      }
+    }
+    it {
+      expect(output).to eq translation: {
+        flags: [:fuzzy],
+        references: ['../../some_file.rb:34', '../../some_other_file.rb:283'],
+        msgid: { text: "\nHello World\nHello Again" },
+        msgid_plural: { text: "\nHello %{n} Worlds\nHello Again" },
+        msgstrs: [
+          { index: 0, text: "\nHello World\nHello Again" },
+          { index: 1, text: "\nHello %{n} Worlds\nHello Again" }
+        ]
+      }
+    }
+  end
+
+end

data/spec/lib/polint_spec.rb

@@ -0,0 +1,15 @@
+require 'polint'
+
+RSpec.describe Polint::Checker do
+
+  Dir.glob(File.join(__dir__, '..', 'data', '*-valid.po')) do |file|
+    context "#{File.basename(file, '.po').split('-').join(' ')}" do
+      let(:checker) { described_class.new(file) }
+
+      it 'has no errors' do
+        expect(checker.run).to eq 0
+      end
+    end
+  end
+
+end

data/spec/spec_helper.rb

@@ -0,0 +1,12 @@
+require 'pry'
+
+# rspec seems to complain about this class not having a #cause method; not sure
+# why but this is a quick hacky fix just to get everything passing. it doesn't
+# seem to affect the results of the tests anyway.
+module Parslet
+  class Cause
+    def cause
+      StandardError.new
+    end
+  end
+end

metadata

@@ -1,14 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: polint
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.2.0
 platform: ruby
 authors:
 - Julien Letessier
+- Greg Beech
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-06 00:00:00.000000000 Z
+date: 2016-06-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -39,7 +40,21 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '10.0'
 - !ruby/object:Gem::Dependency
-  name: pry
+  name: pry-byebug
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: guard-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -66,24 +81,57 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: parslet
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.7'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.7.1
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.7'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.7.1
 description: 
 email:
 - julien.letessier@gmail.com
+- greg@gregbeech.com
 executables:
 - polint
 extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rspec"
 - Gemfile
 - Gemfile.lock
+- Guardfile
 - LICENSE.txt
 - README.md
 - Rakefile
 - bin/polint
 - lib/polint.rb
+- lib/polint/parser.rb
+- lib/polint/transform.rb
 - lib/polint/version.rb
 - polint.gemspec
+- spec/data/ar-valid.po
+- spec/data/en-valid.po
+- spec/data/fr-valid.po
+- spec/data/zh-valid.po
+- spec/lib/polint/parser_spec.rb
+- spec/lib/polint/transform_spec.rb
+- spec/lib/polint_spec.rb
+- spec/spec_helper.rb
 homepage: ''
 licenses:
 - MIT
@@ -104,9 +152,16 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: A linter for Uniforum PO files.
-test_files: []
-has_rdoc: 
+test_files:
+- spec/data/ar-valid.po
+- spec/data/en-valid.po
+- spec/data/fr-valid.po
+- spec/data/zh-valid.po
+- spec/lib/polint/parser_spec.rb
+- spec/lib/polint/transform_spec.rb
+- spec/lib/polint_spec.rb
+- spec/spec_helper.rb