policy 1.2.0 → 2.0.0

data/spec/tests/lib/policy_spec.rb

@@ -0,0 +1,52 @@
+# encoding: utf-8
+
+describe Policy do
+
+  let(:one) { double :one }
+  let(:two) { double :two }
+
+  describe ".and" do
+
+    let(:composer) { Policy::Base::And }
+
+    it "composes policies with And composer" do
+      expect(composer).to receive(:new).with(one, two)
+      described_class.and one, two
+    end
+
+  end # describe .and
+
+  describe ".or" do
+
+    let(:composer) { Policy::Base::Or }
+
+    it "composes policies with Or composer" do
+      expect(composer).to receive(:new).with(one, two)
+      described_class.or one, two
+    end
+
+  end # describe .or
+
+  describe ".xor" do
+
+    let(:composer) { Policy::Base::Xor }
+
+    it "composes policies with Xor composer" do
+      expect(composer).to receive(:new).with(one, two)
+      described_class.xor one, two
+    end
+
+  end # describe .xor
+
+  describe ".not" do
+
+    let(:composer) { Policy::Base::Not }
+
+    it "composes policies with Not composer" do
+      expect(composer).to receive(:new).with(one)
+      described_class.not one
+    end
+
+  end # describe .not
+
+end # describe Policy

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: policy
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 2.0.0
 platform: ruby
 authors:
 - Andrew Kozin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-18 00:00:00.000000000 Z
+date: 2015-03-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -24,20 +24,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '3.1'
-- !ruby/object:Gem::Dependency
-  name: adamantium
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.2'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.2'
 - !ruby/object:Gem::Dependency
   name: hexx-cli
   requirement: !ruby/object:Gem::Requirement
@@ -45,7 +31,7 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.0'
-  type: :runtime
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
@@ -66,7 +52,7 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.3'
-description: A tiny library implementing the Policy Object pattern.
+description: A small library implementing the Policy Object pattern.
 email: andrew.kozin@gmail.com
 executables:
 - policy
@@ -101,31 +87,40 @@ files:
 - config/metrics/simplecov.yml
 - config/metrics/yardstick.yml
 - lib/policy.rb
+- lib/policy/base.rb
+- lib/policy/base/and.rb
+- lib/policy/base/negator.rb
+- lib/policy/base/node.rb
+- lib/policy/base/not.rb
+- lib/policy/base/or.rb
+- lib/policy/base/xor.rb
 - lib/policy/cli.rb
+- lib/policy/cli/attribute.rb
 - lib/policy/cli/locale.erb
 - lib/policy/cli/policy.erb
 - lib/policy/cli/spec.erb
 - lib/policy/follower.rb
-- lib/policy/follower/followed_policies.rb
-- lib/policy/follower/followed_policy.rb
-- lib/policy/follower/names.rb
-- lib/policy/interface.rb
-- lib/policy/validations.rb
+- lib/policy/follower/name_error.rb
+- lib/policy/follower/policies.rb
+- lib/policy/follower/violation_error.rb
 - lib/policy/version.rb
-- lib/policy/violation_error.rb
 - policy.gemspec
-- spec/features/follower_spec.rb
 - spec/spec_helper.rb
+- spec/support/composer.rb
 - spec/tests/bin/policy_spec.rb
-- spec/tests/policy/cli_spec.rb
-- spec/tests/policy/follower/followed_policies_spec.rb
-- spec/tests/policy/follower/followed_policy_spec.rb
-- spec/tests/policy/follower/names_spec.rb
-- spec/tests/policy/follower_spec.rb
-- spec/tests/policy/interface_spec.rb
-- spec/tests/policy/validations_spec.rb
-- spec/tests/policy/violation_error_spec.rb
-- spec/tests/policy_spec.rb
+- spec/tests/lib/policy/base/and_spec.rb
+- spec/tests/lib/policy/base/negator_spec.rb
+- spec/tests/lib/policy/base/not_spec.rb
+- spec/tests/lib/policy/base/or_spec.rb
+- spec/tests/lib/policy/base/xor_spec.rb
+- spec/tests/lib/policy/base_spec.rb
+- spec/tests/lib/policy/cli/attribute_spec.rb
+- spec/tests/lib/policy/cli_spec.rb
+- spec/tests/lib/policy/follower/name_error_spec.rb
+- spec/tests/lib/policy/follower/policies_spec.rb
+- spec/tests/lib/policy/follower/violation_error_spec.rb
+- spec/tests/lib/policy/follower_spec.rb
+- spec/tests/lib/policy_spec.rb
 homepage: https://github.com/nepalez/policy
 licenses:
 - MIT
@@ -152,15 +147,19 @@ specification_version: 4
 summary: Policy Objects for Ruby.
 test_files:
 - spec/spec_helper.rb
-- spec/tests/policy_spec.rb
+- spec/tests/lib/policy_spec.rb
+- spec/tests/lib/policy/base/or_spec.rb
+- spec/tests/lib/policy/base/and_spec.rb
+- spec/tests/lib/policy/base/xor_spec.rb
+- spec/tests/lib/policy/base/negator_spec.rb
+- spec/tests/lib/policy/base/not_spec.rb
+- spec/tests/lib/policy/cli_spec.rb
+- spec/tests/lib/policy/follower_spec.rb
+- spec/tests/lib/policy/cli/attribute_spec.rb
+- spec/tests/lib/policy/base_spec.rb
+- spec/tests/lib/policy/follower/violation_error_spec.rb
+- spec/tests/lib/policy/follower/name_error_spec.rb
+- spec/tests/lib/policy/follower/policies_spec.rb
 - spec/tests/bin/policy_spec.rb
-- spec/tests/policy/cli_spec.rb
-- spec/tests/policy/follower_spec.rb
-- spec/tests/policy/interface_spec.rb
-- spec/tests/policy/validations_spec.rb
-- spec/tests/policy/follower/followed_policies_spec.rb
-- spec/tests/policy/follower/followed_policy_spec.rb
-- spec/tests/policy/follower/names_spec.rb
-- spec/tests/policy/violation_error_spec.rb
-- spec/features/follower_spec.rb
+- spec/support/composer.rb
 has_rdoc: 

data/lib/policy/follower/followed_policies.rb

@@ -1,45 +0,0 @@
-# encoding: utf-8
-
-module Policy
-
-  module Follower
-
-    # Describes the list of followed policies
-    #
-    # @api private
-    class FollowedPolicies < Hash
-
-      # Registers followed policy with given unique key
-      #
-      # @param [Policy::Follower::FollowedPolicy] policy
-      #
-      # @return [undefined]
-      def add(policy)
-        self[policy.name] = policy
-      end
-
-      # Applies to follower the policies, selected by names
-      #
-      # @param [Policy::Follower] follower
-      # @param [Array<#to_s>] names
-      #
-      # @raise [Policy::ViolationError]
-      #   unless all policies are met
-      #
-      # @return [undefined]
-      def apply_to(follower, *names)
-        named_by(names).each { |policy| policy.apply_to(follower) }
-      end
-
-      private
-
-      def named_by(list)
-        names = Names.from list
-        names.any? ? names.map(&method(:[])).compact : values
-      end
-
-    end # class FollowedPolicies
-
-  end # module Follower
-
-end # module Policy

data/lib/policy/follower/followed_policy.rb

@@ -1,104 +0,0 @@
-# encoding: utf-8
-
-module Policy
-
-  module Follower
-
-    # Stores the policy to be applied to all instances of the follower
-    #
-    # The policy object can be set either as a constant, or by name
-    # in given namespace. Namespace and policy name can be set separately.
-    #
-    # The separation is used at the {Policy::Follower#apply_policies}.
-    #
-    # @example The policy can be constant
-    #   FollowedPolicy.new nil, Foo::Bar::Baz, :baz_policy, :baz
-    #
-    # @example The policy can be name, relative to the namespace
-    #   FollowedPolicy.new Foo::Bar, :Baz, :baz_policy, :baz
-    #   # Foo::Bar::Baz policy object will be used
-    #
-    # @api private
-    class FollowedPolicy
-
-      # @!scope class
-      # @!method new(namespace, policy, name, *attributes)
-      # Creates the immutable policy to be followed by given object
-      #
-      # @param [Module] namespace
-      #   the namespace for the policy, given by name
-      # @param [Class, #to_s] policy
-      #   the class for applicable policy
-      # @param [#to_sym, nil] name
-      #   the name for the policy
-      # @param [Array<Symbol>] attributes
-      #   the list of follower attributes to apply the policy to
-      #
-      # @return [Policy::Follower::FollowedPolicy]
-      #   immutable object
-      def initialize(namespace, policy, name, *attributes)
-        @policy     = find_policy(namespace, policy)
-        @name       = (name || SecureRandom.uuid).to_sym
-        @attributes = check_attributes attributes
-      end
-
-      # @!attribute [r] name
-      # The name for the policy
-      #
-      # @return [Symbol]
-      attr_reader :name
-
-      # @!attribute [r] policy
-      # The policy object class to be followed
-      #
-      # @return [Class]
-      attr_reader :policy
-
-      # @!attribute [r] attributes
-      # The list of follower attributes to be send to the policy object
-      #
-      # @return [Array<Symbol>]
-      attr_reader :attributes
-
-      # Applies the policy to follower instance
-      #
-      # @param [Policy::Follower]
-      #   follower
-      #
-      # @raise [Policy::ViolationError]
-      #   it the follower doesn't meet the policy
-      #
-      # @return [undefined]
-      def apply_to(follower)
-        policy.apply(*attributes_of(follower))
-      end
-
-      private
-
-      def find_policy(namespace, policy)
-        return policy if policy.instance_of?(Class)
-        instance_eval [namespace, policy].join("::")
-      end
-
-      def attributes_of(follower)
-        attributes.map(&follower.method(:send))
-      end
-
-      def check_attributes(attributes)
-        number = policy.members.count
-        return attributes if attributes.count.equal?(number)
-        fail wrong_number(number, attributes)
-      end
-
-      def wrong_number(number, attributes)
-        ArgumentError.new [
-          "#{ policy } requires #{ number } attribute(s).",
-          "#{ attributes } cannot be assigned."
-        ].join(" ")
-      end
-
-    end # class FollowedPolicy
-
-  end # module Follower
-
-end # module Policy

data/lib/policy/follower/names.rb

@@ -1,29 +0,0 @@
-# encoding: utf-8
-
-module Policy
-
-  module Follower
-
-    # Converter of items to array of unique symbols
-    #
-    # @api private
-    module Names
-
-      # Converts items to array of unique symbols
-      #
-      # @example
-      #   Policy::Follower::Names.from "foo", [:foo, "bar"], "baz"
-      #   # => [:foo, :bar, :baz]
-      #
-      # @param [Array<#to_sym>] items
-      #
-      # @return [Array<Symbol>]
-      def self.from(*items)
-        items.flatten.map(&:to_sym)
-      end
-
-    end
-
-  end
-
-end

data/lib/policy/interface.rb

@@ -1,48 +0,0 @@
-# encoding: utf-8
-
-module Policy
-
-  # Policy object interface
-  module Interface
-
-    # @private
-    def self.included(klass)
-      klass.extend(ClassMethods).__send__(:include, Validations)
-    end
-
-    # Container for the policy class methods
-    module ClassMethods
-
-      # Creates and validates the policy object
-      #
-      # @param (see Policy.new)
-      #
-      # @raise (see Policy::Interface#apply)
-      #
-      # @return [undefined]
-      def apply(*attributes)
-        new(*attributes).apply
-      end
-
-    end
-
-    # Returns the list of error messages
-    #
-    # @return [Array<String>]
-    def messages
-      errors.messages.values.flatten
-    end
-
-    # Validates the policy object
-    #
-    # @raise [ViolationError]
-    #   if a policy is invalid
-    #
-    # @return [undefined]
-    def apply
-      fail ViolationError.new(self) unless valid?
-    end
-
-  end # class Interface
-
-end # module Policy

data/lib/policy/validations.rb

@@ -1,28 +0,0 @@
-# encoding: utf-8
-require "active_model"
-
-module Policy
-
-  # Wrapper around the ActiveModel::Validations
-  #
-  # Provides shared interface for [Policy::Inteface] and [Policy::Follower].
-  #
-  # @todo Implement it later from scratch without excessive features
-  #
-  # @example
-  #   MyClass.include, Policy::Validations
-  #
-  # @private
-  module Validations
-
-    # The implementation for validations
-    IMPLEMENTATION = ActiveModel::Validations
-
-    # @private
-    def self.included(klass)
-      klass.__send__(:include, IMPLEMENTATION)
-    end
-
-  end # module Validations
-
-end # module Policy