poleica 0.9.12 → 0.10.0

data/test/poleica/converters/utils_test.rb

@@ -4,23 +4,33 @@ require 'test_helper'
 class UtilsTest < Minitest::Test
   def test_exec_with_timeout
     start_time = Time.now
-    Poleica::Converters::Utils.exec_with_timeout('sleep', 2, 0.1) rescue nil
+    # rubocop:disable RescueModifier
+    Poleica::Converters::Utils.exec_with_timeout('sleep', 2, timeout: 0.1) rescue nil
+    # rubocop:enable
     duration = Time.now - start_time
     assert(duration < 2)
   end
 
   def test_exec_with_timeout_raise_an_exception
     assert_raises(Poleica::TimeoutError) do
-      Poleica::Converters::Utils.exec_with_timeout('sleep', 2, 0.1)
+      Poleica::Converters::Utils.exec_with_timeout('sleep', 2, timeout: 0.1)
     end
   end
 
   def test_exec_with_timeout_kill
     assert(`ps -a | grep soffice.bin | grep -v grep`.empty?)
     Poleica.configure { |conf| conf.timeout = 0.001 }
+    # rubocop:disable RescueModifier
     Poleica.new("#{Support.support_path}/files/example.doc").to_png rescue nil
+    # rubocop:enable
     assert(`ps -a | grep example.doc | grep -v grep`.empty?)
   ensure
     Poleica.configure { |config| config.timeout = 120 }
   end
+
+  def test_exec_with_timeout_exception
+    assert_raises(Poleica::ProcessError) do
+      Poleica::Converters::Utils.exec_with_timeout('false')
+    end
+  end
 end

data/test/poleica/types/typeable_test.rb

@@ -2,14 +2,14 @@
 require 'test_helper'
 # Test the Typeable Module
 class TypeableTest < Minitest::Test
-  EXTENSION_NAMES ||= %w{doc pdf mp3 png}
+  EXTENSION_NAMES ||= %w(doc pdf mp3 png)
 
   def test_that_it_extracts_a_mimetype
-    expected_mime_types = %w{
-                            application/pdf
-                            audio/mpeg
-                            image/png
-                          }
+    expected_mime_types = %w(
+      application/pdf
+      audio/mpeg
+      image/png
+    )
     mime_types = files_enumerator.map(&:file_mimetype)
     # Don't test doc files, it doesnt behave the same way
     # on Linux or MacOS (maybe FIXME)
@@ -25,11 +25,11 @@ class TypeableTest < Minitest::Test
 
   def test_that_it_extracts_a_type_object
     expected_classes = [
-                         Poleica::Types::Document,
-                         Poleica::Types::General,
-                         Poleica::Types::Document,
-                         Poleica::Types::Image
-                       ]
+      Poleica::Types::Document,
+      Poleica::Types::General,
+      Poleica::Types::Document,
+      Poleica::Types::Image
+    ]
     classes = files_enumerator.map do |type_detector|
       type_detector.file_type.class
     end

data/test/test_helper.rb

@@ -10,7 +10,8 @@ if ENV['COVERAGE'] || ENV['TRAVIS']
   Coveralls.wear!
 end
 
-gem     'minitest'
+Bundler.require(:default, :test)
+
 require 'minitest/autorun'
 require 'poleica'
 

metadata

@@ -1,57 +1,43 @@
 --- !ruby/object:Gem::Specification
 name: poleica
 version: !ruby/object:Gem::Version
-  version: 0.9.12
+  version: 0.10.0
 platform: ruby
 authors:
 - Antoine Lyset
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-09-10 00:00:00.000000000 Z
+date: 2015-03-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
+  name: childprocess
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+  type: :runtime
+  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-  type: :runtime
-  prerelease: false
-  name: childprocess
 - !ruby/object:Gem::Dependency
+  name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: '1.3'
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.3'
   type: :development
   prerelease: false
-  name: bundler
-- !ruby/object:Gem::Dependency
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  name: rake
+        version: '1.3'
 description: Poleica can convert docs and images to PDF and PNG, it can be extended
   to handle a lot of converters
 email: antoinelyset@gmail.com
@@ -59,8 +45,8 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .travis.yml
+- ".gitignore"
+- ".travis.yml"
 - CHANGELOG.md
 - Gemfile
 - Gemfile.lock
@@ -73,7 +59,9 @@ files:
 - lib/poleica/converters/coercive.rb
 - lib/poleica/converters/convertible.rb
 - lib/poleica/converters/general.rb
-- lib/poleica/converters/graphics_magick.rb
+- lib/poleica/converters/graphics_magick/convert_options_generator.rb
+- lib/poleica/converters/graphics_magick/graphics_magick.rb
+- lib/poleica/converters/graphics_magick/thumbnail_options_generator.rb
 - lib/poleica/converters/libre_office.rb
 - lib/poleica/converters/utils.rb
 - lib/poleica/errors.rb
@@ -99,7 +87,9 @@ files:
 - test/poleica/polei_test.rb
 - test/poleica/types/typeable_test.rb
 - test/poleica_test.rb
+- test/support/files/120x70.png
 - test/support/files/1px.gif
+- test/support/files/30x30.png
 - test/support/files/example.doc
 - test/support/files/example.mp3
 - test/support/files/example.pdf
@@ -115,17 +105,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.0
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: A general converter and thumbnail creator
@@ -141,10 +131,11 @@ test_files:
 - test/poleica/polei_test.rb
 - test/poleica/types/typeable_test.rb
 - test/poleica_test.rb
+- test/support/files/120x70.png
 - test/support/files/1px.gif
+- test/support/files/30x30.png
 - test/support/files/example.doc
 - test/support/files/example.mp3
 - test/support/files/example.pdf
 - test/support/files/example.png
 - test/test_helper.rb
-has_rdoc: 

data/lib/poleica/converters/graphics_magick.rb

@@ -1,118 +0,0 @@
-# -*- encoding: utf-8 -*-
-module Poleica
-  module Converters
-    # The GraphicsMagick converter, use the 'gm' command to convert images and
-    # documents
-    class GraphicsMagick
-      include Poleica::Converters::Utils
-
-     COMPATIBLE_TYPES = [
-       Types::Image,
-       Types::PDF
-     ]
-
-     DEFAULT_MEASURE = 612
-
-      attr_reader :polei
-
-      def initialize(polei)
-        @polei = polei
-      end
-
-      def to_png(options = {})
-        opts_gen = OptionsGenerator.new(polei, options)
-        exec_with_timeout(bin_path, opts_gen.generate)
-        expected_file_path = opts_gen[:path]
-        File.exists?(expected_file_path) ? expected_file_path : nil
-      end
-
-      private
-
-      # Generate options for the gm command
-      # @options page [Array, Integer]
-      class OptionsGenerator
-        attr_reader :polei, :options
-
-        def initialize(polei, options = {})
-          @polei   = polei
-          @options = default_options.merge(options)
-        end
-
-        def generate
-          [
-            'convert',
-            "#{polei.path}#{page_options}",
-            orient_options,
-            thumbnail_or_resize_options,
-            output_options
-          ].flatten
-        end
-
-        def [](key)
-          options[key]
-        end
-
-        private
-
-        def default_options
-          {
-            height: DEFAULT_MEASURE,
-            width: DEFAULT_MEASURE,
-            force_resize: false,
-            auto_orient: true,
-            thumbnail: false,
-            page: 0,
-          }
-        end
-
-        def page_options
-          @page_options ||=
-            "#{Array(options[:page]).flatten.compact.uniq.sort.to_s}"
-        end
-
-        def orient_options
-          @orient_options ||= options[:auto_orient] ? '-auto-orient' : ''
-        end
-
-        def thumbnail_or_resize_options
-          @thumbnail_or_resize_options ||=
-            options[:thumbnail] ? thumbnail_options : resize_options
-        end
-
-        def thumbnail_options
-          @thumbnail_options ||=
-            [
-              '-thumbnail',
-              "#{options[:width]}x#{options[:height]}^",
-              '-gravity',
-              'center',
-              '-extent',
-              "#{options[:width]}x#{options[:height]}"
-            ]
-        end
-
-        def resize_options
-          @resize_options ||=
-            [
-              '-resize',
-              "#{options[:width]}x#{options[:height]}" +
-                "#{'!' if options[:force_resize]}"
-            ]
-        end
-
-        def output_options
-          options[:path] = if options[:path]
-                             if File.directory?(options[:path])
-                               basename = File.basename(polei.path_with_md5)
-                               File.join(options[:path], basename)
-                             else
-                               options[:path]
-                             end
-                           else
-                             polei.path_with_md5(:png)
-                           end
-        end
-      end # class OptionsGenerator
-    end # class GraphicsMagick
-  end # module Converters
-end # module Poleica