polaris_view_components 4.0.0 → 4.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8fec4405e8b1c604811d7bf69ece811a57fa31447754fe6a3f67cac17fc5c9ed
-  data.tar.gz: d670c3c83b34ec0bff77066c94ffbe0eca60530985f6b3d44589108c740f071e
+  metadata.gz: 2556310257a7b7bc5360830ea381c0619787796c347ba9414e7ff98826f6e19b
+  data.tar.gz: 3120e335bb52aca18bf9e7e5a00b773a47b02a74777bf3467204847604f7f2f7
 SHA512:
-  metadata.gz: 29daf7afd8f7a06ec3b9c41530a97b02bdd2accc663f911133ab413d8682c06d503a697afc0ea28719084fc9498d7a04cf98ac61fcdab3632f0c299a451006b2
-  data.tar.gz: 0120f2a3d552796b7eeb7ef4de1d38fb7d8862865e776d96548abfaacb8b95879b0a29ed964006ad8ca7c8b00cd865beeec40333bab665371c05af604033bcb9
+  metadata.gz: d6e016aaaac91d443b9d9846b4d49748819a436ba43f7f9e4d2acfd4d3cf9435d54591a17c143b8f76f8d1d85257ff0387f19c69bd7db769d5419c6acaaa886a
+  data.tar.gz: f88419ccb82a51a2963ed40356c731ab279bbb5892585e27429cdd619ffb43115a6f04180ca6f00299bc026d4ecb424007ae8e1e691859909f6a3839b76b2595

data/app/assets/javascripts/polaris_view_components/autocomplete_controller.js

@@ -44,6 +44,10 @@ export default class extends Controller {
   }
 
   onInputChange = debounce(() => {
+    // The element may have been removed (e.g. replaced by a Turbo Stream)
+    // before the debounced callback fires.
+    if (!this.element.isConnected) return
+
     if (this.isRemote) {
       this.fetchResults()
     } else {
@@ -80,6 +84,9 @@ export default class extends Controller {
   }
 
   handleResults() {
+    // The popover controller is gone once the element has been disconnected.
+    if (!this.popoverController) return
+
     if (this.visibleOptions.length > 0) {
       this.hideEmptyState()
       this.popoverController.show()
@@ -119,6 +126,8 @@ export default class extends Controller {
     if (response.ok) {
       const results = await response.html
 
+      // Ignore responses that arrive after the element was removed from the page.
+      if (!this.element.isConnected) return
       if (requestId !== this.latestRequestId || query !== this.value) return
 
       this.resultsTarget.innerHTML = results

data/app/assets/javascripts/polaris_view_components.js

@@ -212,6 +212,7 @@ class Autocomplete extends Controller {
     this.element.dispatchEvent(changeEvent);
   }
   onInputChange=debounce((() => {
+    if (!this.element.isConnected) return;
     if (this.isRemote) {
       this.fetchResults();
     } else {
@@ -238,6 +239,7 @@ class Autocomplete extends Controller {
     return [ ...this.optionTargets ].filter((option => !option.classList.contains("Polaris--hidden")));
   }
   handleResults() {
+    if (!this.popoverController) return;
     if (this.visibleOptions.length > 0) {
       this.hideEmptyState();
       this.popoverController.show();
@@ -276,6 +278,7 @@ class Autocomplete extends Controller {
     });
     if (response.ok) {
       const results = await response.html;
+      if (!this.element.isConnected) return;
       if (requestId !== this.latestRequestId || query !== this.value) return;
       this.resultsTarget.innerHTML = results;
       this.handleResults();

data/lib/polaris/view_components/version.rb

@@ -1,5 +1,5 @@
 module Polaris
   module ViewComponents
-    VERSION = "4.0.0"
+    VERSION = "4.0.1"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: polaris_view_components
 version: !ruby/object:Gem::Version
-  version: 4.0.0
+  version: 4.0.1
 platform: ruby
 authors:
 - Dan Gamble