polaris_view_components 3.1.1 → 3.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1d930e9979e26f2a16e58a86aaf5477360eb518602900671407fbad50476058a
-  data.tar.gz: c65e3755b6d86787d6a6582c646ed8e81c17fbb33e6ba95fb6e975f240411840
+  metadata.gz: c8125de405dc965d5dc682a8c4d21c682d5a4fd2771bcbd9751fd85f429daf0f
+  data.tar.gz: 400fbb96829bf6bdea7cc842e60f965877a278b806cb27468b8735a30540480e
 SHA512:
-  metadata.gz: 4b74b88c543352ce30e6db7b6478b61aeba71a7688f578335bab15464aa041e1f806f0200fadbfc8015586c18b99f543d1a8633d250e46eed03f984b3543889e
-  data.tar.gz: 04f4ad64a553706075a8fe6a7632707e4334f3a805f717f8dfb40c1e4b47c6db314a05b9684cc923f4dfd2359aafd10b61c53ec0bc47a11b1ee683a6fc54ae24
+  metadata.gz: e745e7869c91205b85352e2db653b11a044c10c6e5d3c7d7c2bb759c93bd96b67eed3e148fb7df090a07f948e36ac9d4a1b588c01839bcbdac1106d12adc3c34
+  data.tar.gz: 2bd1f707013a22583841cf4bd5851b3bbecc5722e93132ec5449a1fb5b369ac447a3f4e82f8db42c952621c5bac93f1f96068f91de180b33dbac9901d8eb950b

data/LICENSE.txt

@@ -1,4 +1,4 @@
-Copyright 2021 Dan Gamble
+Copyright 2021 Dan Gamble, Kirill Platonov
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

data/README.md

@@ -44,10 +44,10 @@ Check out [UPGRADING.md](UPGRADING.md) for upgrade instructions.
 To get started:
 
 1. Run: `bundle install`
-1. Run: `yarn install`
+1. Run: `pnpm install`
 1. Run: `bin/dev`
 
-It will open demo app with component previews on `localhost:4000`. You can change components and they will be updated on page reload. Component previews located in `demo/test/components/previews`.
+It will open the demo app with component previews on `localhost:4000`. You can change components and they will be updated on page reload. Component previews are located in `demo/app/previews`.
 
 To run tests:
 
@@ -57,7 +57,9 @@ rake
 
 ## Releases
 
-The library follows [semantic versioning](https://semver.org/). To draft a new release you need to run `bin/release` with a new version number:
+The library follows [semantic versioning](https://semver.org/). See [GitHub Releases](https://github.com/baoagency/polaris_view_components/releases) for release notes.
+
+To draft a new release you need to run `bin/release` with a new version number:
 
 ```bash
 bin/release VERSION
@@ -68,7 +70,7 @@ Where the VERSION is the version number you want to release. This script will up
 To release a new version of npm package update the package.json file with the new version number and run:
 
 ```bash
-npm run release
+pnpm release
 ```
 
 After that make sure to commit changes in package.json.

data/app/assets/javascripts/polaris_view_components/autocomplete_controller.js

@@ -6,6 +6,8 @@ export default class extends Controller {
   static targets = ['popover', 'input', 'hiddenInput', 'results', 'option', 'emptyState']
   static values = { multiple: Boolean, url: String, selected: Array }
 
+  latestRequestId = 0
+
   connect() {
     this.inputTarget.addEventListener("input", this.onInputChange)
   }
@@ -84,6 +86,7 @@ export default class extends Controller {
       this.checkSelected()
     } else if (this.value.length > 0 && this.hasEmptyStateTarget) {
       this.showEmptyState()
+      this.popoverController.show()
     } else {
       this.popoverController.forceHide()
     }
@@ -108,11 +111,16 @@ export default class extends Controller {
   }
 
   async fetchResults() {
+    const query = this.value
+    const requestId = ++this.latestRequestId
     const response = await get(this.urlValue, {
-      query: { q: this.value }
+      query: { q: query }
     })
     if (response.ok) {
       const results = await response.html
+
+      if (requestId !== this.latestRequestId || query !== this.value) return
+
       this.resultsTarget.innerHTML = results
       this.handleResults()
     }

data/app/assets/javascripts/polaris_view_components.js

@@ -180,6 +180,7 @@ class Autocomplete extends Controller {
     url: String,
     selected: Array
   };
+  latestRequestId=0;
   connect() {
     this.inputTarget.addEventListener("input", this.onInputChange);
   }
@@ -243,6 +244,7 @@ class Autocomplete extends Controller {
       this.checkSelected();
     } else if (this.value.length > 0 && this.hasEmptyStateTarget) {
       this.showEmptyState();
+      this.popoverController.show();
     } else {
       this.popoverController.forceHide();
     }
@@ -265,13 +267,16 @@ class Autocomplete extends Controller {
     this.handleResults();
   }
   async fetchResults() {
+    const query = this.value;
+    const requestId = ++this.latestRequestId;
     const response = await get(this.urlValue, {
       query: {
-        q: this.value
+        q: query
       }
     });
     if (response.ok) {
       const results = await response.html;
+      if (requestId !== this.latestRequestId || query !== this.value) return;
       this.resultsTarget.innerHTML = results;
       this.handleResults();
     }

data/app/helpers/polaris/form_builder.rb

@@ -58,7 +58,7 @@ module Polaris
     def polaris_select(method, **options, &block)
       apply_error_options(options, method)
 
-      value = object&.public_send(method)
+      value = object.public_send(method) if object.respond_to?(method)
       if value.present?
         options[:selected] = value
       end
@@ -86,7 +86,7 @@ module Polaris
     def polaris_collection_check_boxes(method, collection, value_method, text_method, **options, &block)
       apply_error_options(options, method)
 
-      value = object&.public_send(method)
+      value = object.public_send(method) if object.respond_to?(method)
       if value.present?
         options[:selected] = value.map { |el| el.public_send(value_method) }
       end

data/lib/install/install.rb

@@ -42,11 +42,11 @@ else
 
   unless package_json.include?("@rails/request.js")
     say "Add @rails/request.js dependency"
-    run "yarn add @rails/request.js"
+    run "pnpm add @rails/request.js"
   end
 
   say "Add polaris-view-components package"
-  run "yarn add polaris-view-components"
+  run "pnpm add polaris-view-components"
 end
 
 if STIMULUS_PATH.exist?

data/lib/polaris/view_components/version.rb

@@ -1,5 +1,5 @@
 module Polaris
   module ViewComponents
-    VERSION = "3.1.1"
+    VERSION = "3.1.3"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: polaris_view_components
 version: !ruby/object:Gem::Version
-  version: 3.1.1
+  version: 3.1.3
 platform: ruby
 authors:
 - Dan Gamble
@@ -33,7 +33,7 @@ dependencies:
         version: 3.0.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: 4.2.0
+        version: '5.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -43,7 +43,7 @@ dependencies:
         version: 3.0.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: 4.2.0
+        version: '5.0'
 - !ruby/object:Gem::Dependency
   name: webdrivers
   requirement: !ruby/object:Gem::Requirement
@@ -144,6 +144,7 @@ dependencies:
         version: '0'
 email:
 - dan@dangamble.co.uk
+- mail@kirillplatonov.com
 executables: []
 extensions: []
 extra_rdoc_files: []